Change the things we pass to Mangled::SetValue to be ConstStrings instead of 
char*'s - Greg removed the methods which accept char*'s earlier today.


git-svn-id: https://llvm.org/svn/llvm-project/lldb/trunk@160539 91177308-0d34-0410-b5e6-96231b3b80d8
diff --git a/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp b/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp
index 8b074ce..cd0f10f 100644
--- a/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp
+++ b/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp
@@ -1801,7 +1801,7 @@
                                                                 {
                                                                     // We have two consecutive N_SO entries where the first contains a directory
                                                                     // and the second contains a full path.
-                                                                    sym[sym_idx - 1].GetMangled().SetValue(symbol_name, false);
+                                                                    sym[sym_idx - 1].GetMangled().SetValue(ConstString(symbol_name), false);
                                                                     m_nlist_idx_to_sym_idx[nlist_idx] = sym_idx - 1;
                                                                     add_nlist = false;
                                                                 }
@@ -1823,7 +1823,7 @@
                                                                     if (*full_so_path.rbegin() != '/')
                                                                         full_so_path += '/';
                                                                     full_so_path += symbol_name;
-                                                                    sym[sym_idx - 1].GetMangled().SetValue(full_so_path.c_str(), false);
+                                                                    sym[sym_idx - 1].GetMangled().SetValue(ConstString(full_so_path.c_str()), false);
                                                                     add_nlist = false;
                                                                     m_nlist_idx_to_sym_idx[nlist_idx] = sym_idx - 1;
                                                                 }
@@ -2127,8 +2127,8 @@
                                                 
                                                 if (symbol_name_non_abi_mangled)
                                                 {
-                                                    sym[sym_idx].GetMangled().SetMangledName (symbol_name_non_abi_mangled);
-                                                    sym[sym_idx].GetMangled().SetDemangledName (symbol_name);
+                                                    sym[sym_idx].GetMangled().SetMangledName (ConstString(symbol_name_non_abi_mangled));
+                                                    sym[sym_idx].GetMangled().SetDemangledName (ConstString(symbol_name));
                                                 }
                                                 else
                                                 {
@@ -2140,7 +2140,7 @@
                                                     
                                                     if (symbol_name)
                                                     {
-                                                        sym[sym_idx].GetMangled().SetValue(symbol_name, symbol_name_is_mangled);
+                                                        sym[sym_idx].GetMangled().SetValue(ConstString(symbol_name), symbol_name_is_mangled);
                                                     }
                                                 }