<rdar://problem/10103468>
I started work on being able to add symbol files after a debug session
had started with a new "target symfile add" command and quickly ran into
problems with stale Address objects in breakpoint locations that had
lldb_private::Section pointers into modules that had been removed or
replaced. This also let to grabbing stale modules from those sections.
So I needed to thread harded the Address, Section and related objects.
To do this I modified the ModuleChild class to now require a ModuleSP
on initialization so that a weak reference can created. I also changed
all places that were handing out "Section *" to have them hand out SectionSP.
All ObjectFile, SymbolFile and SymbolVendors were inheriting from ModuleChild
so all of the find plug-in, static creation function and constructors now
require ModuleSP references instead of Module *.
Address objects now have weak references to their sections which can
safely go stale when a module gets destructed.
This checkin doesn't complete the "target symfile add" command, but it
does get us a lot clioser to being able to do such things without a high
risk of crashing or memory corruption.
git-svn-id: https://llvm.org/svn/llvm-project/lldb/trunk@151336 91177308-0d34-0410-b5e6-96231b3b80d8
diff --git a/source/API/SBModule.cpp b/source/API/SBModule.cpp
index 77a7af2..c23a35e 100644
--- a/source/API/SBModule.cpp
+++ b/source/API/SBModule.cpp
@@ -331,7 +331,7 @@
SectionList *section_list = obj_file->GetSectionList ();
if (section_list)
- sb_section.SetSection(section_list->GetSectionAtIndex (idx).get());
+ sb_section.SetSP(section_list->GetSectionAtIndex (idx));
}
}
return sb_section;
@@ -467,7 +467,7 @@
SectionSP section_sp (section_list->FindSectionByName(const_sect_name));
if (section_sp)
{
- sb_section.SetSection(section_sp.get());
+ sb_section.SetSP (section_sp);
}
}
}