Reverting 180831 as it crashes TestDefaultConstructorForAPIObjects.py



git-svn-id: https://llvm.org/svn/llvm-project/lldb/trunk@180868 91177308-0d34-0410-b5e6-96231b3b80d8
diff --git a/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp b/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
index aa27ae8..35e455d 100644
--- a/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
+++ b/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
@@ -1703,29 +1703,25 @@
 }
 
 Error
-ProcessGDBRemote::DoDetach(bool keep_stopped)
+ProcessGDBRemote::DoDetach()
 {
     Error error;
     Log *log (ProcessGDBRemoteLog::GetLogIfAllCategoriesSet(GDBR_LOG_PROCESS));
     if (log)
-        log->Printf ("ProcessGDBRemote::DoDetach(keep_stopped: %i)", keep_stopped);
- 
+        log->Printf ("ProcessGDBRemote::DoDetach()");
+
     DisableAllBreakpointSites ();
 
     m_thread_list.DiscardThreadPlans();
 
-    error = m_gdb_comm.Detach (keep_stopped);
+    bool success = m_gdb_comm.Detach ();
     if (log)
     {
-        if (error.Success())
+        if (success)
             log->PutCString ("ProcessGDBRemote::DoDetach() detach packet sent successfully");
         else
-            log->Printf ("ProcessGDBRemote::DoDetach() detach packet send failed: %s", error.AsCString() ? error.AsCString() : "<unknown error>");
+            log->PutCString ("ProcessGDBRemote::DoDetach() detach packet send failed");
     }
-    
-    if (!error.Success())
-        return error;
-
     // Sleep for one second to let the process get all detached...
     StopAsyncThread ();