Enabled extra warnings and fixed a bunch of small issues.



git-svn-id: https://llvm.org/svn/llvm-project/llvdb/trunk@124250 91177308-0d34-0410-b5e6-96231b3b80d8
diff --git a/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp b/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
index d83fb58..6ec7dab 100644
--- a/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
+++ b/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
@@ -1098,13 +1098,13 @@
                 gdb_thread->SetName (thread_name.empty() ? thread_name.c_str() : NULL);
                 if (exc_type != 0)
                 {
-                    const size_t exc_data_count = exc_data.size();
+                    const size_t exc_data_size = exc_data.size();
 
                     gdb_thread->SetStopInfo (StopInfoMachException::CreateStopReasonWithMachException (*thread_sp,
                                                                                                        exc_type, 
-                                                                                                       exc_data_count,
-                                                                                                       exc_data_count >= 1 ? exc_data[0] : 0,
-                                                                                                       exc_data_count >= 2 ? exc_data[1] : 0));
+                                                                                                       exc_data_size,
+                                                                                                       exc_data_size >= 1 ? exc_data[0] : 0,
+                                                                                                       exc_data_size >= 2 ? exc_data[1] : 0));
                 }
                 else if (signo)
                 {
@@ -1230,7 +1230,7 @@
             timeout_time.OffsetWithSeconds(5);
             StateType state = WaitForStateChangedEventsPrivate (&timeout_time, stop_event_sp);
     
-            const bool timed_out = state == eStateInvalid;
+            timed_out = state == eStateInvalid;
             if (log)
                 log->Printf ("ProcessGDBRemote::InterruptIfRunning() catch stop event: state = %s, timed-out=%i", StateAsCString(state), timed_out);
 
diff --git a/source/Plugins/Process/gdb-remote/ProcessGDBRemoteLog.cpp b/source/Plugins/Process/gdb-remote/ProcessGDBRemoteLog.cpp
index 044edd0..0c019bf 100644
--- a/source/Plugins/Process/gdb-remote/ProcessGDBRemoteLog.cpp
+++ b/source/Plugins/Process/gdb-remote/ProcessGDBRemoteLog.cpp
@@ -96,12 +96,10 @@
 {
     // Try see if there already is a log - that way we can reuse its settings.
     // We could reuse the log in toto, but we don't know that the stream is the same.
-    uint32_t flag_bits;
+    uint32_t flag_bits = 0;
     LogSP log(GetLog ());
     if (log)
         flag_bits = log->GetMask().Get();
-    else
-        flag_bits = 0;
 
     // Now make a new log with this stream if one was provided
     if (log_stream_sp)
@@ -112,7 +110,6 @@
 
     if (log)
     {
-        uint32_t flag_bits = 0;
         bool got_unknown_category = false;
         const size_t argc = args.GetArgumentCount();
         for (size_t i=0; i<argc; ++i)