commit 1a525e8c80305777e3ca0cba0e1903fdbf04aa86
author Rafael Espindola <rafael.espindola@gmail.com> Wed Oct 09 16:07:32 2013 +0000
committer Rafael Espindola <rafael.espindola@gmail.com> Wed Oct 09 16:07:32 2013 +0000
tree 439b7b96f5f46b5fca34443f3f730ad608b8dfce
parent 3b73dea538d9c53e205d38bfbcf99dd64306874b

Add a GlobalAlias::isValidLinkage to reduce code duplication.

Thanks to Reid Kleckner for the suggestion.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@192298 91177308-0d34-0410-b5e6-96231b3b80d8

lib/AsmParser/LLParser.cpp

diff --git a/lib/AsmParser/LLParser.cpp b/lib/AsmParser/LLParser.cpp
index d5c5db1..74c0ea4 100644
--- a/lib/AsmParser/LLParser.cpp
+++ b/lib/AsmParser/LLParser.cpp
@@ -634,10 +634,7 @@
 
   GlobalValue::LinkageTypes Linkage = (GlobalValue::LinkageTypes) L;
 
-  if(!GlobalValue::isExternalLinkage(Linkage) &&
-     !GlobalValue::isLocalLinkage(Linkage) &&
-     !GlobalValue::isWeakLinkage(Linkage) &&
-     !GlobalValue::isLinkOnceLinkage(Linkage))
+  if(!GlobalAlias::isValidLinkage(Linkage))
     return Error(LinkageLoc, "invalid linkage type for alias");
 
   Constant *Aliasee;