commit 5b6f42f57e730c2d968c313a27fa505a3c3e5efa
author Bill Wendling <isanbard@gmail.com> Tue Aug 16 20:45:24 2011 +0000
committer Bill Wendling <isanbard@gmail.com> Tue Aug 16 20:45:24 2011 +0000
tree aee4fbd451c00de169c171710e4ee9becd07b2aa
parent d2e103daf8a093e0e25ddbaa7549c083887196e8

Use the getFirstInsertionPt() method instead of getFirstNonPHI + an 'isa<>'
check for a LandingPadInst.


git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@137745 91177308-0d34-0410-b5e6-96231b3b80d8

lib/Transforms/Scalar/CodeGenPrepare.cpp

diff --git a/lib/Transforms/Scalar/CodeGenPrepare.cpp b/lib/Transforms/Scalar/CodeGenPrepare.cpp
index fb4e8a4..607f2c4 100644
--- a/lib/Transforms/Scalar/CodeGenPrepare.cpp
+++ b/lib/Transforms/Scalar/CodeGenPrepare.cpp
@@ -410,9 +410,7 @@
     CastInst *&InsertedCast = InsertedCasts[UserBB];
 
     if (!InsertedCast) {
-      BasicBlock::iterator InsertPt = UserBB->getFirstNonPHI();
-      if (isa<LandingPadInst>(InsertPt)) ++InsertPt;
-
+      BasicBlock::iterator InsertPt = UserBB->getFirstInsertionPt();
       InsertedCast =
         CastInst::Create(CI->getOpcode(), CI->getOperand(0), CI->getType(), "",
                          InsertPt);
@@ -468,8 +466,7 @@
     CmpInst *&InsertedCmp = InsertedCmps[UserBB];
 
     if (!InsertedCmp) {
-      BasicBlock::iterator InsertPt = UserBB->getFirstNonPHI();
-      if (isa<LandingPadInst>(InsertPt)) ++InsertPt; // Skip landingpad inst.
+      BasicBlock::iterator InsertPt = UserBB->getFirstInsertionPt();
       InsertedCmp =
         CmpInst::Create(CI->getOpcode(),
                         CI->getPredicate(),  CI->getOperand(0),
@@ -561,13 +558,10 @@
           (DVI->getParent() != VI->getParent() || DT->dominates(DVI, VI))) {
         DEBUG(dbgs() << "Moving Debug Value before :\n" << *DVI << ' ' << *VI);
         DVI->removeFromParent();
-        if (isa<PHINode>(VI)) {
-          BasicBlock::iterator InsertPt = VI->getParent()->getFirstNonPHI();
-          if (isa<LandingPadInst>(InsertPt)) ++InsertPt;
-          DVI->insertBefore(InsertPt);
-        } else {
+        if (isa<PHINode>(VI))
+          DVI->insertBefore(VI->getParent()->getFirstInsertionPt());
+        else
           DVI->insertAfter(VI);
-        }
         return true;
       }
 
@@ -1063,8 +1057,7 @@
     Instruction *&InsertedTrunc = InsertedTruncs[UserBB];
 
     if (!InsertedTrunc) {
-      BasicBlock::iterator InsertPt = UserBB->getFirstNonPHI();
-      if (isa<LandingPadInst>(InsertPt)) ++InsertPt;
+      BasicBlock::iterator InsertPt = UserBB->getFirstInsertionPt();
       InsertedTrunc = new TruncInst(I, Src->getType(), "", InsertPt);
     }