commit 5f4ee1fc5d00ae55c30fa2ce450c69be4c6d6e63
author Duncan Sands <baldrick@free.fr> Wed Mar 11 08:08:06 2009 +0000
committer Duncan Sands <baldrick@free.fr> Wed Mar 11 08:08:06 2009 +0000
tree 524f8864fae13a926989fb2edb5d72e0dc180dbe
parent 841c6a4345082e9a1252cc39bcce7f1423a76ded

Remove the one-definition-rule version of extern_weak
linkage: this linkage type only applies to declarations,
but ODR is only relevant to globals with definitions.


git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@66650 91177308-0d34-0410-b5e6-96231b3b80d8

lib/AsmParser/LLParser.cpp

diff --git a/lib/AsmParser/LLParser.cpp b/lib/AsmParser/LLParser.cpp
index cb9eb6a..c13c7fc 100644
--- a/lib/AsmParser/LLParser.cpp
+++ b/lib/AsmParser/LLParser.cpp
@@ -125,7 +125,6 @@
     case lltok::kw_common_odr:    // OptionalLinkage
     case lltok::kw_dllimport:     // OptionalLinkage
     case lltok::kw_extern_weak:   // OptionalLinkage
-    case lltok::kw_extern_weak_odr: // OptionalLinkage
     case lltok::kw_external: {    // OptionalLinkage
       unsigned Linkage, Visibility;
       if (ParseOptionalLinkage(Linkage) ||
@@ -458,8 +457,7 @@
   // present.
   Constant *Init = 0;
   if (!HasLinkage || (Linkage != GlobalValue::DLLImportLinkage &&
-                      Linkage != GlobalValue::ExternalWeakAnyLinkage &&
-                      Linkage != GlobalValue::ExternalWeakODRLinkage &&
+                      Linkage != GlobalValue::ExternalWeakLinkage &&
                       Linkage != GlobalValue::ExternalLinkage)) {
     if (ParseGlobalValue(Ty, Init))
       return true;
@@ -574,10 +572,10 @@
       return 0;
     }
     
-    FwdVal = Function::Create(FT, GlobalValue::ExternalWeakAnyLinkage, Name, M);
+    FwdVal = Function::Create(FT, GlobalValue::ExternalWeakLinkage, Name, M);
   } else {
     FwdVal = new GlobalVariable(PTy->getElementType(), false,
-                                GlobalValue::ExternalWeakAnyLinkage, 0, Name, M);
+                                GlobalValue::ExternalWeakLinkage, 0, Name, M);
   }
   
   ForwardRefVals[Name] = std::make_pair(FwdVal, Loc);
@@ -618,10 +616,10 @@
       Error(Loc, "function may not return opaque type");
       return 0;
     }
-    FwdVal = Function::Create(FT, GlobalValue::ExternalWeakAnyLinkage, "", M);
+    FwdVal = Function::Create(FT, GlobalValue::ExternalWeakLinkage, "", M);
   } else {
     FwdVal = new GlobalVariable(PTy->getElementType(), false,
-                                GlobalValue::ExternalWeakAnyLinkage, 0, "", M);
+                                GlobalValue::ExternalWeakLinkage, 0, "", M);
   }
   
   ForwardRefValIDs[ID] = std::make_pair(FwdVal, Loc);
@@ -753,7 +751,6 @@
 ///   ::= 'common_odr'
 ///   ::= 'dllimport'
 ///   ::= 'extern_weak'
-///   ::= 'extern_weak_odr'
 ///   ::= 'external'
 bool LLParser::ParseOptionalLinkage(unsigned &Res, bool &HasLinkage) {
   HasLinkage = false;
@@ -770,9 +767,7 @@
   case lltok::kw_common:       Res = GlobalValue::CommonAnyLinkage; break;
   case lltok::kw_common_odr:   Res = GlobalValue::CommonODRLinkage; break;
   case lltok::kw_dllimport:    Res = GlobalValue::DLLImportLinkage; break;
-  case lltok::kw_extern_weak:  Res = GlobalValue::ExternalWeakAnyLinkage; break;
-  case lltok::kw_extern_weak_odr:
-                               Res = GlobalValue::ExternalWeakODRLinkage; break;
+  case lltok::kw_extern_weak:  Res = GlobalValue::ExternalWeakLinkage; break;
   case lltok::kw_external:     Res = GlobalValue::ExternalLinkage; break;
   }
   Lex.Lex();
@@ -2103,8 +2098,7 @@
   case GlobalValue::ExternalLinkage:
     break; // always ok.
   case GlobalValue::DLLImportLinkage:
-  case GlobalValue::ExternalWeakAnyLinkage:
-  case GlobalValue::ExternalWeakODRLinkage:
+  case GlobalValue::ExternalWeakLinkage:
     if (isDefine)
       return Error(LinkageLoc, "invalid linkage for function definition");
     break;