Simplify the code in DarwinTargetAsmInfo::emitUsedDirectiveFor so that humans can understand it.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@76480 91177308-0d34-0410-b5e6-96231b3b80d8
diff --git a/lib/Target/DarwinTargetAsmInfo.cpp b/lib/Target/DarwinTargetAsmInfo.cpp
index 3eb3d53..6540edd 100644
--- a/lib/Target/DarwinTargetAsmInfo.cpp
+++ b/lib/Target/DarwinTargetAsmInfo.cpp
@@ -107,23 +107,23 @@
/// emitUsedDirectiveFor - On Darwin, internally linked data beginning with
/// the PrivateGlobalPrefix or the LessPrivateGlobalPrefix does not have the
/// directive emitted (this occurs in ObjC metadata).
-bool
-DarwinTargetAsmInfo::emitUsedDirectiveFor(const GlobalValue* GV,
- Mangler *Mang) const {
- if (GV==0)
- return false;
+bool DarwinTargetAsmInfo::emitUsedDirectiveFor(const GlobalValue* GV,
+ Mangler *Mang) const {
+ if (!GV) return false;
- /// FIXME: WHAT IS THIS?
-
- if (GV->hasLocalLinkage() && !isa<Function>(GV) &&
- ((strlen(getPrivateGlobalPrefix()) != 0 &&
- Mang->getMangledName(GV).substr(0,strlen(getPrivateGlobalPrefix())) ==
- getPrivateGlobalPrefix()) ||
- (strlen(getLessPrivateGlobalPrefix()) != 0 &&
- Mang->getMangledName(GV).substr(0,
- strlen(getLessPrivateGlobalPrefix())) ==
- getLessPrivateGlobalPrefix())))
- return false;
+ // Check whether the mangled name has the "Private" or "LessPrivate" prefix.
+ if (GV->hasLocalLinkage() && !isa<Function>(GV)) {
+ const std::string &Name = Mang->getMangledName(GV);
+ const char *PGPrefix = getPrivateGlobalPrefix();
+ const char *LPGPrefix = getLessPrivateGlobalPrefix();
+ unsigned PGPLen = strlen(PGPrefix);
+ unsigned LPGPLen = strlen(LPGPrefix);
+
+ if ((PGPLen != 0 && Name.substr(0, PGPLen) == PGPrefix) ||
+ (LPGPLen != 0 && Name.substr(0, LPGPLen) == LPGPrefix))
+ return false;
+ }
+
return true;
}