blob: 5c0afbeece3e67f0cfb84054e9b6ed19b637b976 [file] [log] [blame]
Chris Lattnerd76efa02002-09-24 00:08:39 +00001//===- BreakCriticalEdges.cpp - Critical Edge Elimination Pass ------------===//
Misha Brukmanfd939082005-04-21 23:48:37 +00002//
John Criswellb576c942003-10-20 19:43:21 +00003// The LLVM Compiler Infrastructure
4//
Chris Lattner4ee451d2007-12-29 20:36:04 +00005// This file is distributed under the University of Illinois Open Source
6// License. See LICENSE.TXT for details.
Misha Brukmanfd939082005-04-21 23:48:37 +00007//
John Criswellb576c942003-10-20 19:43:21 +00008//===----------------------------------------------------------------------===//
Chris Lattnerd76efa02002-09-24 00:08:39 +00009//
10// BreakCriticalEdges pass - Break all of the critical edges in the CFG by
11// inserting a dummy basic block. This pass may be "required" by passes that
12// cannot deal with critical edges. For this usage, the structure type is
13// forward declared. This pass obviously invalidates the CFG, but can update
Chris Lattner363ca612003-11-10 04:42:42 +000014// forward dominator (set, immediate dominators, tree, and frontier)
15// information.
Chris Lattnerd76efa02002-09-24 00:08:39 +000016//
17//===----------------------------------------------------------------------===//
18
Chris Lattnerd216e8b2006-12-19 22:17:40 +000019#define DEBUG_TYPE "break-crit-edges"
Chris Lattnerd76efa02002-09-24 00:08:39 +000020#include "llvm/Transforms/Scalar.h"
Chris Lattnerd23520c2003-11-10 04:10:50 +000021#include "llvm/Transforms/Utils/BasicBlockUtils.h"
Chris Lattnerd76efa02002-09-24 00:08:39 +000022#include "llvm/Analysis/Dominators.h"
Chris Lattner0ae380a2005-08-13 01:38:43 +000023#include "llvm/Analysis/LoopInfo.h"
Andreas Neustifterff5dfdf2009-09-09 17:53:39 +000024#include "llvm/Analysis/ProfileInfo.h"
Chris Lattnerd76efa02002-09-24 00:08:39 +000025#include "llvm/Function.h"
Misha Brukman47b14a42004-07-29 17:30:56 +000026#include "llvm/Instructions.h"
Chris Lattner5b3a4552005-03-17 15:38:16 +000027#include "llvm/Type.h"
Chris Lattnereb0456c2002-09-24 15:51:56 +000028#include "llvm/Support/CFG.h"
Chris Lattnera4f0b3a2006-08-27 12:54:02 +000029#include "llvm/Support/Compiler.h"
Torok Edwinc25e7582009-07-11 20:10:48 +000030#include "llvm/Support/ErrorHandling.h"
Chris Lattner86f7b212006-10-03 07:02:02 +000031#include "llvm/ADT/SmallVector.h"
Reid Spencer551ccae2004-09-01 22:55:40 +000032#include "llvm/ADT/Statistic.h"
Chris Lattnerf7703df2004-01-09 06:12:26 +000033using namespace llvm;
Brian Gaeked0fde302003-11-11 22:41:34 +000034
Chris Lattnerd216e8b2006-12-19 22:17:40 +000035STATISTIC(NumBroken, "Number of blocks inserted");
Chris Lattnerd76efa02002-09-24 00:08:39 +000036
Chris Lattnerd216e8b2006-12-19 22:17:40 +000037namespace {
Chris Lattner95255282006-06-28 23:17:24 +000038 struct VISIBILITY_HIDDEN BreakCriticalEdges : public FunctionPass {
Nick Lewyckyecd94c82007-05-06 13:37:16 +000039 static char ID; // Pass identification, replacement for typeid
Dan Gohmanae73dc12008-09-04 17:05:41 +000040 BreakCriticalEdges() : FunctionPass(&ID) {}
Devang Patel794fd752007-05-01 21:15:47 +000041
Chris Lattner6de302b2002-09-24 15:43:12 +000042 virtual bool runOnFunction(Function &F);
Misha Brukmanfd939082005-04-21 23:48:37 +000043
Chris Lattner6de302b2002-09-24 15:43:12 +000044 virtual void getAnalysisUsage(AnalysisUsage &AU) const {
Owen Andersona3ca0b62007-04-07 05:57:09 +000045 AU.addPreserved<DominatorTree>();
Chris Lattner6918c072002-10-31 02:44:36 +000046 AU.addPreserved<DominanceFrontier>();
Chris Lattner0ae380a2005-08-13 01:38:43 +000047 AU.addPreserved<LoopInfo>();
Andreas Neustifterff5dfdf2009-09-09 17:53:39 +000048 AU.addPreserved<ProfileInfo>();
Chris Lattner98bf4362003-10-12 21:52:28 +000049
50 // No loop canonicalization guarantees are broken by this pass.
51 AU.addPreservedID(LoopSimplifyID);
Chris Lattner6de302b2002-09-24 15:43:12 +000052 }
53 };
Chris Lattner6de302b2002-09-24 15:43:12 +000054}
Chris Lattnerd76efa02002-09-24 00:08:39 +000055
Dan Gohman844731a2008-05-13 00:00:25 +000056char BreakCriticalEdges::ID = 0;
57static RegisterPass<BreakCriticalEdges>
58X("break-crit-edges", "Break critical edges in CFG");
59
Chris Lattnereb0456c2002-09-24 15:51:56 +000060// Publically exposed interface to pass...
Dan Gohman6ddba2b2008-05-13 02:05:11 +000061const PassInfo *const llvm::BreakCriticalEdgesID = &X;
Chris Lattner1e5fdf82004-07-31 10:01:58 +000062FunctionPass *llvm::createBreakCriticalEdgesPass() {
63 return new BreakCriticalEdges();
64}
Chris Lattnerd76efa02002-09-24 00:08:39 +000065
Chris Lattner363ca612003-11-10 04:42:42 +000066// runOnFunction - Loop over all of the edges in the CFG, breaking critical
67// edges as they are found.
68//
69bool BreakCriticalEdges::runOnFunction(Function &F) {
70 bool Changed = false;
71 for (Function::iterator I = F.begin(), E = F.end(); I != E; ++I) {
72 TerminatorInst *TI = I->getTerminator();
73 if (TI->getNumSuccessors() > 1)
74 for (unsigned i = 0, e = TI->getNumSuccessors(); i != e; ++i)
75 if (SplitCriticalEdge(TI, i, this)) {
76 ++NumBroken;
77 Changed = true;
78 }
79 }
80
81 return Changed;
82}
83
84//===----------------------------------------------------------------------===//
85// Implementation of the external critical edge manipulation functions
86//===----------------------------------------------------------------------===//
Chris Lattnereb0456c2002-09-24 15:51:56 +000087
88// isCriticalEdge - Return true if the specified edge is a critical edge.
89// Critical edges are edges from a block with multiple successors to a block
90// with multiple predecessors.
91//
Chris Lattnerb57de332006-10-28 06:58:17 +000092bool llvm::isCriticalEdge(const TerminatorInst *TI, unsigned SuccNum,
93 bool AllowIdenticalEdges) {
Chris Lattnereb0456c2002-09-24 15:51:56 +000094 assert(SuccNum < TI->getNumSuccessors() && "Illegal edge specification!");
Chris Lattnere802a022002-10-08 21:06:27 +000095 if (TI->getNumSuccessors() == 1) return false;
Chris Lattnereb0456c2002-09-24 15:51:56 +000096
97 const BasicBlock *Dest = TI->getSuccessor(SuccNum);
98 pred_const_iterator I = pred_begin(Dest), E = pred_end(Dest);
99
100 // If there is more than one predecessor, this is a critical edge...
101 assert(I != E && "No preds, but we have an edge to the block?");
Chris Lattnerb57de332006-10-28 06:58:17 +0000102 const BasicBlock *FirstPred = *I;
Chris Lattnereb0456c2002-09-24 15:51:56 +0000103 ++I; // Skip one edge due to the incoming arc from TI.
Chris Lattnerb57de332006-10-28 06:58:17 +0000104 if (!AllowIdenticalEdges)
105 return I != E;
106
107 // If AllowIdenticalEdges is true, then we allow this edge to be considered
108 // non-critical iff all preds come from TI's block.
Scott Michel4bf393a2008-04-16 23:46:39 +0000109 while (I != E) {
Scott Michel4bf393a2008-04-16 23:46:39 +0000110 if (*I != FirstPred)
111 return true;
112 // Note: leave this as is until no one ever compiles with either gcc 4.0.1
113 // or Xcode 2. This seems to work around the pred_iterator assert in PR 2207
114 E = pred_end(*I);
115 ++I;
116 }
Chris Lattnerb57de332006-10-28 06:58:17 +0000117 return false;
Chris Lattnereb0456c2002-09-24 15:51:56 +0000118}
119
Chris Lattner862f27e2008-04-21 00:19:16 +0000120/// SplitCriticalEdge - If this edge is a critical edge, insert a new node to
121/// split the critical edge. This will update DominatorTree and
122/// DominatorFrontier information if it is available, thus calling this pass
123/// will not invalidate any of them. This returns true if the edge was split,
124/// false otherwise. This ensures that all edges to that dest go to one block
125/// instead of each going to a different block.
Chris Lattnereb0456c2002-09-24 15:51:56 +0000126//
Dan Gohman5c89b522009-09-08 15:45:00 +0000127BasicBlock *llvm::SplitCriticalEdge(TerminatorInst *TI, unsigned SuccNum,
128 Pass *P, bool MergeIdenticalEdges) {
129 if (!isCriticalEdge(TI, SuccNum, MergeIdenticalEdges)) return 0;
Chris Lattnereb0456c2002-09-24 15:51:56 +0000130 BasicBlock *TIBB = TI->getParent();
Chris Lattner6918c072002-10-31 02:44:36 +0000131 BasicBlock *DestBB = TI->getSuccessor(SuccNum);
Chris Lattnereb0456c2002-09-24 15:51:56 +0000132
133 // Create a new basic block, linking it into the CFG.
Owen Anderson1d0be152009-08-13 21:58:54 +0000134 BasicBlock *NewBB = BasicBlock::Create(TI->getContext(),
135 TIBB->getName() + "." + DestBB->getName() + "_crit_edge");
Chris Lattnereb0456c2002-09-24 15:51:56 +0000136 // Create our unconditional branch...
Gabor Greif051a9502008-04-06 20:25:17 +0000137 BranchInst::Create(DestBB, NewBB);
Misha Brukmanfd939082005-04-21 23:48:37 +0000138
Chris Lattner27e1f902006-10-28 06:44:56 +0000139 // Branch to the new block, breaking the edge.
Chris Lattnereb0456c2002-09-24 15:51:56 +0000140 TI->setSuccessor(SuccNum, NewBB);
141
142 // Insert the block into the function... right after the block TI lives in.
143 Function &F = *TIBB->getParent();
Chris Lattner261cdfb2007-04-17 18:09:47 +0000144 Function::iterator FBBI = TIBB;
145 F.getBasicBlockList().insert(++FBBI, NewBB);
Chris Lattner27e1f902006-10-28 06:44:56 +0000146
Chris Lattnereb0456c2002-09-24 15:51:56 +0000147 // If there are any PHI nodes in DestBB, we need to update them so that they
148 // merge incoming values from NewBB instead of from TIBB.
149 //
Reid Spencer2da5c3d2004-09-15 17:06:42 +0000150 for (BasicBlock::iterator I = DestBB->begin(); isa<PHINode>(I); ++I) {
151 PHINode *PN = cast<PHINode>(I);
Chris Lattner06887c92004-02-29 22:24:41 +0000152 // We no longer enter through TIBB, now we come in through NewBB. Revector
153 // exactly one entry in the PHI node that used to come from TIBB to come
154 // from NewBB.
Chris Lattnerb01bfd42005-08-12 21:58:07 +0000155 int BBIdx = PN->getBasicBlockIndex(TIBB);
156 PN->setIncomingBlock(BBIdx, NewBB);
Chris Lattnereb0456c2002-09-24 15:51:56 +0000157 }
Chris Lattner27e1f902006-10-28 06:44:56 +0000158
159 // If there are any other edges from TIBB to DestBB, update those to go
160 // through the split block, making those edges non-critical as well (and
161 // reducing the number of phi entries in the DestBB if relevant).
162 if (MergeIdenticalEdges) {
163 for (unsigned i = SuccNum+1, e = TI->getNumSuccessors(); i != e; ++i) {
164 if (TI->getSuccessor(i) != DestBB) continue;
165
166 // Remove an entry for TIBB from DestBB phi nodes.
167 DestBB->removePredecessor(TIBB);
168
169 // We found another edge to DestBB, go to NewBB instead.
170 TI->setSuccessor(i, NewBB);
171 }
172 }
173
174
Chris Lattnereb0456c2002-09-24 15:51:56 +0000175
Chris Lattnere802a022002-10-08 21:06:27 +0000176 // If we don't have a pass object, we can't update anything...
Dan Gohman5c89b522009-09-08 15:45:00 +0000177 if (P == 0) return NewBB;
Chris Lattnere802a022002-10-08 21:06:27 +0000178
Chris Lattner86f7b212006-10-03 07:02:02 +0000179 // Now update analysis information. Since the only predecessor of NewBB is
180 // the TIBB, TIBB clearly dominates NewBB. TIBB usually doesn't dominate
181 // anything, as there are other successors of DestBB. However, if all other
182 // predecessors of DestBB are already dominated by DestBB (e.g. DestBB is a
183 // loop header) then NewBB dominates DestBB.
184 SmallVector<BasicBlock*, 8> OtherPreds;
Chris Lattnereb0456c2002-09-24 15:51:56 +0000185
Chris Lattner86f7b212006-10-03 07:02:02 +0000186 for (pred_iterator I = pred_begin(DestBB), E = pred_end(DestBB); I != E; ++I)
187 if (*I != NewBB)
188 OtherPreds.push_back(*I);
189
Chris Lattner86f7b212006-10-03 07:02:02 +0000190 bool NewBBDominatesDestBB = true;
191
Chris Lattnerc178d942002-09-26 16:18:51 +0000192 // Should we update DominatorTree information?
Duncan Sands1465d612009-01-28 13:14:17 +0000193 if (DominatorTree *DT = P->getAnalysisIfAvailable<DominatorTree>()) {
Devang Patel26042422007-06-04 00:32:22 +0000194 DomTreeNode *TINode = DT->getNode(TIBB);
Misha Brukmanfd939082005-04-21 23:48:37 +0000195
Chris Lattnerc178d942002-09-26 16:18:51 +0000196 // The new block is not the immediate dominator for any other nodes, but
197 // TINode is the immediate dominator for the new node.
198 //
Chris Lattner86f7b212006-10-03 07:02:02 +0000199 if (TINode) { // Don't break unreachable code!
Devang Patel83beaee2007-06-04 16:43:25 +0000200 DomTreeNode *NewBBNode = DT->addNewBlock(NewBB, TIBB);
Devang Patel26042422007-06-04 00:32:22 +0000201 DomTreeNode *DestBBNode = 0;
Chris Lattner86f7b212006-10-03 07:02:02 +0000202
203 // If NewBBDominatesDestBB hasn't been computed yet, do so with DT.
204 if (!OtherPreds.empty()) {
205 DestBBNode = DT->getNode(DestBB);
206 while (!OtherPreds.empty() && NewBBDominatesDestBB) {
Devang Patel26042422007-06-04 00:32:22 +0000207 if (DomTreeNode *OPNode = DT->getNode(OtherPreds.back()))
Devang Patel9a511572007-06-07 17:47:21 +0000208 NewBBDominatesDestBB = DT->dominates(DestBBNode, OPNode);
Chris Lattner86f7b212006-10-03 07:02:02 +0000209 OtherPreds.pop_back();
210 }
211 OtherPreds.clear();
212 }
213
214 // If NewBBDominatesDestBB, then NewBB dominates DestBB, otherwise it
215 // doesn't dominate anything.
216 if (NewBBDominatesDestBB) {
217 if (!DestBBNode) DestBBNode = DT->getNode(DestBB);
218 DT->changeImmediateDominator(DestBBNode, NewBBNode);
219 }
220 }
Chris Lattnereb0456c2002-09-24 15:51:56 +0000221 }
Chris Lattner6918c072002-10-31 02:44:36 +0000222
223 // Should we update DominanceFrontier information?
Duncan Sands1465d612009-01-28 13:14:17 +0000224 if (DominanceFrontier *DF = P->getAnalysisIfAvailable<DominanceFrontier>()) {
Chris Lattner86f7b212006-10-03 07:02:02 +0000225 // If NewBBDominatesDestBB hasn't been computed yet, do so with DF.
226 if (!OtherPreds.empty()) {
Chris Lattner86f7b212006-10-03 07:02:02 +0000227 // FIXME: IMPLEMENT THIS!
Torok Edwinc23197a2009-07-14 16:55:14 +0000228 llvm_unreachable("Requiring domfrontiers but not idom/domtree/domset."
Torok Edwinc25e7582009-07-11 20:10:48 +0000229 " not implemented yet!");
Chris Lattner86f7b212006-10-03 07:02:02 +0000230 }
231
Chris Lattner6918c072002-10-31 02:44:36 +0000232 // Since the new block is dominated by its only predecessor TIBB,
Chris Lattner86f7b212006-10-03 07:02:02 +0000233 // it cannot be in any block's dominance frontier. If NewBB dominates
234 // DestBB, its dominance frontier is the same as DestBB's, otherwise it is
235 // just {DestBB}.
Chris Lattner6918c072002-10-31 02:44:36 +0000236 DominanceFrontier::DomSetType NewDFSet;
Chris Lattner86f7b212006-10-03 07:02:02 +0000237 if (NewBBDominatesDestBB) {
238 DominanceFrontier::iterator I = DF->find(DestBB);
Devang Patel6acc9e62007-08-13 21:59:17 +0000239 if (I != DF->end()) {
Chris Lattner86f7b212006-10-03 07:02:02 +0000240 DF->addBasicBlock(NewBB, I->second);
Owen Anderson269db292008-06-03 18:29:48 +0000241
242 if (I->second.count(DestBB)) {
243 // However NewBB's frontier does not include DestBB.
244 DominanceFrontier::iterator NF = DF->find(NewBB);
245 DF->removeFromFrontier(NF, DestBB);
246 }
Devang Patel6acc9e62007-08-13 21:59:17 +0000247 }
Chris Lattner86f7b212006-10-03 07:02:02 +0000248 else
249 DF->addBasicBlock(NewBB, DominanceFrontier::DomSetType());
250 } else {
251 DominanceFrontier::DomSetType NewDFSet;
252 NewDFSet.insert(DestBB);
253 DF->addBasicBlock(NewBB, NewDFSet);
254 }
Chris Lattner6918c072002-10-31 02:44:36 +0000255 }
Chris Lattner0ae380a2005-08-13 01:38:43 +0000256
257 // Update LoopInfo if it is around.
Duncan Sands1465d612009-01-28 13:14:17 +0000258 if (LoopInfo *LI = P->getAnalysisIfAvailable<LoopInfo>()) {
Dan Gohman5c89b522009-09-08 15:45:00 +0000259 if (Loop *TIL = LI->getLoopFor(TIBB)) {
260 // If one or the other blocks were not in a loop, the new block is not
261 // either, and thus LI doesn't need to be updated.
Chris Lattner0ae380a2005-08-13 01:38:43 +0000262 if (Loop *DestLoop = LI->getLoopFor(DestBB)) {
263 if (TIL == DestLoop) {
264 // Both in the same loop, the NewBB joins loop.
Owen Andersond735ee82007-11-27 03:43:35 +0000265 DestLoop->addBasicBlockToLoop(NewBB, LI->getBase());
Chris Lattner0ae380a2005-08-13 01:38:43 +0000266 } else if (TIL->contains(DestLoop->getHeader())) {
Chris Lattner86f7b212006-10-03 07:02:02 +0000267 // Edge from an outer loop to an inner loop. Add to the outer loop.
Owen Andersond735ee82007-11-27 03:43:35 +0000268 TIL->addBasicBlockToLoop(NewBB, LI->getBase());
Chris Lattner0ae380a2005-08-13 01:38:43 +0000269 } else if (DestLoop->contains(TIL->getHeader())) {
Chris Lattner86f7b212006-10-03 07:02:02 +0000270 // Edge from an inner loop to an outer loop. Add to the outer loop.
Owen Andersond735ee82007-11-27 03:43:35 +0000271 DestLoop->addBasicBlockToLoop(NewBB, LI->getBase());
Chris Lattner0ae380a2005-08-13 01:38:43 +0000272 } else {
273 // Edge from two loops with no containment relation. Because these
274 // are natural loops, we know that the destination block must be the
275 // header of its loop (adding a branch into a loop elsewhere would
276 // create an irreducible loop).
277 assert(DestLoop->getHeader() == DestBB &&
278 "Should not create irreducible loops!");
279 if (Loop *P = DestLoop->getParentLoop())
Owen Andersond735ee82007-11-27 03:43:35 +0000280 P->addBasicBlockToLoop(NewBB, LI->getBase());
Chris Lattner0ae380a2005-08-13 01:38:43 +0000281 }
282 }
Dan Gohman5c89b522009-09-08 15:45:00 +0000283 // If TIBB is in a loop and DestBB is outside of that loop, split the
284 // other exit blocks of the loop that also have predecessors outside
285 // the loop, to maintain a LoopSimplify guarantee.
286 if (!TIL->contains(DestBB) &&
287 P->mustPreserveAnalysisID(LoopSimplifyID)) {
288 // For each unique exit block...
289 SmallVector<BasicBlock *, 4> ExitBlocks;
290 TIL->getExitBlocks(ExitBlocks);
291 for (unsigned i = 0, e = ExitBlocks.size(); i != e; ++i) {
292 // Collect all the preds that are inside the loop, and note
293 // whether there are any preds outside the loop.
294 SmallVector<BasicBlock *, 4> Preds;
295 bool AllPredsInLoop = false;
296 BasicBlock *Exit = ExitBlocks[i];
297 for (pred_iterator I = pred_begin(Exit), E = pred_end(Exit);
298 I != E; ++I)
299 if (TIL->contains(*I))
300 Preds.push_back(*I);
301 else
302 AllPredsInLoop = true;
303 // If there are any preds not in the loop, we'll need to split
304 // the edges. The Preds.empty() check is needed because a block
305 // may appear multiple times in the list. We can't use
306 // getUniqueExitBlocks above because that depends on LoopSimplify
307 // form, which we're in the process of restoring!
308 if (Preds.empty() || !AllPredsInLoop) continue;
309 BasicBlock *NewBB = SplitBlockPredecessors(Exit,
310 Preds.data(), Preds.size(),
311 "split", P);
312 // Update LCSSA form by creating new PHIs in the new exit blocks
313 // as needed.
314 if (P->mustPreserveAnalysisID(LCSSAID))
315 for (BasicBlock::iterator I = Exit->begin();
316 PHINode *PN = dyn_cast<PHINode>(I); ++I) {
317 unsigned Idx = PN->getBasicBlockIndex(NewBB);
318 Value *V = PN->getIncomingValue(Idx);
319 // If the PHI is already suitable, don't create a new one.
320 if (PHINode *VP = dyn_cast<PHINode>(V))
321 if (VP->getParent() == NewBB)
322 continue;
323 // A new PHI is needed. Create one and populate it.
324 PHINode *NewPN =
325 PHINode::Create(PN->getType(), "split", NewBB->getTerminator());
326 for (unsigned i = 0, e = Preds.size(); i != e; ++i)
327 NewPN->addIncoming(V, Preds[i]);
328 PN->setIncomingValue(Idx, NewPN);
329 }
330 }
331 }
332 // LCSSA form was updated above for the case where LoopSimplify is
333 // available, which means that all predecessors of loop exit blocks
334 // are within the loop. Without LoopSimplify form, it would be
335 // necessary to insert a new phi.
336 assert((!P->mustPreserveAnalysisID(LCSSAID) ||
337 P->mustPreserveAnalysisID(LoopSimplifyID)) &&
338 "SplitCriticalEdge doesn't know how to update LCCSA form "
339 "without LoopSimplify!");
340 }
Chris Lattner0ae380a2005-08-13 01:38:43 +0000341 }
Dan Gohman5c89b522009-09-08 15:45:00 +0000342
Andreas Neustifterff5dfdf2009-09-09 17:53:39 +0000343 // Update ProfileInfo if it is around.
344 if (ProfileInfo *PI = P->getAnalysisIfAvailable<ProfileInfo>()) {
345 PI->splitEdge(TIBB,DestBB,NewBB,MergeIdenticalEdges);
346 }
347
Dan Gohman5c89b522009-09-08 15:45:00 +0000348 return NewBB;
Chris Lattnereb0456c2002-09-24 15:51:56 +0000349}