blob: 76ebb9ff60aadc6e0ece45086af55b05153b2f26 [file] [log] [blame]
Chris Lattnerd76efa02002-09-24 00:08:39 +00001//===- BreakCriticalEdges.cpp - Critical Edge Elimination Pass ------------===//
Misha Brukmanfd939082005-04-21 23:48:37 +00002//
John Criswellb576c942003-10-20 19:43:21 +00003// The LLVM Compiler Infrastructure
4//
Chris Lattner4ee451d2007-12-29 20:36:04 +00005// This file is distributed under the University of Illinois Open Source
6// License. See LICENSE.TXT for details.
Misha Brukmanfd939082005-04-21 23:48:37 +00007//
John Criswellb576c942003-10-20 19:43:21 +00008//===----------------------------------------------------------------------===//
Chris Lattnerd76efa02002-09-24 00:08:39 +00009//
10// BreakCriticalEdges pass - Break all of the critical edges in the CFG by
11// inserting a dummy basic block. This pass may be "required" by passes that
12// cannot deal with critical edges. For this usage, the structure type is
13// forward declared. This pass obviously invalidates the CFG, but can update
Cameron Zwarich30127872011-01-18 04:11:31 +000014// dominator trees.
Chris Lattnerd76efa02002-09-24 00:08:39 +000015//
16//===----------------------------------------------------------------------===//
17
Chris Lattnerd216e8b2006-12-19 22:17:40 +000018#define DEBUG_TYPE "break-crit-edges"
Chris Lattnerd76efa02002-09-24 00:08:39 +000019#include "llvm/Transforms/Scalar.h"
Chandler Carruthd04a8d42012-12-03 16:50:05 +000020#include "llvm/ADT/SmallVector.h"
21#include "llvm/ADT/Statistic.h"
Nick Lewycky81e48042013-07-27 01:24:00 +000022#include "llvm/Analysis/CFG.h"
Chris Lattner0ae380a2005-08-13 01:38:43 +000023#include "llvm/Analysis/LoopInfo.h"
Stephen Hines36b56882014-04-23 16:57:46 -070024#include "llvm/IR/CFG.h"
25#include "llvm/IR/Dominators.h"
Chandler Carruth0b8c9a82013-01-02 11:36:10 +000026#include "llvm/IR/Function.h"
27#include "llvm/IR/Instructions.h"
28#include "llvm/IR/Type.h"
Torok Edwinc25e7582009-07-11 20:10:48 +000029#include "llvm/Support/ErrorHandling.h"
Chandler Carruthd04a8d42012-12-03 16:50:05 +000030#include "llvm/Transforms/Utils/BasicBlockUtils.h"
Chris Lattnerf7703df2004-01-09 06:12:26 +000031using namespace llvm;
Brian Gaeked0fde302003-11-11 22:41:34 +000032
Chris Lattnerd216e8b2006-12-19 22:17:40 +000033STATISTIC(NumBroken, "Number of blocks inserted");
Chris Lattnerd76efa02002-09-24 00:08:39 +000034
Chris Lattnerd216e8b2006-12-19 22:17:40 +000035namespace {
Nick Lewycky6726b6d2009-10-25 06:33:48 +000036 struct BreakCriticalEdges : public FunctionPass {
Nick Lewyckyecd94c82007-05-06 13:37:16 +000037 static char ID; // Pass identification, replacement for typeid
Owen Anderson081c34b2010-10-19 17:21:58 +000038 BreakCriticalEdges() : FunctionPass(ID) {
39 initializeBreakCriticalEdgesPass(*PassRegistry::getPassRegistry());
40 }
Devang Patel794fd752007-05-01 21:15:47 +000041
Stephen Hines36b56882014-04-23 16:57:46 -070042 bool runOnFunction(Function &F) override;
Misha Brukmanfd939082005-04-21 23:48:37 +000043
Stephen Hines36b56882014-04-23 16:57:46 -070044 void getAnalysisUsage(AnalysisUsage &AU) const override {
45 AU.addPreserved<DominatorTreeWrapperPass>();
Chris Lattner0ae380a2005-08-13 01:38:43 +000046 AU.addPreserved<LoopInfo>();
Chris Lattner98bf4362003-10-12 21:52:28 +000047
48 // No loop canonicalization guarantees are broken by this pass.
49 AU.addPreservedID(LoopSimplifyID);
Chris Lattner6de302b2002-09-24 15:43:12 +000050 }
51 };
Chris Lattner6de302b2002-09-24 15:43:12 +000052}
Chris Lattnerd76efa02002-09-24 00:08:39 +000053
Dan Gohman844731a2008-05-13 00:00:25 +000054char BreakCriticalEdges::ID = 0;
Owen Anderson02dd53e2010-08-23 17:52:01 +000055INITIALIZE_PASS(BreakCriticalEdges, "break-crit-edges",
Owen Andersonce665bd2010-10-07 22:25:06 +000056 "Break critical edges in CFG", false, false)
Dan Gohman844731a2008-05-13 00:00:25 +000057
Chris Lattner7a2bdde2011-04-15 05:18:47 +000058// Publicly exposed interface to pass...
Owen Anderson90c579d2010-08-06 18:33:48 +000059char &llvm::BreakCriticalEdgesID = BreakCriticalEdges::ID;
Chris Lattner1e5fdf82004-07-31 10:01:58 +000060FunctionPass *llvm::createBreakCriticalEdgesPass() {
61 return new BreakCriticalEdges();
62}
Chris Lattnerd76efa02002-09-24 00:08:39 +000063
Chris Lattner363ca612003-11-10 04:42:42 +000064// runOnFunction - Loop over all of the edges in the CFG, breaking critical
65// edges as they are found.
66//
67bool BreakCriticalEdges::runOnFunction(Function &F) {
68 bool Changed = false;
69 for (Function::iterator I = F.begin(), E = F.end(); I != E; ++I) {
70 TerminatorInst *TI = I->getTerminator();
Chris Lattner1b98ff32009-10-31 21:51:10 +000071 if (TI->getNumSuccessors() > 1 && !isa<IndirectBrInst>(TI))
Chris Lattner363ca612003-11-10 04:42:42 +000072 for (unsigned i = 0, e = TI->getNumSuccessors(); i != e; ++i)
73 if (SplitCriticalEdge(TI, i, this)) {
74 ++NumBroken;
75 Changed = true;
76 }
77 }
78
79 return Changed;
80}
81
82//===----------------------------------------------------------------------===//
83// Implementation of the external critical edge manipulation functions
84//===----------------------------------------------------------------------===//
Chris Lattnereb0456c2002-09-24 15:51:56 +000085
Bill Wendling38da2a82012-04-30 10:25:51 +000086/// createPHIsForSplitLoopExit - When a loop exit edge is split, LCSSA form
Dan Gohmanc292caf2009-09-09 18:18:18 +000087/// may require new PHIs in the new exit block. This function inserts the
Bill Wendlingbfbab992012-04-30 10:44:54 +000088/// new PHIs, as needed. Preds is a list of preds inside the loop, SplitBB
Dan Gohmanc292caf2009-09-09 18:18:18 +000089/// is the new loop exit block, and DestBB is the old loop exit, now the
90/// successor of SplitBB.
Bill Wendling38da2a82012-04-30 10:25:51 +000091static void createPHIsForSplitLoopExit(ArrayRef<BasicBlock *> Preds,
Dan Gohmanc292caf2009-09-09 18:18:18 +000092 BasicBlock *SplitBB,
93 BasicBlock *DestBB) {
94 // SplitBB shouldn't have anything non-trivial in it yet.
Bill Wendlingbfbab992012-04-30 10:44:54 +000095 assert((SplitBB->getFirstNonPHI() == SplitBB->getTerminator() ||
96 SplitBB->isLandingPad()) && "SplitBB has non-PHI nodes!");
Dan Gohmanc292caf2009-09-09 18:18:18 +000097
Bill Wendlingbfbab992012-04-30 10:44:54 +000098 // For each PHI in the destination block.
Dan Gohmanc292caf2009-09-09 18:18:18 +000099 for (BasicBlock::iterator I = DestBB->begin();
100 PHINode *PN = dyn_cast<PHINode>(I); ++I) {
101 unsigned Idx = PN->getBasicBlockIndex(SplitBB);
102 Value *V = PN->getIncomingValue(Idx);
Bill Wendlingbfbab992012-04-30 10:44:54 +0000103
Dan Gohmanc292caf2009-09-09 18:18:18 +0000104 // If the input is a PHI which already satisfies LCSSA, don't create
105 // a new one.
106 if (const PHINode *VP = dyn_cast<PHINode>(V))
107 if (VP->getParent() == SplitBB)
108 continue;
Bill Wendlingbfbab992012-04-30 10:44:54 +0000109
Dan Gohmanc292caf2009-09-09 18:18:18 +0000110 // Otherwise a new PHI is needed. Create one and populate it.
Bill Wendlingbfbab992012-04-30 10:44:54 +0000111 PHINode *NewPN =
112 PHINode::Create(PN->getType(), Preds.size(), "split",
113 SplitBB->isLandingPad() ?
114 SplitBB->begin() : SplitBB->getTerminator());
Dan Gohmanc292caf2009-09-09 18:18:18 +0000115 for (unsigned i = 0, e = Preds.size(); i != e; ++i)
116 NewPN->addIncoming(V, Preds[i]);
Bill Wendlingbfbab992012-04-30 10:44:54 +0000117
Dan Gohmanc292caf2009-09-09 18:18:18 +0000118 // Update the original PHI.
119 PN->setIncomingValue(Idx, NewPN);
120 }
121}
122
Chris Lattner862f27e2008-04-21 00:19:16 +0000123/// SplitCriticalEdge - If this edge is a critical edge, insert a new node to
Cameron Zwarich30127872011-01-18 04:11:31 +0000124/// split the critical edge. This will update DominatorTree information if it
125/// is available, thus calling this pass will not invalidate either of them.
126/// This returns the new block if the edge was split, null otherwise.
Chris Lattner1b98ff32009-10-31 21:51:10 +0000127///
128/// If MergeIdenticalEdges is true (not the default), *all* edges from TI to the
Andrew Trick2aeb8022011-10-04 03:34:49 +0000129/// specified successor will be merged into the same critical edge block.
130/// This is most commonly interesting with switch instructions, which may
Chris Lattner1b98ff32009-10-31 21:51:10 +0000131/// have many edges to any one destination. This ensures that all edges to that
Andrew Trick2aeb8022011-10-04 03:34:49 +0000132/// dest go to one block instead of each going to a different block, but isn't
Chris Lattner1b98ff32009-10-31 21:51:10 +0000133/// the standard definition of a "critical edge".
134///
135/// It is invalid to call this function on a critical edge that starts at an
136/// IndirectBrInst. Splitting these edges will almost always create an invalid
Chris Lattner280f3fe2009-11-01 18:17:37 +0000137/// program because the address of the new block won't be the one that is jumped
Chris Lattner1b98ff32009-10-31 21:51:10 +0000138/// to.
139///
Dan Gohman5c89b522009-09-08 15:45:00 +0000140BasicBlock *llvm::SplitCriticalEdge(TerminatorInst *TI, unsigned SuccNum,
Andrew Trickf143b792011-10-04 03:50:44 +0000141 Pass *P, bool MergeIdenticalEdges,
Bill Wendlingbfbab992012-04-30 10:44:54 +0000142 bool DontDeleteUselessPhis,
143 bool SplitLandingPads) {
Dan Gohman5c89b522009-09-08 15:45:00 +0000144 if (!isCriticalEdge(TI, SuccNum, MergeIdenticalEdges)) return 0;
Andrew Trick2aeb8022011-10-04 03:34:49 +0000145
Chris Lattner1b98ff32009-10-31 21:51:10 +0000146 assert(!isa<IndirectBrInst>(TI) &&
147 "Cannot split critical edge from IndirectBrInst");
Andrew Trick2aeb8022011-10-04 03:34:49 +0000148
Chris Lattnereb0456c2002-09-24 15:51:56 +0000149 BasicBlock *TIBB = TI->getParent();
Chris Lattner6918c072002-10-31 02:44:36 +0000150 BasicBlock *DestBB = TI->getSuccessor(SuccNum);
Chris Lattnereb0456c2002-09-24 15:51:56 +0000151
Bill Wendling490606e2011-08-17 21:04:05 +0000152 // Splitting the critical edge to a landing pad block is non-trivial. Don't do
153 // it in this generic function.
Bill Wendlingf0dc2572011-09-20 22:28:17 +0000154 if (DestBB->isLandingPad()) return 0;
Bill Wendling490606e2011-08-17 21:04:05 +0000155
Chris Lattnereb0456c2002-09-24 15:51:56 +0000156 // Create a new basic block, linking it into the CFG.
Owen Anderson1d0be152009-08-13 21:58:54 +0000157 BasicBlock *NewBB = BasicBlock::Create(TI->getContext(),
158 TIBB->getName() + "." + DestBB->getName() + "_crit_edge");
Chris Lattner277cccc2010-02-13 04:24:19 +0000159 // Create our unconditional branch.
Devang Patelc9ea7712011-05-17 19:43:06 +0000160 BranchInst *NewBI = BranchInst::Create(DestBB, NewBB);
161 NewBI->setDebugLoc(TI->getDebugLoc());
Misha Brukmanfd939082005-04-21 23:48:37 +0000162
Chris Lattner27e1f902006-10-28 06:44:56 +0000163 // Branch to the new block, breaking the edge.
Chris Lattnereb0456c2002-09-24 15:51:56 +0000164 TI->setSuccessor(SuccNum, NewBB);
165
166 // Insert the block into the function... right after the block TI lives in.
167 Function &F = *TIBB->getParent();
Chris Lattner261cdfb2007-04-17 18:09:47 +0000168 Function::iterator FBBI = TIBB;
169 F.getBasicBlockList().insert(++FBBI, NewBB);
Andrew Trick2aeb8022011-10-04 03:34:49 +0000170
Chris Lattnereb0456c2002-09-24 15:51:56 +0000171 // If there are any PHI nodes in DestBB, we need to update them so that they
172 // merge incoming values from NewBB instead of from TIBB.
Jay Foad95c3e482011-06-23 09:09:15 +0000173 {
174 unsigned BBIdx = 0;
175 for (BasicBlock::iterator I = DestBB->begin(); isa<PHINode>(I); ++I) {
176 // We no longer enter through TIBB, now we come in through NewBB.
177 // Revector exactly one entry in the PHI node that used to come from
178 // TIBB to come from NewBB.
179 PHINode *PN = cast<PHINode>(I);
180
181 // Reuse the previous value of BBIdx if it lines up. In cases where we
182 // have multiple phi nodes with *lots* of predecessors, this is a speed
183 // win because we don't have to scan the PHI looking for TIBB. This
184 // happens because the BB list of PHI nodes are usually in the same
185 // order.
186 if (PN->getIncomingBlock(BBIdx) != TIBB)
Andrew Trick2aeb8022011-10-04 03:34:49 +0000187 BBIdx = PN->getBasicBlockIndex(TIBB);
Jay Foad95c3e482011-06-23 09:09:15 +0000188 PN->setIncomingBlock(BBIdx, NewBB);
Chris Lattner6686c6b2010-02-13 05:01:14 +0000189 }
Chris Lattnereb0456c2002-09-24 15:51:56 +0000190 }
Andrew Trick2aeb8022011-10-04 03:34:49 +0000191
Chris Lattner27e1f902006-10-28 06:44:56 +0000192 // If there are any other edges from TIBB to DestBB, update those to go
193 // through the split block, making those edges non-critical as well (and
194 // reducing the number of phi entries in the DestBB if relevant).
195 if (MergeIdenticalEdges) {
196 for (unsigned i = SuccNum+1, e = TI->getNumSuccessors(); i != e; ++i) {
197 if (TI->getSuccessor(i) != DestBB) continue;
Andrew Trick2aeb8022011-10-04 03:34:49 +0000198
Chris Lattner27e1f902006-10-28 06:44:56 +0000199 // Remove an entry for TIBB from DestBB phi nodes.
Andrew Trickf143b792011-10-04 03:50:44 +0000200 DestBB->removePredecessor(TIBB, DontDeleteUselessPhis);
Andrew Trick2aeb8022011-10-04 03:34:49 +0000201
Chris Lattner27e1f902006-10-28 06:44:56 +0000202 // We found another edge to DestBB, go to NewBB instead.
203 TI->setSuccessor(i, NewBB);
204 }
205 }
Andrew Trick2aeb8022011-10-04 03:34:49 +0000206
207
Chris Lattnereb0456c2002-09-24 15:51:56 +0000208
Chris Lattnere802a022002-10-08 21:06:27 +0000209 // If we don't have a pass object, we can't update anything...
Dan Gohman5c89b522009-09-08 15:45:00 +0000210 if (P == 0) return NewBB;
Andrew Trick2aeb8022011-10-04 03:34:49 +0000211
Stephen Hines36b56882014-04-23 16:57:46 -0700212 DominatorTreeWrapperPass *DTWP =
213 P->getAnalysisIfAvailable<DominatorTreeWrapperPass>();
214 DominatorTree *DT = DTWP ? &DTWP->getDomTree() : 0;
Chris Lattner6686c6b2010-02-13 05:01:14 +0000215 LoopInfo *LI = P->getAnalysisIfAvailable<LoopInfo>();
Andrew Trick2aeb8022011-10-04 03:34:49 +0000216
Chris Lattner6686c6b2010-02-13 05:01:14 +0000217 // If we have nothing to update, just return.
Chandler Carruthdd5d86d2013-10-02 15:42:23 +0000218 if (DT == 0 && LI == 0)
Chris Lattner6686c6b2010-02-13 05:01:14 +0000219 return NewBB;
Chris Lattnere802a022002-10-08 21:06:27 +0000220
Chris Lattner86f7b212006-10-03 07:02:02 +0000221 // Now update analysis information. Since the only predecessor of NewBB is
222 // the TIBB, TIBB clearly dominates NewBB. TIBB usually doesn't dominate
223 // anything, as there are other successors of DestBB. However, if all other
224 // predecessors of DestBB are already dominated by DestBB (e.g. DestBB is a
225 // loop header) then NewBB dominates DestBB.
226 SmallVector<BasicBlock*, 8> OtherPreds;
Chris Lattnereb0456c2002-09-24 15:51:56 +0000227
Chris Lattner2f36ea82010-02-13 04:15:26 +0000228 // If there is a PHI in the block, loop over predecessors with it, which is
229 // faster than iterating pred_begin/end.
230 if (PHINode *PN = dyn_cast<PHINode>(DestBB->begin())) {
231 for (unsigned i = 0, e = PN->getNumIncomingValues(); i != e; ++i)
232 if (PN->getIncomingBlock(i) != NewBB)
233 OtherPreds.push_back(PN->getIncomingBlock(i));
234 } else {
235 for (pred_iterator I = pred_begin(DestBB), E = pred_end(DestBB);
Gabor Greif7556cf52010-07-09 15:25:42 +0000236 I != E; ++I) {
237 BasicBlock *P = *I;
238 if (P != NewBB)
Chris Lattner70e5e222011-01-14 04:23:53 +0000239 OtherPreds.push_back(P);
Gabor Greif7556cf52010-07-09 15:25:42 +0000240 }
Chris Lattner2f36ea82010-02-13 04:15:26 +0000241 }
Gabor Greif7556cf52010-07-09 15:25:42 +0000242
Chris Lattner86f7b212006-10-03 07:02:02 +0000243 bool NewBBDominatesDestBB = true;
Andrew Trick2aeb8022011-10-04 03:34:49 +0000244
Chris Lattnerc178d942002-09-26 16:18:51 +0000245 // Should we update DominatorTree information?
Chris Lattner6686c6b2010-02-13 05:01:14 +0000246 if (DT) {
Devang Patel26042422007-06-04 00:32:22 +0000247 DomTreeNode *TINode = DT->getNode(TIBB);
Misha Brukmanfd939082005-04-21 23:48:37 +0000248
Chris Lattnerc178d942002-09-26 16:18:51 +0000249 // The new block is not the immediate dominator for any other nodes, but
250 // TINode is the immediate dominator for the new node.
251 //
Chris Lattner86f7b212006-10-03 07:02:02 +0000252 if (TINode) { // Don't break unreachable code!
Devang Patel83beaee2007-06-04 16:43:25 +0000253 DomTreeNode *NewBBNode = DT->addNewBlock(NewBB, TIBB);
Devang Patel26042422007-06-04 00:32:22 +0000254 DomTreeNode *DestBBNode = 0;
Andrew Trick2aeb8022011-10-04 03:34:49 +0000255
Chris Lattner86f7b212006-10-03 07:02:02 +0000256 // If NewBBDominatesDestBB hasn't been computed yet, do so with DT.
257 if (!OtherPreds.empty()) {
258 DestBBNode = DT->getNode(DestBB);
259 while (!OtherPreds.empty() && NewBBDominatesDestBB) {
Devang Patel26042422007-06-04 00:32:22 +0000260 if (DomTreeNode *OPNode = DT->getNode(OtherPreds.back()))
Devang Patel9a511572007-06-07 17:47:21 +0000261 NewBBDominatesDestBB = DT->dominates(DestBBNode, OPNode);
Chris Lattner86f7b212006-10-03 07:02:02 +0000262 OtherPreds.pop_back();
263 }
264 OtherPreds.clear();
265 }
Andrew Trick2aeb8022011-10-04 03:34:49 +0000266
Chris Lattner86f7b212006-10-03 07:02:02 +0000267 // If NewBBDominatesDestBB, then NewBB dominates DestBB, otherwise it
268 // doesn't dominate anything.
269 if (NewBBDominatesDestBB) {
270 if (!DestBBNode) DestBBNode = DT->getNode(DestBB);
271 DT->changeImmediateDominator(DestBBNode, NewBBNode);
272 }
273 }
Chris Lattnereb0456c2002-09-24 15:51:56 +0000274 }
Chris Lattner6918c072002-10-31 02:44:36 +0000275
Chris Lattner0ae380a2005-08-13 01:38:43 +0000276 // Update LoopInfo if it is around.
Chris Lattner6686c6b2010-02-13 05:01:14 +0000277 if (LI) {
Dan Gohman5c89b522009-09-08 15:45:00 +0000278 if (Loop *TIL = LI->getLoopFor(TIBB)) {
279 // If one or the other blocks were not in a loop, the new block is not
280 // either, and thus LI doesn't need to be updated.
Chris Lattner0ae380a2005-08-13 01:38:43 +0000281 if (Loop *DestLoop = LI->getLoopFor(DestBB)) {
282 if (TIL == DestLoop) {
283 // Both in the same loop, the NewBB joins loop.
Owen Andersond735ee82007-11-27 03:43:35 +0000284 DestLoop->addBasicBlockToLoop(NewBB, LI->getBase());
Dan Gohman92329c72009-12-18 01:24:09 +0000285 } else if (TIL->contains(DestLoop)) {
Chris Lattner86f7b212006-10-03 07:02:02 +0000286 // Edge from an outer loop to an inner loop. Add to the outer loop.
Owen Andersond735ee82007-11-27 03:43:35 +0000287 TIL->addBasicBlockToLoop(NewBB, LI->getBase());
Dan Gohman92329c72009-12-18 01:24:09 +0000288 } else if (DestLoop->contains(TIL)) {
Chris Lattner86f7b212006-10-03 07:02:02 +0000289 // Edge from an inner loop to an outer loop. Add to the outer loop.
Owen Andersond735ee82007-11-27 03:43:35 +0000290 DestLoop->addBasicBlockToLoop(NewBB, LI->getBase());
Chris Lattner0ae380a2005-08-13 01:38:43 +0000291 } else {
292 // Edge from two loops with no containment relation. Because these
293 // are natural loops, we know that the destination block must be the
294 // header of its loop (adding a branch into a loop elsewhere would
295 // create an irreducible loop).
296 assert(DestLoop->getHeader() == DestBB &&
297 "Should not create irreducible loops!");
298 if (Loop *P = DestLoop->getParentLoop())
Owen Andersond735ee82007-11-27 03:43:35 +0000299 P->addBasicBlockToLoop(NewBB, LI->getBase());
Chris Lattner0ae380a2005-08-13 01:38:43 +0000300 }
301 }
Stephen Hines36b56882014-04-23 16:57:46 -0700302 // If TIBB is in a loop and DestBB is outside of that loop, we may need
303 // to update LoopSimplify form and LCSSA form.
Dan Gohman5c89b522009-09-08 15:45:00 +0000304 if (!TIL->contains(DestBB) &&
305 P->mustPreserveAnalysisID(LoopSimplifyID)) {
Dan Gohmanc292caf2009-09-09 18:18:18 +0000306 assert(!TIL->contains(NewBB) &&
307 "Split point for loop exit is contained in loop!");
308
309 // Update LCSSA form in the newly created exit block.
Bill Wendling38da2a82012-04-30 10:25:51 +0000310 if (P->mustPreserveAnalysisID(LCSSAID))
311 createPHIsForSplitLoopExit(TIBB, NewBB, DestBB);
Dan Gohmanc292caf2009-09-09 18:18:18 +0000312
Stephen Hines36b56882014-04-23 16:57:46 -0700313 // The only that we can break LoopSimplify form by splitting a critical
314 // edge is if after the split there exists some edge from TIL to DestBB
315 // *and* the only edge into DestBB from outside of TIL is that of
316 // NewBB. If the first isn't true, then LoopSimplify still holds, NewBB
317 // is the new exit block and it has no non-loop predecessors. If the
318 // second isn't true, then DestBB was not in LoopSimplify form prior to
319 // the split as it had a non-loop predecessor. In both of these cases,
320 // the predecessor must be directly in TIL, not in a subloop, or again
321 // LoopSimplify doesn't hold.
322 SmallVector<BasicBlock *, 4> LoopPreds;
323 for (pred_iterator I = pred_begin(DestBB), E = pred_end(DestBB); I != E;
324 ++I) {
325 BasicBlock *P = *I;
326 if (P == NewBB)
327 continue; // The new block is known.
328 if (LI->getLoopFor(P) != TIL) {
329 // No need to re-simplify, it wasn't to start with.
330 LoopPreds.clear();
331 break;
Gabor Greif9085fca2010-07-09 16:31:08 +0000332 }
Stephen Hines36b56882014-04-23 16:57:46 -0700333 LoopPreds.push_back(P);
334 }
335 if (!LoopPreds.empty()) {
336 assert(!DestBB->isLandingPad() &&
337 "We don't split edges to landing pads!");
338 BasicBlock *NewExitBB =
339 SplitBlockPredecessors(DestBB, LoopPreds, "split", P);
340 if (P->mustPreserveAnalysisID(LCSSAID))
341 createPHIsForSplitLoopExit(LoopPreds, NewExitBB, DestBB);
Dan Gohman5c89b522009-09-08 15:45:00 +0000342 }
343 }
344 // LCSSA form was updated above for the case where LoopSimplify is
345 // available, which means that all predecessors of loop exit blocks
346 // are within the loop. Without LoopSimplify form, it would be
347 // necessary to insert a new phi.
348 assert((!P->mustPreserveAnalysisID(LCSSAID) ||
349 P->mustPreserveAnalysisID(LoopSimplifyID)) &&
350 "SplitCriticalEdge doesn't know how to update LCCSA form "
351 "without LoopSimplify!");
352 }
Chris Lattner0ae380a2005-08-13 01:38:43 +0000353 }
Dan Gohman5c89b522009-09-08 15:45:00 +0000354
355 return NewBB;
Chris Lattnereb0456c2002-09-24 15:51:56 +0000356}