Chris Lattner | d76efa0 | 2002-09-24 00:08:39 +0000 | [diff] [blame] | 1 | //===- BreakCriticalEdges.cpp - Critical Edge Elimination Pass ------------===// |
Misha Brukman | fd93908 | 2005-04-21 23:48:37 +0000 | [diff] [blame] | 2 | // |
John Criswell | b576c94 | 2003-10-20 19:43:21 +0000 | [diff] [blame] | 3 | // The LLVM Compiler Infrastructure |
| 4 | // |
Chris Lattner | 4ee451d | 2007-12-29 20:36:04 +0000 | [diff] [blame] | 5 | // This file is distributed under the University of Illinois Open Source |
| 6 | // License. See LICENSE.TXT for details. |
Misha Brukman | fd93908 | 2005-04-21 23:48:37 +0000 | [diff] [blame] | 7 | // |
John Criswell | b576c94 | 2003-10-20 19:43:21 +0000 | [diff] [blame] | 8 | //===----------------------------------------------------------------------===// |
Chris Lattner | d76efa0 | 2002-09-24 00:08:39 +0000 | [diff] [blame] | 9 | // |
| 10 | // BreakCriticalEdges pass - Break all of the critical edges in the CFG by |
| 11 | // inserting a dummy basic block. This pass may be "required" by passes that |
| 12 | // cannot deal with critical edges. For this usage, the structure type is |
| 13 | // forward declared. This pass obviously invalidates the CFG, but can update |
Cameron Zwarich | 3012787 | 2011-01-18 04:11:31 +0000 | [diff] [blame] | 14 | // dominator trees. |
Chris Lattner | d76efa0 | 2002-09-24 00:08:39 +0000 | [diff] [blame] | 15 | // |
| 16 | //===----------------------------------------------------------------------===// |
| 17 | |
Chris Lattner | d216e8b | 2006-12-19 22:17:40 +0000 | [diff] [blame] | 18 | #define DEBUG_TYPE "break-crit-edges" |
Chris Lattner | d76efa0 | 2002-09-24 00:08:39 +0000 | [diff] [blame] | 19 | #include "llvm/Transforms/Scalar.h" |
Chandler Carruth | d04a8d4 | 2012-12-03 16:50:05 +0000 | [diff] [blame] | 20 | #include "llvm/ADT/SmallVector.h" |
| 21 | #include "llvm/ADT/Statistic.h" |
Nick Lewycky | 81e4804 | 2013-07-27 01:24:00 +0000 | [diff] [blame] | 22 | #include "llvm/Analysis/CFG.h" |
Chris Lattner | 0ae380a | 2005-08-13 01:38:43 +0000 | [diff] [blame] | 23 | #include "llvm/Analysis/LoopInfo.h" |
Stephen Hines | 36b5688 | 2014-04-23 16:57:46 -0700 | [diff] [blame] | 24 | #include "llvm/IR/CFG.h" |
| 25 | #include "llvm/IR/Dominators.h" |
Chandler Carruth | 0b8c9a8 | 2013-01-02 11:36:10 +0000 | [diff] [blame] | 26 | #include "llvm/IR/Function.h" |
| 27 | #include "llvm/IR/Instructions.h" |
| 28 | #include "llvm/IR/Type.h" |
Torok Edwin | c25e758 | 2009-07-11 20:10:48 +0000 | [diff] [blame] | 29 | #include "llvm/Support/ErrorHandling.h" |
Chandler Carruth | d04a8d4 | 2012-12-03 16:50:05 +0000 | [diff] [blame] | 30 | #include "llvm/Transforms/Utils/BasicBlockUtils.h" |
Chris Lattner | f7703df | 2004-01-09 06:12:26 +0000 | [diff] [blame] | 31 | using namespace llvm; |
Brian Gaeke | d0fde30 | 2003-11-11 22:41:34 +0000 | [diff] [blame] | 32 | |
Chris Lattner | d216e8b | 2006-12-19 22:17:40 +0000 | [diff] [blame] | 33 | STATISTIC(NumBroken, "Number of blocks inserted"); |
Chris Lattner | d76efa0 | 2002-09-24 00:08:39 +0000 | [diff] [blame] | 34 | |
Chris Lattner | d216e8b | 2006-12-19 22:17:40 +0000 | [diff] [blame] | 35 | namespace { |
Nick Lewycky | 6726b6d | 2009-10-25 06:33:48 +0000 | [diff] [blame] | 36 | struct BreakCriticalEdges : public FunctionPass { |
Nick Lewycky | ecd94c8 | 2007-05-06 13:37:16 +0000 | [diff] [blame] | 37 | static char ID; // Pass identification, replacement for typeid |
Owen Anderson | 081c34b | 2010-10-19 17:21:58 +0000 | [diff] [blame] | 38 | BreakCriticalEdges() : FunctionPass(ID) { |
| 39 | initializeBreakCriticalEdgesPass(*PassRegistry::getPassRegistry()); |
| 40 | } |
Devang Patel | 794fd75 | 2007-05-01 21:15:47 +0000 | [diff] [blame] | 41 | |
Stephen Hines | 36b5688 | 2014-04-23 16:57:46 -0700 | [diff] [blame] | 42 | bool runOnFunction(Function &F) override; |
Misha Brukman | fd93908 | 2005-04-21 23:48:37 +0000 | [diff] [blame] | 43 | |
Stephen Hines | 36b5688 | 2014-04-23 16:57:46 -0700 | [diff] [blame] | 44 | void getAnalysisUsage(AnalysisUsage &AU) const override { |
| 45 | AU.addPreserved<DominatorTreeWrapperPass>(); |
Chris Lattner | 0ae380a | 2005-08-13 01:38:43 +0000 | [diff] [blame] | 46 | AU.addPreserved<LoopInfo>(); |
Chris Lattner | 98bf436 | 2003-10-12 21:52:28 +0000 | [diff] [blame] | 47 | |
| 48 | // No loop canonicalization guarantees are broken by this pass. |
| 49 | AU.addPreservedID(LoopSimplifyID); |
Chris Lattner | 6de302b | 2002-09-24 15:43:12 +0000 | [diff] [blame] | 50 | } |
| 51 | }; |
Chris Lattner | 6de302b | 2002-09-24 15:43:12 +0000 | [diff] [blame] | 52 | } |
Chris Lattner | d76efa0 | 2002-09-24 00:08:39 +0000 | [diff] [blame] | 53 | |
Dan Gohman | 844731a | 2008-05-13 00:00:25 +0000 | [diff] [blame] | 54 | char BreakCriticalEdges::ID = 0; |
Owen Anderson | 02dd53e | 2010-08-23 17:52:01 +0000 | [diff] [blame] | 55 | INITIALIZE_PASS(BreakCriticalEdges, "break-crit-edges", |
Owen Anderson | ce665bd | 2010-10-07 22:25:06 +0000 | [diff] [blame] | 56 | "Break critical edges in CFG", false, false) |
Dan Gohman | 844731a | 2008-05-13 00:00:25 +0000 | [diff] [blame] | 57 | |
Chris Lattner | 7a2bdde | 2011-04-15 05:18:47 +0000 | [diff] [blame] | 58 | // Publicly exposed interface to pass... |
Owen Anderson | 90c579d | 2010-08-06 18:33:48 +0000 | [diff] [blame] | 59 | char &llvm::BreakCriticalEdgesID = BreakCriticalEdges::ID; |
Chris Lattner | 1e5fdf8 | 2004-07-31 10:01:58 +0000 | [diff] [blame] | 60 | FunctionPass *llvm::createBreakCriticalEdgesPass() { |
| 61 | return new BreakCriticalEdges(); |
| 62 | } |
Chris Lattner | d76efa0 | 2002-09-24 00:08:39 +0000 | [diff] [blame] | 63 | |
Chris Lattner | 363ca61 | 2003-11-10 04:42:42 +0000 | [diff] [blame] | 64 | // runOnFunction - Loop over all of the edges in the CFG, breaking critical |
| 65 | // edges as they are found. |
| 66 | // |
| 67 | bool BreakCriticalEdges::runOnFunction(Function &F) { |
| 68 | bool Changed = false; |
| 69 | for (Function::iterator I = F.begin(), E = F.end(); I != E; ++I) { |
| 70 | TerminatorInst *TI = I->getTerminator(); |
Chris Lattner | 1b98ff3 | 2009-10-31 21:51:10 +0000 | [diff] [blame] | 71 | if (TI->getNumSuccessors() > 1 && !isa<IndirectBrInst>(TI)) |
Chris Lattner | 363ca61 | 2003-11-10 04:42:42 +0000 | [diff] [blame] | 72 | for (unsigned i = 0, e = TI->getNumSuccessors(); i != e; ++i) |
| 73 | if (SplitCriticalEdge(TI, i, this)) { |
| 74 | ++NumBroken; |
| 75 | Changed = true; |
| 76 | } |
| 77 | } |
| 78 | |
| 79 | return Changed; |
| 80 | } |
| 81 | |
| 82 | //===----------------------------------------------------------------------===// |
| 83 | // Implementation of the external critical edge manipulation functions |
| 84 | //===----------------------------------------------------------------------===// |
Chris Lattner | eb0456c | 2002-09-24 15:51:56 +0000 | [diff] [blame] | 85 | |
Bill Wendling | 38da2a8 | 2012-04-30 10:25:51 +0000 | [diff] [blame] | 86 | /// createPHIsForSplitLoopExit - When a loop exit edge is split, LCSSA form |
Dan Gohman | c292caf | 2009-09-09 18:18:18 +0000 | [diff] [blame] | 87 | /// may require new PHIs in the new exit block. This function inserts the |
Bill Wendling | bfbab99 | 2012-04-30 10:44:54 +0000 | [diff] [blame] | 88 | /// new PHIs, as needed. Preds is a list of preds inside the loop, SplitBB |
Dan Gohman | c292caf | 2009-09-09 18:18:18 +0000 | [diff] [blame] | 89 | /// is the new loop exit block, and DestBB is the old loop exit, now the |
| 90 | /// successor of SplitBB. |
Bill Wendling | 38da2a8 | 2012-04-30 10:25:51 +0000 | [diff] [blame] | 91 | static void createPHIsForSplitLoopExit(ArrayRef<BasicBlock *> Preds, |
Dan Gohman | c292caf | 2009-09-09 18:18:18 +0000 | [diff] [blame] | 92 | BasicBlock *SplitBB, |
| 93 | BasicBlock *DestBB) { |
| 94 | // SplitBB shouldn't have anything non-trivial in it yet. |
Bill Wendling | bfbab99 | 2012-04-30 10:44:54 +0000 | [diff] [blame] | 95 | assert((SplitBB->getFirstNonPHI() == SplitBB->getTerminator() || |
| 96 | SplitBB->isLandingPad()) && "SplitBB has non-PHI nodes!"); |
Dan Gohman | c292caf | 2009-09-09 18:18:18 +0000 | [diff] [blame] | 97 | |
Bill Wendling | bfbab99 | 2012-04-30 10:44:54 +0000 | [diff] [blame] | 98 | // For each PHI in the destination block. |
Dan Gohman | c292caf | 2009-09-09 18:18:18 +0000 | [diff] [blame] | 99 | for (BasicBlock::iterator I = DestBB->begin(); |
| 100 | PHINode *PN = dyn_cast<PHINode>(I); ++I) { |
| 101 | unsigned Idx = PN->getBasicBlockIndex(SplitBB); |
| 102 | Value *V = PN->getIncomingValue(Idx); |
Bill Wendling | bfbab99 | 2012-04-30 10:44:54 +0000 | [diff] [blame] | 103 | |
Dan Gohman | c292caf | 2009-09-09 18:18:18 +0000 | [diff] [blame] | 104 | // If the input is a PHI which already satisfies LCSSA, don't create |
| 105 | // a new one. |
| 106 | if (const PHINode *VP = dyn_cast<PHINode>(V)) |
| 107 | if (VP->getParent() == SplitBB) |
| 108 | continue; |
Bill Wendling | bfbab99 | 2012-04-30 10:44:54 +0000 | [diff] [blame] | 109 | |
Dan Gohman | c292caf | 2009-09-09 18:18:18 +0000 | [diff] [blame] | 110 | // Otherwise a new PHI is needed. Create one and populate it. |
Bill Wendling | bfbab99 | 2012-04-30 10:44:54 +0000 | [diff] [blame] | 111 | PHINode *NewPN = |
| 112 | PHINode::Create(PN->getType(), Preds.size(), "split", |
| 113 | SplitBB->isLandingPad() ? |
| 114 | SplitBB->begin() : SplitBB->getTerminator()); |
Dan Gohman | c292caf | 2009-09-09 18:18:18 +0000 | [diff] [blame] | 115 | for (unsigned i = 0, e = Preds.size(); i != e; ++i) |
| 116 | NewPN->addIncoming(V, Preds[i]); |
Bill Wendling | bfbab99 | 2012-04-30 10:44:54 +0000 | [diff] [blame] | 117 | |
Dan Gohman | c292caf | 2009-09-09 18:18:18 +0000 | [diff] [blame] | 118 | // Update the original PHI. |
| 119 | PN->setIncomingValue(Idx, NewPN); |
| 120 | } |
| 121 | } |
| 122 | |
Chris Lattner | 862f27e | 2008-04-21 00:19:16 +0000 | [diff] [blame] | 123 | /// SplitCriticalEdge - If this edge is a critical edge, insert a new node to |
Cameron Zwarich | 3012787 | 2011-01-18 04:11:31 +0000 | [diff] [blame] | 124 | /// split the critical edge. This will update DominatorTree information if it |
| 125 | /// is available, thus calling this pass will not invalidate either of them. |
| 126 | /// This returns the new block if the edge was split, null otherwise. |
Chris Lattner | 1b98ff3 | 2009-10-31 21:51:10 +0000 | [diff] [blame] | 127 | /// |
| 128 | /// If MergeIdenticalEdges is true (not the default), *all* edges from TI to the |
Andrew Trick | 2aeb802 | 2011-10-04 03:34:49 +0000 | [diff] [blame] | 129 | /// specified successor will be merged into the same critical edge block. |
| 130 | /// This is most commonly interesting with switch instructions, which may |
Chris Lattner | 1b98ff3 | 2009-10-31 21:51:10 +0000 | [diff] [blame] | 131 | /// have many edges to any one destination. This ensures that all edges to that |
Andrew Trick | 2aeb802 | 2011-10-04 03:34:49 +0000 | [diff] [blame] | 132 | /// dest go to one block instead of each going to a different block, but isn't |
Chris Lattner | 1b98ff3 | 2009-10-31 21:51:10 +0000 | [diff] [blame] | 133 | /// the standard definition of a "critical edge". |
| 134 | /// |
| 135 | /// It is invalid to call this function on a critical edge that starts at an |
| 136 | /// IndirectBrInst. Splitting these edges will almost always create an invalid |
Chris Lattner | 280f3fe | 2009-11-01 18:17:37 +0000 | [diff] [blame] | 137 | /// program because the address of the new block won't be the one that is jumped |
Chris Lattner | 1b98ff3 | 2009-10-31 21:51:10 +0000 | [diff] [blame] | 138 | /// to. |
| 139 | /// |
Dan Gohman | 5c89b52 | 2009-09-08 15:45:00 +0000 | [diff] [blame] | 140 | BasicBlock *llvm::SplitCriticalEdge(TerminatorInst *TI, unsigned SuccNum, |
Andrew Trick | f143b79 | 2011-10-04 03:50:44 +0000 | [diff] [blame] | 141 | Pass *P, bool MergeIdenticalEdges, |
Bill Wendling | bfbab99 | 2012-04-30 10:44:54 +0000 | [diff] [blame] | 142 | bool DontDeleteUselessPhis, |
| 143 | bool SplitLandingPads) { |
Dan Gohman | 5c89b52 | 2009-09-08 15:45:00 +0000 | [diff] [blame] | 144 | if (!isCriticalEdge(TI, SuccNum, MergeIdenticalEdges)) return 0; |
Andrew Trick | 2aeb802 | 2011-10-04 03:34:49 +0000 | [diff] [blame] | 145 | |
Chris Lattner | 1b98ff3 | 2009-10-31 21:51:10 +0000 | [diff] [blame] | 146 | assert(!isa<IndirectBrInst>(TI) && |
| 147 | "Cannot split critical edge from IndirectBrInst"); |
Andrew Trick | 2aeb802 | 2011-10-04 03:34:49 +0000 | [diff] [blame] | 148 | |
Chris Lattner | eb0456c | 2002-09-24 15:51:56 +0000 | [diff] [blame] | 149 | BasicBlock *TIBB = TI->getParent(); |
Chris Lattner | 6918c07 | 2002-10-31 02:44:36 +0000 | [diff] [blame] | 150 | BasicBlock *DestBB = TI->getSuccessor(SuccNum); |
Chris Lattner | eb0456c | 2002-09-24 15:51:56 +0000 | [diff] [blame] | 151 | |
Bill Wendling | 490606e | 2011-08-17 21:04:05 +0000 | [diff] [blame] | 152 | // Splitting the critical edge to a landing pad block is non-trivial. Don't do |
| 153 | // it in this generic function. |
Bill Wendling | f0dc257 | 2011-09-20 22:28:17 +0000 | [diff] [blame] | 154 | if (DestBB->isLandingPad()) return 0; |
Bill Wendling | 490606e | 2011-08-17 21:04:05 +0000 | [diff] [blame] | 155 | |
Chris Lattner | eb0456c | 2002-09-24 15:51:56 +0000 | [diff] [blame] | 156 | // Create a new basic block, linking it into the CFG. |
Owen Anderson | 1d0be15 | 2009-08-13 21:58:54 +0000 | [diff] [blame] | 157 | BasicBlock *NewBB = BasicBlock::Create(TI->getContext(), |
| 158 | TIBB->getName() + "." + DestBB->getName() + "_crit_edge"); |
Chris Lattner | 277cccc | 2010-02-13 04:24:19 +0000 | [diff] [blame] | 159 | // Create our unconditional branch. |
Devang Patel | c9ea771 | 2011-05-17 19:43:06 +0000 | [diff] [blame] | 160 | BranchInst *NewBI = BranchInst::Create(DestBB, NewBB); |
| 161 | NewBI->setDebugLoc(TI->getDebugLoc()); |
Misha Brukman | fd93908 | 2005-04-21 23:48:37 +0000 | [diff] [blame] | 162 | |
Chris Lattner | 27e1f90 | 2006-10-28 06:44:56 +0000 | [diff] [blame] | 163 | // Branch to the new block, breaking the edge. |
Chris Lattner | eb0456c | 2002-09-24 15:51:56 +0000 | [diff] [blame] | 164 | TI->setSuccessor(SuccNum, NewBB); |
| 165 | |
| 166 | // Insert the block into the function... right after the block TI lives in. |
| 167 | Function &F = *TIBB->getParent(); |
Chris Lattner | 261cdfb | 2007-04-17 18:09:47 +0000 | [diff] [blame] | 168 | Function::iterator FBBI = TIBB; |
| 169 | F.getBasicBlockList().insert(++FBBI, NewBB); |
Andrew Trick | 2aeb802 | 2011-10-04 03:34:49 +0000 | [diff] [blame] | 170 | |
Chris Lattner | eb0456c | 2002-09-24 15:51:56 +0000 | [diff] [blame] | 171 | // If there are any PHI nodes in DestBB, we need to update them so that they |
| 172 | // merge incoming values from NewBB instead of from TIBB. |
Jay Foad | 95c3e48 | 2011-06-23 09:09:15 +0000 | [diff] [blame] | 173 | { |
| 174 | unsigned BBIdx = 0; |
| 175 | for (BasicBlock::iterator I = DestBB->begin(); isa<PHINode>(I); ++I) { |
| 176 | // We no longer enter through TIBB, now we come in through NewBB. |
| 177 | // Revector exactly one entry in the PHI node that used to come from |
| 178 | // TIBB to come from NewBB. |
| 179 | PHINode *PN = cast<PHINode>(I); |
| 180 | |
| 181 | // Reuse the previous value of BBIdx if it lines up. In cases where we |
| 182 | // have multiple phi nodes with *lots* of predecessors, this is a speed |
| 183 | // win because we don't have to scan the PHI looking for TIBB. This |
| 184 | // happens because the BB list of PHI nodes are usually in the same |
| 185 | // order. |
| 186 | if (PN->getIncomingBlock(BBIdx) != TIBB) |
Andrew Trick | 2aeb802 | 2011-10-04 03:34:49 +0000 | [diff] [blame] | 187 | BBIdx = PN->getBasicBlockIndex(TIBB); |
Jay Foad | 95c3e48 | 2011-06-23 09:09:15 +0000 | [diff] [blame] | 188 | PN->setIncomingBlock(BBIdx, NewBB); |
Chris Lattner | 6686c6b | 2010-02-13 05:01:14 +0000 | [diff] [blame] | 189 | } |
Chris Lattner | eb0456c | 2002-09-24 15:51:56 +0000 | [diff] [blame] | 190 | } |
Andrew Trick | 2aeb802 | 2011-10-04 03:34:49 +0000 | [diff] [blame] | 191 | |
Chris Lattner | 27e1f90 | 2006-10-28 06:44:56 +0000 | [diff] [blame] | 192 | // If there are any other edges from TIBB to DestBB, update those to go |
| 193 | // through the split block, making those edges non-critical as well (and |
| 194 | // reducing the number of phi entries in the DestBB if relevant). |
| 195 | if (MergeIdenticalEdges) { |
| 196 | for (unsigned i = SuccNum+1, e = TI->getNumSuccessors(); i != e; ++i) { |
| 197 | if (TI->getSuccessor(i) != DestBB) continue; |
Andrew Trick | 2aeb802 | 2011-10-04 03:34:49 +0000 | [diff] [blame] | 198 | |
Chris Lattner | 27e1f90 | 2006-10-28 06:44:56 +0000 | [diff] [blame] | 199 | // Remove an entry for TIBB from DestBB phi nodes. |
Andrew Trick | f143b79 | 2011-10-04 03:50:44 +0000 | [diff] [blame] | 200 | DestBB->removePredecessor(TIBB, DontDeleteUselessPhis); |
Andrew Trick | 2aeb802 | 2011-10-04 03:34:49 +0000 | [diff] [blame] | 201 | |
Chris Lattner | 27e1f90 | 2006-10-28 06:44:56 +0000 | [diff] [blame] | 202 | // We found another edge to DestBB, go to NewBB instead. |
| 203 | TI->setSuccessor(i, NewBB); |
| 204 | } |
| 205 | } |
Andrew Trick | 2aeb802 | 2011-10-04 03:34:49 +0000 | [diff] [blame] | 206 | |
| 207 | |
Chris Lattner | eb0456c | 2002-09-24 15:51:56 +0000 | [diff] [blame] | 208 | |
Chris Lattner | e802a02 | 2002-10-08 21:06:27 +0000 | [diff] [blame] | 209 | // If we don't have a pass object, we can't update anything... |
Dan Gohman | 5c89b52 | 2009-09-08 15:45:00 +0000 | [diff] [blame] | 210 | if (P == 0) return NewBB; |
Andrew Trick | 2aeb802 | 2011-10-04 03:34:49 +0000 | [diff] [blame] | 211 | |
Stephen Hines | 36b5688 | 2014-04-23 16:57:46 -0700 | [diff] [blame] | 212 | DominatorTreeWrapperPass *DTWP = |
| 213 | P->getAnalysisIfAvailable<DominatorTreeWrapperPass>(); |
| 214 | DominatorTree *DT = DTWP ? &DTWP->getDomTree() : 0; |
Chris Lattner | 6686c6b | 2010-02-13 05:01:14 +0000 | [diff] [blame] | 215 | LoopInfo *LI = P->getAnalysisIfAvailable<LoopInfo>(); |
Andrew Trick | 2aeb802 | 2011-10-04 03:34:49 +0000 | [diff] [blame] | 216 | |
Chris Lattner | 6686c6b | 2010-02-13 05:01:14 +0000 | [diff] [blame] | 217 | // If we have nothing to update, just return. |
Chandler Carruth | dd5d86d | 2013-10-02 15:42:23 +0000 | [diff] [blame] | 218 | if (DT == 0 && LI == 0) |
Chris Lattner | 6686c6b | 2010-02-13 05:01:14 +0000 | [diff] [blame] | 219 | return NewBB; |
Chris Lattner | e802a02 | 2002-10-08 21:06:27 +0000 | [diff] [blame] | 220 | |
Chris Lattner | 86f7b21 | 2006-10-03 07:02:02 +0000 | [diff] [blame] | 221 | // Now update analysis information. Since the only predecessor of NewBB is |
| 222 | // the TIBB, TIBB clearly dominates NewBB. TIBB usually doesn't dominate |
| 223 | // anything, as there are other successors of DestBB. However, if all other |
| 224 | // predecessors of DestBB are already dominated by DestBB (e.g. DestBB is a |
| 225 | // loop header) then NewBB dominates DestBB. |
| 226 | SmallVector<BasicBlock*, 8> OtherPreds; |
Chris Lattner | eb0456c | 2002-09-24 15:51:56 +0000 | [diff] [blame] | 227 | |
Chris Lattner | 2f36ea8 | 2010-02-13 04:15:26 +0000 | [diff] [blame] | 228 | // If there is a PHI in the block, loop over predecessors with it, which is |
| 229 | // faster than iterating pred_begin/end. |
| 230 | if (PHINode *PN = dyn_cast<PHINode>(DestBB->begin())) { |
| 231 | for (unsigned i = 0, e = PN->getNumIncomingValues(); i != e; ++i) |
| 232 | if (PN->getIncomingBlock(i) != NewBB) |
| 233 | OtherPreds.push_back(PN->getIncomingBlock(i)); |
| 234 | } else { |
| 235 | for (pred_iterator I = pred_begin(DestBB), E = pred_end(DestBB); |
Gabor Greif | 7556cf5 | 2010-07-09 15:25:42 +0000 | [diff] [blame] | 236 | I != E; ++I) { |
| 237 | BasicBlock *P = *I; |
| 238 | if (P != NewBB) |
Chris Lattner | 70e5e22 | 2011-01-14 04:23:53 +0000 | [diff] [blame] | 239 | OtherPreds.push_back(P); |
Gabor Greif | 7556cf5 | 2010-07-09 15:25:42 +0000 | [diff] [blame] | 240 | } |
Chris Lattner | 2f36ea8 | 2010-02-13 04:15:26 +0000 | [diff] [blame] | 241 | } |
Gabor Greif | 7556cf5 | 2010-07-09 15:25:42 +0000 | [diff] [blame] | 242 | |
Chris Lattner | 86f7b21 | 2006-10-03 07:02:02 +0000 | [diff] [blame] | 243 | bool NewBBDominatesDestBB = true; |
Andrew Trick | 2aeb802 | 2011-10-04 03:34:49 +0000 | [diff] [blame] | 244 | |
Chris Lattner | c178d94 | 2002-09-26 16:18:51 +0000 | [diff] [blame] | 245 | // Should we update DominatorTree information? |
Chris Lattner | 6686c6b | 2010-02-13 05:01:14 +0000 | [diff] [blame] | 246 | if (DT) { |
Devang Patel | 2604242 | 2007-06-04 00:32:22 +0000 | [diff] [blame] | 247 | DomTreeNode *TINode = DT->getNode(TIBB); |
Misha Brukman | fd93908 | 2005-04-21 23:48:37 +0000 | [diff] [blame] | 248 | |
Chris Lattner | c178d94 | 2002-09-26 16:18:51 +0000 | [diff] [blame] | 249 | // The new block is not the immediate dominator for any other nodes, but |
| 250 | // TINode is the immediate dominator for the new node. |
| 251 | // |
Chris Lattner | 86f7b21 | 2006-10-03 07:02:02 +0000 | [diff] [blame] | 252 | if (TINode) { // Don't break unreachable code! |
Devang Patel | 83beaee | 2007-06-04 16:43:25 +0000 | [diff] [blame] | 253 | DomTreeNode *NewBBNode = DT->addNewBlock(NewBB, TIBB); |
Devang Patel | 2604242 | 2007-06-04 00:32:22 +0000 | [diff] [blame] | 254 | DomTreeNode *DestBBNode = 0; |
Andrew Trick | 2aeb802 | 2011-10-04 03:34:49 +0000 | [diff] [blame] | 255 | |
Chris Lattner | 86f7b21 | 2006-10-03 07:02:02 +0000 | [diff] [blame] | 256 | // If NewBBDominatesDestBB hasn't been computed yet, do so with DT. |
| 257 | if (!OtherPreds.empty()) { |
| 258 | DestBBNode = DT->getNode(DestBB); |
| 259 | while (!OtherPreds.empty() && NewBBDominatesDestBB) { |
Devang Patel | 2604242 | 2007-06-04 00:32:22 +0000 | [diff] [blame] | 260 | if (DomTreeNode *OPNode = DT->getNode(OtherPreds.back())) |
Devang Patel | 9a51157 | 2007-06-07 17:47:21 +0000 | [diff] [blame] | 261 | NewBBDominatesDestBB = DT->dominates(DestBBNode, OPNode); |
Chris Lattner | 86f7b21 | 2006-10-03 07:02:02 +0000 | [diff] [blame] | 262 | OtherPreds.pop_back(); |
| 263 | } |
| 264 | OtherPreds.clear(); |
| 265 | } |
Andrew Trick | 2aeb802 | 2011-10-04 03:34:49 +0000 | [diff] [blame] | 266 | |
Chris Lattner | 86f7b21 | 2006-10-03 07:02:02 +0000 | [diff] [blame] | 267 | // If NewBBDominatesDestBB, then NewBB dominates DestBB, otherwise it |
| 268 | // doesn't dominate anything. |
| 269 | if (NewBBDominatesDestBB) { |
| 270 | if (!DestBBNode) DestBBNode = DT->getNode(DestBB); |
| 271 | DT->changeImmediateDominator(DestBBNode, NewBBNode); |
| 272 | } |
| 273 | } |
Chris Lattner | eb0456c | 2002-09-24 15:51:56 +0000 | [diff] [blame] | 274 | } |
Chris Lattner | 6918c07 | 2002-10-31 02:44:36 +0000 | [diff] [blame] | 275 | |
Chris Lattner | 0ae380a | 2005-08-13 01:38:43 +0000 | [diff] [blame] | 276 | // Update LoopInfo if it is around. |
Chris Lattner | 6686c6b | 2010-02-13 05:01:14 +0000 | [diff] [blame] | 277 | if (LI) { |
Dan Gohman | 5c89b52 | 2009-09-08 15:45:00 +0000 | [diff] [blame] | 278 | if (Loop *TIL = LI->getLoopFor(TIBB)) { |
| 279 | // If one or the other blocks were not in a loop, the new block is not |
| 280 | // either, and thus LI doesn't need to be updated. |
Chris Lattner | 0ae380a | 2005-08-13 01:38:43 +0000 | [diff] [blame] | 281 | if (Loop *DestLoop = LI->getLoopFor(DestBB)) { |
| 282 | if (TIL == DestLoop) { |
| 283 | // Both in the same loop, the NewBB joins loop. |
Owen Anderson | d735ee8 | 2007-11-27 03:43:35 +0000 | [diff] [blame] | 284 | DestLoop->addBasicBlockToLoop(NewBB, LI->getBase()); |
Dan Gohman | 92329c7 | 2009-12-18 01:24:09 +0000 | [diff] [blame] | 285 | } else if (TIL->contains(DestLoop)) { |
Chris Lattner | 86f7b21 | 2006-10-03 07:02:02 +0000 | [diff] [blame] | 286 | // Edge from an outer loop to an inner loop. Add to the outer loop. |
Owen Anderson | d735ee8 | 2007-11-27 03:43:35 +0000 | [diff] [blame] | 287 | TIL->addBasicBlockToLoop(NewBB, LI->getBase()); |
Dan Gohman | 92329c7 | 2009-12-18 01:24:09 +0000 | [diff] [blame] | 288 | } else if (DestLoop->contains(TIL)) { |
Chris Lattner | 86f7b21 | 2006-10-03 07:02:02 +0000 | [diff] [blame] | 289 | // Edge from an inner loop to an outer loop. Add to the outer loop. |
Owen Anderson | d735ee8 | 2007-11-27 03:43:35 +0000 | [diff] [blame] | 290 | DestLoop->addBasicBlockToLoop(NewBB, LI->getBase()); |
Chris Lattner | 0ae380a | 2005-08-13 01:38:43 +0000 | [diff] [blame] | 291 | } else { |
| 292 | // Edge from two loops with no containment relation. Because these |
| 293 | // are natural loops, we know that the destination block must be the |
| 294 | // header of its loop (adding a branch into a loop elsewhere would |
| 295 | // create an irreducible loop). |
| 296 | assert(DestLoop->getHeader() == DestBB && |
| 297 | "Should not create irreducible loops!"); |
| 298 | if (Loop *P = DestLoop->getParentLoop()) |
Owen Anderson | d735ee8 | 2007-11-27 03:43:35 +0000 | [diff] [blame] | 299 | P->addBasicBlockToLoop(NewBB, LI->getBase()); |
Chris Lattner | 0ae380a | 2005-08-13 01:38:43 +0000 | [diff] [blame] | 300 | } |
| 301 | } |
Stephen Hines | 36b5688 | 2014-04-23 16:57:46 -0700 | [diff] [blame] | 302 | // If TIBB is in a loop and DestBB is outside of that loop, we may need |
| 303 | // to update LoopSimplify form and LCSSA form. |
Dan Gohman | 5c89b52 | 2009-09-08 15:45:00 +0000 | [diff] [blame] | 304 | if (!TIL->contains(DestBB) && |
| 305 | P->mustPreserveAnalysisID(LoopSimplifyID)) { |
Dan Gohman | c292caf | 2009-09-09 18:18:18 +0000 | [diff] [blame] | 306 | assert(!TIL->contains(NewBB) && |
| 307 | "Split point for loop exit is contained in loop!"); |
| 308 | |
| 309 | // Update LCSSA form in the newly created exit block. |
Bill Wendling | 38da2a8 | 2012-04-30 10:25:51 +0000 | [diff] [blame] | 310 | if (P->mustPreserveAnalysisID(LCSSAID)) |
| 311 | createPHIsForSplitLoopExit(TIBB, NewBB, DestBB); |
Dan Gohman | c292caf | 2009-09-09 18:18:18 +0000 | [diff] [blame] | 312 | |
Stephen Hines | 36b5688 | 2014-04-23 16:57:46 -0700 | [diff] [blame] | 313 | // The only that we can break LoopSimplify form by splitting a critical |
| 314 | // edge is if after the split there exists some edge from TIL to DestBB |
| 315 | // *and* the only edge into DestBB from outside of TIL is that of |
| 316 | // NewBB. If the first isn't true, then LoopSimplify still holds, NewBB |
| 317 | // is the new exit block and it has no non-loop predecessors. If the |
| 318 | // second isn't true, then DestBB was not in LoopSimplify form prior to |
| 319 | // the split as it had a non-loop predecessor. In both of these cases, |
| 320 | // the predecessor must be directly in TIL, not in a subloop, or again |
| 321 | // LoopSimplify doesn't hold. |
| 322 | SmallVector<BasicBlock *, 4> LoopPreds; |
| 323 | for (pred_iterator I = pred_begin(DestBB), E = pred_end(DestBB); I != E; |
| 324 | ++I) { |
| 325 | BasicBlock *P = *I; |
| 326 | if (P == NewBB) |
| 327 | continue; // The new block is known. |
| 328 | if (LI->getLoopFor(P) != TIL) { |
| 329 | // No need to re-simplify, it wasn't to start with. |
| 330 | LoopPreds.clear(); |
| 331 | break; |
Gabor Greif | 9085fca | 2010-07-09 16:31:08 +0000 | [diff] [blame] | 332 | } |
Stephen Hines | 36b5688 | 2014-04-23 16:57:46 -0700 | [diff] [blame] | 333 | LoopPreds.push_back(P); |
| 334 | } |
| 335 | if (!LoopPreds.empty()) { |
| 336 | assert(!DestBB->isLandingPad() && |
| 337 | "We don't split edges to landing pads!"); |
| 338 | BasicBlock *NewExitBB = |
| 339 | SplitBlockPredecessors(DestBB, LoopPreds, "split", P); |
| 340 | if (P->mustPreserveAnalysisID(LCSSAID)) |
| 341 | createPHIsForSplitLoopExit(LoopPreds, NewExitBB, DestBB); |
Dan Gohman | 5c89b52 | 2009-09-08 15:45:00 +0000 | [diff] [blame] | 342 | } |
| 343 | } |
| 344 | // LCSSA form was updated above for the case where LoopSimplify is |
| 345 | // available, which means that all predecessors of loop exit blocks |
| 346 | // are within the loop. Without LoopSimplify form, it would be |
| 347 | // necessary to insert a new phi. |
| 348 | assert((!P->mustPreserveAnalysisID(LCSSAID) || |
| 349 | P->mustPreserveAnalysisID(LoopSimplifyID)) && |
| 350 | "SplitCriticalEdge doesn't know how to update LCCSA form " |
| 351 | "without LoopSimplify!"); |
| 352 | } |
Chris Lattner | 0ae380a | 2005-08-13 01:38:43 +0000 | [diff] [blame] | 353 | } |
Dan Gohman | 5c89b52 | 2009-09-08 15:45:00 +0000 | [diff] [blame] | 354 | |
| 355 | return NewBB; |
Chris Lattner | eb0456c | 2002-09-24 15:51:56 +0000 | [diff] [blame] | 356 | } |