Chris Lattner | 01d1ee3 | 2002-05-21 20:50:24 +0000 | [diff] [blame] | 1 | //===- SimplifyCFG.cpp - Code to perform CFG simplification ---------------===// |
Misha Brukman | fd93908 | 2005-04-21 23:48:37 +0000 | [diff] [blame] | 2 | // |
John Criswell | b576c94 | 2003-10-20 19:43:21 +0000 | [diff] [blame] | 3 | // The LLVM Compiler Infrastructure |
| 4 | // |
Chris Lattner | 4ee451d | 2007-12-29 20:36:04 +0000 | [diff] [blame] | 5 | // This file is distributed under the University of Illinois Open Source |
| 6 | // License. See LICENSE.TXT for details. |
Misha Brukman | fd93908 | 2005-04-21 23:48:37 +0000 | [diff] [blame] | 7 | // |
John Criswell | b576c94 | 2003-10-20 19:43:21 +0000 | [diff] [blame] | 8 | //===----------------------------------------------------------------------===// |
Chris Lattner | 01d1ee3 | 2002-05-21 20:50:24 +0000 | [diff] [blame] | 9 | // |
Chris Lattner | bb190ac | 2002-10-08 21:36:33 +0000 | [diff] [blame] | 10 | // Peephole optimize the CFG. |
Chris Lattner | 01d1ee3 | 2002-05-21 20:50:24 +0000 | [diff] [blame] | 11 | // |
| 12 | //===----------------------------------------------------------------------===// |
| 13 | |
Chris Lattner | 218a822 | 2004-06-20 01:13:18 +0000 | [diff] [blame] | 14 | #define DEBUG_TYPE "simplifycfg" |
Chris Lattner | 01d1ee3 | 2002-05-21 20:50:24 +0000 | [diff] [blame] | 15 | #include "llvm/Transforms/Utils/Local.h" |
Chris Lattner | 723c66d | 2004-02-11 03:36:04 +0000 | [diff] [blame] | 16 | #include "llvm/Constants.h" |
| 17 | #include "llvm/Instructions.h" |
Devang Patel | 383d7ed | 2009-02-03 22:12:02 +0000 | [diff] [blame] | 18 | #include "llvm/IntrinsicInst.h" |
Chris Lattner | 0d56008 | 2004-02-24 05:38:11 +0000 | [diff] [blame] | 19 | #include "llvm/Type.h" |
Reid Spencer | c103057 | 2007-01-19 21:13:56 +0000 | [diff] [blame] | 20 | #include "llvm/DerivedTypes.h" |
Dale Johannesen | f8bc300 | 2009-05-13 18:25:07 +0000 | [diff] [blame] | 21 | #include "llvm/GlobalVariable.h" |
Chris Lattner | 01d1ee3 | 2002-05-21 20:50:24 +0000 | [diff] [blame] | 22 | #include "llvm/Support/CFG.h" |
Reid Spencer | 551ccae | 2004-09-01 22:55:40 +0000 | [diff] [blame] | 23 | #include "llvm/Support/Debug.h" |
Daniel Dunbar | ce63ffb | 2009-07-25 00:23:56 +0000 | [diff] [blame] | 24 | #include "llvm/Support/raw_ostream.h" |
Chris Lattner | 79066fa | 2007-01-30 23:46:24 +0000 | [diff] [blame] | 25 | #include "llvm/Analysis/ConstantFolding.h" |
Chris Lattner | eaba3a1 | 2005-09-19 23:49:37 +0000 | [diff] [blame] | 26 | #include "llvm/Transforms/Utils/BasicBlockUtils.h" |
Dan Gohman | 2c63566 | 2009-10-30 22:39:04 +0000 | [diff] [blame] | 27 | #include "llvm/ADT/DenseMap.h" |
Chris Lattner | 93e985f | 2007-02-13 02:10:56 +0000 | [diff] [blame] | 28 | #include "llvm/ADT/SmallVector.h" |
Chris Lattner | c995123 | 2007-04-02 01:44:59 +0000 | [diff] [blame] | 29 | #include "llvm/ADT/SmallPtrSet.h" |
Evan Cheng | 502a4f5 | 2008-06-12 21:15:59 +0000 | [diff] [blame] | 30 | #include "llvm/ADT/Statistic.h" |
Chris Lattner | 01d1ee3 | 2002-05-21 20:50:24 +0000 | [diff] [blame] | 31 | #include <algorithm> |
| 32 | #include <functional> |
Chris Lattner | d52c261 | 2004-02-24 07:23:58 +0000 | [diff] [blame] | 33 | #include <set> |
Chris Lattner | 698f96f | 2004-10-18 04:07:22 +0000 | [diff] [blame] | 34 | #include <map> |
Chris Lattner | f7703df | 2004-01-09 06:12:26 +0000 | [diff] [blame] | 35 | using namespace llvm; |
Brian Gaeke | d0fde30 | 2003-11-11 22:41:34 +0000 | [diff] [blame] | 36 | |
Evan Cheng | 502a4f5 | 2008-06-12 21:15:59 +0000 | [diff] [blame] | 37 | STATISTIC(NumSpeculations, "Number of speculative executed instructions"); |
| 38 | |
Chris Lattner | 2bdcb56 | 2005-08-03 00:19:45 +0000 | [diff] [blame] | 39 | /// SafeToMergeTerminators - Return true if it is safe to merge these two |
| 40 | /// terminator instructions together. |
| 41 | /// |
| 42 | static bool SafeToMergeTerminators(TerminatorInst *SI1, TerminatorInst *SI2) { |
| 43 | if (SI1 == SI2) return false; // Can't merge with self! |
| 44 | |
| 45 | // It is not safe to merge these two switch instructions if they have a common |
| 46 | // successor, and if that successor has a PHI node, and if *that* PHI node has |
| 47 | // conflicting incoming values from the two switch blocks. |
| 48 | BasicBlock *SI1BB = SI1->getParent(); |
| 49 | BasicBlock *SI2BB = SI2->getParent(); |
Chris Lattner | c995123 | 2007-04-02 01:44:59 +0000 | [diff] [blame] | 50 | SmallPtrSet<BasicBlock*, 16> SI1Succs(succ_begin(SI1BB), succ_end(SI1BB)); |
Chris Lattner | 2bdcb56 | 2005-08-03 00:19:45 +0000 | [diff] [blame] | 51 | |
| 52 | for (succ_iterator I = succ_begin(SI2BB), E = succ_end(SI2BB); I != E; ++I) |
| 53 | if (SI1Succs.count(*I)) |
| 54 | for (BasicBlock::iterator BBI = (*I)->begin(); |
| 55 | isa<PHINode>(BBI); ++BBI) { |
| 56 | PHINode *PN = cast<PHINode>(BBI); |
| 57 | if (PN->getIncomingValueForBlock(SI1BB) != |
| 58 | PN->getIncomingValueForBlock(SI2BB)) |
| 59 | return false; |
| 60 | } |
| 61 | |
| 62 | return true; |
| 63 | } |
| 64 | |
| 65 | /// AddPredecessorToBlock - Update PHI nodes in Succ to indicate that there will |
| 66 | /// now be entries in it from the 'NewPred' block. The values that will be |
| 67 | /// flowing into the PHI nodes will be the same as those coming in from |
| 68 | /// ExistPred, an existing predecessor of Succ. |
| 69 | static void AddPredecessorToBlock(BasicBlock *Succ, BasicBlock *NewPred, |
| 70 | BasicBlock *ExistPred) { |
| 71 | assert(std::find(succ_begin(ExistPred), succ_end(ExistPred), Succ) != |
| 72 | succ_end(ExistPred) && "ExistPred is not a predecessor of Succ!"); |
| 73 | if (!isa<PHINode>(Succ->begin())) return; // Quick exit if nothing to do |
| 74 | |
Chris Lattner | 093a438 | 2008-07-13 22:23:11 +0000 | [diff] [blame] | 75 | PHINode *PN; |
| 76 | for (BasicBlock::iterator I = Succ->begin(); |
| 77 | (PN = dyn_cast<PHINode>(I)); ++I) |
| 78 | PN->addIncoming(PN->getIncomingValueForBlock(ExistPred), NewPred); |
Chris Lattner | 2bdcb56 | 2005-08-03 00:19:45 +0000 | [diff] [blame] | 79 | } |
| 80 | |
Chris Lattner | 7e66348 | 2005-08-03 00:11:16 +0000 | [diff] [blame] | 81 | |
Chris Lattner | 723c66d | 2004-02-11 03:36:04 +0000 | [diff] [blame] | 82 | /// GetIfCondition - Given a basic block (BB) with two predecessors (and |
| 83 | /// presumably PHI nodes in it), check to see if the merge at this block is due |
| 84 | /// to an "if condition". If so, return the boolean condition that determines |
| 85 | /// which entry into BB will be taken. Also, return by references the block |
| 86 | /// that will be entered from if the condition is true, and the block that will |
| 87 | /// be entered if the condition is false. |
Misha Brukman | fd93908 | 2005-04-21 23:48:37 +0000 | [diff] [blame] | 88 | /// |
Chris Lattner | 723c66d | 2004-02-11 03:36:04 +0000 | [diff] [blame] | 89 | /// |
| 90 | static Value *GetIfCondition(BasicBlock *BB, |
| 91 | BasicBlock *&IfTrue, BasicBlock *&IfFalse) { |
| 92 | assert(std::distance(pred_begin(BB), pred_end(BB)) == 2 && |
| 93 | "Function can only handle blocks with 2 predecessors!"); |
| 94 | BasicBlock *Pred1 = *pred_begin(BB); |
| 95 | BasicBlock *Pred2 = *++pred_begin(BB); |
| 96 | |
| 97 | // We can only handle branches. Other control flow will be lowered to |
| 98 | // branches if possible anyway. |
| 99 | if (!isa<BranchInst>(Pred1->getTerminator()) || |
| 100 | !isa<BranchInst>(Pred2->getTerminator())) |
| 101 | return 0; |
| 102 | BranchInst *Pred1Br = cast<BranchInst>(Pred1->getTerminator()); |
| 103 | BranchInst *Pred2Br = cast<BranchInst>(Pred2->getTerminator()); |
| 104 | |
| 105 | // Eliminate code duplication by ensuring that Pred1Br is conditional if |
| 106 | // either are. |
| 107 | if (Pred2Br->isConditional()) { |
| 108 | // If both branches are conditional, we don't have an "if statement". In |
| 109 | // reality, we could transform this case, but since the condition will be |
| 110 | // required anyway, we stand no chance of eliminating it, so the xform is |
| 111 | // probably not profitable. |
| 112 | if (Pred1Br->isConditional()) |
| 113 | return 0; |
| 114 | |
| 115 | std::swap(Pred1, Pred2); |
| 116 | std::swap(Pred1Br, Pred2Br); |
| 117 | } |
| 118 | |
| 119 | if (Pred1Br->isConditional()) { |
| 120 | // If we found a conditional branch predecessor, make sure that it branches |
| 121 | // to BB and Pred2Br. If it doesn't, this isn't an "if statement". |
| 122 | if (Pred1Br->getSuccessor(0) == BB && |
| 123 | Pred1Br->getSuccessor(1) == Pred2) { |
| 124 | IfTrue = Pred1; |
| 125 | IfFalse = Pred2; |
| 126 | } else if (Pred1Br->getSuccessor(0) == Pred2 && |
| 127 | Pred1Br->getSuccessor(1) == BB) { |
| 128 | IfTrue = Pred2; |
| 129 | IfFalse = Pred1; |
| 130 | } else { |
| 131 | // We know that one arm of the conditional goes to BB, so the other must |
| 132 | // go somewhere unrelated, and this must not be an "if statement". |
| 133 | return 0; |
| 134 | } |
| 135 | |
| 136 | // The only thing we have to watch out for here is to make sure that Pred2 |
| 137 | // doesn't have incoming edges from other blocks. If it does, the condition |
| 138 | // doesn't dominate BB. |
| 139 | if (++pred_begin(Pred2) != pred_end(Pred2)) |
| 140 | return 0; |
| 141 | |
| 142 | return Pred1Br->getCondition(); |
| 143 | } |
| 144 | |
| 145 | // Ok, if we got here, both predecessors end with an unconditional branch to |
| 146 | // BB. Don't panic! If both blocks only have a single (identical) |
| 147 | // predecessor, and THAT is a conditional branch, then we're all ok! |
| 148 | if (pred_begin(Pred1) == pred_end(Pred1) || |
| 149 | ++pred_begin(Pred1) != pred_end(Pred1) || |
| 150 | pred_begin(Pred2) == pred_end(Pred2) || |
| 151 | ++pred_begin(Pred2) != pred_end(Pred2) || |
| 152 | *pred_begin(Pred1) != *pred_begin(Pred2)) |
| 153 | return 0; |
| 154 | |
| 155 | // Otherwise, if this is a conditional branch, then we can use it! |
| 156 | BasicBlock *CommonPred = *pred_begin(Pred1); |
| 157 | if (BranchInst *BI = dyn_cast<BranchInst>(CommonPred->getTerminator())) { |
| 158 | assert(BI->isConditional() && "Two successors but not conditional?"); |
| 159 | if (BI->getSuccessor(0) == Pred1) { |
| 160 | IfTrue = Pred1; |
| 161 | IfFalse = Pred2; |
| 162 | } else { |
| 163 | IfTrue = Pred2; |
| 164 | IfFalse = Pred1; |
| 165 | } |
| 166 | return BI->getCondition(); |
| 167 | } |
| 168 | return 0; |
| 169 | } |
| 170 | |
Bill Wendling | 5049fa6 | 2009-01-19 23:43:56 +0000 | [diff] [blame] | 171 | /// DominatesMergePoint - If we have a merge point of an "if condition" as |
| 172 | /// accepted above, return true if the specified value dominates the block. We |
| 173 | /// don't handle the true generality of domination here, just a special case |
| 174 | /// which works well enough for us. |
| 175 | /// |
| 176 | /// If AggressiveInsts is non-null, and if V does not dominate BB, we check to |
| 177 | /// see if V (which must be an instruction) is cheap to compute and is |
| 178 | /// non-trapping. If both are true, the instruction is inserted into the set |
| 179 | /// and true is returned. |
Chris Lattner | 9c07866 | 2004-10-14 05:13:36 +0000 | [diff] [blame] | 180 | static bool DominatesMergePoint(Value *V, BasicBlock *BB, |
| 181 | std::set<Instruction*> *AggressiveInsts) { |
Chris Lattner | 570751c | 2004-04-09 22:50:22 +0000 | [diff] [blame] | 182 | Instruction *I = dyn_cast<Instruction>(V); |
Chris Lattner | b74b181 | 2006-10-20 00:42:07 +0000 | [diff] [blame] | 183 | if (!I) { |
| 184 | // Non-instructions all dominate instructions, but not all constantexprs |
| 185 | // can be executed unconditionally. |
| 186 | if (ConstantExpr *C = dyn_cast<ConstantExpr>(V)) |
| 187 | if (C->canTrap()) |
| 188 | return false; |
| 189 | return true; |
| 190 | } |
Chris Lattner | 570751c | 2004-04-09 22:50:22 +0000 | [diff] [blame] | 191 | BasicBlock *PBB = I->getParent(); |
Chris Lattner | 723c66d | 2004-02-11 03:36:04 +0000 | [diff] [blame] | 192 | |
Chris Lattner | da895d6 | 2005-02-27 06:18:25 +0000 | [diff] [blame] | 193 | // We don't want to allow weird loops that might have the "if condition" in |
Chris Lattner | 570751c | 2004-04-09 22:50:22 +0000 | [diff] [blame] | 194 | // the bottom of this block. |
| 195 | if (PBB == BB) return false; |
Chris Lattner | 723c66d | 2004-02-11 03:36:04 +0000 | [diff] [blame] | 196 | |
Chris Lattner | 570751c | 2004-04-09 22:50:22 +0000 | [diff] [blame] | 197 | // If this instruction is defined in a block that contains an unconditional |
| 198 | // branch to BB, then it must be in the 'conditional' part of the "if |
| 199 | // statement". |
| 200 | if (BranchInst *BI = dyn_cast<BranchInst>(PBB->getTerminator())) |
| 201 | if (BI->isUnconditional() && BI->getSuccessor(0) == BB) { |
Chris Lattner | 9c07866 | 2004-10-14 05:13:36 +0000 | [diff] [blame] | 202 | if (!AggressiveInsts) return false; |
Chris Lattner | 570751c | 2004-04-09 22:50:22 +0000 | [diff] [blame] | 203 | // Okay, it looks like the instruction IS in the "condition". Check to |
| 204 | // see if its a cheap instruction to unconditionally compute, and if it |
| 205 | // only uses stuff defined outside of the condition. If so, hoist it out. |
Eli Friedman | 0b79a77 | 2009-07-17 04:28:42 +0000 | [diff] [blame] | 206 | if (!I->isSafeToSpeculativelyExecute()) |
| 207 | return false; |
| 208 | |
Chris Lattner | 570751c | 2004-04-09 22:50:22 +0000 | [diff] [blame] | 209 | switch (I->getOpcode()) { |
| 210 | default: return false; // Cannot hoist this out safely. |
Dale Johannesen | 3a56d14 | 2009-03-06 21:08:33 +0000 | [diff] [blame] | 211 | case Instruction::Load: { |
Eli Friedman | 0b79a77 | 2009-07-17 04:28:42 +0000 | [diff] [blame] | 212 | // We have to check to make sure there are no instructions before the |
| 213 | // load in its basic block, as we are going to hoist the loop out to |
| 214 | // its predecessor. |
Dale Johannesen | 3a56d14 | 2009-03-06 21:08:33 +0000 | [diff] [blame] | 215 | BasicBlock::iterator IP = PBB->begin(); |
| 216 | while (isa<DbgInfoIntrinsic>(IP)) |
| 217 | IP++; |
| 218 | if (IP != BasicBlock::iterator(I)) |
Chris Lattner | 570751c | 2004-04-09 22:50:22 +0000 | [diff] [blame] | 219 | return false; |
| 220 | break; |
Dale Johannesen | 3a56d14 | 2009-03-06 21:08:33 +0000 | [diff] [blame] | 221 | } |
Chris Lattner | 570751c | 2004-04-09 22:50:22 +0000 | [diff] [blame] | 222 | case Instruction::Add: |
| 223 | case Instruction::Sub: |
| 224 | case Instruction::And: |
| 225 | case Instruction::Or: |
| 226 | case Instruction::Xor: |
| 227 | case Instruction::Shl: |
Reid Spencer | 3822ff5 | 2006-11-08 06:47:33 +0000 | [diff] [blame] | 228 | case Instruction::LShr: |
| 229 | case Instruction::AShr: |
Reid Spencer | e4d87aa | 2006-12-23 06:05:41 +0000 | [diff] [blame] | 230 | case Instruction::ICmp: |
Chris Lattner | 570751c | 2004-04-09 22:50:22 +0000 | [diff] [blame] | 231 | break; // These are all cheap and non-trapping instructions. |
| 232 | } |
Misha Brukman | fd93908 | 2005-04-21 23:48:37 +0000 | [diff] [blame] | 233 | |
Chris Lattner | 570751c | 2004-04-09 22:50:22 +0000 | [diff] [blame] | 234 | // Okay, we can only really hoist these out if their operands are not |
| 235 | // defined in the conditional region. |
Gabor Greif | f7ea363 | 2008-06-10 22:03:26 +0000 | [diff] [blame] | 236 | for (User::op_iterator i = I->op_begin(), e = I->op_end(); i != e; ++i) |
| 237 | if (!DominatesMergePoint(*i, BB, 0)) |
Chris Lattner | 570751c | 2004-04-09 22:50:22 +0000 | [diff] [blame] | 238 | return false; |
Chris Lattner | 9c07866 | 2004-10-14 05:13:36 +0000 | [diff] [blame] | 239 | // Okay, it's safe to do this! Remember this instruction. |
| 240 | AggressiveInsts->insert(I); |
Chris Lattner | 570751c | 2004-04-09 22:50:22 +0000 | [diff] [blame] | 241 | } |
| 242 | |
Chris Lattner | 723c66d | 2004-02-11 03:36:04 +0000 | [diff] [blame] | 243 | return true; |
| 244 | } |
Chris Lattner | 01d1ee3 | 2002-05-21 20:50:24 +0000 | [diff] [blame] | 245 | |
Bill Wendling | 5049fa6 | 2009-01-19 23:43:56 +0000 | [diff] [blame] | 246 | /// GatherConstantSetEQs - Given a potentially 'or'd together collection of |
| 247 | /// icmp_eq instructions that compare a value against a constant, return the |
| 248 | /// value being compared, and stick the constant into the Values vector. |
Chris Lattner | 1654cff | 2004-06-19 07:02:14 +0000 | [diff] [blame] | 249 | static Value *GatherConstantSetEQs(Value *V, std::vector<ConstantInt*> &Values){ |
Anton Korobeynikov | 07e6e56 | 2008-02-20 11:26:25 +0000 | [diff] [blame] | 250 | if (Instruction *Inst = dyn_cast<Instruction>(V)) { |
Reid Spencer | e4d87aa | 2006-12-23 06:05:41 +0000 | [diff] [blame] | 251 | if (Inst->getOpcode() == Instruction::ICmp && |
| 252 | cast<ICmpInst>(Inst)->getPredicate() == ICmpInst::ICMP_EQ) { |
Chris Lattner | 1654cff | 2004-06-19 07:02:14 +0000 | [diff] [blame] | 253 | if (ConstantInt *C = dyn_cast<ConstantInt>(Inst->getOperand(1))) { |
Chris Lattner | 0d56008 | 2004-02-24 05:38:11 +0000 | [diff] [blame] | 254 | Values.push_back(C); |
| 255 | return Inst->getOperand(0); |
Chris Lattner | 1654cff | 2004-06-19 07:02:14 +0000 | [diff] [blame] | 256 | } else if (ConstantInt *C = dyn_cast<ConstantInt>(Inst->getOperand(0))) { |
Chris Lattner | 0d56008 | 2004-02-24 05:38:11 +0000 | [diff] [blame] | 257 | Values.push_back(C); |
| 258 | return Inst->getOperand(1); |
| 259 | } |
| 260 | } else if (Inst->getOpcode() == Instruction::Or) { |
| 261 | if (Value *LHS = GatherConstantSetEQs(Inst->getOperand(0), Values)) |
| 262 | if (Value *RHS = GatherConstantSetEQs(Inst->getOperand(1), Values)) |
| 263 | if (LHS == RHS) |
| 264 | return LHS; |
| 265 | } |
Anton Korobeynikov | 07e6e56 | 2008-02-20 11:26:25 +0000 | [diff] [blame] | 266 | } |
Chris Lattner | 0d56008 | 2004-02-24 05:38:11 +0000 | [diff] [blame] | 267 | return 0; |
| 268 | } |
| 269 | |
Bill Wendling | 5049fa6 | 2009-01-19 23:43:56 +0000 | [diff] [blame] | 270 | /// GatherConstantSetNEs - Given a potentially 'and'd together collection of |
| 271 | /// setne instructions that compare a value against a constant, return the value |
| 272 | /// being compared, and stick the constant into the Values vector. |
Chris Lattner | 1654cff | 2004-06-19 07:02:14 +0000 | [diff] [blame] | 273 | static Value *GatherConstantSetNEs(Value *V, std::vector<ConstantInt*> &Values){ |
Anton Korobeynikov | 07e6e56 | 2008-02-20 11:26:25 +0000 | [diff] [blame] | 274 | if (Instruction *Inst = dyn_cast<Instruction>(V)) { |
Reid Spencer | e4d87aa | 2006-12-23 06:05:41 +0000 | [diff] [blame] | 275 | if (Inst->getOpcode() == Instruction::ICmp && |
| 276 | cast<ICmpInst>(Inst)->getPredicate() == ICmpInst::ICMP_NE) { |
Chris Lattner | 1654cff | 2004-06-19 07:02:14 +0000 | [diff] [blame] | 277 | if (ConstantInt *C = dyn_cast<ConstantInt>(Inst->getOperand(1))) { |
Chris Lattner | 0d56008 | 2004-02-24 05:38:11 +0000 | [diff] [blame] | 278 | Values.push_back(C); |
| 279 | return Inst->getOperand(0); |
Chris Lattner | 1654cff | 2004-06-19 07:02:14 +0000 | [diff] [blame] | 280 | } else if (ConstantInt *C = dyn_cast<ConstantInt>(Inst->getOperand(0))) { |
Chris Lattner | 0d56008 | 2004-02-24 05:38:11 +0000 | [diff] [blame] | 281 | Values.push_back(C); |
| 282 | return Inst->getOperand(1); |
| 283 | } |
Chris Lattner | 0d56008 | 2004-02-24 05:38:11 +0000 | [diff] [blame] | 284 | } else if (Inst->getOpcode() == Instruction::And) { |
| 285 | if (Value *LHS = GatherConstantSetNEs(Inst->getOperand(0), Values)) |
| 286 | if (Value *RHS = GatherConstantSetNEs(Inst->getOperand(1), Values)) |
| 287 | if (LHS == RHS) |
| 288 | return LHS; |
| 289 | } |
Anton Korobeynikov | 07e6e56 | 2008-02-20 11:26:25 +0000 | [diff] [blame] | 290 | } |
Chris Lattner | 0d56008 | 2004-02-24 05:38:11 +0000 | [diff] [blame] | 291 | return 0; |
| 292 | } |
| 293 | |
Chris Lattner | 0d56008 | 2004-02-24 05:38:11 +0000 | [diff] [blame] | 294 | /// GatherValueComparisons - If the specified Cond is an 'and' or 'or' of a |
| 295 | /// bunch of comparisons of one value against constants, return the value and |
| 296 | /// the constants being compared. |
| 297 | static bool GatherValueComparisons(Instruction *Cond, Value *&CompVal, |
Chris Lattner | 1654cff | 2004-06-19 07:02:14 +0000 | [diff] [blame] | 298 | std::vector<ConstantInt*> &Values) { |
Chris Lattner | 0d56008 | 2004-02-24 05:38:11 +0000 | [diff] [blame] | 299 | if (Cond->getOpcode() == Instruction::Or) { |
| 300 | CompVal = GatherConstantSetEQs(Cond, Values); |
| 301 | |
| 302 | // Return true to indicate that the condition is true if the CompVal is |
| 303 | // equal to one of the constants. |
| 304 | return true; |
| 305 | } else if (Cond->getOpcode() == Instruction::And) { |
| 306 | CompVal = GatherConstantSetNEs(Cond, Values); |
Misha Brukman | fd93908 | 2005-04-21 23:48:37 +0000 | [diff] [blame] | 307 | |
Chris Lattner | 0d56008 | 2004-02-24 05:38:11 +0000 | [diff] [blame] | 308 | // Return false to indicate that the condition is false if the CompVal is |
| 309 | // equal to one of the constants. |
| 310 | return false; |
| 311 | } |
| 312 | return false; |
| 313 | } |
| 314 | |
Eli Friedman | 080efb8 | 2008-12-16 20:54:32 +0000 | [diff] [blame] | 315 | static void EraseTerminatorInstAndDCECond(TerminatorInst *TI) { |
| 316 | Instruction* Cond = 0; |
| 317 | if (SwitchInst *SI = dyn_cast<SwitchInst>(TI)) { |
| 318 | Cond = dyn_cast<Instruction>(SI->getCondition()); |
| 319 | } else if (BranchInst *BI = dyn_cast<BranchInst>(TI)) { |
| 320 | if (BI->isConditional()) |
| 321 | Cond = dyn_cast<Instruction>(BI->getCondition()); |
| 322 | } |
| 323 | |
| 324 | TI->eraseFromParent(); |
| 325 | if (Cond) RecursivelyDeleteTriviallyDeadInstructions(Cond); |
| 326 | } |
| 327 | |
Chris Lattner | 9fd4955 | 2008-11-27 23:25:44 +0000 | [diff] [blame] | 328 | /// isValueEqualityComparison - Return true if the specified terminator checks |
| 329 | /// to see if a value is equal to constant integer value. |
Chris Lattner | 542f149 | 2004-02-28 21:28:10 +0000 | [diff] [blame] | 330 | static Value *isValueEqualityComparison(TerminatorInst *TI) { |
Chris Lattner | 4bebf08 | 2004-03-16 19:45:22 +0000 | [diff] [blame] | 331 | if (SwitchInst *SI = dyn_cast<SwitchInst>(TI)) { |
| 332 | // Do not permit merging of large switch instructions into their |
| 333 | // predecessors unless there is only one predecessor. |
| 334 | if (SI->getNumSuccessors() * std::distance(pred_begin(SI->getParent()), |
| 335 | pred_end(SI->getParent())) > 128) |
| 336 | return 0; |
| 337 | |
Chris Lattner | 542f149 | 2004-02-28 21:28:10 +0000 | [diff] [blame] | 338 | return SI->getCondition(); |
Chris Lattner | 4bebf08 | 2004-03-16 19:45:22 +0000 | [diff] [blame] | 339 | } |
Chris Lattner | 542f149 | 2004-02-28 21:28:10 +0000 | [diff] [blame] | 340 | if (BranchInst *BI = dyn_cast<BranchInst>(TI)) |
| 341 | if (BI->isConditional() && BI->getCondition()->hasOneUse()) |
Reid Spencer | e4d87aa | 2006-12-23 06:05:41 +0000 | [diff] [blame] | 342 | if (ICmpInst *ICI = dyn_cast<ICmpInst>(BI->getCondition())) |
| 343 | if ((ICI->getPredicate() == ICmpInst::ICMP_EQ || |
| 344 | ICI->getPredicate() == ICmpInst::ICMP_NE) && |
| 345 | isa<ConstantInt>(ICI->getOperand(1))) |
| 346 | return ICI->getOperand(0); |
Chris Lattner | 542f149 | 2004-02-28 21:28:10 +0000 | [diff] [blame] | 347 | return 0; |
| 348 | } |
| 349 | |
Bill Wendling | 5049fa6 | 2009-01-19 23:43:56 +0000 | [diff] [blame] | 350 | /// GetValueEqualityComparisonCases - Given a value comparison instruction, |
| 351 | /// decode all of the 'cases' that it represents and return the 'default' block. |
Chris Lattner | 542f149 | 2004-02-28 21:28:10 +0000 | [diff] [blame] | 352 | static BasicBlock * |
Misha Brukman | fd93908 | 2005-04-21 23:48:37 +0000 | [diff] [blame] | 353 | GetValueEqualityComparisonCases(TerminatorInst *TI, |
Chris Lattner | 542f149 | 2004-02-28 21:28:10 +0000 | [diff] [blame] | 354 | std::vector<std::pair<ConstantInt*, |
| 355 | BasicBlock*> > &Cases) { |
| 356 | if (SwitchInst *SI = dyn_cast<SwitchInst>(TI)) { |
| 357 | Cases.reserve(SI->getNumCases()); |
| 358 | for (unsigned i = 1, e = SI->getNumCases(); i != e; ++i) |
Chris Lattner | be54dcc | 2005-02-26 18:33:28 +0000 | [diff] [blame] | 359 | Cases.push_back(std::make_pair(SI->getCaseValue(i), SI->getSuccessor(i))); |
Chris Lattner | 542f149 | 2004-02-28 21:28:10 +0000 | [diff] [blame] | 360 | return SI->getDefaultDest(); |
| 361 | } |
| 362 | |
| 363 | BranchInst *BI = cast<BranchInst>(TI); |
Reid Spencer | e4d87aa | 2006-12-23 06:05:41 +0000 | [diff] [blame] | 364 | ICmpInst *ICI = cast<ICmpInst>(BI->getCondition()); |
| 365 | Cases.push_back(std::make_pair(cast<ConstantInt>(ICI->getOperand(1)), |
| 366 | BI->getSuccessor(ICI->getPredicate() == |
| 367 | ICmpInst::ICMP_NE))); |
| 368 | return BI->getSuccessor(ICI->getPredicate() == ICmpInst::ICMP_EQ); |
Chris Lattner | 542f149 | 2004-02-28 21:28:10 +0000 | [diff] [blame] | 369 | } |
| 370 | |
| 371 | |
Bill Wendling | 5049fa6 | 2009-01-19 23:43:56 +0000 | [diff] [blame] | 372 | /// EliminateBlockCases - Given a vector of bb/value pairs, remove any entries |
| 373 | /// in the list that match the specified block. |
Misha Brukman | fd93908 | 2005-04-21 23:48:37 +0000 | [diff] [blame] | 374 | static void EliminateBlockCases(BasicBlock *BB, |
Chris Lattner | 623369a | 2005-02-24 06:17:52 +0000 | [diff] [blame] | 375 | std::vector<std::pair<ConstantInt*, BasicBlock*> > &Cases) { |
| 376 | for (unsigned i = 0, e = Cases.size(); i != e; ++i) |
| 377 | if (Cases[i].second == BB) { |
| 378 | Cases.erase(Cases.begin()+i); |
| 379 | --i; --e; |
| 380 | } |
| 381 | } |
| 382 | |
Bill Wendling | 5049fa6 | 2009-01-19 23:43:56 +0000 | [diff] [blame] | 383 | /// ValuesOverlap - Return true if there are any keys in C1 that exist in C2 as |
| 384 | /// well. |
Chris Lattner | 623369a | 2005-02-24 06:17:52 +0000 | [diff] [blame] | 385 | static bool |
| 386 | ValuesOverlap(std::vector<std::pair<ConstantInt*, BasicBlock*> > &C1, |
| 387 | std::vector<std::pair<ConstantInt*, BasicBlock*> > &C2) { |
| 388 | std::vector<std::pair<ConstantInt*, BasicBlock*> > *V1 = &C1, *V2 = &C2; |
| 389 | |
| 390 | // Make V1 be smaller than V2. |
| 391 | if (V1->size() > V2->size()) |
| 392 | std::swap(V1, V2); |
| 393 | |
| 394 | if (V1->size() == 0) return false; |
| 395 | if (V1->size() == 1) { |
| 396 | // Just scan V2. |
| 397 | ConstantInt *TheVal = (*V1)[0].first; |
| 398 | for (unsigned i = 0, e = V2->size(); i != e; ++i) |
| 399 | if (TheVal == (*V2)[i].first) |
| 400 | return true; |
| 401 | } |
| 402 | |
| 403 | // Otherwise, just sort both lists and compare element by element. |
| 404 | std::sort(V1->begin(), V1->end()); |
| 405 | std::sort(V2->begin(), V2->end()); |
| 406 | unsigned i1 = 0, i2 = 0, e1 = V1->size(), e2 = V2->size(); |
| 407 | while (i1 != e1 && i2 != e2) { |
| 408 | if ((*V1)[i1].first == (*V2)[i2].first) |
| 409 | return true; |
| 410 | if ((*V1)[i1].first < (*V2)[i2].first) |
| 411 | ++i1; |
| 412 | else |
| 413 | ++i2; |
| 414 | } |
| 415 | return false; |
| 416 | } |
| 417 | |
Bill Wendling | 5049fa6 | 2009-01-19 23:43:56 +0000 | [diff] [blame] | 418 | /// SimplifyEqualityComparisonWithOnlyPredecessor - If TI is known to be a |
| 419 | /// terminator instruction and its block is known to only have a single |
| 420 | /// predecessor block, check to see if that predecessor is also a value |
| 421 | /// comparison with the same value, and if that comparison determines the |
| 422 | /// outcome of this comparison. If so, simplify TI. This does a very limited |
| 423 | /// form of jump threading. |
Chris Lattner | 623369a | 2005-02-24 06:17:52 +0000 | [diff] [blame] | 424 | static bool SimplifyEqualityComparisonWithOnlyPredecessor(TerminatorInst *TI, |
| 425 | BasicBlock *Pred) { |
| 426 | Value *PredVal = isValueEqualityComparison(Pred->getTerminator()); |
| 427 | if (!PredVal) return false; // Not a value comparison in predecessor. |
| 428 | |
| 429 | Value *ThisVal = isValueEqualityComparison(TI); |
| 430 | assert(ThisVal && "This isn't a value comparison!!"); |
| 431 | if (ThisVal != PredVal) return false; // Different predicates. |
| 432 | |
| 433 | // Find out information about when control will move from Pred to TI's block. |
| 434 | std::vector<std::pair<ConstantInt*, BasicBlock*> > PredCases; |
| 435 | BasicBlock *PredDef = GetValueEqualityComparisonCases(Pred->getTerminator(), |
| 436 | PredCases); |
| 437 | EliminateBlockCases(PredDef, PredCases); // Remove default from cases. |
Misha Brukman | fd93908 | 2005-04-21 23:48:37 +0000 | [diff] [blame] | 438 | |
Chris Lattner | 623369a | 2005-02-24 06:17:52 +0000 | [diff] [blame] | 439 | // Find information about how control leaves this block. |
| 440 | std::vector<std::pair<ConstantInt*, BasicBlock*> > ThisCases; |
| 441 | BasicBlock *ThisDef = GetValueEqualityComparisonCases(TI, ThisCases); |
| 442 | EliminateBlockCases(ThisDef, ThisCases); // Remove default from cases. |
| 443 | |
| 444 | // If TI's block is the default block from Pred's comparison, potentially |
| 445 | // simplify TI based on this knowledge. |
| 446 | if (PredDef == TI->getParent()) { |
| 447 | // If we are here, we know that the value is none of those cases listed in |
| 448 | // PredCases. If there are any cases in ThisCases that are in PredCases, we |
| 449 | // can simplify TI. |
| 450 | if (ValuesOverlap(PredCases, ThisCases)) { |
Eli Friedman | 080efb8 | 2008-12-16 20:54:32 +0000 | [diff] [blame] | 451 | if (isa<BranchInst>(TI)) { |
Chris Lattner | 623369a | 2005-02-24 06:17:52 +0000 | [diff] [blame] | 452 | // Okay, one of the successors of this condbr is dead. Convert it to a |
| 453 | // uncond br. |
| 454 | assert(ThisCases.size() == 1 && "Branch can only have one case!"); |
Chris Lattner | 623369a | 2005-02-24 06:17:52 +0000 | [diff] [blame] | 455 | // Insert the new branch. |
Gabor Greif | 051a950 | 2008-04-06 20:25:17 +0000 | [diff] [blame] | 456 | Instruction *NI = BranchInst::Create(ThisDef, TI); |
Daniel Dunbar | e317bcc | 2009-08-23 10:29:55 +0000 | [diff] [blame] | 457 | (void) NI; |
Chris Lattner | 623369a | 2005-02-24 06:17:52 +0000 | [diff] [blame] | 458 | |
| 459 | // Remove PHI node entries for the dead edge. |
| 460 | ThisCases[0].second->removePredecessor(TI->getParent()); |
| 461 | |
Chris Lattner | bdff548 | 2009-08-23 04:37:46 +0000 | [diff] [blame] | 462 | DEBUG(errs() << "Threading pred instr: " << *Pred->getTerminator() |
| 463 | << "Through successor TI: " << *TI << "Leaving: " << *NI << "\n"); |
Chris Lattner | 623369a | 2005-02-24 06:17:52 +0000 | [diff] [blame] | 464 | |
Eli Friedman | 080efb8 | 2008-12-16 20:54:32 +0000 | [diff] [blame] | 465 | EraseTerminatorInstAndDCECond(TI); |
Chris Lattner | 623369a | 2005-02-24 06:17:52 +0000 | [diff] [blame] | 466 | return true; |
| 467 | |
| 468 | } else { |
| 469 | SwitchInst *SI = cast<SwitchInst>(TI); |
| 470 | // Okay, TI has cases that are statically dead, prune them away. |
Chris Lattner | c995123 | 2007-04-02 01:44:59 +0000 | [diff] [blame] | 471 | SmallPtrSet<Constant*, 16> DeadCases; |
Chris Lattner | 623369a | 2005-02-24 06:17:52 +0000 | [diff] [blame] | 472 | for (unsigned i = 0, e = PredCases.size(); i != e; ++i) |
| 473 | DeadCases.insert(PredCases[i].first); |
| 474 | |
Chris Lattner | bdff548 | 2009-08-23 04:37:46 +0000 | [diff] [blame] | 475 | DEBUG(errs() << "Threading pred instr: " << *Pred->getTerminator() |
| 476 | << "Through successor TI: " << *TI); |
Chris Lattner | 623369a | 2005-02-24 06:17:52 +0000 | [diff] [blame] | 477 | |
| 478 | for (unsigned i = SI->getNumCases()-1; i != 0; --i) |
| 479 | if (DeadCases.count(SI->getCaseValue(i))) { |
| 480 | SI->getSuccessor(i)->removePredecessor(TI->getParent()); |
| 481 | SI->removeCase(i); |
| 482 | } |
| 483 | |
Chris Lattner | bdff548 | 2009-08-23 04:37:46 +0000 | [diff] [blame] | 484 | DEBUG(errs() << "Leaving: " << *TI << "\n"); |
Chris Lattner | 623369a | 2005-02-24 06:17:52 +0000 | [diff] [blame] | 485 | return true; |
| 486 | } |
| 487 | } |
| 488 | |
| 489 | } else { |
| 490 | // Otherwise, TI's block must correspond to some matched value. Find out |
| 491 | // which value (or set of values) this is. |
| 492 | ConstantInt *TIV = 0; |
| 493 | BasicBlock *TIBB = TI->getParent(); |
| 494 | for (unsigned i = 0, e = PredCases.size(); i != e; ++i) |
Anton Korobeynikov | 07e6e56 | 2008-02-20 11:26:25 +0000 | [diff] [blame] | 495 | if (PredCases[i].second == TIBB) { |
Chris Lattner | 623369a | 2005-02-24 06:17:52 +0000 | [diff] [blame] | 496 | if (TIV == 0) |
| 497 | TIV = PredCases[i].first; |
| 498 | else |
| 499 | return false; // Cannot handle multiple values coming to this block. |
Anton Korobeynikov | 07e6e56 | 2008-02-20 11:26:25 +0000 | [diff] [blame] | 500 | } |
Chris Lattner | 623369a | 2005-02-24 06:17:52 +0000 | [diff] [blame] | 501 | assert(TIV && "No edge from pred to succ?"); |
| 502 | |
| 503 | // Okay, we found the one constant that our value can be if we get into TI's |
| 504 | // BB. Find out which successor will unconditionally be branched to. |
| 505 | BasicBlock *TheRealDest = 0; |
| 506 | for (unsigned i = 0, e = ThisCases.size(); i != e; ++i) |
| 507 | if (ThisCases[i].first == TIV) { |
| 508 | TheRealDest = ThisCases[i].second; |
| 509 | break; |
| 510 | } |
| 511 | |
| 512 | // If not handled by any explicit cases, it is handled by the default case. |
| 513 | if (TheRealDest == 0) TheRealDest = ThisDef; |
| 514 | |
| 515 | // Remove PHI node entries for dead edges. |
| 516 | BasicBlock *CheckEdge = TheRealDest; |
| 517 | for (succ_iterator SI = succ_begin(TIBB), e = succ_end(TIBB); SI != e; ++SI) |
| 518 | if (*SI != CheckEdge) |
| 519 | (*SI)->removePredecessor(TIBB); |
| 520 | else |
| 521 | CheckEdge = 0; |
| 522 | |
| 523 | // Insert the new branch. |
Gabor Greif | 051a950 | 2008-04-06 20:25:17 +0000 | [diff] [blame] | 524 | Instruction *NI = BranchInst::Create(TheRealDest, TI); |
Daniel Dunbar | e317bcc | 2009-08-23 10:29:55 +0000 | [diff] [blame] | 525 | (void) NI; |
Chris Lattner | 623369a | 2005-02-24 06:17:52 +0000 | [diff] [blame] | 526 | |
Chris Lattner | bdff548 | 2009-08-23 04:37:46 +0000 | [diff] [blame] | 527 | DEBUG(errs() << "Threading pred instr: " << *Pred->getTerminator() |
| 528 | << "Through successor TI: " << *TI << "Leaving: " << *NI << "\n"); |
Chris Lattner | 623369a | 2005-02-24 06:17:52 +0000 | [diff] [blame] | 529 | |
Eli Friedman | 080efb8 | 2008-12-16 20:54:32 +0000 | [diff] [blame] | 530 | EraseTerminatorInstAndDCECond(TI); |
Chris Lattner | 623369a | 2005-02-24 06:17:52 +0000 | [diff] [blame] | 531 | return true; |
| 532 | } |
| 533 | return false; |
| 534 | } |
| 535 | |
Dale Johannesen | c81f544 | 2009-03-12 21:01:11 +0000 | [diff] [blame] | 536 | namespace { |
| 537 | /// ConstantIntOrdering - This class implements a stable ordering of constant |
| 538 | /// integers that does not depend on their address. This is important for |
| 539 | /// applications that sort ConstantInt's to ensure uniqueness. |
| 540 | struct ConstantIntOrdering { |
| 541 | bool operator()(const ConstantInt *LHS, const ConstantInt *RHS) const { |
| 542 | return LHS->getValue().ult(RHS->getValue()); |
| 543 | } |
| 544 | }; |
| 545 | } |
Dale Johannesen | a9537cf | 2009-03-12 01:00:26 +0000 | [diff] [blame] | 546 | |
Bill Wendling | 5049fa6 | 2009-01-19 23:43:56 +0000 | [diff] [blame] | 547 | /// FoldValueComparisonIntoPredecessors - The specified terminator is a value |
| 548 | /// equality comparison instruction (either a switch or a branch on "X == c"). |
| 549 | /// See if any of the predecessors of the terminator block are value comparisons |
| 550 | /// on the same value. If so, and if safe to do so, fold them together. |
Chris Lattner | 542f149 | 2004-02-28 21:28:10 +0000 | [diff] [blame] | 551 | static bool FoldValueComparisonIntoPredecessors(TerminatorInst *TI) { |
| 552 | BasicBlock *BB = TI->getParent(); |
| 553 | Value *CV = isValueEqualityComparison(TI); // CondVal |
| 554 | assert(CV && "Not a comparison?"); |
| 555 | bool Changed = false; |
| 556 | |
Chris Lattner | 8244243 | 2008-02-18 07:42:56 +0000 | [diff] [blame] | 557 | SmallVector<BasicBlock*, 16> Preds(pred_begin(BB), pred_end(BB)); |
Chris Lattner | 542f149 | 2004-02-28 21:28:10 +0000 | [diff] [blame] | 558 | while (!Preds.empty()) { |
Dan Gohman | e9d87f4 | 2009-05-06 17:22:41 +0000 | [diff] [blame] | 559 | BasicBlock *Pred = Preds.pop_back_val(); |
Misha Brukman | fd93908 | 2005-04-21 23:48:37 +0000 | [diff] [blame] | 560 | |
Chris Lattner | 542f149 | 2004-02-28 21:28:10 +0000 | [diff] [blame] | 561 | // See if the predecessor is a comparison with the same value. |
| 562 | TerminatorInst *PTI = Pred->getTerminator(); |
| 563 | Value *PCV = isValueEqualityComparison(PTI); // PredCondVal |
| 564 | |
| 565 | if (PCV == CV && SafeToMergeTerminators(TI, PTI)) { |
| 566 | // Figure out which 'cases' to copy from SI to PSI. |
| 567 | std::vector<std::pair<ConstantInt*, BasicBlock*> > BBCases; |
| 568 | BasicBlock *BBDefault = GetValueEqualityComparisonCases(TI, BBCases); |
| 569 | |
| 570 | std::vector<std::pair<ConstantInt*, BasicBlock*> > PredCases; |
| 571 | BasicBlock *PredDefault = GetValueEqualityComparisonCases(PTI, PredCases); |
| 572 | |
| 573 | // Based on whether the default edge from PTI goes to BB or not, fill in |
| 574 | // PredCases and PredDefault with the new switch cases we would like to |
| 575 | // build. |
Chris Lattner | 8244243 | 2008-02-18 07:42:56 +0000 | [diff] [blame] | 576 | SmallVector<BasicBlock*, 8> NewSuccessors; |
Chris Lattner | 542f149 | 2004-02-28 21:28:10 +0000 | [diff] [blame] | 577 | |
| 578 | if (PredDefault == BB) { |
| 579 | // If this is the default destination from PTI, only the edges in TI |
| 580 | // that don't occur in PTI, or that branch to BB will be activated. |
Dale Johannesen | c81f544 | 2009-03-12 21:01:11 +0000 | [diff] [blame] | 581 | std::set<ConstantInt*, ConstantIntOrdering> PTIHandled; |
Chris Lattner | 542f149 | 2004-02-28 21:28:10 +0000 | [diff] [blame] | 582 | for (unsigned i = 0, e = PredCases.size(); i != e; ++i) |
| 583 | if (PredCases[i].second != BB) |
| 584 | PTIHandled.insert(PredCases[i].first); |
| 585 | else { |
| 586 | // The default destination is BB, we don't need explicit targets. |
| 587 | std::swap(PredCases[i], PredCases.back()); |
| 588 | PredCases.pop_back(); |
| 589 | --i; --e; |
| 590 | } |
| 591 | |
| 592 | // Reconstruct the new switch statement we will be building. |
| 593 | if (PredDefault != BBDefault) { |
| 594 | PredDefault->removePredecessor(Pred); |
| 595 | PredDefault = BBDefault; |
| 596 | NewSuccessors.push_back(BBDefault); |
| 597 | } |
| 598 | for (unsigned i = 0, e = BBCases.size(); i != e; ++i) |
| 599 | if (!PTIHandled.count(BBCases[i].first) && |
| 600 | BBCases[i].second != BBDefault) { |
| 601 | PredCases.push_back(BBCases[i]); |
| 602 | NewSuccessors.push_back(BBCases[i].second); |
| 603 | } |
| 604 | |
| 605 | } else { |
| 606 | // If this is not the default destination from PSI, only the edges |
| 607 | // in SI that occur in PSI with a destination of BB will be |
| 608 | // activated. |
Dale Johannesen | c81f544 | 2009-03-12 21:01:11 +0000 | [diff] [blame] | 609 | std::set<ConstantInt*, ConstantIntOrdering> PTIHandled; |
Chris Lattner | 542f149 | 2004-02-28 21:28:10 +0000 | [diff] [blame] | 610 | for (unsigned i = 0, e = PredCases.size(); i != e; ++i) |
| 611 | if (PredCases[i].second == BB) { |
| 612 | PTIHandled.insert(PredCases[i].first); |
| 613 | std::swap(PredCases[i], PredCases.back()); |
| 614 | PredCases.pop_back(); |
| 615 | --i; --e; |
| 616 | } |
| 617 | |
| 618 | // Okay, now we know which constants were sent to BB from the |
| 619 | // predecessor. Figure out where they will all go now. |
| 620 | for (unsigned i = 0, e = BBCases.size(); i != e; ++i) |
| 621 | if (PTIHandled.count(BBCases[i].first)) { |
| 622 | // If this is one we are capable of getting... |
| 623 | PredCases.push_back(BBCases[i]); |
| 624 | NewSuccessors.push_back(BBCases[i].second); |
| 625 | PTIHandled.erase(BBCases[i].first);// This constant is taken care of |
| 626 | } |
| 627 | |
| 628 | // If there are any constants vectored to BB that TI doesn't handle, |
| 629 | // they must go to the default destination of TI. |
Dale Johannesen | c81f544 | 2009-03-12 21:01:11 +0000 | [diff] [blame] | 630 | for (std::set<ConstantInt*, ConstantIntOrdering>::iterator I = |
| 631 | PTIHandled.begin(), |
Chris Lattner | 542f149 | 2004-02-28 21:28:10 +0000 | [diff] [blame] | 632 | E = PTIHandled.end(); I != E; ++I) { |
| 633 | PredCases.push_back(std::make_pair(*I, BBDefault)); |
| 634 | NewSuccessors.push_back(BBDefault); |
| 635 | } |
| 636 | } |
| 637 | |
| 638 | // Okay, at this point, we know which new successor Pred will get. Make |
| 639 | // sure we update the number of entries in the PHI nodes for these |
| 640 | // successors. |
| 641 | for (unsigned i = 0, e = NewSuccessors.size(); i != e; ++i) |
| 642 | AddPredecessorToBlock(NewSuccessors[i], Pred, BB); |
| 643 | |
| 644 | // Now that the successors are updated, create the new Switch instruction. |
Gabor Greif | b1dbcd8 | 2008-05-15 10:04:30 +0000 | [diff] [blame] | 645 | SwitchInst *NewSI = SwitchInst::Create(CV, PredDefault, |
| 646 | PredCases.size(), PTI); |
Chris Lattner | 542f149 | 2004-02-28 21:28:10 +0000 | [diff] [blame] | 647 | for (unsigned i = 0, e = PredCases.size(); i != e; ++i) |
| 648 | NewSI->addCase(PredCases[i].first, PredCases[i].second); |
Chris Lattner | 13b2f76 | 2005-01-01 16:02:12 +0000 | [diff] [blame] | 649 | |
Eli Friedman | 080efb8 | 2008-12-16 20:54:32 +0000 | [diff] [blame] | 650 | EraseTerminatorInstAndDCECond(PTI); |
Chris Lattner | 13b2f76 | 2005-01-01 16:02:12 +0000 | [diff] [blame] | 651 | |
Chris Lattner | 542f149 | 2004-02-28 21:28:10 +0000 | [diff] [blame] | 652 | // Okay, last check. If BB is still a successor of PSI, then we must |
| 653 | // have an infinite loop case. If so, add an infinitely looping block |
| 654 | // to handle the case to preserve the behavior of the code. |
| 655 | BasicBlock *InfLoopBlock = 0; |
| 656 | for (unsigned i = 0, e = NewSI->getNumSuccessors(); i != e; ++i) |
| 657 | if (NewSI->getSuccessor(i) == BB) { |
| 658 | if (InfLoopBlock == 0) { |
Chris Lattner | 093a438 | 2008-07-13 22:23:11 +0000 | [diff] [blame] | 659 | // Insert it at the end of the function, because it's either code, |
Chris Lattner | 542f149 | 2004-02-28 21:28:10 +0000 | [diff] [blame] | 660 | // or it won't matter if it's hot. :) |
Owen Anderson | 1d0be15 | 2009-08-13 21:58:54 +0000 | [diff] [blame] | 661 | InfLoopBlock = BasicBlock::Create(BB->getContext(), |
| 662 | "infloop", BB->getParent()); |
Gabor Greif | 051a950 | 2008-04-06 20:25:17 +0000 | [diff] [blame] | 663 | BranchInst::Create(InfLoopBlock, InfLoopBlock); |
Chris Lattner | 542f149 | 2004-02-28 21:28:10 +0000 | [diff] [blame] | 664 | } |
| 665 | NewSI->setSuccessor(i, InfLoopBlock); |
| 666 | } |
Misha Brukman | fd93908 | 2005-04-21 23:48:37 +0000 | [diff] [blame] | 667 | |
Chris Lattner | 542f149 | 2004-02-28 21:28:10 +0000 | [diff] [blame] | 668 | Changed = true; |
| 669 | } |
| 670 | } |
| 671 | return Changed; |
| 672 | } |
| 673 | |
Dale Johannesen | c1f1040 | 2009-06-15 20:59:27 +0000 | [diff] [blame] | 674 | // isSafeToHoistInvoke - If we would need to insert a select that uses the |
| 675 | // value of this invoke (comments in HoistThenElseCodeToIf explain why we |
| 676 | // would need to do this), we can't hoist the invoke, as there is nowhere |
| 677 | // to put the select in this case. |
| 678 | static bool isSafeToHoistInvoke(BasicBlock *BB1, BasicBlock *BB2, |
| 679 | Instruction *I1, Instruction *I2) { |
| 680 | for (succ_iterator SI = succ_begin(BB1), E = succ_end(BB1); SI != E; ++SI) { |
| 681 | PHINode *PN; |
| 682 | for (BasicBlock::iterator BBI = SI->begin(); |
| 683 | (PN = dyn_cast<PHINode>(BBI)); ++BBI) { |
| 684 | Value *BB1V = PN->getIncomingValueForBlock(BB1); |
| 685 | Value *BB2V = PN->getIncomingValueForBlock(BB2); |
| 686 | if (BB1V != BB2V && (BB1V==I1 || BB2V==I2)) { |
| 687 | return false; |
| 688 | } |
| 689 | } |
| 690 | } |
| 691 | return true; |
| 692 | } |
| 693 | |
Chris Lattner | 6306d07 | 2005-08-03 17:59:45 +0000 | [diff] [blame] | 694 | /// HoistThenElseCodeToIf - Given a conditional branch that goes to BB1 and |
Chris Lattner | 37dc938 | 2004-11-30 00:29:14 +0000 | [diff] [blame] | 695 | /// BB2, hoist any common code in the two blocks up into the branch block. The |
| 696 | /// caller of this function guarantees that BI's block dominates BB1 and BB2. |
| 697 | static bool HoistThenElseCodeToIf(BranchInst *BI) { |
| 698 | // This does very trivial matching, with limited scanning, to find identical |
| 699 | // instructions in the two blocks. In particular, we don't want to get into |
| 700 | // O(M*N) situations here where M and N are the sizes of BB1 and BB2. As |
| 701 | // such, we currently just scan for obviously identical instructions in an |
| 702 | // identical order. |
| 703 | BasicBlock *BB1 = BI->getSuccessor(0); // The true destination. |
| 704 | BasicBlock *BB2 = BI->getSuccessor(1); // The false destination |
| 705 | |
Devang Patel | 65085cf | 2009-02-04 00:03:08 +0000 | [diff] [blame] | 706 | BasicBlock::iterator BB1_Itr = BB1->begin(); |
| 707 | BasicBlock::iterator BB2_Itr = BB2->begin(); |
| 708 | |
| 709 | Instruction *I1 = BB1_Itr++, *I2 = BB2_Itr++; |
| 710 | while (isa<DbgInfoIntrinsic>(I1)) |
| 711 | I1 = BB1_Itr++; |
| 712 | while (isa<DbgInfoIntrinsic>(I2)) |
| 713 | I2 = BB2_Itr++; |
Dale Johannesen | c1f1040 | 2009-06-15 20:59:27 +0000 | [diff] [blame] | 714 | if (I1->getOpcode() != I2->getOpcode() || isa<PHINode>(I1) || |
Dan Gohman | 58cfa3b | 2009-08-25 22:11:20 +0000 | [diff] [blame] | 715 | !I1->isIdenticalToWhenDefined(I2) || |
Dale Johannesen | c1f1040 | 2009-06-15 20:59:27 +0000 | [diff] [blame] | 716 | (isa<InvokeInst>(I1) && !isSafeToHoistInvoke(BB1, BB2, I1, I2))) |
Chris Lattner | 37dc938 | 2004-11-30 00:29:14 +0000 | [diff] [blame] | 717 | return false; |
| 718 | |
| 719 | // If we get here, we can hoist at least one instruction. |
| 720 | BasicBlock *BIParent = BI->getParent(); |
Chris Lattner | 37dc938 | 2004-11-30 00:29:14 +0000 | [diff] [blame] | 721 | |
| 722 | do { |
| 723 | // If we are hoisting the terminator instruction, don't move one (making a |
| 724 | // broken BB), instead clone it, and remove BI. |
| 725 | if (isa<TerminatorInst>(I1)) |
| 726 | goto HoistTerminator; |
Misha Brukman | fd93908 | 2005-04-21 23:48:37 +0000 | [diff] [blame] | 727 | |
Chris Lattner | 37dc938 | 2004-11-30 00:29:14 +0000 | [diff] [blame] | 728 | // For a normal instruction, we just move one to right before the branch, |
| 729 | // then replace all uses of the other with the first. Finally, we remove |
| 730 | // the now redundant second instruction. |
| 731 | BIParent->getInstList().splice(BI, BB1->getInstList(), I1); |
| 732 | if (!I2->use_empty()) |
| 733 | I2->replaceAllUsesWith(I1); |
Dan Gohman | 58cfa3b | 2009-08-25 22:11:20 +0000 | [diff] [blame] | 734 | I1->intersectOptionalDataWith(I2); |
Chris Lattner | 37dc938 | 2004-11-30 00:29:14 +0000 | [diff] [blame] | 735 | BB2->getInstList().erase(I2); |
Misha Brukman | fd93908 | 2005-04-21 23:48:37 +0000 | [diff] [blame] | 736 | |
Devang Patel | 65085cf | 2009-02-04 00:03:08 +0000 | [diff] [blame] | 737 | I1 = BB1_Itr++; |
| 738 | while (isa<DbgInfoIntrinsic>(I1)) |
| 739 | I1 = BB1_Itr++; |
| 740 | I2 = BB2_Itr++; |
| 741 | while (isa<DbgInfoIntrinsic>(I2)) |
| 742 | I2 = BB2_Itr++; |
Dan Gohman | 58cfa3b | 2009-08-25 22:11:20 +0000 | [diff] [blame] | 743 | } while (I1->getOpcode() == I2->getOpcode() && |
| 744 | I1->isIdenticalToWhenDefined(I2)); |
Chris Lattner | 37dc938 | 2004-11-30 00:29:14 +0000 | [diff] [blame] | 745 | |
| 746 | return true; |
| 747 | |
| 748 | HoistTerminator: |
Dale Johannesen | c1f1040 | 2009-06-15 20:59:27 +0000 | [diff] [blame] | 749 | // It may not be possible to hoist an invoke. |
| 750 | if (isa<InvokeInst>(I1) && !isSafeToHoistInvoke(BB1, BB2, I1, I2)) |
| 751 | return true; |
| 752 | |
Chris Lattner | 37dc938 | 2004-11-30 00:29:14 +0000 | [diff] [blame] | 753 | // Okay, it is safe to hoist the terminator. |
Nick Lewycky | 6776064 | 2009-09-27 07:38:41 +0000 | [diff] [blame] | 754 | Instruction *NT = I1->clone(); |
Chris Lattner | 37dc938 | 2004-11-30 00:29:14 +0000 | [diff] [blame] | 755 | BIParent->getInstList().insert(BI, NT); |
Owen Anderson | 1d0be15 | 2009-08-13 21:58:54 +0000 | [diff] [blame] | 756 | if (NT->getType() != Type::getVoidTy(BB1->getContext())) { |
Chris Lattner | 37dc938 | 2004-11-30 00:29:14 +0000 | [diff] [blame] | 757 | I1->replaceAllUsesWith(NT); |
| 758 | I2->replaceAllUsesWith(NT); |
Chris Lattner | 86cc423 | 2007-02-11 01:37:51 +0000 | [diff] [blame] | 759 | NT->takeName(I1); |
Chris Lattner | 37dc938 | 2004-11-30 00:29:14 +0000 | [diff] [blame] | 760 | } |
| 761 | |
| 762 | // Hoisting one of the terminators from our successor is a great thing. |
| 763 | // Unfortunately, the successors of the if/else blocks may have PHI nodes in |
| 764 | // them. If they do, all PHI entries for BB1/BB2 must agree for all PHI |
| 765 | // nodes, so we insert select instruction to compute the final result. |
| 766 | std::map<std::pair<Value*,Value*>, SelectInst*> InsertedSelects; |
| 767 | for (succ_iterator SI = succ_begin(BB1), E = succ_end(BB1); SI != E; ++SI) { |
| 768 | PHINode *PN; |
| 769 | for (BasicBlock::iterator BBI = SI->begin(); |
Chris Lattner | 0f535c6 | 2004-11-30 07:47:34 +0000 | [diff] [blame] | 770 | (PN = dyn_cast<PHINode>(BBI)); ++BBI) { |
Chris Lattner | 37dc938 | 2004-11-30 00:29:14 +0000 | [diff] [blame] | 771 | Value *BB1V = PN->getIncomingValueForBlock(BB1); |
| 772 | Value *BB2V = PN->getIncomingValueForBlock(BB2); |
| 773 | if (BB1V != BB2V) { |
| 774 | // These values do not agree. Insert a select instruction before NT |
| 775 | // that determines the right value. |
| 776 | SelectInst *&SI = InsertedSelects[std::make_pair(BB1V, BB2V)]; |
| 777 | if (SI == 0) |
Gabor Greif | 051a950 | 2008-04-06 20:25:17 +0000 | [diff] [blame] | 778 | SI = SelectInst::Create(BI->getCondition(), BB1V, BB2V, |
| 779 | BB1V->getName()+"."+BB2V->getName(), NT); |
Chris Lattner | 37dc938 | 2004-11-30 00:29:14 +0000 | [diff] [blame] | 780 | // Make the PHI node use the select for all incoming values for BB1/BB2 |
| 781 | for (unsigned i = 0, e = PN->getNumIncomingValues(); i != e; ++i) |
| 782 | if (PN->getIncomingBlock(i) == BB1 || PN->getIncomingBlock(i) == BB2) |
| 783 | PN->setIncomingValue(i, SI); |
| 784 | } |
| 785 | } |
| 786 | } |
| 787 | |
| 788 | // Update any PHI nodes in our new successors. |
| 789 | for (succ_iterator SI = succ_begin(BB1), E = succ_end(BB1); SI != E; ++SI) |
| 790 | AddPredecessorToBlock(*SI, BIParent, BB1); |
Misha Brukman | fd93908 | 2005-04-21 23:48:37 +0000 | [diff] [blame] | 791 | |
Eli Friedman | 080efb8 | 2008-12-16 20:54:32 +0000 | [diff] [blame] | 792 | EraseTerminatorInstAndDCECond(BI); |
Chris Lattner | 37dc938 | 2004-11-30 00:29:14 +0000 | [diff] [blame] | 793 | return true; |
| 794 | } |
| 795 | |
Evan Cheng | 4d09efd | 2008-06-07 08:52:29 +0000 | [diff] [blame] | 796 | /// SpeculativelyExecuteBB - Given a conditional branch that goes to BB1 |
| 797 | /// and an BB2 and the only successor of BB1 is BB2, hoist simple code |
| 798 | /// (for now, restricted to a single instruction that's side effect free) from |
| 799 | /// the BB1 into the branch block to speculatively execute it. |
| 800 | static bool SpeculativelyExecuteBB(BranchInst *BI, BasicBlock *BB1) { |
| 801 | // Only speculatively execution a single instruction (not counting the |
| 802 | // terminator) for now. |
Devang Patel | 06b1e67 | 2009-03-06 06:00:17 +0000 | [diff] [blame] | 803 | Instruction *HInst = NULL; |
| 804 | Instruction *Term = BB1->getTerminator(); |
| 805 | for (BasicBlock::iterator BBI = BB1->begin(), BBE = BB1->end(); |
| 806 | BBI != BBE; ++BBI) { |
| 807 | Instruction *I = BBI; |
| 808 | // Skip debug info. |
| 809 | if (isa<DbgInfoIntrinsic>(I)) continue; |
| 810 | if (I == Term) break; |
| 811 | |
| 812 | if (!HInst) |
| 813 | HInst = I; |
| 814 | else |
| 815 | return false; |
| 816 | } |
| 817 | if (!HInst) |
| 818 | return false; |
Evan Cheng | 4d09efd | 2008-06-07 08:52:29 +0000 | [diff] [blame] | 819 | |
Evan Cheng | 797d951 | 2008-06-11 19:18:20 +0000 | [diff] [blame] | 820 | // Be conservative for now. FP select instruction can often be expensive. |
| 821 | Value *BrCond = BI->getCondition(); |
| 822 | if (isa<Instruction>(BrCond) && |
| 823 | cast<Instruction>(BrCond)->getOpcode() == Instruction::FCmp) |
| 824 | return false; |
| 825 | |
Evan Cheng | 4d09efd | 2008-06-07 08:52:29 +0000 | [diff] [blame] | 826 | // If BB1 is actually on the false edge of the conditional branch, remember |
| 827 | // to swap the select operands later. |
| 828 | bool Invert = false; |
| 829 | if (BB1 != BI->getSuccessor(0)) { |
| 830 | assert(BB1 == BI->getSuccessor(1) && "No edge from 'if' block?"); |
| 831 | Invert = true; |
| 832 | } |
| 833 | |
| 834 | // Turn |
| 835 | // BB: |
| 836 | // %t1 = icmp |
| 837 | // br i1 %t1, label %BB1, label %BB2 |
| 838 | // BB1: |
| 839 | // %t3 = add %t2, c |
| 840 | // br label BB2 |
| 841 | // BB2: |
| 842 | // => |
| 843 | // BB: |
| 844 | // %t1 = icmp |
| 845 | // %t4 = add %t2, c |
| 846 | // %t3 = select i1 %t1, %t2, %t3 |
Devang Patel | 06b1e67 | 2009-03-06 06:00:17 +0000 | [diff] [blame] | 847 | switch (HInst->getOpcode()) { |
Evan Cheng | 4d09efd | 2008-06-07 08:52:29 +0000 | [diff] [blame] | 848 | default: return false; // Not safe / profitable to hoist. |
| 849 | case Instruction::Add: |
| 850 | case Instruction::Sub: |
Dan Gohman | ae3a0be | 2009-06-04 22:49:04 +0000 | [diff] [blame] | 851 | // Not worth doing for vector ops. |
| 852 | if (isa<VectorType>(HInst->getType())) |
Chris Lattner | 9dd3b61 | 2009-01-18 23:22:07 +0000 | [diff] [blame] | 853 | return false; |
| 854 | break; |
Evan Cheng | 4d09efd | 2008-06-07 08:52:29 +0000 | [diff] [blame] | 855 | case Instruction::And: |
| 856 | case Instruction::Or: |
| 857 | case Instruction::Xor: |
| 858 | case Instruction::Shl: |
| 859 | case Instruction::LShr: |
| 860 | case Instruction::AShr: |
Chris Lattner | 9dd3b61 | 2009-01-18 23:22:07 +0000 | [diff] [blame] | 861 | // Don't mess with vector operations. |
Devang Patel | 06b1e67 | 2009-03-06 06:00:17 +0000 | [diff] [blame] | 862 | if (isa<VectorType>(HInst->getType())) |
Evan Cheng | e5334ea | 2008-06-25 07:50:12 +0000 | [diff] [blame] | 863 | return false; |
Evan Cheng | 4d09efd | 2008-06-07 08:52:29 +0000 | [diff] [blame] | 864 | break; // These are all cheap and non-trapping instructions. |
| 865 | } |
Chris Lattner | 6fe73bb | 2009-01-19 00:36:37 +0000 | [diff] [blame] | 866 | |
| 867 | // If the instruction is obviously dead, don't try to predicate it. |
Devang Patel | 06b1e67 | 2009-03-06 06:00:17 +0000 | [diff] [blame] | 868 | if (HInst->use_empty()) { |
| 869 | HInst->eraseFromParent(); |
Chris Lattner | 6fe73bb | 2009-01-19 00:36:37 +0000 | [diff] [blame] | 870 | return true; |
| 871 | } |
Evan Cheng | 4d09efd | 2008-06-07 08:52:29 +0000 | [diff] [blame] | 872 | |
| 873 | // Can we speculatively execute the instruction? And what is the value |
| 874 | // if the condition is false? Consider the phi uses, if the incoming value |
| 875 | // from the "if" block are all the same V, then V is the value of the |
| 876 | // select if the condition is false. |
| 877 | BasicBlock *BIParent = BI->getParent(); |
| 878 | SmallVector<PHINode*, 4> PHIUses; |
| 879 | Value *FalseV = NULL; |
Chris Lattner | 6fe73bb | 2009-01-19 00:36:37 +0000 | [diff] [blame] | 880 | |
| 881 | BasicBlock *BB2 = BB1->getTerminator()->getSuccessor(0); |
Devang Patel | 06b1e67 | 2009-03-06 06:00:17 +0000 | [diff] [blame] | 882 | for (Value::use_iterator UI = HInst->use_begin(), E = HInst->use_end(); |
Evan Cheng | 4d09efd | 2008-06-07 08:52:29 +0000 | [diff] [blame] | 883 | UI != E; ++UI) { |
Chris Lattner | 6fe73bb | 2009-01-19 00:36:37 +0000 | [diff] [blame] | 884 | // Ignore any user that is not a PHI node in BB2. These can only occur in |
| 885 | // unreachable blocks, because they would not be dominated by the instr. |
Evan Cheng | 4d09efd | 2008-06-07 08:52:29 +0000 | [diff] [blame] | 886 | PHINode *PN = dyn_cast<PHINode>(UI); |
Chris Lattner | 6fe73bb | 2009-01-19 00:36:37 +0000 | [diff] [blame] | 887 | if (!PN || PN->getParent() != BB2) |
| 888 | return false; |
Evan Cheng | 4d09efd | 2008-06-07 08:52:29 +0000 | [diff] [blame] | 889 | PHIUses.push_back(PN); |
Chris Lattner | 6fe73bb | 2009-01-19 00:36:37 +0000 | [diff] [blame] | 890 | |
Evan Cheng | 4d09efd | 2008-06-07 08:52:29 +0000 | [diff] [blame] | 891 | Value *PHIV = PN->getIncomingValueForBlock(BIParent); |
| 892 | if (!FalseV) |
| 893 | FalseV = PHIV; |
| 894 | else if (FalseV != PHIV) |
Chris Lattner | 6fe73bb | 2009-01-19 00:36:37 +0000 | [diff] [blame] | 895 | return false; // Inconsistent value when condition is false. |
Evan Cheng | 4d09efd | 2008-06-07 08:52:29 +0000 | [diff] [blame] | 896 | } |
Chris Lattner | 6fe73bb | 2009-01-19 00:36:37 +0000 | [diff] [blame] | 897 | |
| 898 | assert(FalseV && "Must have at least one user, and it must be a PHI"); |
Evan Cheng | 4d09efd | 2008-06-07 08:52:29 +0000 | [diff] [blame] | 899 | |
Evan Cheng | 502a4f5 | 2008-06-12 21:15:59 +0000 | [diff] [blame] | 900 | // Do not hoist the instruction if any of its operands are defined but not |
| 901 | // used in this BB. The transformation will prevent the operand from |
| 902 | // being sunk into the use block. |
Devang Patel | 06b1e67 | 2009-03-06 06:00:17 +0000 | [diff] [blame] | 903 | for (User::op_iterator i = HInst->op_begin(), e = HInst->op_end(); |
| 904 | i != e; ++i) { |
Evan Cheng | 502a4f5 | 2008-06-12 21:15:59 +0000 | [diff] [blame] | 905 | Instruction *OpI = dyn_cast<Instruction>(*i); |
| 906 | if (OpI && OpI->getParent() == BIParent && |
| 907 | !OpI->isUsedInBasicBlock(BIParent)) |
| 908 | return false; |
| 909 | } |
| 910 | |
Devang Patel | 3d0a9a3 | 2008-09-18 22:50:42 +0000 | [diff] [blame] | 911 | // If we get here, we can hoist the instruction. Try to place it |
Dale Johannesen | 990afed | 2009-03-13 01:05:24 +0000 | [diff] [blame] | 912 | // before the icmp instruction preceding the conditional branch. |
Devang Patel | 3d0a9a3 | 2008-09-18 22:50:42 +0000 | [diff] [blame] | 913 | BasicBlock::iterator InsertPos = BI; |
Dale Johannesen | 990afed | 2009-03-13 01:05:24 +0000 | [diff] [blame] | 914 | if (InsertPos != BIParent->begin()) |
| 915 | --InsertPos; |
| 916 | // Skip debug info between condition and branch. |
| 917 | while (InsertPos != BIParent->begin() && isa<DbgInfoIntrinsic>(InsertPos)) |
Devang Patel | 3d0a9a3 | 2008-09-18 22:50:42 +0000 | [diff] [blame] | 918 | --InsertPos; |
Devang Patel | 20da1f0 | 2008-10-03 18:57:37 +0000 | [diff] [blame] | 919 | if (InsertPos == BrCond && !isa<PHINode>(BrCond)) { |
Devang Patel | 3d0a9a3 | 2008-09-18 22:50:42 +0000 | [diff] [blame] | 920 | SmallPtrSet<Instruction *, 4> BB1Insns; |
| 921 | for(BasicBlock::iterator BB1I = BB1->begin(), BB1E = BB1->end(); |
| 922 | BB1I != BB1E; ++BB1I) |
| 923 | BB1Insns.insert(BB1I); |
| 924 | for(Value::use_iterator UI = BrCond->use_begin(), UE = BrCond->use_end(); |
| 925 | UI != UE; ++UI) { |
| 926 | Instruction *Use = cast<Instruction>(*UI); |
| 927 | if (BB1Insns.count(Use)) { |
| 928 | // If BrCond uses the instruction that place it just before |
| 929 | // branch instruction. |
| 930 | InsertPos = BI; |
| 931 | break; |
| 932 | } |
| 933 | } |
| 934 | } else |
| 935 | InsertPos = BI; |
Devang Patel | 06b1e67 | 2009-03-06 06:00:17 +0000 | [diff] [blame] | 936 | BIParent->getInstList().splice(InsertPos, BB1->getInstList(), HInst); |
Evan Cheng | 4d09efd | 2008-06-07 08:52:29 +0000 | [diff] [blame] | 937 | |
| 938 | // Create a select whose true value is the speculatively executed value and |
| 939 | // false value is the previously determined FalseV. |
| 940 | SelectInst *SI; |
| 941 | if (Invert) |
Devang Patel | 06b1e67 | 2009-03-06 06:00:17 +0000 | [diff] [blame] | 942 | SI = SelectInst::Create(BrCond, FalseV, HInst, |
| 943 | FalseV->getName() + "." + HInst->getName(), BI); |
Evan Cheng | 4d09efd | 2008-06-07 08:52:29 +0000 | [diff] [blame] | 944 | else |
Devang Patel | 06b1e67 | 2009-03-06 06:00:17 +0000 | [diff] [blame] | 945 | SI = SelectInst::Create(BrCond, HInst, FalseV, |
| 946 | HInst->getName() + "." + FalseV->getName(), BI); |
Evan Cheng | 4d09efd | 2008-06-07 08:52:29 +0000 | [diff] [blame] | 947 | |
| 948 | // Make the PHI node use the select for all incoming values for "then" and |
| 949 | // "if" blocks. |
| 950 | for (unsigned i = 0, e = PHIUses.size(); i != e; ++i) { |
| 951 | PHINode *PN = PHIUses[i]; |
| 952 | for (unsigned j = 0, ee = PN->getNumIncomingValues(); j != ee; ++j) |
| 953 | if (PN->getIncomingBlock(j) == BB1 || |
| 954 | PN->getIncomingBlock(j) == BIParent) |
| 955 | PN->setIncomingValue(j, SI); |
| 956 | } |
| 957 | |
Evan Cheng | 502a4f5 | 2008-06-12 21:15:59 +0000 | [diff] [blame] | 958 | ++NumSpeculations; |
Evan Cheng | 4d09efd | 2008-06-07 08:52:29 +0000 | [diff] [blame] | 959 | return true; |
| 960 | } |
| 961 | |
Chris Lattner | 2e42e36 | 2005-09-20 00:43:16 +0000 | [diff] [blame] | 962 | /// BlockIsSimpleEnoughToThreadThrough - Return true if we can thread a branch |
| 963 | /// across this block. |
| 964 | static bool BlockIsSimpleEnoughToThreadThrough(BasicBlock *BB) { |
| 965 | BranchInst *BI = cast<BranchInst>(BB->getTerminator()); |
Chris Lattner | e9487f0 | 2005-09-20 01:48:40 +0000 | [diff] [blame] | 966 | unsigned Size = 0; |
| 967 | |
Devang Patel | 9200c89 | 2009-03-10 18:00:05 +0000 | [diff] [blame] | 968 | for (BasicBlock::iterator BBI = BB->begin(); &*BBI != BI; ++BBI) { |
Dale Johannesen | 8483e54 | 2009-03-12 23:18:09 +0000 | [diff] [blame] | 969 | if (isa<DbgInfoIntrinsic>(BBI)) |
| 970 | continue; |
Chris Lattner | e9487f0 | 2005-09-20 01:48:40 +0000 | [diff] [blame] | 971 | if (Size > 10) return false; // Don't clone large BB's. |
Dale Johannesen | 8483e54 | 2009-03-12 23:18:09 +0000 | [diff] [blame] | 972 | ++Size; |
Chris Lattner | 2e42e36 | 2005-09-20 00:43:16 +0000 | [diff] [blame] | 973 | |
Dale Johannesen | 8483e54 | 2009-03-12 23:18:09 +0000 | [diff] [blame] | 974 | // We can only support instructions that do not define values that are |
Chris Lattner | e9487f0 | 2005-09-20 01:48:40 +0000 | [diff] [blame] | 975 | // live outside of the current basic block. |
| 976 | for (Value::use_iterator UI = BBI->use_begin(), E = BBI->use_end(); |
| 977 | UI != E; ++UI) { |
| 978 | Instruction *U = cast<Instruction>(*UI); |
| 979 | if (U->getParent() != BB || isa<PHINode>(U)) return false; |
| 980 | } |
Chris Lattner | 2e42e36 | 2005-09-20 00:43:16 +0000 | [diff] [blame] | 981 | |
| 982 | // Looks ok, continue checking. |
| 983 | } |
Chris Lattner | e9487f0 | 2005-09-20 01:48:40 +0000 | [diff] [blame] | 984 | |
Chris Lattner | 2e42e36 | 2005-09-20 00:43:16 +0000 | [diff] [blame] | 985 | return true; |
| 986 | } |
| 987 | |
Chris Lattner | eaba3a1 | 2005-09-19 23:49:37 +0000 | [diff] [blame] | 988 | /// FoldCondBranchOnPHI - If we have a conditional branch on a PHI node value |
| 989 | /// that is defined in the same block as the branch and if any PHI entries are |
| 990 | /// constants, thread edges corresponding to that entry to be branches to their |
| 991 | /// ultimate destination. |
| 992 | static bool FoldCondBranchOnPHI(BranchInst *BI) { |
| 993 | BasicBlock *BB = BI->getParent(); |
| 994 | PHINode *PN = dyn_cast<PHINode>(BI->getCondition()); |
Chris Lattner | 9c88d98 | 2005-09-19 23:57:04 +0000 | [diff] [blame] | 995 | // NOTE: we currently cannot transform this case if the PHI node is used |
| 996 | // outside of the block. |
Chris Lattner | 2e42e36 | 2005-09-20 00:43:16 +0000 | [diff] [blame] | 997 | if (!PN || PN->getParent() != BB || !PN->hasOneUse()) |
| 998 | return false; |
Chris Lattner | eaba3a1 | 2005-09-19 23:49:37 +0000 | [diff] [blame] | 999 | |
| 1000 | // Degenerate case of a single entry PHI. |
| 1001 | if (PN->getNumIncomingValues() == 1) { |
Chris Lattner | 29874e0 | 2008-12-03 19:44:02 +0000 | [diff] [blame] | 1002 | FoldSingleEntryPHINodes(PN->getParent()); |
Chris Lattner | eaba3a1 | 2005-09-19 23:49:37 +0000 | [diff] [blame] | 1003 | return true; |
| 1004 | } |
| 1005 | |
| 1006 | // Now we know that this block has multiple preds and two succs. |
Chris Lattner | 2e42e36 | 2005-09-20 00:43:16 +0000 | [diff] [blame] | 1007 | if (!BlockIsSimpleEnoughToThreadThrough(BB)) return false; |
Chris Lattner | eaba3a1 | 2005-09-19 23:49:37 +0000 | [diff] [blame] | 1008 | |
| 1009 | // Okay, this is a simple enough basic block. See if any phi values are |
| 1010 | // constants. |
Zhou Sheng | 6b6b6ef | 2007-01-11 12:24:14 +0000 | [diff] [blame] | 1011 | for (unsigned i = 0, e = PN->getNumIncomingValues(); i != e; ++i) { |
| 1012 | ConstantInt *CB; |
| 1013 | if ((CB = dyn_cast<ConstantInt>(PN->getIncomingValue(i))) && |
Owen Anderson | 1d0be15 | 2009-08-13 21:58:54 +0000 | [diff] [blame] | 1014 | CB->getType() == Type::getInt1Ty(BB->getContext())) { |
Chris Lattner | eaba3a1 | 2005-09-19 23:49:37 +0000 | [diff] [blame] | 1015 | // Okay, we now know that all edges from PredBB should be revectored to |
| 1016 | // branch to RealDest. |
| 1017 | BasicBlock *PredBB = PN->getIncomingBlock(i); |
Reid Spencer | 579dca1 | 2007-01-12 04:24:46 +0000 | [diff] [blame] | 1018 | BasicBlock *RealDest = BI->getSuccessor(!CB->getZExtValue()); |
Chris Lattner | eaba3a1 | 2005-09-19 23:49:37 +0000 | [diff] [blame] | 1019 | |
Chris Lattner | e9487f0 | 2005-09-20 01:48:40 +0000 | [diff] [blame] | 1020 | if (RealDest == BB) continue; // Skip self loops. |
Chris Lattner | eaba3a1 | 2005-09-19 23:49:37 +0000 | [diff] [blame] | 1021 | |
Chris Lattner | e9487f0 | 2005-09-20 01:48:40 +0000 | [diff] [blame] | 1022 | // The dest block might have PHI nodes, other predecessors and other |
| 1023 | // difficult cases. Instead of being smart about this, just insert a new |
| 1024 | // block that jumps to the destination block, effectively splitting |
| 1025 | // the edge we are about to create. |
Owen Anderson | 1d0be15 | 2009-08-13 21:58:54 +0000 | [diff] [blame] | 1026 | BasicBlock *EdgeBB = BasicBlock::Create(BB->getContext(), |
| 1027 | RealDest->getName()+".critedge", |
Gabor Greif | 051a950 | 2008-04-06 20:25:17 +0000 | [diff] [blame] | 1028 | RealDest->getParent(), RealDest); |
| 1029 | BranchInst::Create(RealDest, EdgeBB); |
Chris Lattner | e9487f0 | 2005-09-20 01:48:40 +0000 | [diff] [blame] | 1030 | PHINode *PN; |
| 1031 | for (BasicBlock::iterator BBI = RealDest->begin(); |
| 1032 | (PN = dyn_cast<PHINode>(BBI)); ++BBI) { |
| 1033 | Value *V = PN->getIncomingValueForBlock(BB); |
| 1034 | PN->addIncoming(V, EdgeBB); |
| 1035 | } |
| 1036 | |
| 1037 | // BB may have instructions that are being threaded over. Clone these |
| 1038 | // instructions into EdgeBB. We know that there will be no uses of the |
| 1039 | // cloned instructions outside of EdgeBB. |
| 1040 | BasicBlock::iterator InsertPt = EdgeBB->begin(); |
| 1041 | std::map<Value*, Value*> TranslateMap; // Track translated values. |
| 1042 | for (BasicBlock::iterator BBI = BB->begin(); &*BBI != BI; ++BBI) { |
| 1043 | if (PHINode *PN = dyn_cast<PHINode>(BBI)) { |
| 1044 | TranslateMap[PN] = PN->getIncomingValueForBlock(PredBB); |
| 1045 | } else { |
| 1046 | // Clone the instruction. |
Nick Lewycky | 6776064 | 2009-09-27 07:38:41 +0000 | [diff] [blame] | 1047 | Instruction *N = BBI->clone(); |
Chris Lattner | e9487f0 | 2005-09-20 01:48:40 +0000 | [diff] [blame] | 1048 | if (BBI->hasName()) N->setName(BBI->getName()+".c"); |
| 1049 | |
| 1050 | // Update operands due to translation. |
Gabor Greif | f7ea363 | 2008-06-10 22:03:26 +0000 | [diff] [blame] | 1051 | for (User::op_iterator i = N->op_begin(), e = N->op_end(); |
| 1052 | i != e; ++i) { |
Chris Lattner | e9487f0 | 2005-09-20 01:48:40 +0000 | [diff] [blame] | 1053 | std::map<Value*, Value*>::iterator PI = |
Gabor Greif | f7ea363 | 2008-06-10 22:03:26 +0000 | [diff] [blame] | 1054 | TranslateMap.find(*i); |
Chris Lattner | e9487f0 | 2005-09-20 01:48:40 +0000 | [diff] [blame] | 1055 | if (PI != TranslateMap.end()) |
Gabor Greif | f7ea363 | 2008-06-10 22:03:26 +0000 | [diff] [blame] | 1056 | *i = PI->second; |
Chris Lattner | e9487f0 | 2005-09-20 01:48:40 +0000 | [diff] [blame] | 1057 | } |
| 1058 | |
| 1059 | // Check for trivial simplification. |
Chris Lattner | 7b550cc | 2009-11-06 04:27:31 +0000 | [diff] [blame] | 1060 | if (Constant *C = ConstantFoldInstruction(N)) { |
Chris Lattner | e9487f0 | 2005-09-20 01:48:40 +0000 | [diff] [blame] | 1061 | TranslateMap[BBI] = C; |
| 1062 | delete N; // Constant folded away, don't need actual inst |
| 1063 | } else { |
| 1064 | // Insert the new instruction into its new home. |
| 1065 | EdgeBB->getInstList().insert(InsertPt, N); |
| 1066 | if (!BBI->use_empty()) |
| 1067 | TranslateMap[BBI] = N; |
| 1068 | } |
| 1069 | } |
| 1070 | } |
| 1071 | |
Chris Lattner | eaba3a1 | 2005-09-19 23:49:37 +0000 | [diff] [blame] | 1072 | // Loop over all of the edges from PredBB to BB, changing them to branch |
Chris Lattner | e9487f0 | 2005-09-20 01:48:40 +0000 | [diff] [blame] | 1073 | // to EdgeBB instead. |
Chris Lattner | eaba3a1 | 2005-09-19 23:49:37 +0000 | [diff] [blame] | 1074 | TerminatorInst *PredBBTI = PredBB->getTerminator(); |
| 1075 | for (unsigned i = 0, e = PredBBTI->getNumSuccessors(); i != e; ++i) |
| 1076 | if (PredBBTI->getSuccessor(i) == BB) { |
| 1077 | BB->removePredecessor(PredBB); |
Chris Lattner | e9487f0 | 2005-09-20 01:48:40 +0000 | [diff] [blame] | 1078 | PredBBTI->setSuccessor(i, EdgeBB); |
Chris Lattner | eaba3a1 | 2005-09-19 23:49:37 +0000 | [diff] [blame] | 1079 | } |
| 1080 | |
Chris Lattner | eaba3a1 | 2005-09-19 23:49:37 +0000 | [diff] [blame] | 1081 | // Recurse, simplifying any other constants. |
| 1082 | return FoldCondBranchOnPHI(BI) | true; |
| 1083 | } |
Zhou Sheng | 6b6b6ef | 2007-01-11 12:24:14 +0000 | [diff] [blame] | 1084 | } |
Chris Lattner | eaba3a1 | 2005-09-19 23:49:37 +0000 | [diff] [blame] | 1085 | |
| 1086 | return false; |
| 1087 | } |
| 1088 | |
Chris Lattner | f58c1a5 | 2005-09-23 06:39:30 +0000 | [diff] [blame] | 1089 | /// FoldTwoEntryPHINode - Given a BB that starts with the specified two-entry |
| 1090 | /// PHI node, see if we can eliminate it. |
| 1091 | static bool FoldTwoEntryPHINode(PHINode *PN) { |
| 1092 | // Ok, this is a two entry PHI node. Check to see if this is a simple "if |
| 1093 | // statement", which has a very simple dominance structure. Basically, we |
| 1094 | // are trying to find the condition that is being branched on, which |
| 1095 | // subsequently causes this merge to happen. We really want control |
| 1096 | // dependence information for this check, but simplifycfg can't keep it up |
| 1097 | // to date, and this catches most of the cases we care about anyway. |
| 1098 | // |
| 1099 | BasicBlock *BB = PN->getParent(); |
| 1100 | BasicBlock *IfTrue, *IfFalse; |
| 1101 | Value *IfCond = GetIfCondition(BB, IfTrue, IfFalse); |
| 1102 | if (!IfCond) return false; |
| 1103 | |
Chris Lattner | 822a879 | 2006-11-18 19:19:36 +0000 | [diff] [blame] | 1104 | // Okay, we found that we can merge this two-entry phi node into a select. |
| 1105 | // Doing so would require us to fold *all* two entry phi nodes in this block. |
| 1106 | // At some point this becomes non-profitable (particularly if the target |
| 1107 | // doesn't support cmov's). Only do this transformation if there are two or |
| 1108 | // fewer PHI nodes in this block. |
| 1109 | unsigned NumPhis = 0; |
| 1110 | for (BasicBlock::iterator I = BB->begin(); isa<PHINode>(I); ++NumPhis, ++I) |
| 1111 | if (NumPhis > 2) |
| 1112 | return false; |
| 1113 | |
Daniel Dunbar | ce63ffb | 2009-07-25 00:23:56 +0000 | [diff] [blame] | 1114 | DEBUG(errs() << "FOUND IF CONDITION! " << *IfCond << " T: " |
| 1115 | << IfTrue->getName() << " F: " << IfFalse->getName() << "\n"); |
Chris Lattner | f58c1a5 | 2005-09-23 06:39:30 +0000 | [diff] [blame] | 1116 | |
| 1117 | // Loop over the PHI's seeing if we can promote them all to select |
| 1118 | // instructions. While we are at it, keep track of the instructions |
| 1119 | // that need to be moved to the dominating block. |
| 1120 | std::set<Instruction*> AggressiveInsts; |
| 1121 | |
Chris Lattner | f58c1a5 | 2005-09-23 06:39:30 +0000 | [diff] [blame] | 1122 | BasicBlock::iterator AfterPHIIt = BB->begin(); |
| 1123 | while (isa<PHINode>(AfterPHIIt)) { |
| 1124 | PHINode *PN = cast<PHINode>(AfterPHIIt++); |
| 1125 | if (PN->getIncomingValue(0) == PN->getIncomingValue(1)) { |
| 1126 | if (PN->getIncomingValue(0) != PN) |
| 1127 | PN->replaceAllUsesWith(PN->getIncomingValue(0)); |
| 1128 | else |
Owen Anderson | 9e9a0d5 | 2009-07-30 23:03:37 +0000 | [diff] [blame] | 1129 | PN->replaceAllUsesWith(UndefValue::get(PN->getType())); |
Chris Lattner | f58c1a5 | 2005-09-23 06:39:30 +0000 | [diff] [blame] | 1130 | } else if (!DominatesMergePoint(PN->getIncomingValue(0), BB, |
| 1131 | &AggressiveInsts) || |
| 1132 | !DominatesMergePoint(PN->getIncomingValue(1), BB, |
| 1133 | &AggressiveInsts)) { |
Chris Lattner | 055dc10 | 2005-09-23 07:23:18 +0000 | [diff] [blame] | 1134 | return false; |
Chris Lattner | f58c1a5 | 2005-09-23 06:39:30 +0000 | [diff] [blame] | 1135 | } |
| 1136 | } |
| 1137 | |
Chris Lattner | f58c1a5 | 2005-09-23 06:39:30 +0000 | [diff] [blame] | 1138 | // If we all PHI nodes are promotable, check to make sure that all |
| 1139 | // instructions in the predecessor blocks can be promoted as well. If |
| 1140 | // not, we won't be able to get rid of the control flow, so it's not |
| 1141 | // worth promoting to select instructions. |
| 1142 | BasicBlock *DomBlock = 0, *IfBlock1 = 0, *IfBlock2 = 0; |
| 1143 | PN = cast<PHINode>(BB->begin()); |
| 1144 | BasicBlock *Pred = PN->getIncomingBlock(0); |
| 1145 | if (cast<BranchInst>(Pred->getTerminator())->isUnconditional()) { |
| 1146 | IfBlock1 = Pred; |
| 1147 | DomBlock = *pred_begin(Pred); |
| 1148 | for (BasicBlock::iterator I = Pred->begin(); |
| 1149 | !isa<TerminatorInst>(I); ++I) |
Devang Patel | 383d7ed | 2009-02-03 22:12:02 +0000 | [diff] [blame] | 1150 | if (!AggressiveInsts.count(I) && !isa<DbgInfoIntrinsic>(I)) { |
Chris Lattner | f58c1a5 | 2005-09-23 06:39:30 +0000 | [diff] [blame] | 1151 | // This is not an aggressive instruction that we can promote. |
| 1152 | // Because of this, we won't be able to get rid of the control |
| 1153 | // flow, so the xform is not worth it. |
| 1154 | return false; |
| 1155 | } |
| 1156 | } |
| 1157 | |
| 1158 | Pred = PN->getIncomingBlock(1); |
| 1159 | if (cast<BranchInst>(Pred->getTerminator())->isUnconditional()) { |
| 1160 | IfBlock2 = Pred; |
| 1161 | DomBlock = *pred_begin(Pred); |
| 1162 | for (BasicBlock::iterator I = Pred->begin(); |
| 1163 | !isa<TerminatorInst>(I); ++I) |
Devang Patel | 383d7ed | 2009-02-03 22:12:02 +0000 | [diff] [blame] | 1164 | if (!AggressiveInsts.count(I) && !isa<DbgInfoIntrinsic>(I)) { |
Chris Lattner | f58c1a5 | 2005-09-23 06:39:30 +0000 | [diff] [blame] | 1165 | // This is not an aggressive instruction that we can promote. |
| 1166 | // Because of this, we won't be able to get rid of the control |
| 1167 | // flow, so the xform is not worth it. |
| 1168 | return false; |
| 1169 | } |
| 1170 | } |
| 1171 | |
| 1172 | // If we can still promote the PHI nodes after this gauntlet of tests, |
| 1173 | // do all of the PHI's now. |
| 1174 | |
| 1175 | // Move all 'aggressive' instructions, which are defined in the |
| 1176 | // conditional parts of the if's up to the dominating block. |
| 1177 | if (IfBlock1) { |
| 1178 | DomBlock->getInstList().splice(DomBlock->getTerminator(), |
| 1179 | IfBlock1->getInstList(), |
| 1180 | IfBlock1->begin(), |
| 1181 | IfBlock1->getTerminator()); |
| 1182 | } |
| 1183 | if (IfBlock2) { |
| 1184 | DomBlock->getInstList().splice(DomBlock->getTerminator(), |
| 1185 | IfBlock2->getInstList(), |
| 1186 | IfBlock2->begin(), |
| 1187 | IfBlock2->getTerminator()); |
| 1188 | } |
| 1189 | |
| 1190 | while (PHINode *PN = dyn_cast<PHINode>(BB->begin())) { |
| 1191 | // Change the PHI node into a select instruction. |
| 1192 | Value *TrueVal = |
| 1193 | PN->getIncomingValue(PN->getIncomingBlock(0) == IfFalse); |
| 1194 | Value *FalseVal = |
| 1195 | PN->getIncomingValue(PN->getIncomingBlock(0) == IfTrue); |
| 1196 | |
Gabor Greif | 051a950 | 2008-04-06 20:25:17 +0000 | [diff] [blame] | 1197 | Value *NV = SelectInst::Create(IfCond, TrueVal, FalseVal, "", AfterPHIIt); |
Chris Lattner | 86cc423 | 2007-02-11 01:37:51 +0000 | [diff] [blame] | 1198 | PN->replaceAllUsesWith(NV); |
| 1199 | NV->takeName(PN); |
| 1200 | |
Chris Lattner | f58c1a5 | 2005-09-23 06:39:30 +0000 | [diff] [blame] | 1201 | BB->getInstList().erase(PN); |
| 1202 | } |
| 1203 | return true; |
| 1204 | } |
Chris Lattner | eaba3a1 | 2005-09-19 23:49:37 +0000 | [diff] [blame] | 1205 | |
Devang Patel | 998cbb0 | 2009-02-05 21:46:41 +0000 | [diff] [blame] | 1206 | /// isTerminatorFirstRelevantInsn - Return true if Term is very first |
| 1207 | /// instruction ignoring Phi nodes and dbg intrinsics. |
| 1208 | static bool isTerminatorFirstRelevantInsn(BasicBlock *BB, Instruction *Term) { |
| 1209 | BasicBlock::iterator BBI = Term; |
| 1210 | while (BBI != BB->begin()) { |
| 1211 | --BBI; |
| 1212 | if (!isa<DbgInfoIntrinsic>(BBI)) |
| 1213 | break; |
| 1214 | } |
Devang Patel | 0464a14 | 2009-02-10 22:14:17 +0000 | [diff] [blame] | 1215 | |
| 1216 | if (isa<PHINode>(BBI) || &*BBI == Term || isa<DbgInfoIntrinsic>(BBI)) |
Devang Patel | 998cbb0 | 2009-02-05 21:46:41 +0000 | [diff] [blame] | 1217 | return true; |
| 1218 | return false; |
| 1219 | } |
| 1220 | |
Chris Lattner | c9e495c | 2008-04-24 00:01:19 +0000 | [diff] [blame] | 1221 | /// SimplifyCondBranchToTwoReturns - If we found a conditional branch that goes |
| 1222 | /// to two returning blocks, try to merge them together into one return, |
| 1223 | /// introducing a select if the return values disagree. |
| 1224 | static bool SimplifyCondBranchToTwoReturns(BranchInst *BI) { |
| 1225 | assert(BI->isConditional() && "Must be a conditional branch"); |
| 1226 | BasicBlock *TrueSucc = BI->getSuccessor(0); |
| 1227 | BasicBlock *FalseSucc = BI->getSuccessor(1); |
| 1228 | ReturnInst *TrueRet = cast<ReturnInst>(TrueSucc->getTerminator()); |
| 1229 | ReturnInst *FalseRet = cast<ReturnInst>(FalseSucc->getTerminator()); |
| 1230 | |
| 1231 | // Check to ensure both blocks are empty (just a return) or optionally empty |
| 1232 | // with PHI nodes. If there are other instructions, merging would cause extra |
| 1233 | // computation on one path or the other. |
Devang Patel | 2cc86a1 | 2009-02-05 00:30:42 +0000 | [diff] [blame] | 1234 | if (!isTerminatorFirstRelevantInsn(TrueSucc, TrueRet)) |
| 1235 | return false; |
| 1236 | if (!isTerminatorFirstRelevantInsn(FalseSucc, FalseRet)) |
| 1237 | return false; |
Chris Lattner | c9e495c | 2008-04-24 00:01:19 +0000 | [diff] [blame] | 1238 | |
| 1239 | // Okay, we found a branch that is going to two return nodes. If |
| 1240 | // there is no return value for this function, just change the |
| 1241 | // branch into a return. |
| 1242 | if (FalseRet->getNumOperands() == 0) { |
| 1243 | TrueSucc->removePredecessor(BI->getParent()); |
| 1244 | FalseSucc->removePredecessor(BI->getParent()); |
Owen Anderson | 1d0be15 | 2009-08-13 21:58:54 +0000 | [diff] [blame] | 1245 | ReturnInst::Create(BI->getContext(), 0, BI); |
Eli Friedman | 080efb8 | 2008-12-16 20:54:32 +0000 | [diff] [blame] | 1246 | EraseTerminatorInstAndDCECond(BI); |
Chris Lattner | c9e495c | 2008-04-24 00:01:19 +0000 | [diff] [blame] | 1247 | return true; |
| 1248 | } |
| 1249 | |
Dan Gohman | fc74abf | 2008-07-23 00:34:11 +0000 | [diff] [blame] | 1250 | // Otherwise, figure out what the true and false return values are |
| 1251 | // so we can insert a new select instruction. |
| 1252 | Value *TrueValue = TrueRet->getReturnValue(); |
| 1253 | Value *FalseValue = FalseRet->getReturnValue(); |
Chris Lattner | c9e495c | 2008-04-24 00:01:19 +0000 | [diff] [blame] | 1254 | |
Dan Gohman | fc74abf | 2008-07-23 00:34:11 +0000 | [diff] [blame] | 1255 | // Unwrap any PHI nodes in the return blocks. |
| 1256 | if (PHINode *TVPN = dyn_cast_or_null<PHINode>(TrueValue)) |
| 1257 | if (TVPN->getParent() == TrueSucc) |
| 1258 | TrueValue = TVPN->getIncomingValueForBlock(BI->getParent()); |
| 1259 | if (PHINode *FVPN = dyn_cast_or_null<PHINode>(FalseValue)) |
| 1260 | if (FVPN->getParent() == FalseSucc) |
| 1261 | FalseValue = FVPN->getIncomingValueForBlock(BI->getParent()); |
| 1262 | |
| 1263 | // In order for this transformation to be safe, we must be able to |
| 1264 | // unconditionally execute both operands to the return. This is |
| 1265 | // normally the case, but we could have a potentially-trapping |
| 1266 | // constant expression that prevents this transformation from being |
| 1267 | // safe. |
| 1268 | if (ConstantExpr *TCV = dyn_cast_or_null<ConstantExpr>(TrueValue)) |
| 1269 | if (TCV->canTrap()) |
| 1270 | return false; |
| 1271 | if (ConstantExpr *FCV = dyn_cast_or_null<ConstantExpr>(FalseValue)) |
| 1272 | if (FCV->canTrap()) |
| 1273 | return false; |
| 1274 | |
Chris Lattner | c9e495c | 2008-04-24 00:01:19 +0000 | [diff] [blame] | 1275 | // Okay, we collected all the mapped values and checked them for sanity, and |
| 1276 | // defined to really do this transformation. First, update the CFG. |
| 1277 | TrueSucc->removePredecessor(BI->getParent()); |
| 1278 | FalseSucc->removePredecessor(BI->getParent()); |
| 1279 | |
| 1280 | // Insert select instructions where needed. |
| 1281 | Value *BrCond = BI->getCondition(); |
Dan Gohman | fc74abf | 2008-07-23 00:34:11 +0000 | [diff] [blame] | 1282 | if (TrueValue) { |
Chris Lattner | c9e495c | 2008-04-24 00:01:19 +0000 | [diff] [blame] | 1283 | // Insert a select if the results differ. |
Dan Gohman | fc74abf | 2008-07-23 00:34:11 +0000 | [diff] [blame] | 1284 | if (TrueValue == FalseValue || isa<UndefValue>(FalseValue)) { |
| 1285 | } else if (isa<UndefValue>(TrueValue)) { |
| 1286 | TrueValue = FalseValue; |
| 1287 | } else { |
| 1288 | TrueValue = SelectInst::Create(BrCond, TrueValue, |
| 1289 | FalseValue, "retval", BI); |
Chris Lattner | c9e495c | 2008-04-24 00:01:19 +0000 | [diff] [blame] | 1290 | } |
Chris Lattner | c9e495c | 2008-04-24 00:01:19 +0000 | [diff] [blame] | 1291 | } |
| 1292 | |
Dan Gohman | fc74abf | 2008-07-23 00:34:11 +0000 | [diff] [blame] | 1293 | Value *RI = !TrueValue ? |
Owen Anderson | 1d0be15 | 2009-08-13 21:58:54 +0000 | [diff] [blame] | 1294 | ReturnInst::Create(BI->getContext(), BI) : |
| 1295 | ReturnInst::Create(BI->getContext(), TrueValue, BI); |
Daniel Dunbar | e317bcc | 2009-08-23 10:29:55 +0000 | [diff] [blame] | 1296 | (void) RI; |
Chris Lattner | c9e495c | 2008-04-24 00:01:19 +0000 | [diff] [blame] | 1297 | |
Chris Lattner | bdff548 | 2009-08-23 04:37:46 +0000 | [diff] [blame] | 1298 | DEBUG(errs() << "\nCHANGING BRANCH TO TWO RETURNS INTO SELECT:" |
| 1299 | << "\n " << *BI << "NewRet = " << *RI |
| 1300 | << "TRUEBLOCK: " << *TrueSucc << "FALSEBLOCK: "<< *FalseSucc); |
Chris Lattner | c9e495c | 2008-04-24 00:01:19 +0000 | [diff] [blame] | 1301 | |
Eli Friedman | 080efb8 | 2008-12-16 20:54:32 +0000 | [diff] [blame] | 1302 | EraseTerminatorInstAndDCECond(BI); |
| 1303 | |
Chris Lattner | c9e495c | 2008-04-24 00:01:19 +0000 | [diff] [blame] | 1304 | return true; |
| 1305 | } |
| 1306 | |
Chris Lattner | 1347e87 | 2008-07-13 21:12:01 +0000 | [diff] [blame] | 1307 | /// FoldBranchToCommonDest - If this basic block is ONLY a setcc and a branch, |
| 1308 | /// and if a predecessor branches to us and one of our successors, fold the |
| 1309 | /// setcc into the predecessor and use logical operations to pick the right |
| 1310 | /// destination. |
Dan Gohman | 4b35f83 | 2009-06-27 21:30:38 +0000 | [diff] [blame] | 1311 | bool llvm::FoldBranchToCommonDest(BranchInst *BI) { |
Chris Lattner | 093a438 | 2008-07-13 22:23:11 +0000 | [diff] [blame] | 1312 | BasicBlock *BB = BI->getParent(); |
Chris Lattner | 1347e87 | 2008-07-13 21:12:01 +0000 | [diff] [blame] | 1313 | Instruction *Cond = dyn_cast<Instruction>(BI->getCondition()); |
| 1314 | if (Cond == 0) return false; |
| 1315 | |
Chris Lattner | 093a438 | 2008-07-13 22:23:11 +0000 | [diff] [blame] | 1316 | |
Chris Lattner | 1347e87 | 2008-07-13 21:12:01 +0000 | [diff] [blame] | 1317 | // Only allow this if the condition is a simple instruction that can be |
| 1318 | // executed unconditionally. It must be in the same block as the branch, and |
| 1319 | // must be at the front of the block. |
Devang Patel | d0a203d | 2009-02-04 21:39:48 +0000 | [diff] [blame] | 1320 | BasicBlock::iterator FrontIt = BB->front(); |
| 1321 | // Ignore dbg intrinsics. |
| 1322 | while(isa<DbgInfoIntrinsic>(FrontIt)) |
| 1323 | ++FrontIt; |
Chris Lattner | 1347e87 | 2008-07-13 21:12:01 +0000 | [diff] [blame] | 1324 | if ((!isa<CmpInst>(Cond) && !isa<BinaryOperator>(Cond)) || |
Devang Patel | d0a203d | 2009-02-04 21:39:48 +0000 | [diff] [blame] | 1325 | Cond->getParent() != BB || &*FrontIt != Cond || !Cond->hasOneUse()) { |
Chris Lattner | 1347e87 | 2008-07-13 21:12:01 +0000 | [diff] [blame] | 1326 | return false; |
Devang Patel | d0a203d | 2009-02-04 21:39:48 +0000 | [diff] [blame] | 1327 | } |
Chris Lattner | 6ff645b | 2009-01-19 23:03:13 +0000 | [diff] [blame] | 1328 | |
Chris Lattner | 1347e87 | 2008-07-13 21:12:01 +0000 | [diff] [blame] | 1329 | // Make sure the instruction after the condition is the cond branch. |
| 1330 | BasicBlock::iterator CondIt = Cond; ++CondIt; |
Devang Patel | d0a203d | 2009-02-04 21:39:48 +0000 | [diff] [blame] | 1331 | // Ingore dbg intrinsics. |
| 1332 | while(isa<DbgInfoIntrinsic>(CondIt)) |
| 1333 | ++CondIt; |
| 1334 | if (&*CondIt != BI) { |
| 1335 | assert (!isa<DbgInfoIntrinsic>(CondIt) && "Hey do not forget debug info!"); |
Chris Lattner | 1347e87 | 2008-07-13 21:12:01 +0000 | [diff] [blame] | 1336 | return false; |
Devang Patel | d0a203d | 2009-02-04 21:39:48 +0000 | [diff] [blame] | 1337 | } |
Chris Lattner | 6ff645b | 2009-01-19 23:03:13 +0000 | [diff] [blame] | 1338 | |
| 1339 | // Cond is known to be a compare or binary operator. Check to make sure that |
| 1340 | // neither operand is a potentially-trapping constant expression. |
| 1341 | if (ConstantExpr *CE = dyn_cast<ConstantExpr>(Cond->getOperand(0))) |
| 1342 | if (CE->canTrap()) |
| 1343 | return false; |
| 1344 | if (ConstantExpr *CE = dyn_cast<ConstantExpr>(Cond->getOperand(1))) |
| 1345 | if (CE->canTrap()) |
| 1346 | return false; |
| 1347 | |
Chris Lattner | 1347e87 | 2008-07-13 21:12:01 +0000 | [diff] [blame] | 1348 | |
| 1349 | // Finally, don't infinitely unroll conditional loops. |
| 1350 | BasicBlock *TrueDest = BI->getSuccessor(0); |
| 1351 | BasicBlock *FalseDest = BI->getSuccessor(1); |
| 1352 | if (TrueDest == BB || FalseDest == BB) |
| 1353 | return false; |
| 1354 | |
| 1355 | for (pred_iterator PI = pred_begin(BB), E = pred_end(BB); PI != E; ++PI) { |
| 1356 | BasicBlock *PredBlock = *PI; |
| 1357 | BranchInst *PBI = dyn_cast<BranchInst>(PredBlock->getTerminator()); |
Chris Lattner | 6ff645b | 2009-01-19 23:03:13 +0000 | [diff] [blame] | 1358 | |
Chris Lattner | 093a438 | 2008-07-13 22:23:11 +0000 | [diff] [blame] | 1359 | // Check that we have two conditional branches. If there is a PHI node in |
| 1360 | // the common successor, verify that the same value flows in from both |
| 1361 | // blocks. |
Chris Lattner | 1347e87 | 2008-07-13 21:12:01 +0000 | [diff] [blame] | 1362 | if (PBI == 0 || PBI->isUnconditional() || |
| 1363 | !SafeToMergeTerminators(BI, PBI)) |
| 1364 | continue; |
| 1365 | |
Chris Lattner | 3698909 | 2008-07-13 21:20:19 +0000 | [diff] [blame] | 1366 | Instruction::BinaryOps Opc; |
| 1367 | bool InvertPredCond = false; |
| 1368 | |
| 1369 | if (PBI->getSuccessor(0) == TrueDest) |
| 1370 | Opc = Instruction::Or; |
| 1371 | else if (PBI->getSuccessor(1) == FalseDest) |
| 1372 | Opc = Instruction::And; |
| 1373 | else if (PBI->getSuccessor(0) == FalseDest) |
| 1374 | Opc = Instruction::And, InvertPredCond = true; |
| 1375 | else if (PBI->getSuccessor(1) == TrueDest) |
| 1376 | Opc = Instruction::Or, InvertPredCond = true; |
| 1377 | else |
| 1378 | continue; |
| 1379 | |
Chris Lattner | bdff548 | 2009-08-23 04:37:46 +0000 | [diff] [blame] | 1380 | DEBUG(errs() << "FOLDING BRANCH TO COMMON DEST:\n" << *PBI << *BB); |
Chris Lattner | 6ff645b | 2009-01-19 23:03:13 +0000 | [diff] [blame] | 1381 | |
Chris Lattner | 3698909 | 2008-07-13 21:20:19 +0000 | [diff] [blame] | 1382 | // If we need to invert the condition in the pred block to match, do so now. |
| 1383 | if (InvertPredCond) { |
Chris Lattner | 1347e87 | 2008-07-13 21:12:01 +0000 | [diff] [blame] | 1384 | Value *NewCond = |
Dan Gohman | 4ae5126 | 2009-08-12 16:23:25 +0000 | [diff] [blame] | 1385 | BinaryOperator::CreateNot(PBI->getCondition(), |
Chris Lattner | 3698909 | 2008-07-13 21:20:19 +0000 | [diff] [blame] | 1386 | PBI->getCondition()->getName()+".not", PBI); |
Chris Lattner | 1347e87 | 2008-07-13 21:12:01 +0000 | [diff] [blame] | 1387 | PBI->setCondition(NewCond); |
| 1388 | BasicBlock *OldTrue = PBI->getSuccessor(0); |
| 1389 | BasicBlock *OldFalse = PBI->getSuccessor(1); |
| 1390 | PBI->setSuccessor(0, OldFalse); |
| 1391 | PBI->setSuccessor(1, OldTrue); |
| 1392 | } |
Chris Lattner | 70087f3 | 2008-07-13 21:15:11 +0000 | [diff] [blame] | 1393 | |
Chris Lattner | 3698909 | 2008-07-13 21:20:19 +0000 | [diff] [blame] | 1394 | // Clone Cond into the predecessor basic block, and or/and the |
| 1395 | // two conditions together. |
Nick Lewycky | 6776064 | 2009-09-27 07:38:41 +0000 | [diff] [blame] | 1396 | Instruction *New = Cond->clone(); |
Chris Lattner | 3698909 | 2008-07-13 21:20:19 +0000 | [diff] [blame] | 1397 | PredBlock->getInstList().insert(PBI, New); |
| 1398 | New->takeName(Cond); |
| 1399 | Cond->setName(New->getName()+".old"); |
Chris Lattner | 70087f3 | 2008-07-13 21:15:11 +0000 | [diff] [blame] | 1400 | |
Chris Lattner | 3698909 | 2008-07-13 21:20:19 +0000 | [diff] [blame] | 1401 | Value *NewCond = BinaryOperator::Create(Opc, PBI->getCondition(), |
| 1402 | New, "or.cond", PBI); |
| 1403 | PBI->setCondition(NewCond); |
| 1404 | if (PBI->getSuccessor(0) == BB) { |
| 1405 | AddPredecessorToBlock(TrueDest, PredBlock, BB); |
| 1406 | PBI->setSuccessor(0, TrueDest); |
Chris Lattner | 1347e87 | 2008-07-13 21:12:01 +0000 | [diff] [blame] | 1407 | } |
Chris Lattner | 3698909 | 2008-07-13 21:20:19 +0000 | [diff] [blame] | 1408 | if (PBI->getSuccessor(1) == BB) { |
| 1409 | AddPredecessorToBlock(FalseDest, PredBlock, BB); |
| 1410 | PBI->setSuccessor(1, FalseDest); |
| 1411 | } |
| 1412 | return true; |
Chris Lattner | 1347e87 | 2008-07-13 21:12:01 +0000 | [diff] [blame] | 1413 | } |
| 1414 | return false; |
| 1415 | } |
| 1416 | |
Chris Lattner | 867661a | 2008-07-13 21:53:26 +0000 | [diff] [blame] | 1417 | /// SimplifyCondBranchToCondBranch - If we have a conditional branch as a |
| 1418 | /// predecessor of another block, this function tries to simplify it. We know |
| 1419 | /// that PBI and BI are both conditional branches, and BI is in one of the |
| 1420 | /// successor blocks of PBI - PBI branches to BI. |
| 1421 | static bool SimplifyCondBranchToCondBranch(BranchInst *PBI, BranchInst *BI) { |
| 1422 | assert(PBI->isConditional() && BI->isConditional()); |
| 1423 | BasicBlock *BB = BI->getParent(); |
Dan Gohman | 4ae5126 | 2009-08-12 16:23:25 +0000 | [diff] [blame] | 1424 | |
Chris Lattner | 867661a | 2008-07-13 21:53:26 +0000 | [diff] [blame] | 1425 | // If this block ends with a branch instruction, and if there is a |
| 1426 | // predecessor that ends on a branch of the same condition, make |
| 1427 | // this conditional branch redundant. |
| 1428 | if (PBI->getCondition() == BI->getCondition() && |
| 1429 | PBI->getSuccessor(0) != PBI->getSuccessor(1)) { |
| 1430 | // Okay, the outcome of this conditional branch is statically |
| 1431 | // knowable. If this block had a single pred, handle specially. |
| 1432 | if (BB->getSinglePredecessor()) { |
| 1433 | // Turn this into a branch on constant. |
| 1434 | bool CondIsTrue = PBI->getSuccessor(0) == BB; |
Owen Anderson | 1d0be15 | 2009-08-13 21:58:54 +0000 | [diff] [blame] | 1435 | BI->setCondition(ConstantInt::get(Type::getInt1Ty(BB->getContext()), |
| 1436 | CondIsTrue)); |
Chris Lattner | 867661a | 2008-07-13 21:53:26 +0000 | [diff] [blame] | 1437 | return true; // Nuke the branch on constant. |
| 1438 | } |
| 1439 | |
| 1440 | // Otherwise, if there are multiple predecessors, insert a PHI that merges |
| 1441 | // in the constant and simplify the block result. Subsequent passes of |
| 1442 | // simplifycfg will thread the block. |
| 1443 | if (BlockIsSimpleEnoughToThreadThrough(BB)) { |
Owen Anderson | 1d0be15 | 2009-08-13 21:58:54 +0000 | [diff] [blame] | 1444 | PHINode *NewPN = PHINode::Create(Type::getInt1Ty(BB->getContext()), |
Chris Lattner | 867661a | 2008-07-13 21:53:26 +0000 | [diff] [blame] | 1445 | BI->getCondition()->getName() + ".pr", |
| 1446 | BB->begin()); |
Chris Lattner | eb388af | 2008-07-13 21:55:46 +0000 | [diff] [blame] | 1447 | // Okay, we're going to insert the PHI node. Since PBI is not the only |
| 1448 | // predecessor, compute the PHI'd conditional value for all of the preds. |
| 1449 | // Any predecessor where the condition is not computable we keep symbolic. |
Chris Lattner | 867661a | 2008-07-13 21:53:26 +0000 | [diff] [blame] | 1450 | for (pred_iterator PI = pred_begin(BB), E = pred_end(BB); PI != E; ++PI) |
| 1451 | if ((PBI = dyn_cast<BranchInst>((*PI)->getTerminator())) && |
| 1452 | PBI != BI && PBI->isConditional() && |
| 1453 | PBI->getCondition() == BI->getCondition() && |
| 1454 | PBI->getSuccessor(0) != PBI->getSuccessor(1)) { |
| 1455 | bool CondIsTrue = PBI->getSuccessor(0) == BB; |
Owen Anderson | 1d0be15 | 2009-08-13 21:58:54 +0000 | [diff] [blame] | 1456 | NewPN->addIncoming(ConstantInt::get(Type::getInt1Ty(BB->getContext()), |
Chris Lattner | 867661a | 2008-07-13 21:53:26 +0000 | [diff] [blame] | 1457 | CondIsTrue), *PI); |
| 1458 | } else { |
| 1459 | NewPN->addIncoming(BI->getCondition(), *PI); |
| 1460 | } |
| 1461 | |
| 1462 | BI->setCondition(NewPN); |
Chris Lattner | 867661a | 2008-07-13 21:53:26 +0000 | [diff] [blame] | 1463 | return true; |
| 1464 | } |
| 1465 | } |
| 1466 | |
| 1467 | // If this is a conditional branch in an empty block, and if any |
| 1468 | // predecessors is a conditional branch to one of our destinations, |
| 1469 | // fold the conditions into logical ops and one cond br. |
Zhou Sheng | a8d57fe | 2009-02-26 06:56:37 +0000 | [diff] [blame] | 1470 | BasicBlock::iterator BBI = BB->begin(); |
| 1471 | // Ignore dbg intrinsics. |
| 1472 | while (isa<DbgInfoIntrinsic>(BBI)) |
| 1473 | ++BBI; |
| 1474 | if (&*BBI != BI) |
Chris Lattner | b824512 | 2008-07-13 22:04:41 +0000 | [diff] [blame] | 1475 | return false; |
Chris Lattner | 63bf29b | 2009-01-20 01:15:41 +0000 | [diff] [blame] | 1476 | |
| 1477 | |
| 1478 | if (ConstantExpr *CE = dyn_cast<ConstantExpr>(BI->getCondition())) |
| 1479 | if (CE->canTrap()) |
| 1480 | return false; |
Chris Lattner | b824512 | 2008-07-13 22:04:41 +0000 | [diff] [blame] | 1481 | |
| 1482 | int PBIOp, BIOp; |
| 1483 | if (PBI->getSuccessor(0) == BI->getSuccessor(0)) |
| 1484 | PBIOp = BIOp = 0; |
| 1485 | else if (PBI->getSuccessor(0) == BI->getSuccessor(1)) |
| 1486 | PBIOp = 0, BIOp = 1; |
| 1487 | else if (PBI->getSuccessor(1) == BI->getSuccessor(0)) |
| 1488 | PBIOp = 1, BIOp = 0; |
| 1489 | else if (PBI->getSuccessor(1) == BI->getSuccessor(1)) |
| 1490 | PBIOp = BIOp = 1; |
| 1491 | else |
| 1492 | return false; |
Chris Lattner | 867661a | 2008-07-13 21:53:26 +0000 | [diff] [blame] | 1493 | |
Chris Lattner | b824512 | 2008-07-13 22:04:41 +0000 | [diff] [blame] | 1494 | // Check to make sure that the other destination of this branch |
| 1495 | // isn't BB itself. If so, this is an infinite loop that will |
| 1496 | // keep getting unwound. |
| 1497 | if (PBI->getSuccessor(PBIOp) == BB) |
| 1498 | return false; |
Chris Lattner | 867661a | 2008-07-13 21:53:26 +0000 | [diff] [blame] | 1499 | |
Chris Lattner | b824512 | 2008-07-13 22:04:41 +0000 | [diff] [blame] | 1500 | // Do not perform this transformation if it would require |
| 1501 | // insertion of a large number of select instructions. For targets |
| 1502 | // without predication/cmovs, this is a big pessimization. |
| 1503 | BasicBlock *CommonDest = PBI->getSuccessor(PBIOp); |
Chris Lattner | 867661a | 2008-07-13 21:53:26 +0000 | [diff] [blame] | 1504 | |
Chris Lattner | b824512 | 2008-07-13 22:04:41 +0000 | [diff] [blame] | 1505 | unsigned NumPhis = 0; |
| 1506 | for (BasicBlock::iterator II = CommonDest->begin(); |
| 1507 | isa<PHINode>(II); ++II, ++NumPhis) |
| 1508 | if (NumPhis > 2) // Disable this xform. |
| 1509 | return false; |
Chris Lattner | 867661a | 2008-07-13 21:53:26 +0000 | [diff] [blame] | 1510 | |
Chris Lattner | b824512 | 2008-07-13 22:04:41 +0000 | [diff] [blame] | 1511 | // Finally, if everything is ok, fold the branches to logical ops. |
| 1512 | BasicBlock *OtherDest = BI->getSuccessor(BIOp ^ 1); |
| 1513 | |
Chris Lattner | bdff548 | 2009-08-23 04:37:46 +0000 | [diff] [blame] | 1514 | DEBUG(errs() << "FOLDING BRs:" << *PBI->getParent() |
| 1515 | << "AND: " << *BI->getParent()); |
Chris Lattner | b824512 | 2008-07-13 22:04:41 +0000 | [diff] [blame] | 1516 | |
Chris Lattner | 093a438 | 2008-07-13 22:23:11 +0000 | [diff] [blame] | 1517 | |
| 1518 | // If OtherDest *is* BB, then BB is a basic block with a single conditional |
| 1519 | // branch in it, where one edge (OtherDest) goes back to itself but the other |
| 1520 | // exits. We don't *know* that the program avoids the infinite loop |
| 1521 | // (even though that seems likely). If we do this xform naively, we'll end up |
| 1522 | // recursively unpeeling the loop. Since we know that (after the xform is |
| 1523 | // done) that the block *is* infinite if reached, we just make it an obviously |
| 1524 | // infinite loop with no cond branch. |
| 1525 | if (OtherDest == BB) { |
| 1526 | // Insert it at the end of the function, because it's either code, |
| 1527 | // or it won't matter if it's hot. :) |
Owen Anderson | 1d0be15 | 2009-08-13 21:58:54 +0000 | [diff] [blame] | 1528 | BasicBlock *InfLoopBlock = BasicBlock::Create(BB->getContext(), |
| 1529 | "infloop", BB->getParent()); |
Chris Lattner | 093a438 | 2008-07-13 22:23:11 +0000 | [diff] [blame] | 1530 | BranchInst::Create(InfLoopBlock, InfLoopBlock); |
| 1531 | OtherDest = InfLoopBlock; |
| 1532 | } |
| 1533 | |
Chris Lattner | bdff548 | 2009-08-23 04:37:46 +0000 | [diff] [blame] | 1534 | DEBUG(errs() << *PBI->getParent()->getParent()); |
Chris Lattner | b824512 | 2008-07-13 22:04:41 +0000 | [diff] [blame] | 1535 | |
| 1536 | // BI may have other predecessors. Because of this, we leave |
| 1537 | // it alone, but modify PBI. |
| 1538 | |
| 1539 | // Make sure we get to CommonDest on True&True directions. |
| 1540 | Value *PBICond = PBI->getCondition(); |
| 1541 | if (PBIOp) |
Dan Gohman | 4ae5126 | 2009-08-12 16:23:25 +0000 | [diff] [blame] | 1542 | PBICond = BinaryOperator::CreateNot(PBICond, |
Chris Lattner | b824512 | 2008-07-13 22:04:41 +0000 | [diff] [blame] | 1543 | PBICond->getName()+".not", |
| 1544 | PBI); |
| 1545 | Value *BICond = BI->getCondition(); |
| 1546 | if (BIOp) |
Dan Gohman | 4ae5126 | 2009-08-12 16:23:25 +0000 | [diff] [blame] | 1547 | BICond = BinaryOperator::CreateNot(BICond, |
Chris Lattner | b824512 | 2008-07-13 22:04:41 +0000 | [diff] [blame] | 1548 | BICond->getName()+".not", |
| 1549 | PBI); |
| 1550 | // Merge the conditions. |
| 1551 | Value *Cond = BinaryOperator::CreateOr(PBICond, BICond, "brmerge", PBI); |
| 1552 | |
| 1553 | // Modify PBI to branch on the new condition to the new dests. |
| 1554 | PBI->setCondition(Cond); |
| 1555 | PBI->setSuccessor(0, CommonDest); |
| 1556 | PBI->setSuccessor(1, OtherDest); |
| 1557 | |
| 1558 | // OtherDest may have phi nodes. If so, add an entry from PBI's |
| 1559 | // block that are identical to the entries for BI's block. |
| 1560 | PHINode *PN; |
| 1561 | for (BasicBlock::iterator II = OtherDest->begin(); |
| 1562 | (PN = dyn_cast<PHINode>(II)); ++II) { |
| 1563 | Value *V = PN->getIncomingValueForBlock(BB); |
| 1564 | PN->addIncoming(V, PBI->getParent()); |
| 1565 | } |
| 1566 | |
| 1567 | // We know that the CommonDest already had an edge from PBI to |
| 1568 | // it. If it has PHIs though, the PHIs may have different |
| 1569 | // entries for BB and PBI's BB. If so, insert a select to make |
| 1570 | // them agree. |
| 1571 | for (BasicBlock::iterator II = CommonDest->begin(); |
| 1572 | (PN = dyn_cast<PHINode>(II)); ++II) { |
| 1573 | Value *BIV = PN->getIncomingValueForBlock(BB); |
| 1574 | unsigned PBBIdx = PN->getBasicBlockIndex(PBI->getParent()); |
| 1575 | Value *PBIV = PN->getIncomingValue(PBBIdx); |
| 1576 | if (BIV != PBIV) { |
| 1577 | // Insert a select in PBI to pick the right value. |
| 1578 | Value *NV = SelectInst::Create(PBICond, PBIV, BIV, |
| 1579 | PBIV->getName()+".mux", PBI); |
| 1580 | PN->setIncomingValue(PBBIdx, NV); |
Chris Lattner | 867661a | 2008-07-13 21:53:26 +0000 | [diff] [blame] | 1581 | } |
| 1582 | } |
Chris Lattner | b824512 | 2008-07-13 22:04:41 +0000 | [diff] [blame] | 1583 | |
Chris Lattner | bdff548 | 2009-08-23 04:37:46 +0000 | [diff] [blame] | 1584 | DEBUG(errs() << "INTO: " << *PBI->getParent()); |
| 1585 | DEBUG(errs() << *PBI->getParent()->getParent()); |
Chris Lattner | b824512 | 2008-07-13 22:04:41 +0000 | [diff] [blame] | 1586 | |
| 1587 | // This basic block is probably dead. We know it has at least |
| 1588 | // one fewer predecessor. |
| 1589 | return true; |
Chris Lattner | 867661a | 2008-07-13 21:53:26 +0000 | [diff] [blame] | 1590 | } |
| 1591 | |
Bill Wendling | 5049fa6 | 2009-01-19 23:43:56 +0000 | [diff] [blame] | 1592 | /// SimplifyCFG - This function is used to do simplification of a CFG. For |
| 1593 | /// example, it adjusts branches to branches to eliminate the extra hop, it |
| 1594 | /// eliminates unreachable basic blocks, and does other "peephole" optimization |
| 1595 | /// of the CFG. It returns true if a modification was made. |
| 1596 | /// |
| 1597 | /// WARNING: The entry node of a function may not be simplified. |
| 1598 | /// |
Chris Lattner | f7703df | 2004-01-09 06:12:26 +0000 | [diff] [blame] | 1599 | bool llvm::SimplifyCFG(BasicBlock *BB) { |
Chris Lattner | dc3602b | 2003-08-24 18:36:16 +0000 | [diff] [blame] | 1600 | bool Changed = false; |
Chris Lattner | 01d1ee3 | 2002-05-21 20:50:24 +0000 | [diff] [blame] | 1601 | Function *M = BB->getParent(); |
| 1602 | |
| 1603 | assert(BB && BB->getParent() && "Block not embedded in function!"); |
| 1604 | assert(BB->getTerminator() && "Degenerate basic block encountered!"); |
Dan Gohman | ecb7a77 | 2007-03-22 16:38:57 +0000 | [diff] [blame] | 1605 | assert(&BB->getParent()->getEntryBlock() != BB && |
| 1606 | "Can't Simplify entry block!"); |
Chris Lattner | 01d1ee3 | 2002-05-21 20:50:24 +0000 | [diff] [blame] | 1607 | |
Chris Lattner | 5a5c9a5 | 2008-11-27 07:54:38 +0000 | [diff] [blame] | 1608 | // Remove basic blocks that have no predecessors... or that just have themself |
| 1609 | // as a predecessor. These are unreachable. |
| 1610 | if (pred_begin(BB) == pred_end(BB) || BB->getSinglePredecessor() == BB) { |
Chris Lattner | bdff548 | 2009-08-23 04:37:46 +0000 | [diff] [blame] | 1611 | DEBUG(errs() << "Removing BB: \n" << *BB); |
Chris Lattner | 71af9b0 | 2008-12-03 06:40:52 +0000 | [diff] [blame] | 1612 | DeleteDeadBlock(BB); |
Chris Lattner | 01d1ee3 | 2002-05-21 20:50:24 +0000 | [diff] [blame] | 1613 | return true; |
| 1614 | } |
| 1615 | |
Chris Lattner | 694e37f | 2003-08-17 19:41:53 +0000 | [diff] [blame] | 1616 | // Check to see if we can constant propagate this terminator instruction |
| 1617 | // away... |
Chris Lattner | dc3602b | 2003-08-24 18:36:16 +0000 | [diff] [blame] | 1618 | Changed |= ConstantFoldTerminator(BB); |
Chris Lattner | 694e37f | 2003-08-17 19:41:53 +0000 | [diff] [blame] | 1619 | |
Dan Gohman | 2c63566 | 2009-10-30 22:39:04 +0000 | [diff] [blame] | 1620 | // Check for and eliminate duplicate PHI nodes in this block. |
| 1621 | Changed |= EliminateDuplicatePHINodes(BB); |
| 1622 | |
Dan Gohman | 882d87d | 2008-03-11 21:53:06 +0000 | [diff] [blame] | 1623 | // If there is a trivial two-entry PHI node in this basic block, and we can |
| 1624 | // eliminate it, do so now. |
| 1625 | if (PHINode *PN = dyn_cast<PHINode>(BB->begin())) |
| 1626 | if (PN->getNumIncomingValues() == 2) |
| 1627 | Changed |= FoldTwoEntryPHINode(PN); |
| 1628 | |
Chris Lattner | 19831ec | 2004-02-16 06:35:48 +0000 | [diff] [blame] | 1629 | // If this is a returning block with only PHI nodes in it, fold the return |
| 1630 | // instruction into any unconditional branch predecessors. |
Chris Lattner | 147af6b | 2004-04-02 18:13:43 +0000 | [diff] [blame] | 1631 | // |
| 1632 | // If any predecessor is a conditional branch that just selects among |
| 1633 | // different return values, fold the replace the branch/return with a select |
| 1634 | // and return. |
Chris Lattner | 19831ec | 2004-02-16 06:35:48 +0000 | [diff] [blame] | 1635 | if (ReturnInst *RI = dyn_cast<ReturnInst>(BB->getTerminator())) { |
Devang Patel | 2cc86a1 | 2009-02-05 00:30:42 +0000 | [diff] [blame] | 1636 | if (isTerminatorFirstRelevantInsn(BB, BB->getTerminator())) { |
Chris Lattner | 147af6b | 2004-04-02 18:13:43 +0000 | [diff] [blame] | 1637 | // Find predecessors that end with branches. |
Chris Lattner | 8244243 | 2008-02-18 07:42:56 +0000 | [diff] [blame] | 1638 | SmallVector<BasicBlock*, 8> UncondBranchPreds; |
| 1639 | SmallVector<BranchInst*, 8> CondBranchPreds; |
Chris Lattner | 19831ec | 2004-02-16 06:35:48 +0000 | [diff] [blame] | 1640 | for (pred_iterator PI = pred_begin(BB), E = pred_end(BB); PI != E; ++PI) { |
| 1641 | TerminatorInst *PTI = (*PI)->getTerminator(); |
Anton Korobeynikov | 07e6e56 | 2008-02-20 11:26:25 +0000 | [diff] [blame] | 1642 | if (BranchInst *BI = dyn_cast<BranchInst>(PTI)) { |
Chris Lattner | 19831ec | 2004-02-16 06:35:48 +0000 | [diff] [blame] | 1643 | if (BI->isUnconditional()) |
| 1644 | UncondBranchPreds.push_back(*PI); |
Chris Lattner | 147af6b | 2004-04-02 18:13:43 +0000 | [diff] [blame] | 1645 | else |
| 1646 | CondBranchPreds.push_back(BI); |
Anton Korobeynikov | 07e6e56 | 2008-02-20 11:26:25 +0000 | [diff] [blame] | 1647 | } |
Chris Lattner | 19831ec | 2004-02-16 06:35:48 +0000 | [diff] [blame] | 1648 | } |
Misha Brukman | fd93908 | 2005-04-21 23:48:37 +0000 | [diff] [blame] | 1649 | |
Chris Lattner | 19831ec | 2004-02-16 06:35:48 +0000 | [diff] [blame] | 1650 | // If we found some, do the transformation! |
Bill Wendling | 1c85503 | 2009-03-03 19:25:16 +0000 | [diff] [blame] | 1651 | if (!UncondBranchPreds.empty()) { |
Chris Lattner | 19831ec | 2004-02-16 06:35:48 +0000 | [diff] [blame] | 1652 | while (!UncondBranchPreds.empty()) { |
Dan Gohman | e9d87f4 | 2009-05-06 17:22:41 +0000 | [diff] [blame] | 1653 | BasicBlock *Pred = UncondBranchPreds.pop_back_val(); |
Chris Lattner | bdff548 | 2009-08-23 04:37:46 +0000 | [diff] [blame] | 1654 | DEBUG(errs() << "FOLDING: " << *BB |
| 1655 | << "INTO UNCOND BRANCH PRED: " << *Pred); |
Chris Lattner | 19831ec | 2004-02-16 06:35:48 +0000 | [diff] [blame] | 1656 | Instruction *UncondBranch = Pred->getTerminator(); |
| 1657 | // Clone the return and add it to the end of the predecessor. |
Nick Lewycky | 6776064 | 2009-09-27 07:38:41 +0000 | [diff] [blame] | 1658 | Instruction *NewRet = RI->clone(); |
Chris Lattner | 19831ec | 2004-02-16 06:35:48 +0000 | [diff] [blame] | 1659 | Pred->getInstList().push_back(NewRet); |
| 1660 | |
Devang Patel | 5622f07 | 2009-02-24 00:05:16 +0000 | [diff] [blame] | 1661 | BasicBlock::iterator BBI = RI; |
| 1662 | if (BBI != BB->begin()) { |
| 1663 | // Move region end info into the predecessor. |
| 1664 | if (DbgRegionEndInst *DREI = dyn_cast<DbgRegionEndInst>(--BBI)) |
| 1665 | DREI->moveBefore(NewRet); |
| 1666 | } |
| 1667 | |
Chris Lattner | 19831ec | 2004-02-16 06:35:48 +0000 | [diff] [blame] | 1668 | // If the return instruction returns a value, and if the value was a |
| 1669 | // PHI node in "BB", propagate the right value into the return. |
Gabor Greif | f7ea363 | 2008-06-10 22:03:26 +0000 | [diff] [blame] | 1670 | for (User::op_iterator i = NewRet->op_begin(), e = NewRet->op_end(); |
| 1671 | i != e; ++i) |
| 1672 | if (PHINode *PN = dyn_cast<PHINode>(*i)) |
Chris Lattner | 19831ec | 2004-02-16 06:35:48 +0000 | [diff] [blame] | 1673 | if (PN->getParent() == BB) |
Gabor Greif | f7ea363 | 2008-06-10 22:03:26 +0000 | [diff] [blame] | 1674 | *i = PN->getIncomingValueForBlock(Pred); |
Chris Lattner | ffba582 | 2008-04-28 00:19:07 +0000 | [diff] [blame] | 1675 | |
Chris Lattner | 19831ec | 2004-02-16 06:35:48 +0000 | [diff] [blame] | 1676 | // Update any PHI nodes in the returning block to realize that we no |
| 1677 | // longer branch to them. |
| 1678 | BB->removePredecessor(Pred); |
| 1679 | Pred->getInstList().erase(UncondBranch); |
| 1680 | } |
| 1681 | |
| 1682 | // If we eliminated all predecessors of the block, delete the block now. |
| 1683 | if (pred_begin(BB) == pred_end(BB)) |
| 1684 | // We know there are no successors, so just nuke the block. |
Devang Patel | 5622f07 | 2009-02-24 00:05:16 +0000 | [diff] [blame] | 1685 | M->getBasicBlockList().erase(BB); |
Chris Lattner | 19831ec | 2004-02-16 06:35:48 +0000 | [diff] [blame] | 1686 | |
Chris Lattner | 19831ec | 2004-02-16 06:35:48 +0000 | [diff] [blame] | 1687 | return true; |
| 1688 | } |
Chris Lattner | 147af6b | 2004-04-02 18:13:43 +0000 | [diff] [blame] | 1689 | |
| 1690 | // Check out all of the conditional branches going to this return |
| 1691 | // instruction. If any of them just select between returns, change the |
| 1692 | // branch itself into a select/return pair. |
| 1693 | while (!CondBranchPreds.empty()) { |
Dan Gohman | e9d87f4 | 2009-05-06 17:22:41 +0000 | [diff] [blame] | 1694 | BranchInst *BI = CondBranchPreds.pop_back_val(); |
Chris Lattner | 147af6b | 2004-04-02 18:13:43 +0000 | [diff] [blame] | 1695 | |
| 1696 | // Check to see if the non-BB successor is also a return block. |
Chris Lattner | c9e495c | 2008-04-24 00:01:19 +0000 | [diff] [blame] | 1697 | if (isa<ReturnInst>(BI->getSuccessor(0)->getTerminator()) && |
| 1698 | isa<ReturnInst>(BI->getSuccessor(1)->getTerminator()) && |
| 1699 | SimplifyCondBranchToTwoReturns(BI)) |
| 1700 | return true; |
Chris Lattner | 147af6b | 2004-04-02 18:13:43 +0000 | [diff] [blame] | 1701 | } |
Chris Lattner | 19831ec | 2004-02-16 06:35:48 +0000 | [diff] [blame] | 1702 | } |
Reid Spencer | 3ed469c | 2006-11-02 20:25:50 +0000 | [diff] [blame] | 1703 | } else if (isa<UnwindInst>(BB->begin())) { |
Chris Lattner | e14ea08 | 2004-02-24 05:54:22 +0000 | [diff] [blame] | 1704 | // Check to see if the first instruction in this block is just an unwind. |
| 1705 | // If so, replace any invoke instructions which use this as an exception |
Chris Lattner | 11f15db | 2009-10-13 18:13:05 +0000 | [diff] [blame] | 1706 | // destination with call instructions. |
Chris Lattner | e14ea08 | 2004-02-24 05:54:22 +0000 | [diff] [blame] | 1707 | // |
Chris Lattner | 8244243 | 2008-02-18 07:42:56 +0000 | [diff] [blame] | 1708 | SmallVector<BasicBlock*, 8> Preds(pred_begin(BB), pred_end(BB)); |
Chris Lattner | e14ea08 | 2004-02-24 05:54:22 +0000 | [diff] [blame] | 1709 | while (!Preds.empty()) { |
| 1710 | BasicBlock *Pred = Preds.back(); |
Chris Lattner | 11f15db | 2009-10-13 18:13:05 +0000 | [diff] [blame] | 1711 | if (InvokeInst *II = dyn_cast<InvokeInst>(Pred->getTerminator())) |
Chris Lattner | e14ea08 | 2004-02-24 05:54:22 +0000 | [diff] [blame] | 1712 | if (II->getUnwindDest() == BB) { |
| 1713 | // Insert a new branch instruction before the invoke, because this |
Chris Lattner | 11f15db | 2009-10-13 18:13:05 +0000 | [diff] [blame] | 1714 | // is now a fall through. |
Gabor Greif | 051a950 | 2008-04-06 20:25:17 +0000 | [diff] [blame] | 1715 | BranchInst *BI = BranchInst::Create(II->getNormalDest(), II); |
Chris Lattner | e14ea08 | 2004-02-24 05:54:22 +0000 | [diff] [blame] | 1716 | Pred->getInstList().remove(II); // Take out of symbol table |
Misha Brukman | fd93908 | 2005-04-21 23:48:37 +0000 | [diff] [blame] | 1717 | |
Chris Lattner | 11f15db | 2009-10-13 18:13:05 +0000 | [diff] [blame] | 1718 | // Insert the call now. |
Chris Lattner | 93e985f | 2007-02-13 02:10:56 +0000 | [diff] [blame] | 1719 | SmallVector<Value*,8> Args(II->op_begin()+3, II->op_end()); |
Gabor Greif | 051a950 | 2008-04-06 20:25:17 +0000 | [diff] [blame] | 1720 | CallInst *CI = CallInst::Create(II->getCalledValue(), |
Gabor Greif | f7ea363 | 2008-06-10 22:03:26 +0000 | [diff] [blame] | 1721 | Args.begin(), Args.end(), |
| 1722 | II->getName(), BI); |
Chris Lattner | 16d0db2 | 2005-05-14 12:21:56 +0000 | [diff] [blame] | 1723 | CI->setCallingConv(II->getCallingConv()); |
Devang Patel | 0598866 | 2008-09-25 21:00:45 +0000 | [diff] [blame] | 1724 | CI->setAttributes(II->getAttributes()); |
Chris Lattner | 11f15db | 2009-10-13 18:13:05 +0000 | [diff] [blame] | 1725 | // If the invoke produced a value, the Call now does instead. |
Chris Lattner | e14ea08 | 2004-02-24 05:54:22 +0000 | [diff] [blame] | 1726 | II->replaceAllUsesWith(CI); |
| 1727 | delete II; |
| 1728 | Changed = true; |
| 1729 | } |
Misha Brukman | fd93908 | 2005-04-21 23:48:37 +0000 | [diff] [blame] | 1730 | |
Chris Lattner | e14ea08 | 2004-02-24 05:54:22 +0000 | [diff] [blame] | 1731 | Preds.pop_back(); |
| 1732 | } |
Chris Lattner | 8e509dd | 2004-02-24 16:09:21 +0000 | [diff] [blame] | 1733 | |
| 1734 | // If this block is now dead, remove it. |
| 1735 | if (pred_begin(BB) == pred_end(BB)) { |
| 1736 | // We know there are no successors, so just nuke the block. |
| 1737 | M->getBasicBlockList().erase(BB); |
| 1738 | return true; |
| 1739 | } |
| 1740 | |
Chris Lattner | 623369a | 2005-02-24 06:17:52 +0000 | [diff] [blame] | 1741 | } else if (SwitchInst *SI = dyn_cast<SwitchInst>(BB->getTerminator())) { |
| 1742 | if (isValueEqualityComparison(SI)) { |
| 1743 | // If we only have one predecessor, and if it is a branch on this value, |
| 1744 | // see if that predecessor totally determines the outcome of this switch. |
| 1745 | if (BasicBlock *OnlyPred = BB->getSinglePredecessor()) |
| 1746 | if (SimplifyEqualityComparisonWithOnlyPredecessor(SI, OnlyPred)) |
| 1747 | return SimplifyCFG(BB) || 1; |
| 1748 | |
| 1749 | // If the block only contains the switch, see if we can fold the block |
| 1750 | // away into any preds. |
Zhou Sheng | 9a7c743 | 2009-02-25 15:34:27 +0000 | [diff] [blame] | 1751 | BasicBlock::iterator BBI = BB->begin(); |
| 1752 | // Ignore dbg intrinsics. |
| 1753 | while (isa<DbgInfoIntrinsic>(BBI)) |
| 1754 | ++BBI; |
| 1755 | if (SI == &*BBI) |
Chris Lattner | 623369a | 2005-02-24 06:17:52 +0000 | [diff] [blame] | 1756 | if (FoldValueComparisonIntoPredecessors(SI)) |
| 1757 | return SimplifyCFG(BB) || 1; |
| 1758 | } |
Chris Lattner | 542f149 | 2004-02-28 21:28:10 +0000 | [diff] [blame] | 1759 | } else if (BranchInst *BI = dyn_cast<BranchInst>(BB->getTerminator())) { |
Chris Lattner | 7e66348 | 2005-08-03 00:11:16 +0000 | [diff] [blame] | 1760 | if (BI->isUnconditional()) { |
Dan Gohman | 02dea8b | 2008-05-23 21:05:58 +0000 | [diff] [blame] | 1761 | BasicBlock::iterator BBI = BB->getFirstNonPHI(); |
Chris Lattner | 7e66348 | 2005-08-03 00:11:16 +0000 | [diff] [blame] | 1762 | |
Devang Patel | d0a203d | 2009-02-04 21:39:48 +0000 | [diff] [blame] | 1763 | // Ignore dbg intrinsics. |
| 1764 | while (isa<DbgInfoIntrinsic>(BBI)) |
| 1765 | ++BBI; |
Chris Lattner | dce94d9 | 2009-11-10 05:59:26 +0000 | [diff] [blame] | 1766 | if (BBI->isTerminator()) // Terminator is the only non-phi instruction! |
| 1767 | if (TryToSimplifyUncondBranchFromEmptyBlock(BB)) |
Chris Lattner | 1347e87 | 2008-07-13 21:12:01 +0000 | [diff] [blame] | 1768 | return true; |
Chris Lattner | 7e66348 | 2005-08-03 00:11:16 +0000 | [diff] [blame] | 1769 | |
| 1770 | } else { // Conditional branch |
Reid Spencer | 3ed469c | 2006-11-02 20:25:50 +0000 | [diff] [blame] | 1771 | if (isValueEqualityComparison(BI)) { |
Chris Lattner | 623369a | 2005-02-24 06:17:52 +0000 | [diff] [blame] | 1772 | // If we only have one predecessor, and if it is a branch on this value, |
| 1773 | // see if that predecessor totally determines the outcome of this |
| 1774 | // switch. |
| 1775 | if (BasicBlock *OnlyPred = BB->getSinglePredecessor()) |
| 1776 | if (SimplifyEqualityComparisonWithOnlyPredecessor(BI, OnlyPred)) |
| 1777 | return SimplifyCFG(BB) || 1; |
| 1778 | |
Chris Lattner | e67fa05 | 2004-05-01 23:35:43 +0000 | [diff] [blame] | 1779 | // This block must be empty, except for the setcond inst, if it exists. |
Devang Patel | 556b20a | 2009-02-04 01:06:11 +0000 | [diff] [blame] | 1780 | // Ignore dbg intrinsics. |
Chris Lattner | e67fa05 | 2004-05-01 23:35:43 +0000 | [diff] [blame] | 1781 | BasicBlock::iterator I = BB->begin(); |
Devang Patel | d0a203d | 2009-02-04 21:39:48 +0000 | [diff] [blame] | 1782 | // Ignore dbg intrinsics. |
Devang Patel | 556b20a | 2009-02-04 01:06:11 +0000 | [diff] [blame] | 1783 | while (isa<DbgInfoIntrinsic>(I)) |
Devang Patel | d0a203d | 2009-02-04 21:39:48 +0000 | [diff] [blame] | 1784 | ++I; |
| 1785 | if (&*I == BI) { |
Chris Lattner | e67fa05 | 2004-05-01 23:35:43 +0000 | [diff] [blame] | 1786 | if (FoldValueComparisonIntoPredecessors(BI)) |
| 1787 | return SimplifyCFG(BB) | true; |
Devang Patel | d0a203d | 2009-02-04 21:39:48 +0000 | [diff] [blame] | 1788 | } else if (&*I == cast<Instruction>(BI->getCondition())){ |
| 1789 | ++I; |
| 1790 | // Ignore dbg intrinsics. |
| 1791 | while (isa<DbgInfoIntrinsic>(I)) |
| 1792 | ++I; |
| 1793 | if(&*I == BI) { |
| 1794 | if (FoldValueComparisonIntoPredecessors(BI)) |
| 1795 | return SimplifyCFG(BB) | true; |
| 1796 | } |
| 1797 | } |
Chris Lattner | e67fa05 | 2004-05-01 23:35:43 +0000 | [diff] [blame] | 1798 | } |
Devang Patel | d0a203d | 2009-02-04 21:39:48 +0000 | [diff] [blame] | 1799 | |
Chris Lattner | eaba3a1 | 2005-09-19 23:49:37 +0000 | [diff] [blame] | 1800 | // If this is a branch on a phi node in the current block, thread control |
| 1801 | // through this block if any PHI node entries are constants. |
| 1802 | if (PHINode *PN = dyn_cast<PHINode>(BI->getCondition())) |
| 1803 | if (PN->getParent() == BI->getParent()) |
| 1804 | if (FoldCondBranchOnPHI(BI)) |
| 1805 | return SimplifyCFG(BB) | true; |
Chris Lattner | e67fa05 | 2004-05-01 23:35:43 +0000 | [diff] [blame] | 1806 | |
| 1807 | // If this basic block is ONLY a setcc and a branch, and if a predecessor |
| 1808 | // branches to us and one of our successors, fold the setcc into the |
| 1809 | // predecessor and use logical operations to pick the right destination. |
Chris Lattner | 1347e87 | 2008-07-13 21:12:01 +0000 | [diff] [blame] | 1810 | if (FoldBranchToCommonDest(BI)) |
| 1811 | return SimplifyCFG(BB) | 1; |
Chris Lattner | e67fa05 | 2004-05-01 23:35:43 +0000 | [diff] [blame] | 1812 | |
Chris Lattner | 867661a | 2008-07-13 21:53:26 +0000 | [diff] [blame] | 1813 | |
| 1814 | // Scan predecessor blocks for conditional branches. |
Chris Lattner | 2e42e36 | 2005-09-20 00:43:16 +0000 | [diff] [blame] | 1815 | for (pred_iterator PI = pred_begin(BB), E = pred_end(BB); PI != E; ++PI) |
| 1816 | if (BranchInst *PBI = dyn_cast<BranchInst>((*PI)->getTerminator())) |
Chris Lattner | 867661a | 2008-07-13 21:53:26 +0000 | [diff] [blame] | 1817 | if (PBI != BI && PBI->isConditional()) |
| 1818 | if (SimplifyCondBranchToCondBranch(PBI, BI)) |
| 1819 | return SimplifyCFG(BB) | true; |
Chris Lattner | d52c261 | 2004-02-24 07:23:58 +0000 | [diff] [blame] | 1820 | } |
Chris Lattner | 698f96f | 2004-10-18 04:07:22 +0000 | [diff] [blame] | 1821 | } else if (isa<UnreachableInst>(BB->getTerminator())) { |
| 1822 | // If there are any instructions immediately before the unreachable that can |
| 1823 | // be removed, do so. |
| 1824 | Instruction *Unreachable = BB->getTerminator(); |
| 1825 | while (Unreachable != BB->begin()) { |
| 1826 | BasicBlock::iterator BBI = Unreachable; |
| 1827 | --BBI; |
Chris Lattner | f8131c9 | 2008-10-29 17:46:26 +0000 | [diff] [blame] | 1828 | // Do not delete instructions that can have side effects, like calls |
| 1829 | // (which may never return) and volatile loads and stores. |
Dale Johannesen | 80b8a62 | 2009-03-12 17:42:45 +0000 | [diff] [blame] | 1830 | if (isa<CallInst>(BBI) && !isa<DbgInfoIntrinsic>(BBI)) break; |
Chris Lattner | f8131c9 | 2008-10-29 17:46:26 +0000 | [diff] [blame] | 1831 | |
| 1832 | if (StoreInst *SI = dyn_cast<StoreInst>(BBI)) |
| 1833 | if (SI->isVolatile()) |
| 1834 | break; |
| 1835 | |
| 1836 | if (LoadInst *LI = dyn_cast<LoadInst>(BBI)) |
| 1837 | if (LI->isVolatile()) |
| 1838 | break; |
| 1839 | |
Chris Lattner | 698f96f | 2004-10-18 04:07:22 +0000 | [diff] [blame] | 1840 | // Delete this instruction |
| 1841 | BB->getInstList().erase(BBI); |
| 1842 | Changed = true; |
| 1843 | } |
| 1844 | |
| 1845 | // If the unreachable instruction is the first in the block, take a gander |
| 1846 | // at all of the predecessors of this instruction, and simplify them. |
| 1847 | if (&BB->front() == Unreachable) { |
Chris Lattner | 8244243 | 2008-02-18 07:42:56 +0000 | [diff] [blame] | 1848 | SmallVector<BasicBlock*, 8> Preds(pred_begin(BB), pred_end(BB)); |
Chris Lattner | 698f96f | 2004-10-18 04:07:22 +0000 | [diff] [blame] | 1849 | for (unsigned i = 0, e = Preds.size(); i != e; ++i) { |
| 1850 | TerminatorInst *TI = Preds[i]->getTerminator(); |
| 1851 | |
| 1852 | if (BranchInst *BI = dyn_cast<BranchInst>(TI)) { |
| 1853 | if (BI->isUnconditional()) { |
| 1854 | if (BI->getSuccessor(0) == BB) { |
Owen Anderson | 1d0be15 | 2009-08-13 21:58:54 +0000 | [diff] [blame] | 1855 | new UnreachableInst(TI->getContext(), TI); |
Chris Lattner | 698f96f | 2004-10-18 04:07:22 +0000 | [diff] [blame] | 1856 | TI->eraseFromParent(); |
| 1857 | Changed = true; |
| 1858 | } |
| 1859 | } else { |
| 1860 | if (BI->getSuccessor(0) == BB) { |
Gabor Greif | 051a950 | 2008-04-06 20:25:17 +0000 | [diff] [blame] | 1861 | BranchInst::Create(BI->getSuccessor(1), BI); |
Eli Friedman | 080efb8 | 2008-12-16 20:54:32 +0000 | [diff] [blame] | 1862 | EraseTerminatorInstAndDCECond(BI); |
Chris Lattner | 698f96f | 2004-10-18 04:07:22 +0000 | [diff] [blame] | 1863 | } else if (BI->getSuccessor(1) == BB) { |
Gabor Greif | 051a950 | 2008-04-06 20:25:17 +0000 | [diff] [blame] | 1864 | BranchInst::Create(BI->getSuccessor(0), BI); |
Eli Friedman | 080efb8 | 2008-12-16 20:54:32 +0000 | [diff] [blame] | 1865 | EraseTerminatorInstAndDCECond(BI); |
Chris Lattner | 698f96f | 2004-10-18 04:07:22 +0000 | [diff] [blame] | 1866 | Changed = true; |
| 1867 | } |
| 1868 | } |
| 1869 | } else if (SwitchInst *SI = dyn_cast<SwitchInst>(TI)) { |
| 1870 | for (unsigned i = 1, e = SI->getNumCases(); i != e; ++i) |
| 1871 | if (SI->getSuccessor(i) == BB) { |
Chris Lattner | 42eb752 | 2005-05-20 22:19:54 +0000 | [diff] [blame] | 1872 | BB->removePredecessor(SI->getParent()); |
Chris Lattner | 698f96f | 2004-10-18 04:07:22 +0000 | [diff] [blame] | 1873 | SI->removeCase(i); |
| 1874 | --i; --e; |
| 1875 | Changed = true; |
| 1876 | } |
| 1877 | // If the default value is unreachable, figure out the most popular |
| 1878 | // destination and make it the default. |
| 1879 | if (SI->getSuccessor(0) == BB) { |
| 1880 | std::map<BasicBlock*, unsigned> Popularity; |
| 1881 | for (unsigned i = 1, e = SI->getNumCases(); i != e; ++i) |
| 1882 | Popularity[SI->getSuccessor(i)]++; |
| 1883 | |
| 1884 | // Find the most popular block. |
| 1885 | unsigned MaxPop = 0; |
| 1886 | BasicBlock *MaxBlock = 0; |
| 1887 | for (std::map<BasicBlock*, unsigned>::iterator |
| 1888 | I = Popularity.begin(), E = Popularity.end(); I != E; ++I) { |
| 1889 | if (I->second > MaxPop) { |
| 1890 | MaxPop = I->second; |
| 1891 | MaxBlock = I->first; |
| 1892 | } |
| 1893 | } |
| 1894 | if (MaxBlock) { |
| 1895 | // Make this the new default, allowing us to delete any explicit |
| 1896 | // edges to it. |
| 1897 | SI->setSuccessor(0, MaxBlock); |
| 1898 | Changed = true; |
| 1899 | |
Chris Lattner | 42eb752 | 2005-05-20 22:19:54 +0000 | [diff] [blame] | 1900 | // If MaxBlock has phinodes in it, remove MaxPop-1 entries from |
| 1901 | // it. |
| 1902 | if (isa<PHINode>(MaxBlock->begin())) |
| 1903 | for (unsigned i = 0; i != MaxPop-1; ++i) |
| 1904 | MaxBlock->removePredecessor(SI->getParent()); |
| 1905 | |
Chris Lattner | 698f96f | 2004-10-18 04:07:22 +0000 | [diff] [blame] | 1906 | for (unsigned i = 1, e = SI->getNumCases(); i != e; ++i) |
| 1907 | if (SI->getSuccessor(i) == MaxBlock) { |
| 1908 | SI->removeCase(i); |
| 1909 | --i; --e; |
| 1910 | } |
| 1911 | } |
| 1912 | } |
| 1913 | } else if (InvokeInst *II = dyn_cast<InvokeInst>(TI)) { |
| 1914 | if (II->getUnwindDest() == BB) { |
| 1915 | // Convert the invoke to a call instruction. This would be a good |
| 1916 | // place to note that the call does not throw though. |
Gabor Greif | 051a950 | 2008-04-06 20:25:17 +0000 | [diff] [blame] | 1917 | BranchInst *BI = BranchInst::Create(II->getNormalDest(), II); |
Chris Lattner | 698f96f | 2004-10-18 04:07:22 +0000 | [diff] [blame] | 1918 | II->removeFromParent(); // Take out of symbol table |
Misha Brukman | fd93908 | 2005-04-21 23:48:37 +0000 | [diff] [blame] | 1919 | |
Chris Lattner | 698f96f | 2004-10-18 04:07:22 +0000 | [diff] [blame] | 1920 | // Insert the call now... |
Chris Lattner | 93e985f | 2007-02-13 02:10:56 +0000 | [diff] [blame] | 1921 | SmallVector<Value*, 8> Args(II->op_begin()+3, II->op_end()); |
Gabor Greif | 051a950 | 2008-04-06 20:25:17 +0000 | [diff] [blame] | 1922 | CallInst *CI = CallInst::Create(II->getCalledValue(), |
| 1923 | Args.begin(), Args.end(), |
| 1924 | II->getName(), BI); |
Chris Lattner | 16d0db2 | 2005-05-14 12:21:56 +0000 | [diff] [blame] | 1925 | CI->setCallingConv(II->getCallingConv()); |
Devang Patel | 0598866 | 2008-09-25 21:00:45 +0000 | [diff] [blame] | 1926 | CI->setAttributes(II->getAttributes()); |
Chris Lattner | 698f96f | 2004-10-18 04:07:22 +0000 | [diff] [blame] | 1927 | // If the invoke produced a value, the Call does now instead. |
| 1928 | II->replaceAllUsesWith(CI); |
| 1929 | delete II; |
| 1930 | Changed = true; |
| 1931 | } |
| 1932 | } |
| 1933 | } |
| 1934 | |
| 1935 | // If this block is now dead, remove it. |
| 1936 | if (pred_begin(BB) == pred_end(BB)) { |
| 1937 | // We know there are no successors, so just nuke the block. |
| 1938 | M->getBasicBlockList().erase(BB); |
| 1939 | return true; |
| 1940 | } |
| 1941 | } |
Chris Lattner | 19831ec | 2004-02-16 06:35:48 +0000 | [diff] [blame] | 1942 | } |
| 1943 | |
Chris Lattner | 01d1ee3 | 2002-05-21 20:50:24 +0000 | [diff] [blame] | 1944 | // Merge basic blocks into their predecessor if there is only one distinct |
| 1945 | // pred, and if there is only one distinct successor of the predecessor, and |
| 1946 | // if there are no PHI nodes. |
| 1947 | // |
Owen Anderson | cfa9419 | 2008-07-18 17:49:43 +0000 | [diff] [blame] | 1948 | if (MergeBlockIntoPredecessor(BB)) |
| 1949 | return true; |
| 1950 | |
| 1951 | // Otherwise, if this block only has a single predecessor, and if that block |
| 1952 | // is a conditional branch, see if we can hoist any code from this block up |
| 1953 | // into our predecessor. |
Chris Lattner | 2355f94 | 2004-02-11 01:17:07 +0000 | [diff] [blame] | 1954 | pred_iterator PI(pred_begin(BB)), PE(pred_end(BB)); |
| 1955 | BasicBlock *OnlyPred = *PI++; |
| 1956 | for (; PI != PE; ++PI) // Search all predecessors, see if they are all same |
| 1957 | if (*PI != OnlyPred) { |
| 1958 | OnlyPred = 0; // There are multiple different predecessors... |
| 1959 | break; |
| 1960 | } |
Owen Anderson | cfa9419 | 2008-07-18 17:49:43 +0000 | [diff] [blame] | 1961 | |
Chris Lattner | 37dc938 | 2004-11-30 00:29:14 +0000 | [diff] [blame] | 1962 | if (OnlyPred) |
Chris Lattner | 7613437 | 2004-12-10 17:42:31 +0000 | [diff] [blame] | 1963 | if (BranchInst *BI = dyn_cast<BranchInst>(OnlyPred->getTerminator())) |
| 1964 | if (BI->isConditional()) { |
| 1965 | // Get the other block. |
| 1966 | BasicBlock *OtherBB = BI->getSuccessor(BI->getSuccessor(0) == BB); |
| 1967 | PI = pred_begin(OtherBB); |
| 1968 | ++PI; |
Owen Anderson | cfa9419 | 2008-07-18 17:49:43 +0000 | [diff] [blame] | 1969 | |
Chris Lattner | 7613437 | 2004-12-10 17:42:31 +0000 | [diff] [blame] | 1970 | if (PI == pred_end(OtherBB)) { |
| 1971 | // We have a conditional branch to two blocks that are only reachable |
| 1972 | // from the condbr. We know that the condbr dominates the two blocks, |
| 1973 | // so see if there is any identical code in the "then" and "else" |
| 1974 | // blocks. If so, we can hoist it up to the branching block. |
| 1975 | Changed |= HoistThenElseCodeToIf(BI); |
Evan Cheng | 4d09efd | 2008-06-07 08:52:29 +0000 | [diff] [blame] | 1976 | } else { |
Owen Anderson | cfa9419 | 2008-07-18 17:49:43 +0000 | [diff] [blame] | 1977 | BasicBlock* OnlySucc = NULL; |
Evan Cheng | 4d09efd | 2008-06-07 08:52:29 +0000 | [diff] [blame] | 1978 | for (succ_iterator SI = succ_begin(BB), SE = succ_end(BB); |
| 1979 | SI != SE; ++SI) { |
| 1980 | if (!OnlySucc) |
| 1981 | OnlySucc = *SI; |
| 1982 | else if (*SI != OnlySucc) { |
| 1983 | OnlySucc = 0; // There are multiple distinct successors! |
| 1984 | break; |
| 1985 | } |
| 1986 | } |
| 1987 | |
| 1988 | if (OnlySucc == OtherBB) { |
| 1989 | // If BB's only successor is the other successor of the predecessor, |
| 1990 | // i.e. a triangle, see if we can hoist any code from this block up |
| 1991 | // to the "if" block. |
| 1992 | Changed |= SpeculativelyExecuteBB(BI, BB); |
| 1993 | } |
Chris Lattner | 7613437 | 2004-12-10 17:42:31 +0000 | [diff] [blame] | 1994 | } |
Chris Lattner | 37dc938 | 2004-11-30 00:29:14 +0000 | [diff] [blame] | 1995 | } |
Chris Lattner | 37dc938 | 2004-11-30 00:29:14 +0000 | [diff] [blame] | 1996 | |
Chris Lattner | 0d56008 | 2004-02-24 05:38:11 +0000 | [diff] [blame] | 1997 | for (pred_iterator PI = pred_begin(BB), E = pred_end(BB); PI != E; ++PI) |
| 1998 | if (BranchInst *BI = dyn_cast<BranchInst>((*PI)->getTerminator())) |
| 1999 | // Change br (X == 0 | X == 1), T, F into a switch instruction. |
| 2000 | if (BI->isConditional() && isa<Instruction>(BI->getCondition())) { |
| 2001 | Instruction *Cond = cast<Instruction>(BI->getCondition()); |
| 2002 | // If this is a bunch of seteq's or'd together, or if it's a bunch of |
| 2003 | // 'setne's and'ed together, collect them. |
| 2004 | Value *CompVal = 0; |
Chris Lattner | 1654cff | 2004-06-19 07:02:14 +0000 | [diff] [blame] | 2005 | std::vector<ConstantInt*> Values; |
Chris Lattner | 0d56008 | 2004-02-24 05:38:11 +0000 | [diff] [blame] | 2006 | bool TrueWhenEqual = GatherValueComparisons(Cond, CompVal, Values); |
Chris Lattner | 42a7551 | 2007-01-15 02:27:26 +0000 | [diff] [blame] | 2007 | if (CompVal && CompVal->getType()->isInteger()) { |
Chris Lattner | 0d56008 | 2004-02-24 05:38:11 +0000 | [diff] [blame] | 2008 | // There might be duplicate constants in the list, which the switch |
| 2009 | // instruction can't handle, remove them now. |
Chris Lattner | 1654cff | 2004-06-19 07:02:14 +0000 | [diff] [blame] | 2010 | std::sort(Values.begin(), Values.end(), ConstantIntOrdering()); |
Chris Lattner | 0d56008 | 2004-02-24 05:38:11 +0000 | [diff] [blame] | 2011 | Values.erase(std::unique(Values.begin(), Values.end()), Values.end()); |
Misha Brukman | fd93908 | 2005-04-21 23:48:37 +0000 | [diff] [blame] | 2012 | |
Chris Lattner | 0d56008 | 2004-02-24 05:38:11 +0000 | [diff] [blame] | 2013 | // Figure out which block is which destination. |
| 2014 | BasicBlock *DefaultBB = BI->getSuccessor(1); |
| 2015 | BasicBlock *EdgeBB = BI->getSuccessor(0); |
| 2016 | if (!TrueWhenEqual) std::swap(DefaultBB, EdgeBB); |
Misha Brukman | fd93908 | 2005-04-21 23:48:37 +0000 | [diff] [blame] | 2017 | |
Chris Lattner | 0d56008 | 2004-02-24 05:38:11 +0000 | [diff] [blame] | 2018 | // Create the new switch instruction now. |
Gabor Greif | b1dbcd8 | 2008-05-15 10:04:30 +0000 | [diff] [blame] | 2019 | SwitchInst *New = SwitchInst::Create(CompVal, DefaultBB, |
| 2020 | Values.size(), BI); |
Misha Brukman | fd93908 | 2005-04-21 23:48:37 +0000 | [diff] [blame] | 2021 | |
Chris Lattner | 0d56008 | 2004-02-24 05:38:11 +0000 | [diff] [blame] | 2022 | // Add all of the 'cases' to the switch instruction. |
| 2023 | for (unsigned i = 0, e = Values.size(); i != e; ++i) |
| 2024 | New->addCase(Values[i], EdgeBB); |
Misha Brukman | fd93908 | 2005-04-21 23:48:37 +0000 | [diff] [blame] | 2025 | |
Chris Lattner | 0d56008 | 2004-02-24 05:38:11 +0000 | [diff] [blame] | 2026 | // We added edges from PI to the EdgeBB. As such, if there were any |
| 2027 | // PHI nodes in EdgeBB, they need entries to be added corresponding to |
| 2028 | // the number of edges added. |
| 2029 | for (BasicBlock::iterator BBI = EdgeBB->begin(); |
Reid Spencer | 2da5c3d | 2004-09-15 17:06:42 +0000 | [diff] [blame] | 2030 | isa<PHINode>(BBI); ++BBI) { |
| 2031 | PHINode *PN = cast<PHINode>(BBI); |
Chris Lattner | 0d56008 | 2004-02-24 05:38:11 +0000 | [diff] [blame] | 2032 | Value *InVal = PN->getIncomingValueForBlock(*PI); |
| 2033 | for (unsigned i = 0, e = Values.size()-1; i != e; ++i) |
| 2034 | PN->addIncoming(InVal, *PI); |
| 2035 | } |
| 2036 | |
| 2037 | // Erase the old branch instruction. |
Eli Friedman | 080efb8 | 2008-12-16 20:54:32 +0000 | [diff] [blame] | 2038 | EraseTerminatorInstAndDCECond(BI); |
Chris Lattner | 0d56008 | 2004-02-24 05:38:11 +0000 | [diff] [blame] | 2039 | return true; |
| 2040 | } |
| 2041 | } |
| 2042 | |
Chris Lattner | 694e37f | 2003-08-17 19:41:53 +0000 | [diff] [blame] | 2043 | return Changed; |
Chris Lattner | 01d1ee3 | 2002-05-21 20:50:24 +0000 | [diff] [blame] | 2044 | } |