blob: d683a2c5aaec1e54316041b3b4bcb941d388a017 [file] [log] [blame]
Dan Gohmanf17a25c2007-07-18 16:29:46 +00001//===- BreakCriticalEdges.cpp - Critical Edge Elimination Pass ------------===//
2//
3// The LLVM Compiler Infrastructure
4//
Chris Lattner081ce942007-12-29 20:36:04 +00005// This file is distributed under the University of Illinois Open Source
6// License. See LICENSE.TXT for details.
Dan Gohmanf17a25c2007-07-18 16:29:46 +00007//
8//===----------------------------------------------------------------------===//
9//
10// BreakCriticalEdges pass - Break all of the critical edges in the CFG by
11// inserting a dummy basic block. This pass may be "required" by passes that
12// cannot deal with critical edges. For this usage, the structure type is
13// forward declared. This pass obviously invalidates the CFG, but can update
14// forward dominator (set, immediate dominators, tree, and frontier)
15// information.
16//
17//===----------------------------------------------------------------------===//
18
19#define DEBUG_TYPE "break-crit-edges"
20#include "llvm/Transforms/Scalar.h"
21#include "llvm/Transforms/Utils/BasicBlockUtils.h"
22#include "llvm/Analysis/Dominators.h"
23#include "llvm/Analysis/LoopInfo.h"
Andreas Neustifterf193e182009-09-09 17:53:39 +000024#include "llvm/Analysis/ProfileInfo.h"
Dan Gohmanf17a25c2007-07-18 16:29:46 +000025#include "llvm/Function.h"
26#include "llvm/Instructions.h"
27#include "llvm/Type.h"
28#include "llvm/Support/CFG.h"
Edwin Török675d5622009-07-11 20:10:48 +000029#include "llvm/Support/ErrorHandling.h"
Dan Gohmanf17a25c2007-07-18 16:29:46 +000030#include "llvm/ADT/SmallVector.h"
31#include "llvm/ADT/Statistic.h"
32using namespace llvm;
33
34STATISTIC(NumBroken, "Number of blocks inserted");
35
36namespace {
Nick Lewycky492d06e2009-10-25 06:33:48 +000037 struct BreakCriticalEdges : public FunctionPass {
Dan Gohmanf17a25c2007-07-18 16:29:46 +000038 static char ID; // Pass identification, replacement for typeid
Dan Gohman26f8c272008-09-04 17:05:41 +000039 BreakCriticalEdges() : FunctionPass(&ID) {}
Dan Gohmanf17a25c2007-07-18 16:29:46 +000040
41 virtual bool runOnFunction(Function &F);
42
43 virtual void getAnalysisUsage(AnalysisUsage &AU) const {
44 AU.addPreserved<DominatorTree>();
45 AU.addPreserved<DominanceFrontier>();
46 AU.addPreserved<LoopInfo>();
Andreas Neustifterf193e182009-09-09 17:53:39 +000047 AU.addPreserved<ProfileInfo>();
Dan Gohmanf17a25c2007-07-18 16:29:46 +000048
49 // No loop canonicalization guarantees are broken by this pass.
50 AU.addPreservedID(LoopSimplifyID);
51 }
52 };
Dan Gohmanf17a25c2007-07-18 16:29:46 +000053}
54
Dan Gohman089efff2008-05-13 00:00:25 +000055char BreakCriticalEdges::ID = 0;
56static RegisterPass<BreakCriticalEdges>
57X("break-crit-edges", "Break critical edges in CFG");
58
Dan Gohmanf17a25c2007-07-18 16:29:46 +000059// Publically exposed interface to pass...
Dan Gohman66a636e2008-05-13 02:05:11 +000060const PassInfo *const llvm::BreakCriticalEdgesID = &X;
Dan Gohmanf17a25c2007-07-18 16:29:46 +000061FunctionPass *llvm::createBreakCriticalEdgesPass() {
62 return new BreakCriticalEdges();
63}
64
65// runOnFunction - Loop over all of the edges in the CFG, breaking critical
66// edges as they are found.
67//
68bool BreakCriticalEdges::runOnFunction(Function &F) {
69 bool Changed = false;
70 for (Function::iterator I = F.begin(), E = F.end(); I != E; ++I) {
71 TerminatorInst *TI = I->getTerminator();
72 if (TI->getNumSuccessors() > 1)
73 for (unsigned i = 0, e = TI->getNumSuccessors(); i != e; ++i)
74 if (SplitCriticalEdge(TI, i, this)) {
75 ++NumBroken;
76 Changed = true;
77 }
78 }
79
80 return Changed;
81}
82
83//===----------------------------------------------------------------------===//
84// Implementation of the external critical edge manipulation functions
85//===----------------------------------------------------------------------===//
86
87// isCriticalEdge - Return true if the specified edge is a critical edge.
88// Critical edges are edges from a block with multiple successors to a block
89// with multiple predecessors.
90//
91bool llvm::isCriticalEdge(const TerminatorInst *TI, unsigned SuccNum,
92 bool AllowIdenticalEdges) {
93 assert(SuccNum < TI->getNumSuccessors() && "Illegal edge specification!");
94 if (TI->getNumSuccessors() == 1) return false;
95
96 const BasicBlock *Dest = TI->getSuccessor(SuccNum);
97 pred_const_iterator I = pred_begin(Dest), E = pred_end(Dest);
98
99 // If there is more than one predecessor, this is a critical edge...
100 assert(I != E && "No preds, but we have an edge to the block?");
101 const BasicBlock *FirstPred = *I;
102 ++I; // Skip one edge due to the incoming arc from TI.
103 if (!AllowIdenticalEdges)
104 return I != E;
105
106 // If AllowIdenticalEdges is true, then we allow this edge to be considered
107 // non-critical iff all preds come from TI's block.
Scott Michelaad62cc2008-04-16 23:46:39 +0000108 while (I != E) {
Scott Michelaad62cc2008-04-16 23:46:39 +0000109 if (*I != FirstPred)
110 return true;
111 // Note: leave this as is until no one ever compiles with either gcc 4.0.1
112 // or Xcode 2. This seems to work around the pred_iterator assert in PR 2207
113 E = pred_end(*I);
114 ++I;
115 }
Dan Gohmanf17a25c2007-07-18 16:29:46 +0000116 return false;
117}
118
Dan Gohmanf06a9ba2009-09-09 18:18:18 +0000119/// CreatePHIsForSplitLoopExit - When a loop exit edge is split, LCSSA form
120/// may require new PHIs in the new exit block. This function inserts the
121/// new PHIs, as needed. Preds is a list of preds inside the loop, SplitBB
122/// is the new loop exit block, and DestBB is the old loop exit, now the
123/// successor of SplitBB.
124static void CreatePHIsForSplitLoopExit(SmallVectorImpl<BasicBlock *> &Preds,
125 BasicBlock *SplitBB,
126 BasicBlock *DestBB) {
127 // SplitBB shouldn't have anything non-trivial in it yet.
128 assert(SplitBB->getFirstNonPHI() == SplitBB->getTerminator() &&
129 "SplitBB has non-PHI nodes!");
130
131 // For each PHI in the destination block...
132 for (BasicBlock::iterator I = DestBB->begin();
133 PHINode *PN = dyn_cast<PHINode>(I); ++I) {
134 unsigned Idx = PN->getBasicBlockIndex(SplitBB);
135 Value *V = PN->getIncomingValue(Idx);
136 // If the input is a PHI which already satisfies LCSSA, don't create
137 // a new one.
138 if (const PHINode *VP = dyn_cast<PHINode>(V))
139 if (VP->getParent() == SplitBB)
140 continue;
141 // Otherwise a new PHI is needed. Create one and populate it.
142 PHINode *NewPN = PHINode::Create(PN->getType(), "split",
143 SplitBB->getTerminator());
144 for (unsigned i = 0, e = Preds.size(); i != e; ++i)
145 NewPN->addIncoming(V, Preds[i]);
146 // Update the original PHI.
147 PN->setIncomingValue(Idx, NewPN);
148 }
149}
150
Chris Lattner8e767592008-04-21 00:19:16 +0000151/// SplitCriticalEdge - If this edge is a critical edge, insert a new node to
152/// split the critical edge. This will update DominatorTree and
153/// DominatorFrontier information if it is available, thus calling this pass
154/// will not invalidate any of them. This returns true if the edge was split,
155/// false otherwise. This ensures that all edges to that dest go to one block
156/// instead of each going to a different block.
Dan Gohmanf17a25c2007-07-18 16:29:46 +0000157//
Dan Gohman9cec4122009-09-08 15:45:00 +0000158BasicBlock *llvm::SplitCriticalEdge(TerminatorInst *TI, unsigned SuccNum,
159 Pass *P, bool MergeIdenticalEdges) {
160 if (!isCriticalEdge(TI, SuccNum, MergeIdenticalEdges)) return 0;
Dan Gohmanf17a25c2007-07-18 16:29:46 +0000161 BasicBlock *TIBB = TI->getParent();
162 BasicBlock *DestBB = TI->getSuccessor(SuccNum);
163
164 // Create a new basic block, linking it into the CFG.
Owen Anderson35b47072009-08-13 21:58:54 +0000165 BasicBlock *NewBB = BasicBlock::Create(TI->getContext(),
166 TIBB->getName() + "." + DestBB->getName() + "_crit_edge");
Dan Gohmanf17a25c2007-07-18 16:29:46 +0000167 // Create our unconditional branch...
Gabor Greifd6da1d02008-04-06 20:25:17 +0000168 BranchInst::Create(DestBB, NewBB);
Dan Gohmanf17a25c2007-07-18 16:29:46 +0000169
170 // Branch to the new block, breaking the edge.
171 TI->setSuccessor(SuccNum, NewBB);
172
173 // Insert the block into the function... right after the block TI lives in.
174 Function &F = *TIBB->getParent();
175 Function::iterator FBBI = TIBB;
176 F.getBasicBlockList().insert(++FBBI, NewBB);
177
178 // If there are any PHI nodes in DestBB, we need to update them so that they
179 // merge incoming values from NewBB instead of from TIBB.
180 //
181 for (BasicBlock::iterator I = DestBB->begin(); isa<PHINode>(I); ++I) {
182 PHINode *PN = cast<PHINode>(I);
183 // We no longer enter through TIBB, now we come in through NewBB. Revector
184 // exactly one entry in the PHI node that used to come from TIBB to come
185 // from NewBB.
186 int BBIdx = PN->getBasicBlockIndex(TIBB);
187 PN->setIncomingBlock(BBIdx, NewBB);
188 }
189
190 // If there are any other edges from TIBB to DestBB, update those to go
191 // through the split block, making those edges non-critical as well (and
192 // reducing the number of phi entries in the DestBB if relevant).
193 if (MergeIdenticalEdges) {
194 for (unsigned i = SuccNum+1, e = TI->getNumSuccessors(); i != e; ++i) {
195 if (TI->getSuccessor(i) != DestBB) continue;
196
197 // Remove an entry for TIBB from DestBB phi nodes.
198 DestBB->removePredecessor(TIBB);
199
200 // We found another edge to DestBB, go to NewBB instead.
201 TI->setSuccessor(i, NewBB);
202 }
203 }
204
205
206
207 // If we don't have a pass object, we can't update anything...
Dan Gohman9cec4122009-09-08 15:45:00 +0000208 if (P == 0) return NewBB;
Dan Gohmanf17a25c2007-07-18 16:29:46 +0000209
210 // Now update analysis information. Since the only predecessor of NewBB is
211 // the TIBB, TIBB clearly dominates NewBB. TIBB usually doesn't dominate
212 // anything, as there are other successors of DestBB. However, if all other
213 // predecessors of DestBB are already dominated by DestBB (e.g. DestBB is a
214 // loop header) then NewBB dominates DestBB.
215 SmallVector<BasicBlock*, 8> OtherPreds;
216
217 for (pred_iterator I = pred_begin(DestBB), E = pred_end(DestBB); I != E; ++I)
218 if (*I != NewBB)
219 OtherPreds.push_back(*I);
220
221 bool NewBBDominatesDestBB = true;
222
223 // Should we update DominatorTree information?
Duncan Sands4e0d6a72009-01-28 13:14:17 +0000224 if (DominatorTree *DT = P->getAnalysisIfAvailable<DominatorTree>()) {
Dan Gohmanf17a25c2007-07-18 16:29:46 +0000225 DomTreeNode *TINode = DT->getNode(TIBB);
226
227 // The new block is not the immediate dominator for any other nodes, but
228 // TINode is the immediate dominator for the new node.
229 //
230 if (TINode) { // Don't break unreachable code!
231 DomTreeNode *NewBBNode = DT->addNewBlock(NewBB, TIBB);
232 DomTreeNode *DestBBNode = 0;
233
234 // If NewBBDominatesDestBB hasn't been computed yet, do so with DT.
235 if (!OtherPreds.empty()) {
236 DestBBNode = DT->getNode(DestBB);
237 while (!OtherPreds.empty() && NewBBDominatesDestBB) {
238 if (DomTreeNode *OPNode = DT->getNode(OtherPreds.back()))
239 NewBBDominatesDestBB = DT->dominates(DestBBNode, OPNode);
240 OtherPreds.pop_back();
241 }
242 OtherPreds.clear();
243 }
244
245 // If NewBBDominatesDestBB, then NewBB dominates DestBB, otherwise it
246 // doesn't dominate anything.
247 if (NewBBDominatesDestBB) {
248 if (!DestBBNode) DestBBNode = DT->getNode(DestBB);
249 DT->changeImmediateDominator(DestBBNode, NewBBNode);
250 }
251 }
252 }
253
254 // Should we update DominanceFrontier information?
Duncan Sands4e0d6a72009-01-28 13:14:17 +0000255 if (DominanceFrontier *DF = P->getAnalysisIfAvailable<DominanceFrontier>()) {
Dan Gohmanf17a25c2007-07-18 16:29:46 +0000256 // If NewBBDominatesDestBB hasn't been computed yet, do so with DF.
257 if (!OtherPreds.empty()) {
258 // FIXME: IMPLEMENT THIS!
Edwin Törökbd448e32009-07-14 16:55:14 +0000259 llvm_unreachable("Requiring domfrontiers but not idom/domtree/domset."
Edwin Török675d5622009-07-11 20:10:48 +0000260 " not implemented yet!");
Dan Gohmanf17a25c2007-07-18 16:29:46 +0000261 }
262
263 // Since the new block is dominated by its only predecessor TIBB,
264 // it cannot be in any block's dominance frontier. If NewBB dominates
265 // DestBB, its dominance frontier is the same as DestBB's, otherwise it is
266 // just {DestBB}.
267 DominanceFrontier::DomSetType NewDFSet;
268 if (NewBBDominatesDestBB) {
269 DominanceFrontier::iterator I = DF->find(DestBB);
Devang Patel112468c2007-08-13 21:59:17 +0000270 if (I != DF->end()) {
Dan Gohmanf17a25c2007-07-18 16:29:46 +0000271 DF->addBasicBlock(NewBB, I->second);
Owen Anderson0bb12f12008-06-03 18:29:48 +0000272
273 if (I->second.count(DestBB)) {
274 // However NewBB's frontier does not include DestBB.
275 DominanceFrontier::iterator NF = DF->find(NewBB);
276 DF->removeFromFrontier(NF, DestBB);
277 }
Devang Patel112468c2007-08-13 21:59:17 +0000278 }
Dan Gohmanf17a25c2007-07-18 16:29:46 +0000279 else
280 DF->addBasicBlock(NewBB, DominanceFrontier::DomSetType());
281 } else {
282 DominanceFrontier::DomSetType NewDFSet;
283 NewDFSet.insert(DestBB);
284 DF->addBasicBlock(NewBB, NewDFSet);
285 }
286 }
287
288 // Update LoopInfo if it is around.
Duncan Sands4e0d6a72009-01-28 13:14:17 +0000289 if (LoopInfo *LI = P->getAnalysisIfAvailable<LoopInfo>()) {
Dan Gohman9cec4122009-09-08 15:45:00 +0000290 if (Loop *TIL = LI->getLoopFor(TIBB)) {
291 // If one or the other blocks were not in a loop, the new block is not
292 // either, and thus LI doesn't need to be updated.
Dan Gohmanf17a25c2007-07-18 16:29:46 +0000293 if (Loop *DestLoop = LI->getLoopFor(DestBB)) {
294 if (TIL == DestLoop) {
295 // Both in the same loop, the NewBB joins loop.
Owen Andersonca0b9d42007-11-27 03:43:35 +0000296 DestLoop->addBasicBlockToLoop(NewBB, LI->getBase());
Dan Gohmanf17a25c2007-07-18 16:29:46 +0000297 } else if (TIL->contains(DestLoop->getHeader())) {
298 // Edge from an outer loop to an inner loop. Add to the outer loop.
Owen Andersonca0b9d42007-11-27 03:43:35 +0000299 TIL->addBasicBlockToLoop(NewBB, LI->getBase());
Dan Gohmanf17a25c2007-07-18 16:29:46 +0000300 } else if (DestLoop->contains(TIL->getHeader())) {
301 // Edge from an inner loop to an outer loop. Add to the outer loop.
Owen Andersonca0b9d42007-11-27 03:43:35 +0000302 DestLoop->addBasicBlockToLoop(NewBB, LI->getBase());
Dan Gohmanf17a25c2007-07-18 16:29:46 +0000303 } else {
304 // Edge from two loops with no containment relation. Because these
305 // are natural loops, we know that the destination block must be the
306 // header of its loop (adding a branch into a loop elsewhere would
307 // create an irreducible loop).
308 assert(DestLoop->getHeader() == DestBB &&
309 "Should not create irreducible loops!");
310 if (Loop *P = DestLoop->getParentLoop())
Owen Andersonca0b9d42007-11-27 03:43:35 +0000311 P->addBasicBlockToLoop(NewBB, LI->getBase());
Dan Gohmanf17a25c2007-07-18 16:29:46 +0000312 }
313 }
Dan Gohman9cec4122009-09-08 15:45:00 +0000314 // If TIBB is in a loop and DestBB is outside of that loop, split the
315 // other exit blocks of the loop that also have predecessors outside
316 // the loop, to maintain a LoopSimplify guarantee.
317 if (!TIL->contains(DestBB) &&
318 P->mustPreserveAnalysisID(LoopSimplifyID)) {
Dan Gohmanf06a9ba2009-09-09 18:18:18 +0000319 assert(!TIL->contains(NewBB) &&
320 "Split point for loop exit is contained in loop!");
321
322 // Update LCSSA form in the newly created exit block.
323 if (P->mustPreserveAnalysisID(LCSSAID)) {
324 SmallVector<BasicBlock *, 1> OrigPred;
325 OrigPred.push_back(TIBB);
326 CreatePHIsForSplitLoopExit(OrigPred, NewBB, DestBB);
327 }
328
Dan Gohman9cec4122009-09-08 15:45:00 +0000329 // For each unique exit block...
330 SmallVector<BasicBlock *, 4> ExitBlocks;
331 TIL->getExitBlocks(ExitBlocks);
332 for (unsigned i = 0, e = ExitBlocks.size(); i != e; ++i) {
333 // Collect all the preds that are inside the loop, and note
334 // whether there are any preds outside the loop.
335 SmallVector<BasicBlock *, 4> Preds;
Dan Gohmanf06a9ba2009-09-09 18:18:18 +0000336 bool HasPredOutsideOfLoop = false;
Dan Gohman9cec4122009-09-08 15:45:00 +0000337 BasicBlock *Exit = ExitBlocks[i];
338 for (pred_iterator I = pred_begin(Exit), E = pred_end(Exit);
339 I != E; ++I)
340 if (TIL->contains(*I))
341 Preds.push_back(*I);
342 else
Dan Gohmanf06a9ba2009-09-09 18:18:18 +0000343 HasPredOutsideOfLoop = true;
Dan Gohman9cec4122009-09-08 15:45:00 +0000344 // If there are any preds not in the loop, we'll need to split
345 // the edges. The Preds.empty() check is needed because a block
346 // may appear multiple times in the list. We can't use
347 // getUniqueExitBlocks above because that depends on LoopSimplify
348 // form, which we're in the process of restoring!
Dan Gohmanf06a9ba2009-09-09 18:18:18 +0000349 if (!Preds.empty() && HasPredOutsideOfLoop) {
350 BasicBlock *NewExitBB =
351 SplitBlockPredecessors(Exit, Preds.data(), Preds.size(),
352 "split", P);
353 if (P->mustPreserveAnalysisID(LCSSAID))
354 CreatePHIsForSplitLoopExit(Preds, NewExitBB, Exit);
355 }
Dan Gohman9cec4122009-09-08 15:45:00 +0000356 }
357 }
358 // LCSSA form was updated above for the case where LoopSimplify is
359 // available, which means that all predecessors of loop exit blocks
360 // are within the loop. Without LoopSimplify form, it would be
361 // necessary to insert a new phi.
362 assert((!P->mustPreserveAnalysisID(LCSSAID) ||
363 P->mustPreserveAnalysisID(LoopSimplifyID)) &&
364 "SplitCriticalEdge doesn't know how to update LCCSA form "
365 "without LoopSimplify!");
366 }
Dan Gohmanf17a25c2007-07-18 16:29:46 +0000367 }
Dan Gohman9cec4122009-09-08 15:45:00 +0000368
Andreas Neustifterf193e182009-09-09 17:53:39 +0000369 // Update ProfileInfo if it is around.
370 if (ProfileInfo *PI = P->getAnalysisIfAvailable<ProfileInfo>()) {
371 PI->splitEdge(TIBB,DestBB,NewBB,MergeIdenticalEdges);
372 }
373
Dan Gohman9cec4122009-09-08 15:45:00 +0000374 return NewBB;
Dan Gohmanf17a25c2007-07-18 16:29:46 +0000375}