commit 0722a2ba05fbb7f320e3f3cc63f86c97393bdd71
author vapier <vapier> Fri May 12 15:44:11 2006 +0000
committer vapier <vapier> Fri May 12 15:44:11 2006 +0000
tree 9cd9df9fa9a60b8adc05c5e4b73fc8361403e2ae
parent 5ea3f5c72ab028007bf2ebdeb10aa8cb2f6c74fe

as reported by Jane Lv, mmap() returns an unsigned value (MAP_FAILED) upon error, so checking with <= 0 will not work

testcases/kernel/syscalls/writev/writev01.c

diff --git a/testcases/kernel/syscalls/writev/writev01.c b/testcases/kernel/syscalls/writev/writev01.c
index b4f3328..5f48fd0 100644
--- a/testcases/kernel/syscalls/writev/writev01.c
+++ b/testcases/kernel/syscalls/writev/writev01.c
@@ -482,7 +482,7 @@
 
         bad_addr = mmap(0, 1, PROT_NONE,
 			MAP_PRIVATE_EXCEPT_UCLINUX|MAP_ANONYMOUS, 0, 0);
-        if (bad_addr <= 0) {
+        if (bad_addr == MAP_FAILED) {
             printf("mmap failed\n");
         }
         wr_iovec[7].iov_base = bad_addr;

testcases/kernel/syscalls/writev/writev02.c

diff --git a/testcases/kernel/syscalls/writev/writev02.c b/testcases/kernel/syscalls/writev/writev02.c
index 870d83b..c9b7568 100644
--- a/testcases/kernel/syscalls/writev/writev02.c
+++ b/testcases/kernel/syscalls/writev/writev02.c
@@ -261,7 +261,7 @@
 
         bad_addr = mmap(0, 1, PROT_NONE,
 			MAP_PRIVATE_EXCEPT_UCLINUX|MAP_ANONYMOUS, 0, 0);
-        if (bad_addr <= 0) {
+        if (bad_addr == MAP_FAILED) {
             printf("mmap failed\n");
         }
         wr_iovec[0].iov_base = bad_addr;

testcases/kernel/syscalls/writev/writev03.c

diff --git a/testcases/kernel/syscalls/writev/writev03.c b/testcases/kernel/syscalls/writev/writev03.c
index da57730..1d5bc65 100644
--- a/testcases/kernel/syscalls/writev/writev03.c
+++ b/testcases/kernel/syscalls/writev/writev03.c
@@ -309,7 +309,7 @@
 	sprintf(f_name, "%s.%d", name, getpid());
 	
 	bad_addr = mmap(0, 1, PROT_NONE, MAP_PRIVATE|MAP_ANONYMOUS, 0, 0);
-	if (bad_addr <= 0) {
+	if (bad_addr == MAP_FAILED) {
 		tst_brkm(TBROK, cleanup, "mmap failed");
 	}
 	wr_iovec[1].iov_base = bad_addr;

testcases/kernel/syscalls/writev/writev04.c

diff --git a/testcases/kernel/syscalls/writev/writev04.c b/testcases/kernel/syscalls/writev/writev04.c
index aef63c6..496c61d 100644
--- a/testcases/kernel/syscalls/writev/writev04.c
+++ b/testcases/kernel/syscalls/writev/writev04.c
@@ -317,7 +317,7 @@
 	sprintf(f_name, "%s.%d", name, getpid());
 	
         bad_addr = mmap(0, 1, PROT_NONE, MAP_PRIVATE|MAP_ANONYMOUS, 0, 0);
-        if (bad_addr <= 0) {
+        if (bad_addr == MAP_FAILED) {
                 tst_brkm(TBROK, cleanup, "mmap failed");
         }
         wr_iovec[1].iov_base = bad_addr;

testcases/kernel/syscalls/writev/writev05.c

diff --git a/testcases/kernel/syscalls/writev/writev05.c b/testcases/kernel/syscalls/writev/writev05.c
index 8c89834..66b9cbd 100644
--- a/testcases/kernel/syscalls/writev/writev05.c
+++ b/testcases/kernel/syscalls/writev/writev05.c
@@ -246,7 +246,7 @@
 
         bad_addr = mmap(0, 1, PROT_NONE,
 			MAP_PRIVATE_EXCEPT_UCLINUX|MAP_ANONYMOUS, 0, 0);
-        if (bad_addr <= 0) {
+        if (bad_addr == MAP_FAILED) {
             printf("mmap failed\n");
         }
         wr_iovec[0].iov_base = bad_addr;