Remove STD_FUNCTIONAL_TEST
Only small part of the testcases was using STD_FUNCTIONAL_TEST and these
that were actually using it mostly misused the interface or used it only
to disable the tst_rest(TPASS, "sycall passed") message.
The default value was STD_FUNCTION_TEST enabled, so this only removes
code that is not executed in LTP testrun and there should be no
functional changes.
Signed-off-by: Cyril Hrubis <chrubis@suse.cz>
diff --git a/testcases/kernel/syscalls/lseek/lseek06.c b/testcases/kernel/syscalls/lseek/lseek06.c
index 635ea55..8b29172 100644
--- a/testcases/kernel/syscalls/lseek/lseek06.c
+++ b/testcases/kernel/syscalls/lseek/lseek06.c
@@ -117,49 +117,40 @@
continue;
}
/*
- * Perform functional verification if test
- * executed without (-f) option.
+ * Check if the return value from lseek(2)
+ * is equal to the specified OFFSET value.
*/
- if (STD_FUNCTIONAL_TEST) {
- /*
- * Check if the return value from lseek(2)
- * is equal to the specified OFFSET value.
- */
- if (TEST_RETURN != OFFSET) {
- tst_resm(TFAIL, "lseek() returned incorrect "
- "value %ld, expected %d",
- TEST_RETURN, OFFSET);
- continue;
- }
- /*
- * The return value is good, now check data.
- * Read the data byte from this location.
- */
- if (read(fildes, &read_buf, sizeof(read_buf)) < 0) {
- tst_brkm(TFAIL, cleanup, "read() failed "
- "on %s, error=%d", TEMP_FILE, errno);
- } else {
- /*
- * Check if read byte is the expected character.
- * For pos 4 ---> 'e'
- */
- if (read_buf[0] != 'e') {
- tst_resm(TFAIL, "Incorrect data read "
- "from file %s", TEMP_FILE);
- } else {
- tst_resm(TPASS, "Functionality "
- "of lseek() on %s "
- "successful", TEMP_FILE);
- }
- }
+ if (TEST_RETURN != OFFSET) {
+ tst_resm(TFAIL, "lseek() returned incorrect "
+ "value %ld, expected %d",
+ TEST_RETURN, OFFSET);
+ continue;
+ }
+ /*
+ * The return value is good, now check data.
+ * Read the data byte from this location.
+ */
+ if (read(fildes, &read_buf, sizeof(read_buf)) < 0) {
+ tst_brkm(TFAIL, cleanup, "read() failed "
+ "on %s, error=%d", TEMP_FILE, errno);
} else {
- tst_resm(TPASS, "call succeeded");
+ /*
+ * Check if read byte is the expected character.
+ * For pos 4 ---> 'e'
+ */
+ if (read_buf[0] != 'e') {
+ tst_resm(TFAIL, "Incorrect data read "
+ "from file %s", TEMP_FILE);
+ } else {
+ tst_resm(TPASS, "Functionality "
+ "of lseek() on %s "
+ "successful", TEMP_FILE);
+ }
}
}
cleanup();
tst_exit();
-
}
/*