1. My Gentoo system lacks the ip utility, which is required for this
test. So I took care of that issue by integrating this script in with
the `cmdlib.sh' script's exist function.
2. Several variables were either improperly quoted, or incorrectly
used. -eq, -lt, -ne, etc should be used for integers, = and != for
strings.
3. When using ps | {awk,grep}, one must do filter out awk or grep,
respectively, or the script will accidentally grab a false positive
from the output, like so:
gcooper@orangebox ~ $ ps ax | grep ps | egrep -v 'mice|mouse'
21057 pts/4 R+ 0:00 ps ax
21058 pts/4 S+ 0:00 grep --colour=auto ps
4. Block off the rest of the testcases if one of the prerequisite
steps fails to initialize properly.
5. Fix up a build-tree dependent pathname to the smount script in the
fs_bind directory.
The only difference between the patch here and the patch posted on ltp-list is that I applied the more POSIX compliant method of incrementing, suggested in another diff review by Mike F.
Signed-off-by: Garrett Cooper <yanegomi@gmail.com>
3 files changed