Gitiles
Code Review
Sign In
gerrit-public.fairphone.software
/
platform
/
external
/
ltp
/
45e285d46ab47b0ff76c88acb5ba97b0bd5f753d
/
testcases
/
kernel
/
syscalls
/
umount
/
umount02.c
45e285d
Remove useless casts.
by Garrett Cooper
· 14 years ago
344d5c3
Rohit Verma <rohit.170309@gmail.com> reported: I think there is a bug in the source code. In both the cases the string variable "Type" is not null- terminated. This variable ("Type") indicates the filesystem type, which is used later in the code. In the above said lines of code, I can observe that 'strlen(fstype)' is used within strncpy. Now, strlen returns the length of string excluding the null character. Man page of strncpy states that the 'dest' string is null terminated only if it is present in first 'n' bytes of the 'src'. In our case, since strlen returns lenght excluding the null character the string "Type" is not null terminated.
by subrata_modak
· 15 years ago
56207ce
Coding Syle Cleanups. Signed-Off-By: <michal.simek@petalogix.com>.
by subrata_modak
· 16 years ago
bdbaec5
Clean Trailing Tab: Signed-off-by: Michal Simek <monstr@monstr.eu>.
by subrata_modak
· 16 years ago
4bb656a
Clear Trailing Whitespace. Signed-off-by: Michal Simek <monstr@monstr.eu>.
by subrata_modak
· 16 years ago
d13d74b
ugh, dos CRLFs, how i hate you so
by vapier
· 19 years ago
eb275f5
Added umount() tests created by Nirmala Devi Dhanasekar <nirmala.devi@wipro.com>.
by robbiew
· 22 years ago