commit 239e4e87fc830ec2ee3e97b7a7600873af260013
author Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com> Tue Oct 06 21:46:56 2020 -0400
committer Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com> Sat Oct 10 17:15:02 2020 -0400
tree d0affda85c428220c2ed424daa17496c61a0a01b
parent 3943bcec9c81d4848cb2463697c57a86e23e2528

panfrost: Fix Bifrost high LOD clamp

Broke mipmapping.

Fixes: ad0b32cdbd5 ("panfrost: XMLify Bifrost textures")
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7081>

src/panfrost/lib/pan_texture.c

diff --git a/src/panfrost/lib/pan_texture.c b/src/panfrost/lib/pan_texture.c
index 4ea05e0..c65c60b 100644
--- a/src/panfrost/lib/pan_texture.c
+++ b/src/panfrost/lib/pan_texture.c
@@ -405,9 +405,10 @@
                 cfg.levels = last_level - first_level;
                 cfg.surfaces = payload->gpu;
 
-                /* Use the sampler descriptor for LOD clamping */
-                cfg.minimum_lod = 0;
-                cfg.maximum_lod = last_level - first_level;
+                /* We specify API-level LOD clamps in the sampler descriptor
+                 * and use these clamps simply for bounds checking */
+                cfg.minimum_lod = FIXED_16(0, false);
+                cfg.maximum_lod = FIXED_16(cfg.levels, false);
         }
 }