commit 806533ba7ff9d52583d6340b9b2b3c1212d77d79
author Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com> Thu Mar 05 17:49:45 2020 -0500
committer Marge Bot <eric+marge@anholt.net> Sat Mar 07 00:37:39 2020 +0000
tree 11e2285d4a4061d28701ba9331c3a73604c3273d
parent 65c8dcca3b35a482c8378e10bb245a92e2e2bfdf

pan/bi: Fix destination printing

It should get the same treatment as sources to handle SSA/reg/etc.

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4097>

src/panfrost/bifrost/bi_print.c

diff --git a/src/panfrost/bifrost/bi_print.c b/src/panfrost/bifrost/bi_print.c
index 9c9f677..1697fb9 100644
--- a/src/panfrost/bifrost/bi_print.c
+++ b/src/panfrost/bifrost/bi_print.c
@@ -140,6 +140,25 @@
 }
 
 static void
+bi_print_index(FILE *fp, bi_instruction *ins, unsigned index)
+{
+        if (!index)
+                fprintf(fp, "_");
+        else if (index & BIR_INDEX_REGISTER)
+                fprintf(fp, "br%u", index & ~BIR_INDEX_REGISTER);
+        else if (index & BIR_INDEX_UNIFORM)
+                fprintf(fp, "u%u", index & ~BIR_INDEX_UNIFORM);
+        else if (index & BIR_INDEX_CONSTANT)
+                fprintf(fp, "#0x%" PRIx64, ins->constant.u64);
+        else if (index & BIR_INDEX_ZERO)
+                fprintf(fp, "#0");
+        else if (index & BIR_IS_REG)
+                fprintf(fp, "r%u", index >> 1);
+        else
+                fprintf(fp, "%u", (index >> 1) - 1);
+}
+
+static void
 bi_print_src(FILE *fp, bi_instruction *ins, unsigned s)
 {
         unsigned src = ins->src[s];
@@ -153,20 +172,7 @@
         if (abs)
                 fprintf(fp, "abs(");
 
-        if (!src)
-                fprintf(fp, "_");
-        else if (src & BIR_INDEX_REGISTER)
-                fprintf(fp, "br%u", src & ~BIR_INDEX_REGISTER);
-        else if (src & BIR_INDEX_UNIFORM)
-                fprintf(fp, "u%u", src & ~BIR_INDEX_UNIFORM);
-        else if (src & BIR_INDEX_CONSTANT)
-                fprintf(fp, "#0x%" PRIx64, ins->constant.u64);
-        else if (src & BIR_INDEX_ZERO)
-                fprintf(fp, "#0");
-        else if (src & BIR_IS_REG)
-                fprintf(fp, "r%u", src >> 1);
-        else
-                fprintf(fp, "%u", (src >> 1) - 1);
+        bi_print_index(fp, ins, src);
 
         if (abs)
                 fprintf(fp, ")");
@@ -303,12 +309,7 @@
                 fprintf(fp, "%s", bi_round_mode_name(ins->roundmode));
 
         fprintf(fp, " ");
-
-        if (ins->dest)
-                fprintf(fp, "%d", ins->dest);
-        else
-                fprintf(fp, "_");
-
+        bi_print_index(fp, ins, ins->dest);
         fprintf(fp, ", ");
 
         bi_foreach_src(ins, s) {