commit 85053c016c898455434f6264981a2ddd4b60f04e
author Vinson Lee <vlee@freedesktop.org> Thu Oct 15 16:14:16 2020 -0700
committer Vinson Lee <vlee@freedesktop.org> Mon Oct 19 15:48:29 2020 -0700
tree b348c23a9db093b504dd25f1a1228ba204c96ea6
parent 8dd03a7c125f8e7f3d29d0fd131f7129cddb5244

panfrost: Fix stride for AFBC_FORMAT_MOD_BLOCK_SIZE_32x8.

Fix defect reported by Coverity Scan.

Identical code for different branches (IDENTICAL_BRANCHES)
identical_branches: Ternary expression on condition width has
identical then and else expressions: 32. Should one of the
expressions be modified, or the entire ternary expression
replaced?

Fixes: 8bb1d61f276c ("panfrost: Add panfrost_block_dim helper")
Signed-off-by: Vinson Lee <vlee@freedesktop.org>
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Reviewed-by: Daniel Stone <daniels@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7177>

src/panfrost/lib/pan_texture.c

diff --git a/src/panfrost/lib/pan_texture.c b/src/panfrost/lib/pan_texture.c
index 6de8223..c380293 100644
--- a/src/panfrost/lib/pan_texture.c
+++ b/src/panfrost/lib/pan_texture.c
@@ -219,7 +219,7 @@
         case AFBC_FORMAT_MOD_BLOCK_SIZE_16x16:
                 return 16;
         case AFBC_FORMAT_MOD_BLOCK_SIZE_32x8:
-                return width ? 32 : 32;
+                return width ? 32 : 8;
         case AFBC_FORMAT_MOD_BLOCK_SIZE_64x4:
                 return width ? 64 : 4;
         case AFBC_FORMAT_MOD_BLOCK_SIZE_32x8_64x4: