commit be3f9dd26cf59cadc21e4d5cc27dd199c9752b1c
author José Fonseca <jfonseca@vmware.com> Thu Apr 30 13:10:58 2009 +0100
committer Keith Whitwell <keithw@vmware.com> Fri May 08 14:57:27 2009 +0100
tree e7ef76ab8b2e77ad1212ad2ca55322fa436141d1
parent f628d7f5eebe9743f85ea8edf7c09b32cf393e4a

util: Limit the stack walk to avoid referencing undefined memory.

src/gallium/auxiliary/util/u_debug_stack.c

diff --git a/src/gallium/auxiliary/util/u_debug_stack.c b/src/gallium/auxiliary/util/u_debug_stack.c
index e9891fd..528a1c3 100644
--- a/src/gallium/auxiliary/util/u_debug_stack.c
+++ b/src/gallium/auxiliary/util/u_debug_stack.c
@@ -62,6 +62,8 @@
    
 #ifdef PIPE_ARCH_X86
    while(nr_frames) {
+      const void **next_frame_pointer;
+
       if(!frame_pointer)
          break;
       
@@ -72,7 +74,14 @@
          --nr_frames;
       }
       
-      frame_pointer = (const void **)frame_pointer[0];
+      next_frame_pointer = (const void **)frame_pointer[0];
+      
+      /* Limit the stack walk to avoid referencing undefined memory */
+      if((uintptr_t)next_frame_pointer <= (uintptr_t)frame_pointer ||
+         (uintptr_t)next_frame_pointer > (uintptr_t)frame_pointer + 64*1024)
+         break;
+      
+      frame_pointer = next_frame_pointer;
    }
 #endif