commit cf8b14ce6dc8e6c741005fa76cfda046e1618ea4
author Ian Romanick <ian.d.romanick@intel.com> Tue Oct 22 15:07:00 2013 -0700
committer Ian Romanick <ian.d.romanick@intel.com> Tue Oct 22 15:23:30 2013 -0700
tree 2cd3f5994808fce6d7131a21e19627284d1a2978
parent af229c94e357fb4747f108603382168e49b6fd02

glsl: Modify interface to link_invalidate_variable_locations

This will make it easier to unit test this function in successive
patches.  Also, correct the prototype in linker.h.  It was... wrong.

v2: Split the interface change from adding the unit tests.  Suggested by
Paul.

Signed-off-by: Ian Romanick <ian.d.romanick@intel.com>
Reviewed-by: Paul Berry <stereotype441@gmail.com>

src/glsl/linker.cpp

diff --git a/src/glsl/linker.cpp b/src/glsl/linker.cpp
index 0a949b4..bf96d60 100644
--- a/src/glsl/linker.cpp
+++ b/src/glsl/linker.cpp
@@ -366,10 +366,10 @@
 
 
 void
-link_invalidate_variable_locations(gl_shader *sh, int input_base,
+link_invalidate_variable_locations(exec_list *ir, int input_base,
                                    int output_base)
 {
-   foreach_list(node, sh->ir) {
+   foreach_list(node, ir) {
       ir_variable *const var = ((ir_instruction *) node)->as_variable();
 
       if (var == NULL)
@@ -2217,17 +2217,17 @@
    /* Mark all generic shader inputs and outputs as unpaired. */
    if (prog->_LinkedShaders[MESA_SHADER_VERTEX] != NULL) {
       link_invalidate_variable_locations(
-            prog->_LinkedShaders[MESA_SHADER_VERTEX],
+            prog->_LinkedShaders[MESA_SHADER_VERTEX]->ir,
             VERT_ATTRIB_GENERIC0, VARYING_SLOT_VAR0);
    }
    if (prog->_LinkedShaders[MESA_SHADER_GEOMETRY] != NULL) {
       link_invalidate_variable_locations(
-            prog->_LinkedShaders[MESA_SHADER_GEOMETRY],
+            prog->_LinkedShaders[MESA_SHADER_GEOMETRY]->ir,
             VARYING_SLOT_VAR0, VARYING_SLOT_VAR0);
    }
    if (prog->_LinkedShaders[MESA_SHADER_FRAGMENT] != NULL) {
       link_invalidate_variable_locations(
-            prog->_LinkedShaders[MESA_SHADER_FRAGMENT],
+            prog->_LinkedShaders[MESA_SHADER_FRAGMENT]->ir,
             VARYING_SLOT_VAR0, FRAG_RESULT_DATA0);
    }