commit f4314d06e8b7ac2ecd0adf67a885f9af84dcf557
author Jason Ekstrand <jason.ekstrand@intel.com> Tue Jul 26 11:47:05 2016 -0700
committer Jason Ekstrand <jason.ekstrand@intel.com> Mon Aug 29 12:17:34 2016 -0700
tree 0a7eeab79a8f28b3727d4027ae5fa3e38e402ea7
parent 87214414fd584aac80bb88f337ba119cac5109f3

isl/state: Add some asserts about format capabilities

This keeps invalid surface states from leaking through and potentially
hanging the GPU.  We shouldn't actually be hitting this on a regular basis,
but a helpful assert is better than a hang.

Signed-off-by: Jason Ekstrand <jason@jlekstrand.net>
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
Reviewed-by: Anuj Phogat <anuj.phogat@gmail.com>

src/intel/isl/isl_surface_state.c

diff --git a/src/intel/isl/isl_surface_state.c b/src/intel/isl/isl_surface_state.c
index 4a7e921..979e140 100644
--- a/src/intel/isl/isl_surface_state.c
+++ b/src/intel/isl/isl_surface_state.c
@@ -210,6 +210,11 @@
    struct GENX(RENDER_SURFACE_STATE) s = { 0 };
 
    s.SurfaceType = get_surftype(info->surf->dim, info->view->usage);
+
+   if (info->view->usage & ISL_SURF_USAGE_RENDER_TARGET_BIT)
+      assert(isl_format_supports_rendering(dev->info, info->view->format));
+   else if (info->view->usage & ISL_SURF_USAGE_TEXTURE_BIT)
+      assert(isl_format_supports_sampling(dev->info, info->view->format));
    s.SurfaceFormat = info->view->format;
 
 #if GEN_IS_HASWELL