Jorge Lucangeli Obes | 106d97f | 2016-08-19 12:34:02 -0400 | [diff] [blame] | 1 | // syscall_filter_unittest.cpp |
| 2 | // Copyright (C) 2016 The Android Open Source Project |
| 3 | // |
| 4 | // Licensed under the Apache License, Version 2.0 (the "License"); |
| 5 | // you may not use this file except in compliance with the License. |
| 6 | // You may obtain a copy of the License at |
| 7 | // |
| 8 | // http://www.apache.org/licenses/LICENSE-2.0 |
| 9 | // |
| 10 | // Unless required by applicable law or agreed to in writing, software |
| 11 | // distributed under the License is distributed on an "AS IS" BASIS, |
| 12 | // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 13 | // See the License for the specific language governing permissions and |
| 14 | // limitations under the License. |
| 15 | // |
| 16 | // Test syscall filtering using gtest. |
| 17 | |
| 18 | #include <asm/unistd.h> |
| 19 | #include <errno.h> |
| 20 | #include <fcntl.h> /* For O_WRONLY. */ |
| 21 | |
| 22 | #include <gtest/gtest.h> |
| 23 | |
| 24 | #include "bpf.h" |
| 25 | #include "syscall_filter.h" |
| 26 | #include "syscall_filter_unittest_macros.h" |
| 27 | #include "util.h" |
| 28 | |
| 29 | /* Test that setting one BPF instruction works. */ |
| 30 | TEST(bpf, set_bpf_instr) { |
| 31 | struct sock_filter instr; |
| 32 | unsigned char code = BPF_LD + BPF_W + BPF_ABS; |
| 33 | unsigned int k = 4; |
| 34 | unsigned char jt = 1, jf = 2; |
| 35 | |
| 36 | size_t len = set_bpf_instr(&instr, code, k, jt, jf); |
| 37 | |
| 38 | EXPECT_EQ(len, 1U); |
| 39 | EXPECT_EQ_BLOCK(&instr, code, k, jt, jf); |
| 40 | } |
| 41 | |
| 42 | TEST(bpf, bpf_load_arg) { |
| 43 | struct sock_filter load_arg[BPF_LOAD_ARG_LEN]; |
| 44 | int argidx = 1; |
| 45 | size_t len = bpf_load_arg(load_arg, argidx); |
| 46 | |
| 47 | EXPECT_EQ(len, BPF_LOAD_ARG_LEN); |
| 48 | |
| 49 | #if defined(BITS32) |
| 50 | EXPECT_EQ_STMT(&load_arg[0], BPF_LD + BPF_W + BPF_ABS, LO_ARG(argidx)); |
| 51 | #elif defined(BITS64) |
| 52 | EXPECT_EQ_STMT(&load_arg[0], BPF_LD + BPF_W + BPF_ABS, LO_ARG(argidx)); |
| 53 | EXPECT_EQ_STMT(&load_arg[1], BPF_ST, 0); |
| 54 | EXPECT_EQ_STMT(&load_arg[2], BPF_LD + BPF_W + BPF_ABS, HI_ARG(argidx)); |
| 55 | EXPECT_EQ_STMT(&load_arg[3], BPF_ST, 1); |
| 56 | #endif |
| 57 | } |
| 58 | |
| 59 | TEST(bpf, bpf_comp_jeq) { |
| 60 | struct sock_filter comp_jeq[BPF_COMP_LEN]; |
| 61 | unsigned long c = 1; |
| 62 | unsigned char jt = 1; |
| 63 | unsigned char jf = 2; |
| 64 | |
| 65 | size_t len = bpf_comp_jeq(comp_jeq, c, jt, jf); |
| 66 | |
| 67 | EXPECT_EQ(len, BPF_COMP_LEN); |
| 68 | |
| 69 | #if defined(BITS32) |
| 70 | EXPECT_EQ_BLOCK(&comp_jeq[0], BPF_JMP + BPF_JEQ + BPF_K, c, jt, jf); |
| 71 | #elif defined(BITS64) |
| 72 | EXPECT_EQ_BLOCK(&comp_jeq[0], BPF_JMP + BPF_JEQ + BPF_K, 0, 0, jf + 2); |
| 73 | EXPECT_EQ_STMT(&comp_jeq[1], BPF_LD + BPF_MEM, 0); |
| 74 | EXPECT_EQ_BLOCK(&comp_jeq[2], BPF_JMP + BPF_JEQ + BPF_K, c, jt, jf); |
| 75 | #endif |
| 76 | } |
| 77 | |
| 78 | TEST(bpf, bpf_comp_jset) { |
| 79 | struct sock_filter comp_jset[BPF_COMP_LEN]; |
Jorge Lucangeli Obes | fd6f8e3 | 2016-10-12 11:19:28 -0400 | [diff] [blame] | 80 | unsigned long mask = (1UL << (sizeof(unsigned long) * 8 - 1)) | O_WRONLY; |
Jorge Lucangeli Obes | 106d97f | 2016-08-19 12:34:02 -0400 | [diff] [blame] | 81 | unsigned char jt = 1; |
| 82 | unsigned char jf = 2; |
| 83 | |
| 84 | size_t len = bpf_comp_jset(comp_jset, mask, jt, jf); |
| 85 | |
| 86 | EXPECT_EQ(len, BPF_COMP_LEN); |
| 87 | |
| 88 | #if defined(BITS32) |
| 89 | EXPECT_EQ_BLOCK(&comp_jset[0], BPF_JMP + BPF_JSET + BPF_K, mask, jt, jf); |
| 90 | #elif defined(BITS64) |
Jorge Lucangeli Obes | fd6f8e3 | 2016-10-12 11:19:28 -0400 | [diff] [blame] | 91 | EXPECT_EQ_BLOCK( |
| 92 | &comp_jset[0], BPF_JMP + BPF_JSET + BPF_K, 0x80000000, jt + 2, 0); |
Jorge Lucangeli Obes | 106d97f | 2016-08-19 12:34:02 -0400 | [diff] [blame] | 93 | EXPECT_EQ_STMT(&comp_jset[1], BPF_LD + BPF_MEM, 0); |
Jorge Lucangeli Obes | fd6f8e3 | 2016-10-12 11:19:28 -0400 | [diff] [blame] | 94 | EXPECT_EQ_BLOCK(&comp_jset[2], BPF_JMP + BPF_JSET + BPF_K, O_WRONLY, jt, jf); |
| 95 | #endif |
| 96 | } |
| 97 | |
| 98 | TEST(bpf, bpf_comp_jin) { |
| 99 | struct sock_filter comp_jin[BPF_COMP_LEN]; |
| 100 | unsigned long mask = (1UL << (sizeof(unsigned long) * 8 - 1)) | O_WRONLY; |
| 101 | unsigned char jt = 10; |
| 102 | unsigned char jf = 20; |
| 103 | |
| 104 | size_t len = bpf_comp_jin(comp_jin, mask, jt, jf); |
| 105 | |
| 106 | EXPECT_EQ(len, BPF_COMP_LEN); |
| 107 | |
| 108 | #if defined(BITS32) |
| 109 | EXPECT_EQ_BLOCK(&comp_jin[0], BPF_JMP + BPF_JSET + BPF_K, ~mask, jf, jt); |
| 110 | #elif defined(BITS64) |
| 111 | EXPECT_EQ_BLOCK( |
| 112 | &comp_jin[0], BPF_JMP + BPF_JSET + BPF_K, 0x7FFFFFFF, jf + 2, 0); |
| 113 | EXPECT_EQ_STMT(&comp_jin[1], BPF_LD + BPF_MEM, 0); |
| 114 | EXPECT_EQ_BLOCK(&comp_jin[2], BPF_JMP + BPF_JSET + BPF_K, ~O_WRONLY, jf, jt); |
Jorge Lucangeli Obes | 106d97f | 2016-08-19 12:34:02 -0400 | [diff] [blame] | 115 | #endif |
| 116 | } |
| 117 | |
| 118 | TEST(bpf, bpf_arg_comp) { |
| 119 | struct sock_filter *arg_comp; |
| 120 | int op = EQ; |
| 121 | int argidx = 1; |
| 122 | unsigned long c = 3; |
| 123 | unsigned int label_id = 0; |
| 124 | |
| 125 | size_t len = bpf_arg_comp(&arg_comp, op, argidx, c, label_id); |
| 126 | |
| 127 | EXPECT_EQ(len, BPF_ARG_COMP_LEN + 1); |
| 128 | |
| 129 | #if defined(BITS32) |
| 130 | EXPECT_EQ_STMT(&arg_comp[0], BPF_LD + BPF_W + BPF_ABS, LO_ARG(argidx)); |
| 131 | EXPECT_EQ_BLOCK(&arg_comp[1], BPF_JMP + BPF_JEQ + BPF_K, c, 1, 0); |
| 132 | EXPECT_JUMP_LBL(&arg_comp[2]); |
| 133 | #elif defined(BITS64) |
| 134 | EXPECT_EQ_STMT(&arg_comp[0], BPF_LD + BPF_W + BPF_ABS, LO_ARG(argidx)); |
| 135 | EXPECT_EQ_STMT(&arg_comp[1], BPF_ST, 0); |
| 136 | EXPECT_EQ_STMT(&arg_comp[2], BPF_LD + BPF_W + BPF_ABS, HI_ARG(argidx)); |
| 137 | EXPECT_EQ_STMT(&arg_comp[3], BPF_ST, 1); |
| 138 | |
| 139 | EXPECT_EQ_BLOCK(&arg_comp[4], BPF_JMP + BPF_JEQ + BPF_K, 0, 0, 2); |
| 140 | EXPECT_EQ_STMT(&arg_comp[5], BPF_LD + BPF_MEM, 0); |
| 141 | EXPECT_EQ_BLOCK(&arg_comp[6], BPF_JMP + BPF_JEQ + BPF_K, c, 1, 0); |
| 142 | EXPECT_JUMP_LBL(&arg_comp[7]); |
| 143 | #endif |
| 144 | free(arg_comp); |
| 145 | } |
| 146 | |
| 147 | TEST(bpf, bpf_validate_arch) { |
| 148 | struct sock_filter validate_arch[ARCH_VALIDATION_LEN]; |
| 149 | |
| 150 | size_t len = bpf_validate_arch(validate_arch); |
| 151 | |
| 152 | EXPECT_EQ(len, ARCH_VALIDATION_LEN); |
| 153 | EXPECT_ARCH_VALIDATION(validate_arch); |
| 154 | } |
| 155 | |
| 156 | TEST(bpf, bpf_allow_syscall) { |
| 157 | struct sock_filter allow_syscall[ALLOW_SYSCALL_LEN]; |
| 158 | int nr = 1; |
| 159 | |
| 160 | size_t len = bpf_allow_syscall(allow_syscall, nr); |
| 161 | |
| 162 | EXPECT_EQ(len, ALLOW_SYSCALL_LEN); |
| 163 | EXPECT_ALLOW_SYSCALL(allow_syscall, nr); |
| 164 | } |
| 165 | |
| 166 | TEST(bpf, bpf_allow_syscall_args) { |
| 167 | struct sock_filter allow_syscall[ALLOW_SYSCALL_LEN]; |
| 168 | int nr = 1; |
| 169 | unsigned int id = 1024; |
| 170 | |
| 171 | size_t len = bpf_allow_syscall_args(allow_syscall, nr, id); |
| 172 | |
| 173 | EXPECT_EQ(len, ALLOW_SYSCALL_LEN); |
| 174 | EXPECT_ALLOW_SYSCALL_ARGS(allow_syscall, nr, id, JUMP_JT, JUMP_JF); |
| 175 | } |
| 176 | |
Jorge Lucangeli Obes | 8cc9d4a | 2016-10-03 10:00:57 -0400 | [diff] [blame] | 177 | class BpfLabelTest : public ::testing::Test { |
| 178 | protected: |
| 179 | virtual void TearDown() { free_label_strings(&labels_); } |
| 180 | struct bpf_labels labels_; |
| 181 | }; |
| 182 | |
| 183 | TEST_F(BpfLabelTest, zero_length_filter) { |
| 184 | int res = bpf_resolve_jumps(&labels_, NULL, 0); |
| 185 | |
| 186 | EXPECT_EQ(res, 0); |
| 187 | EXPECT_EQ(labels_.count, 0U); |
| 188 | } |
| 189 | |
| 190 | TEST_F(BpfLabelTest, single_label) { |
| 191 | struct sock_filter test_label[1]; |
| 192 | |
| 193 | int id = bpf_label_id(&labels_, "test"); |
| 194 | set_bpf_lbl(test_label, id); |
| 195 | int res = bpf_resolve_jumps(&labels_, test_label, 1); |
| 196 | |
| 197 | EXPECT_EQ(res, 0); |
| 198 | EXPECT_EQ(labels_.count, 1U); |
| 199 | } |
| 200 | |
| 201 | TEST_F(BpfLabelTest, repeated_label) { |
| 202 | struct sock_filter test_label[2]; |
| 203 | |
| 204 | int id = bpf_label_id(&labels_, "test"); |
| 205 | set_bpf_lbl(&test_label[0], id); |
| 206 | set_bpf_lbl(&test_label[1], id); |
| 207 | int res = bpf_resolve_jumps(&labels_, test_label, 2); |
| 208 | |
| 209 | EXPECT_EQ(res, -1); |
| 210 | } |
| 211 | |
| 212 | TEST_F(BpfLabelTest, jump_with_no_label) { |
| 213 | struct sock_filter test_jump[1]; |
| 214 | |
| 215 | set_bpf_jump_lbl(test_jump, 14831); |
| 216 | int res = bpf_resolve_jumps(&labels_, test_jump, 1); |
| 217 | |
| 218 | EXPECT_EQ(res, -1); |
| 219 | } |
| 220 | |
| 221 | TEST_F(BpfLabelTest, jump_to_valid_label) { |
| 222 | struct sock_filter test_jump[2]; |
| 223 | |
| 224 | int id = bpf_label_id(&labels_, "test"); |
| 225 | set_bpf_jump_lbl(&test_jump[0], id); |
| 226 | set_bpf_lbl(&test_jump[1], id); |
| 227 | |
| 228 | int res = bpf_resolve_jumps(&labels_, test_jump, 2); |
| 229 | EXPECT_EQ(res, 0); |
| 230 | EXPECT_EQ(labels_.count, 1U); |
| 231 | } |
| 232 | |
| 233 | TEST_F(BpfLabelTest, jump_to_invalid_label) { |
| 234 | struct sock_filter test_jump[2]; |
| 235 | |
| 236 | int id = bpf_label_id(&labels_, "test"); |
| 237 | set_bpf_jump_lbl(&test_jump[0], id + 1); |
| 238 | set_bpf_lbl(&test_jump[1], id); |
| 239 | |
| 240 | int res = bpf_resolve_jumps(&labels_, test_jump, 2); |
| 241 | EXPECT_EQ(res, -1); |
| 242 | } |
| 243 | |
| 244 | TEST_F(BpfLabelTest, jump_to_unresolved_label) { |
| 245 | struct sock_filter test_jump[2]; |
| 246 | |
| 247 | int id = bpf_label_id(&labels_, "test"); |
| 248 | /* Notice the order of the instructions is reversed. */ |
| 249 | set_bpf_lbl(&test_jump[0], id); |
| 250 | set_bpf_jump_lbl(&test_jump[1], id); |
| 251 | |
| 252 | int res = bpf_resolve_jumps(&labels_, test_jump, 2); |
| 253 | EXPECT_EQ(res, -1); |
| 254 | } |
| 255 | |
| 256 | TEST_F(BpfLabelTest, too_many_labels) { |
| 257 | unsigned int i; |
| 258 | char label[20]; |
| 259 | |
| 260 | for (i = 0; i < BPF_LABELS_MAX; i++) { |
| 261 | snprintf(label, 20, "test%u", i); |
| 262 | (void) bpf_label_id(&labels_, label); |
| 263 | } |
| 264 | int id = bpf_label_id(&labels_, "test"); |
| 265 | |
| 266 | /* Insertion failed... */ |
| 267 | EXPECT_EQ(id, -1); |
| 268 | /* ... because the label lookup table is full. */ |
| 269 | EXPECT_EQ(labels_.count, BPF_LABELS_MAX); |
| 270 | } |
| 271 | |
Jorge Lucangeli Obes | 106d97f | 2016-08-19 12:34:02 -0400 | [diff] [blame] | 272 | class ArgFilterTest : public ::testing::Test { |
| 273 | protected: |
| 274 | virtual void TearDown() { free_label_strings(&labels_); } |
| 275 | struct bpf_labels labels_; |
| 276 | }; |
| 277 | |
| 278 | TEST_F(ArgFilterTest, arg0_equals) { |
| 279 | const char *fragment = "arg0 == 0"; |
| 280 | int nr = 1; |
| 281 | unsigned int id = 0; |
| 282 | struct filter_block *block = |
| 283 | compile_section(nr, fragment, id, &labels_, NO_LOGGING); |
| 284 | |
| 285 | ASSERT_TRUE(block != NULL); |
| 286 | size_t exp_total_len = 1 + (BPF_ARG_COMP_LEN + 1) + 2 + 1 + 2; |
| 287 | EXPECT_EQ(block->total_len, exp_total_len); |
| 288 | |
| 289 | /* First block is a label. */ |
| 290 | struct filter_block *curr_block = block; |
| 291 | ASSERT_TRUE(curr_block != NULL); |
| 292 | EXPECT_EQ(block->len, 1U); |
| 293 | EXPECT_LBL(curr_block->instrs); |
| 294 | |
| 295 | /* Second block is a comparison. */ |
| 296 | curr_block = block->next; |
| 297 | EXPECT_COMP(curr_block); |
| 298 | |
| 299 | /* Third block is a jump and a label (end of AND group). */ |
| 300 | curr_block = curr_block->next; |
| 301 | ASSERT_TRUE(curr_block != NULL); |
| 302 | EXPECT_GROUP_END(curr_block); |
| 303 | |
| 304 | /* Fourth block is SECCOMP_RET_KILL. */ |
| 305 | curr_block = curr_block->next; |
| 306 | ASSERT_TRUE(curr_block != NULL); |
| 307 | EXPECT_KILL(curr_block); |
| 308 | |
| 309 | /* Fifth block is "SUCCESS" label and SECCOMP_RET_ALLOW. */ |
| 310 | curr_block = curr_block->next; |
| 311 | ASSERT_TRUE(curr_block != NULL); |
| 312 | EXPECT_ALLOW(curr_block); |
| 313 | |
| 314 | EXPECT_TRUE(curr_block->next == NULL); |
| 315 | |
| 316 | free_block_list(block); |
| 317 | } |
| 318 | |
| 319 | TEST_F(ArgFilterTest, arg0_mask) { |
| 320 | const char *fragment = "arg1 & O_RDWR"; |
| 321 | int nr = 1; |
| 322 | unsigned int id = 0; |
| 323 | struct filter_block *block = |
| 324 | compile_section(nr, fragment, id, &labels_, NO_LOGGING); |
| 325 | |
| 326 | ASSERT_TRUE(block != NULL); |
| 327 | size_t exp_total_len = 1 + (BPF_ARG_COMP_LEN + 1) + 2 + 1 + 2; |
| 328 | EXPECT_EQ(block->total_len, exp_total_len); |
| 329 | |
| 330 | /* First block is a label. */ |
| 331 | struct filter_block *curr_block = block; |
| 332 | ASSERT_TRUE(curr_block != NULL); |
| 333 | EXPECT_EQ(block->len, 1U); |
| 334 | EXPECT_LBL(curr_block->instrs); |
| 335 | |
| 336 | /* Second block is a comparison. */ |
| 337 | curr_block = block->next; |
| 338 | EXPECT_COMP(curr_block); |
| 339 | |
| 340 | /* Third block is a jump and a label (end of AND group). */ |
| 341 | curr_block = curr_block->next; |
| 342 | ASSERT_TRUE(curr_block != NULL); |
| 343 | EXPECT_GROUP_END(curr_block); |
| 344 | |
| 345 | /* Fourth block is SECCOMP_RET_KILL. */ |
| 346 | curr_block = curr_block->next; |
| 347 | ASSERT_TRUE(curr_block != NULL); |
| 348 | EXPECT_KILL(curr_block); |
| 349 | |
| 350 | /* Fifth block is "SUCCESS" label and SECCOMP_RET_ALLOW. */ |
| 351 | curr_block = curr_block->next; |
| 352 | ASSERT_TRUE(curr_block != NULL); |
| 353 | EXPECT_ALLOW(curr_block); |
| 354 | |
| 355 | EXPECT_TRUE(curr_block->next == NULL); |
| 356 | |
| 357 | free_block_list(block); |
| 358 | } |
| 359 | |
Jorge Lucangeli Obes | fd6f8e3 | 2016-10-12 11:19:28 -0400 | [diff] [blame] | 360 | TEST_F(ArgFilterTest, arg0_flag_set_inclusion) { |
| 361 | const char *fragment = "arg0 in O_RDONLY|O_CREAT"; |
| 362 | int nr = 1; |
| 363 | unsigned int id = 0; |
| 364 | struct filter_block *block = |
| 365 | compile_section(nr, fragment, id, &labels_, NO_LOGGING); |
| 366 | |
| 367 | ASSERT_NE(block, nullptr); |
| 368 | size_t exp_total_len = 1 + (BPF_ARG_COMP_LEN + 1) + 2 + 1 + 2; |
| 369 | EXPECT_EQ(block->total_len, exp_total_len); |
| 370 | |
| 371 | /* First block is a label. */ |
| 372 | struct filter_block *curr_block = block; |
| 373 | ASSERT_NE(curr_block, nullptr); |
| 374 | EXPECT_EQ(block->len, 1U); |
| 375 | EXPECT_LBL(curr_block->instrs); |
| 376 | |
| 377 | /* Second block is a comparison. */ |
| 378 | curr_block = block->next; |
| 379 | ASSERT_NE(curr_block, nullptr); |
| 380 | EXPECT_COMP(curr_block); |
| 381 | |
| 382 | /* Third block is a jump and a label (end of AND group). */ |
| 383 | curr_block = curr_block->next; |
| 384 | ASSERT_NE(curr_block, nullptr); |
| 385 | EXPECT_GROUP_END(curr_block); |
| 386 | |
| 387 | /* Fourth block is SECCOMP_RET_KILL. */ |
| 388 | curr_block = curr_block->next; |
| 389 | ASSERT_NE(curr_block, nullptr); |
| 390 | EXPECT_KILL(curr_block); |
| 391 | |
| 392 | /* Fifth block is "SUCCESS" label and SECCOMP_RET_ALLOW. */ |
| 393 | curr_block = curr_block->next; |
| 394 | ASSERT_NE(curr_block, nullptr); |
| 395 | EXPECT_ALLOW(curr_block); |
| 396 | |
| 397 | EXPECT_EQ(curr_block->next, nullptr); |
| 398 | |
| 399 | free_block_list(block); |
| 400 | } |
| 401 | |
Jorge Lucangeli Obes | 106d97f | 2016-08-19 12:34:02 -0400 | [diff] [blame] | 402 | TEST_F(ArgFilterTest, arg0_eq_mask) { |
| 403 | const char *fragment = "arg1 == O_WRONLY|O_CREAT"; |
| 404 | int nr = 1; |
| 405 | unsigned int id = 0; |
| 406 | |
| 407 | struct filter_block *block = |
| 408 | compile_section(nr, fragment, id, &labels_, NO_LOGGING); |
| 409 | |
| 410 | ASSERT_TRUE(block != NULL); |
| 411 | size_t exp_total_len = 1 + (BPF_ARG_COMP_LEN + 1) + 2 + 1 + 2; |
| 412 | EXPECT_EQ(block->total_len, exp_total_len); |
| 413 | |
| 414 | /* First block is a label. */ |
| 415 | struct filter_block *curr_block = block; |
| 416 | ASSERT_TRUE(curr_block != NULL); |
| 417 | EXPECT_EQ(block->len, 1U); |
| 418 | EXPECT_LBL(curr_block->instrs); |
| 419 | |
| 420 | /* Second block is a comparison. */ |
| 421 | curr_block = block->next; |
| 422 | ASSERT_TRUE(curr_block != NULL); |
| 423 | EXPECT_COMP(curr_block); |
| 424 | EXPECT_EQ(curr_block->instrs[BPF_ARG_COMP_LEN - 1].k, |
| 425 | (unsigned int)(O_WRONLY | O_CREAT)); |
| 426 | |
| 427 | /* Third block is a jump and a label (end of AND group). */ |
| 428 | curr_block = curr_block->next; |
| 429 | ASSERT_TRUE(curr_block != NULL); |
| 430 | EXPECT_GROUP_END(curr_block); |
| 431 | |
| 432 | /* Fourth block is SECCOMP_RET_KILL. */ |
| 433 | curr_block = curr_block->next; |
| 434 | ASSERT_TRUE(curr_block != NULL); |
| 435 | EXPECT_KILL(curr_block); |
| 436 | |
| 437 | /* Fifth block is "SUCCESS" label and SECCOMP_RET_ALLOW. */ |
| 438 | curr_block = curr_block->next; |
| 439 | ASSERT_TRUE(curr_block != NULL); |
| 440 | EXPECT_ALLOW(curr_block); |
| 441 | |
| 442 | EXPECT_TRUE(curr_block->next == NULL); |
| 443 | |
| 444 | free_block_list(block); |
| 445 | } |
| 446 | |
| 447 | TEST_F(ArgFilterTest, and_or) { |
| 448 | const char *fragment = "arg0 == 0 && arg1 == 0 || arg0 == 1"; |
| 449 | int nr = 1; |
| 450 | unsigned int id = 0; |
| 451 | |
| 452 | struct filter_block *block = |
| 453 | compile_section(nr, fragment, id, &labels_, NO_LOGGING); |
| 454 | ASSERT_TRUE(block != NULL); |
| 455 | size_t exp_total_len = 1 + 3 * (BPF_ARG_COMP_LEN + 1) + 2 + 2 + 1 + 2; |
| 456 | EXPECT_EQ(block->total_len, exp_total_len); |
| 457 | |
| 458 | /* First block is a label. */ |
| 459 | struct filter_block *curr_block = block; |
| 460 | ASSERT_TRUE(curr_block != NULL); |
| 461 | EXPECT_EQ(block->len, 1U); |
| 462 | EXPECT_LBL(curr_block->instrs); |
| 463 | |
| 464 | /* Second block is a comparison ("arg0 == 0"). */ |
| 465 | curr_block = curr_block->next; |
| 466 | ASSERT_TRUE(curr_block != NULL); |
| 467 | EXPECT_COMP(curr_block); |
| 468 | |
| 469 | /* Third block is a comparison ("arg1 == 0"). */ |
| 470 | curr_block = curr_block->next; |
| 471 | ASSERT_TRUE(curr_block != NULL); |
| 472 | EXPECT_COMP(curr_block); |
| 473 | |
| 474 | /* Fourth block is a jump and a label (end of AND group). */ |
| 475 | curr_block = curr_block->next; |
| 476 | ASSERT_TRUE(curr_block != NULL); |
| 477 | EXPECT_GROUP_END(curr_block); |
| 478 | |
| 479 | /* Fifth block is a comparison ("arg0 == 1"). */ |
| 480 | curr_block = curr_block->next; |
| 481 | ASSERT_TRUE(curr_block != NULL); |
| 482 | EXPECT_COMP(curr_block); |
| 483 | |
| 484 | /* Sixth block is a jump and a label (end of AND group). */ |
| 485 | curr_block = curr_block->next; |
| 486 | ASSERT_TRUE(curr_block != NULL); |
| 487 | EXPECT_GROUP_END(curr_block); |
| 488 | |
| 489 | /* Seventh block is SECCOMP_RET_KILL. */ |
| 490 | curr_block = curr_block->next; |
| 491 | ASSERT_TRUE(curr_block != NULL); |
| 492 | EXPECT_KILL(curr_block); |
| 493 | |
| 494 | /* Eigth block is "SUCCESS" label and SECCOMP_RET_ALLOW. */ |
| 495 | curr_block = curr_block->next; |
| 496 | ASSERT_TRUE(curr_block != NULL); |
| 497 | EXPECT_ALLOW(curr_block); |
| 498 | |
| 499 | EXPECT_TRUE(curr_block->next == NULL); |
| 500 | |
| 501 | free_block_list(block); |
| 502 | } |
| 503 | |
| 504 | TEST_F(ArgFilterTest, ret_errno) { |
| 505 | const char *fragment = "arg0 == 0 || arg0 == 1; return 1"; |
| 506 | int nr = 1; |
| 507 | unsigned int id = 0; |
| 508 | |
| 509 | struct filter_block *block = |
| 510 | compile_section(nr, fragment, id, &labels_, NO_LOGGING); |
| 511 | ASSERT_TRUE(block != NULL); |
| 512 | size_t exp_total_len = 1 + 2 * (BPF_ARG_COMP_LEN + 1) + 2 + 2 + 1 + 2; |
| 513 | EXPECT_EQ(block->total_len, exp_total_len); |
| 514 | |
| 515 | /* First block is a label. */ |
| 516 | struct filter_block *curr_block = block; |
| 517 | ASSERT_TRUE(curr_block != NULL); |
| 518 | EXPECT_EQ(block->len, 1U); |
| 519 | EXPECT_LBL(curr_block->instrs); |
| 520 | |
| 521 | /* Second block is a comparison ("arg0 == 0"). */ |
| 522 | curr_block = curr_block->next; |
| 523 | ASSERT_TRUE(curr_block != NULL); |
| 524 | EXPECT_COMP(curr_block); |
| 525 | |
| 526 | /* Third block is a jump and a label (end of AND group). */ |
| 527 | curr_block = curr_block->next; |
| 528 | ASSERT_TRUE(curr_block != NULL); |
| 529 | EXPECT_GROUP_END(curr_block); |
| 530 | |
| 531 | /* Fourth block is a comparison ("arg0 == 1"). */ |
| 532 | curr_block = curr_block->next; |
| 533 | ASSERT_TRUE(curr_block != NULL); |
| 534 | EXPECT_COMP(curr_block); |
| 535 | |
| 536 | /* Fifth block is a jump and a label (end of AND group). */ |
| 537 | curr_block = curr_block->next; |
| 538 | ASSERT_TRUE(curr_block != NULL); |
| 539 | EXPECT_GROUP_END(curr_block); |
| 540 | |
| 541 | /* Sixth block is SECCOMP_RET_ERRNO. */ |
| 542 | curr_block = curr_block->next; |
| 543 | ASSERT_TRUE(curr_block != NULL); |
| 544 | EXPECT_EQ(curr_block->len, 1U); |
| 545 | EXPECT_EQ_STMT(curr_block->instrs, |
| 546 | BPF_RET + BPF_K, |
| 547 | SECCOMP_RET_ERRNO | (1 & SECCOMP_RET_DATA)); |
| 548 | |
| 549 | /* Seventh block is "SUCCESS" label and SECCOMP_RET_ALLOW. */ |
| 550 | curr_block = curr_block->next; |
| 551 | ASSERT_TRUE(curr_block != NULL); |
| 552 | EXPECT_ALLOW(curr_block); |
| 553 | |
| 554 | EXPECT_TRUE(curr_block->next == NULL); |
| 555 | |
| 556 | free_block_list(block); |
| 557 | } |
| 558 | |
| 559 | TEST_F(ArgFilterTest, unconditional_errno) { |
| 560 | const char *fragment = "return 1"; |
| 561 | int nr = 1; |
| 562 | unsigned int id = 0; |
| 563 | |
| 564 | struct filter_block *block = |
| 565 | compile_section(nr, fragment, id, &labels_, NO_LOGGING); |
| 566 | ASSERT_TRUE(block != NULL); |
| 567 | size_t exp_total_len = 2; |
| 568 | EXPECT_EQ(block->total_len, exp_total_len); |
| 569 | |
| 570 | /* First block is a label. */ |
| 571 | struct filter_block *curr_block = block; |
| 572 | ASSERT_TRUE(curr_block != NULL); |
| 573 | EXPECT_EQ(block->len, 1U); |
| 574 | EXPECT_LBL(curr_block->instrs); |
| 575 | |
| 576 | /* Second block is SECCOMP_RET_ERRNO. */ |
| 577 | curr_block = curr_block->next; |
| 578 | ASSERT_TRUE(curr_block != NULL); |
| 579 | EXPECT_EQ(curr_block->len, 1U); |
| 580 | EXPECT_EQ_STMT(curr_block->instrs, |
| 581 | BPF_RET + BPF_K, |
| 582 | SECCOMP_RET_ERRNO | (1 & SECCOMP_RET_DATA)); |
| 583 | |
| 584 | EXPECT_TRUE(curr_block->next == NULL); |
| 585 | |
| 586 | free_block_list(block); |
| 587 | } |
| 588 | |
| 589 | TEST_F(ArgFilterTest, invalid) { |
| 590 | const char *fragment = "argnn == 0"; |
| 591 | int nr = 1; |
| 592 | unsigned int id = 0; |
| 593 | |
| 594 | struct filter_block *block = |
| 595 | compile_section(nr, fragment, id, &labels_, NO_LOGGING); |
| 596 | ASSERT_TRUE(block == NULL); |
| 597 | |
| 598 | fragment = "arg0 == 0 && arg1 == 1; return errno"; |
| 599 | block = compile_section(nr, fragment, id, &labels_, NO_LOGGING); |
| 600 | ASSERT_TRUE(block == NULL); |
| 601 | } |
| 602 | |
| 603 | TEST_F(ArgFilterTest, log_no_ret_error) { |
| 604 | const char *fragment = "arg0 == 0"; |
| 605 | int nr = 1; |
| 606 | unsigned int id = 0; |
| 607 | struct filter_block *block = |
| 608 | compile_section(nr, fragment, id, &labels_, USE_LOGGING); |
| 609 | |
| 610 | ASSERT_TRUE(block != NULL); |
| 611 | size_t exp_total_len = 1 + (BPF_ARG_COMP_LEN + 1) + 2 + 1 + 2; |
| 612 | EXPECT_EQ(block->total_len, exp_total_len); |
| 613 | |
| 614 | /* First block is a label. */ |
| 615 | struct filter_block *curr_block = block; |
| 616 | ASSERT_TRUE(curr_block != NULL); |
| 617 | EXPECT_EQ(block->len, 1U); |
| 618 | EXPECT_LBL(curr_block->instrs); |
| 619 | |
| 620 | /* Second block is a comparison. */ |
| 621 | curr_block = block->next; |
| 622 | ASSERT_TRUE(curr_block != NULL); |
| 623 | EXPECT_COMP(curr_block); |
| 624 | |
| 625 | /* Third block is a jump and a label (end of AND group). */ |
| 626 | curr_block = curr_block->next; |
| 627 | ASSERT_TRUE(curr_block != NULL); |
| 628 | EXPECT_GROUP_END(curr_block); |
| 629 | |
| 630 | /* Fourth block is SECCOMP_RET_TRAP, with no errno. */ |
| 631 | curr_block = curr_block->next; |
| 632 | ASSERT_TRUE(curr_block != NULL); |
| 633 | EXPECT_TRAP(curr_block); |
| 634 | |
| 635 | /* Fifth block is "SUCCESS" label and SECCOMP_RET_ALLOW. */ |
| 636 | curr_block = curr_block->next; |
| 637 | ASSERT_TRUE(curr_block != NULL); |
| 638 | EXPECT_ALLOW(curr_block); |
| 639 | |
| 640 | EXPECT_TRUE(curr_block->next == NULL); |
| 641 | |
| 642 | free_block_list(block); |
| 643 | } |
| 644 | |
| 645 | TEST_F(ArgFilterTest, log_bad_ret_error) { |
| 646 | const char *fragment = "arg0 == 0; return"; |
| 647 | int nr = 1; |
| 648 | unsigned int id = 0; |
| 649 | |
| 650 | struct filter_block *block = |
| 651 | compile_section(nr, fragment, id, &labels_, NO_LOGGING); |
| 652 | ASSERT_TRUE(block != NULL); |
| 653 | size_t exp_total_len = 1 + (BPF_ARG_COMP_LEN + 1) + 2 + 1 + 2; |
| 654 | EXPECT_EQ(block->total_len, exp_total_len); |
| 655 | |
| 656 | /* First block is a label. */ |
| 657 | struct filter_block *curr_block = block; |
| 658 | ASSERT_TRUE(curr_block != NULL); |
| 659 | EXPECT_EQ(block->len, 1U); |
| 660 | EXPECT_LBL(curr_block->instrs); |
| 661 | |
| 662 | /* Second block is a comparison ("arg0 == 0"). */ |
| 663 | curr_block = curr_block->next; |
| 664 | ASSERT_TRUE(curr_block != NULL); |
| 665 | EXPECT_COMP(curr_block); |
| 666 | |
| 667 | /* Third block is a jump and a label (end of AND group). */ |
| 668 | curr_block = curr_block->next; |
| 669 | ASSERT_TRUE(curr_block != NULL); |
| 670 | EXPECT_GROUP_END(curr_block); |
| 671 | |
| 672 | /* |
| 673 | * Sixth block is NOT SECCOMP_RET_ERRNO, it should be SECCOMP_RET_KILL. |
| 674 | */ |
| 675 | curr_block = curr_block->next; |
| 676 | ASSERT_TRUE(curr_block != NULL); |
| 677 | EXPECT_KILL(curr_block); |
| 678 | |
| 679 | /* Seventh block is "SUCCESS" label and SECCOMP_RET_ALLOW. */ |
| 680 | curr_block = curr_block->next; |
| 681 | ASSERT_TRUE(curr_block != NULL); |
| 682 | EXPECT_ALLOW(curr_block); |
| 683 | |
| 684 | EXPECT_TRUE(curr_block->next == NULL); |
| 685 | |
| 686 | free_block_list(block); |
| 687 | } |
| 688 | |
| 689 | TEST_F(ArgFilterTest, no_log_bad_ret_error) { |
| 690 | const char *fragment = "arg0 == 0; return"; |
| 691 | int nr = 1; |
| 692 | unsigned int id = 0; |
| 693 | |
| 694 | struct filter_block *block = |
| 695 | compile_section(nr, fragment, id, &labels_, USE_LOGGING); |
| 696 | ASSERT_TRUE(block != NULL); |
| 697 | size_t exp_total_len = 1 + (BPF_ARG_COMP_LEN + 1) + 2 + 1 + 2; |
| 698 | EXPECT_EQ(block->total_len, exp_total_len); |
| 699 | |
| 700 | /* First block is a label. */ |
| 701 | struct filter_block *curr_block = block; |
| 702 | ASSERT_TRUE(curr_block != NULL); |
| 703 | EXPECT_EQ(block->len, 1U); |
| 704 | EXPECT_LBL(curr_block->instrs); |
| 705 | |
| 706 | /* Second block is a comparison ("arg0 == 0"). */ |
| 707 | curr_block = curr_block->next; |
| 708 | ASSERT_TRUE(curr_block != NULL); |
| 709 | EXPECT_COMP(curr_block); |
| 710 | |
| 711 | /* Third block is a jump and a label (end of AND group). */ |
| 712 | curr_block = curr_block->next; |
| 713 | ASSERT_TRUE(curr_block != NULL); |
| 714 | EXPECT_GROUP_END(curr_block); |
| 715 | |
| 716 | /* |
| 717 | * Sixth block is *not* SECCOMP_RET_ERRNO, it should be |
| 718 | * SECCOMP_RET_TRAP. |
| 719 | */ |
| 720 | curr_block = curr_block->next; |
| 721 | ASSERT_TRUE(curr_block != NULL); |
| 722 | EXPECT_TRAP(curr_block); |
| 723 | |
| 724 | /* Seventh block is "SUCCESS" label and SECCOMP_RET_ALLOW. */ |
| 725 | curr_block = curr_block->next; |
| 726 | ASSERT_TRUE(curr_block != NULL); |
| 727 | EXPECT_ALLOW(curr_block); |
| 728 | |
| 729 | EXPECT_TRUE(curr_block->next == NULL); |
| 730 | |
| 731 | free_block_list(block); |
| 732 | } |
| 733 | |
| 734 | FILE *write_policy_to_pipe(const char *policy, size_t len) { |
| 735 | int pipefd[2]; |
| 736 | if (pipe(pipefd) == -1) { |
| 737 | pwarn("pipe(pipefd) failed"); |
| 738 | return NULL; |
| 739 | } |
| 740 | |
| 741 | size_t i = 0; |
| 742 | unsigned int attempts = 0; |
| 743 | ssize_t ret; |
| 744 | while (i < len) { |
| 745 | ret = write(pipefd[1], &policy[i], len - i); |
| 746 | if (ret == -1) { |
| 747 | close(pipefd[0]); |
| 748 | close(pipefd[1]); |
| 749 | return NULL; |
| 750 | } |
| 751 | |
| 752 | /* If we write 0 bytes three times in a row, fail. */ |
| 753 | if (ret == 0) { |
| 754 | if (++attempts >= 3) { |
| 755 | close(pipefd[0]); |
| 756 | close(pipefd[1]); |
| 757 | warn("write() returned 0 three times in a row"); |
| 758 | return NULL; |
| 759 | } |
| 760 | continue; |
| 761 | } |
| 762 | |
| 763 | attempts = 0; |
| 764 | i += (size_t)ret; |
| 765 | } |
| 766 | |
| 767 | close(pipefd[1]); |
| 768 | return fdopen(pipefd[0], "r"); |
| 769 | } |
| 770 | |
| 771 | TEST(FilterTest, seccomp_mode1) { |
| 772 | struct sock_fprog actual; |
| 773 | const char *policy = |
| 774 | "read: 1\n" |
| 775 | "write: 1\n" |
| 776 | "rt_sigreturn: 1\n" |
| 777 | "exit: 1\n"; |
| 778 | |
| 779 | FILE *policy_file = write_policy_to_pipe(policy, strlen(policy)); |
| 780 | ASSERT_TRUE(policy_file != NULL); |
| 781 | |
Jorge Lucangeli Obes | 713f6fb | 2016-10-03 13:03:25 -0400 | [diff] [blame] | 782 | int res = compile_filter(policy_file, &actual, USE_RET_KILL, NO_LOGGING); |
Jorge Lucangeli Obes | 106d97f | 2016-08-19 12:34:02 -0400 | [diff] [blame] | 783 | fclose(policy_file); |
| 784 | |
| 785 | /* |
| 786 | * Checks return value, filter length, and that the filter |
| 787 | * validates arch, loads syscall number, and |
| 788 | * only allows expected syscalls. |
| 789 | */ |
| 790 | ASSERT_EQ(res, 0); |
| 791 | EXPECT_EQ(actual.len, 13); |
| 792 | EXPECT_ARCH_VALIDATION(actual.filter); |
| 793 | EXPECT_EQ_STMT(actual.filter + ARCH_VALIDATION_LEN, |
| 794 | BPF_LD + BPF_W + BPF_ABS, |
| 795 | syscall_nr); |
| 796 | EXPECT_ALLOW_SYSCALL(actual.filter + ARCH_VALIDATION_LEN + 1, __NR_read); |
| 797 | EXPECT_ALLOW_SYSCALL(actual.filter + ARCH_VALIDATION_LEN + 3, __NR_write); |
| 798 | EXPECT_ALLOW_SYSCALL(actual.filter + ARCH_VALIDATION_LEN + 5, |
| 799 | __NR_rt_sigreturn); |
| 800 | EXPECT_ALLOW_SYSCALL(actual.filter + ARCH_VALIDATION_LEN + 7, __NR_exit); |
| 801 | EXPECT_EQ_STMT(actual.filter + ARCH_VALIDATION_LEN + 9, |
| 802 | BPF_RET + BPF_K, |
| 803 | SECCOMP_RET_KILL); |
| 804 | |
| 805 | free(actual.filter); |
| 806 | } |
| 807 | |
Jorge Lucangeli Obes | 713f6fb | 2016-10-03 13:03:25 -0400 | [diff] [blame] | 808 | TEST(FilterTest, seccomp_mode1_trap) { |
| 809 | struct sock_fprog actual; |
| 810 | const char *policy = |
| 811 | "read: 1\n" |
| 812 | "write: 1\n" |
| 813 | "rt_sigreturn: 1\n" |
| 814 | "exit: 1\n"; |
| 815 | |
| 816 | FILE *policy_file = write_policy_to_pipe(policy, strlen(policy)); |
| 817 | ASSERT_TRUE(policy_file != NULL); |
| 818 | |
| 819 | int res = compile_filter(policy_file, &actual, USE_RET_TRAP, NO_LOGGING); |
| 820 | fclose(policy_file); |
| 821 | |
| 822 | /* |
| 823 | * Checks return value, filter length, and that the filter |
| 824 | * validates arch, loads syscall number, and |
| 825 | * only allows expected syscalls. |
| 826 | */ |
| 827 | ASSERT_EQ(res, 0); |
| 828 | EXPECT_EQ(actual.len, 13); |
| 829 | EXPECT_ARCH_VALIDATION(actual.filter); |
| 830 | EXPECT_EQ_STMT(actual.filter + ARCH_VALIDATION_LEN, |
| 831 | BPF_LD+BPF_W+BPF_ABS, syscall_nr); |
| 832 | EXPECT_ALLOW_SYSCALL(actual.filter + ARCH_VALIDATION_LEN + 1, |
| 833 | __NR_read); |
| 834 | EXPECT_ALLOW_SYSCALL(actual.filter + ARCH_VALIDATION_LEN + 3, |
| 835 | __NR_write); |
| 836 | EXPECT_ALLOW_SYSCALL(actual.filter + ARCH_VALIDATION_LEN + 5, |
| 837 | __NR_rt_sigreturn); |
| 838 | EXPECT_ALLOW_SYSCALL(actual.filter + ARCH_VALIDATION_LEN + 7, |
| 839 | __NR_exit); |
| 840 | EXPECT_EQ_STMT(actual.filter + ARCH_VALIDATION_LEN + 9, BPF_RET+BPF_K, |
| 841 | SECCOMP_RET_TRAP); |
| 842 | |
| 843 | free(actual.filter); |
| 844 | } |
| 845 | |
Jorge Lucangeli Obes | 106d97f | 2016-08-19 12:34:02 -0400 | [diff] [blame] | 846 | TEST(FilterTest, seccomp_read_write) { |
| 847 | struct sock_fprog actual; |
| 848 | const char *policy = |
| 849 | "read: arg0 == 0\n" |
| 850 | "write: arg0 == 1 || arg0 == 2\n" |
| 851 | "rt_sigreturn: 1\n" |
| 852 | "exit: 1\n"; |
| 853 | |
| 854 | FILE *policy_file = write_policy_to_pipe(policy, strlen(policy)); |
| 855 | ASSERT_TRUE(policy_file != NULL); |
| 856 | |
Jorge Lucangeli Obes | 713f6fb | 2016-10-03 13:03:25 -0400 | [diff] [blame] | 857 | int res = compile_filter(policy_file, &actual, USE_RET_KILL, NO_LOGGING); |
Jorge Lucangeli Obes | 106d97f | 2016-08-19 12:34:02 -0400 | [diff] [blame] | 858 | fclose(policy_file); |
| 859 | |
| 860 | /* |
| 861 | * Checks return value, filter length, and that the filter |
| 862 | * validates arch, loads syscall number, and |
| 863 | * only allows expected syscalls, jumping to correct arg filter |
| 864 | * offsets. |
| 865 | */ |
| 866 | ASSERT_EQ(res, 0); |
| 867 | size_t exp_total_len = 27 + 3 * (BPF_ARG_COMP_LEN + 1); |
| 868 | EXPECT_EQ(actual.len, exp_total_len); |
| 869 | |
| 870 | EXPECT_ARCH_VALIDATION(actual.filter); |
| 871 | EXPECT_EQ_STMT(actual.filter + ARCH_VALIDATION_LEN, |
| 872 | BPF_LD + BPF_W + BPF_ABS, |
| 873 | syscall_nr); |
| 874 | EXPECT_ALLOW_SYSCALL_ARGS( |
| 875 | actual.filter + ARCH_VALIDATION_LEN + 1, __NR_read, 7, 0, 0); |
| 876 | EXPECT_ALLOW_SYSCALL_ARGS(actual.filter + ARCH_VALIDATION_LEN + 3, |
| 877 | __NR_write, |
| 878 | 12 + BPF_ARG_COMP_LEN, |
| 879 | 0, |
| 880 | 0); |
| 881 | EXPECT_ALLOW_SYSCALL(actual.filter + ARCH_VALIDATION_LEN + 5, |
| 882 | __NR_rt_sigreturn); |
| 883 | EXPECT_ALLOW_SYSCALL(actual.filter + ARCH_VALIDATION_LEN + 7, __NR_exit); |
| 884 | EXPECT_EQ_STMT(actual.filter + ARCH_VALIDATION_LEN + 9, |
| 885 | BPF_RET + BPF_K, |
| 886 | SECCOMP_RET_KILL); |
| 887 | |
| 888 | free(actual.filter); |
| 889 | } |
| 890 | |
| 891 | TEST(FilterTest, invalid_name) { |
| 892 | struct sock_fprog actual; |
| 893 | const char *policy = "notasyscall: 1\n"; |
| 894 | |
| 895 | FILE *policy_file = write_policy_to_pipe(policy, strlen(policy)); |
| 896 | ASSERT_TRUE(policy_file != NULL); |
| 897 | |
Jorge Lucangeli Obes | 713f6fb | 2016-10-03 13:03:25 -0400 | [diff] [blame] | 898 | int res = compile_filter(policy_file, &actual, 0, NO_LOGGING); |
Jorge Lucangeli Obes | 106d97f | 2016-08-19 12:34:02 -0400 | [diff] [blame] | 899 | fclose(policy_file); |
| 900 | ASSERT_NE(res, 0); |
| 901 | } |
| 902 | |
| 903 | TEST(FilterTest, invalid_arg) { |
| 904 | struct sock_fprog actual; |
| 905 | const char *policy = "open: argnn ==\n"; |
| 906 | |
| 907 | FILE *policy_file = write_policy_to_pipe(policy, strlen(policy)); |
| 908 | ASSERT_TRUE(policy_file != NULL); |
| 909 | |
Jorge Lucangeli Obes | 713f6fb | 2016-10-03 13:03:25 -0400 | [diff] [blame] | 910 | int res = compile_filter(policy_file, &actual, 0, NO_LOGGING); |
Jorge Lucangeli Obes | 106d97f | 2016-08-19 12:34:02 -0400 | [diff] [blame] | 911 | fclose(policy_file); |
| 912 | ASSERT_NE(res, 0); |
| 913 | } |
| 914 | |
| 915 | TEST(FilterTest, nonexistent) { |
| 916 | struct sock_fprog actual; |
Jorge Lucangeli Obes | 713f6fb | 2016-10-03 13:03:25 -0400 | [diff] [blame] | 917 | int res = compile_filter(NULL, &actual, 0, NO_LOGGING); |
Jorge Lucangeli Obes | 106d97f | 2016-08-19 12:34:02 -0400 | [diff] [blame] | 918 | ASSERT_NE(res, 0); |
| 919 | } |
| 920 | |
| 921 | TEST(FilterTest, log) { |
| 922 | struct sock_fprog actual; |
| 923 | const char *policy = |
| 924 | "read: 1\n" |
| 925 | "write: 1\n" |
| 926 | "rt_sigreturn: 1\n" |
| 927 | "exit: 1\n"; |
| 928 | |
| 929 | FILE *policy_file = write_policy_to_pipe(policy, strlen(policy)); |
| 930 | ASSERT_TRUE(policy_file != NULL); |
| 931 | |
Jorge Lucangeli Obes | 713f6fb | 2016-10-03 13:03:25 -0400 | [diff] [blame] | 932 | int res = compile_filter(policy_file, &actual, USE_RET_TRAP, USE_LOGGING); |
Jorge Lucangeli Obes | 106d97f | 2016-08-19 12:34:02 -0400 | [diff] [blame] | 933 | fclose(policy_file); |
| 934 | |
| 935 | size_t i; |
| 936 | size_t index = 0; |
| 937 | /* |
| 938 | * Checks return value, filter length, and that the filter |
| 939 | * validates arch, loads syscall number, only allows expected syscalls, |
| 940 | * and returns TRAP on failure. |
| 941 | * NOTE(jorgelo): the filter is longer since we add the syscalls needed |
| 942 | * for logging. |
| 943 | */ |
| 944 | ASSERT_EQ(res, 0); |
| 945 | EXPECT_EQ(actual.len, 13 + 2 * log_syscalls_len); |
| 946 | EXPECT_ARCH_VALIDATION(actual.filter); |
| 947 | EXPECT_EQ_STMT(actual.filter + ARCH_VALIDATION_LEN, |
| 948 | BPF_LD + BPF_W + BPF_ABS, |
| 949 | syscall_nr); |
| 950 | |
| 951 | index = ARCH_VALIDATION_LEN + 1; |
| 952 | for (i = 0; i < log_syscalls_len; i++) |
| 953 | EXPECT_ALLOW_SYSCALL(actual.filter + (index + 2 * i), |
| 954 | lookup_syscall(log_syscalls[i])); |
| 955 | |
| 956 | index += 2 * log_syscalls_len; |
| 957 | |
| 958 | EXPECT_ALLOW_SYSCALL(actual.filter + index, __NR_read); |
| 959 | EXPECT_ALLOW_SYSCALL(actual.filter + index + 2, __NR_write); |
| 960 | EXPECT_ALLOW_SYSCALL(actual.filter + index + 4, __NR_rt_sigreturn); |
| 961 | EXPECT_ALLOW_SYSCALL(actual.filter + index + 6, __NR_exit); |
| 962 | EXPECT_EQ_STMT(actual.filter + index + 8, BPF_RET + BPF_K, SECCOMP_RET_TRAP); |
| 963 | |
| 964 | free(actual.filter); |
| 965 | } |
Jorge Lucangeli Obes | 713f6fb | 2016-10-03 13:03:25 -0400 | [diff] [blame] | 966 | |
| 967 | TEST(FilterTest, allow_log_but_kill) { |
| 968 | struct sock_fprog actual; |
| 969 | const char *policy = |
| 970 | "read: 1\n" |
| 971 | "write: 1\n" |
| 972 | "rt_sigreturn: 1\n" |
| 973 | "exit: 1\n"; |
| 974 | |
| 975 | FILE *policy_file = write_policy_to_pipe(policy, strlen(policy)); |
| 976 | ASSERT_TRUE(policy_file != NULL); |
| 977 | |
| 978 | int res = compile_filter(policy_file, &actual, USE_RET_KILL, USE_LOGGING); |
| 979 | fclose(policy_file); |
| 980 | |
| 981 | size_t i; |
| 982 | size_t index = 0; |
| 983 | /* |
| 984 | * Checks return value, filter length, and that the filter |
| 985 | * validates arch, loads syscall number, only allows expected syscalls, |
| 986 | * and returns TRAP on failure. |
| 987 | * NOTE(jorgelo): the filter is longer since we add the syscalls needed |
| 988 | * for logging. |
| 989 | */ |
| 990 | ASSERT_EQ(res, 0); |
| 991 | EXPECT_EQ(actual.len, 13 + 2 * log_syscalls_len); |
| 992 | EXPECT_ARCH_VALIDATION(actual.filter); |
| 993 | EXPECT_EQ_STMT(actual.filter + ARCH_VALIDATION_LEN, |
| 994 | BPF_LD+BPF_W+BPF_ABS, syscall_nr); |
| 995 | |
| 996 | index = ARCH_VALIDATION_LEN + 1; |
| 997 | for (i = 0; i < log_syscalls_len; i++) |
| 998 | EXPECT_ALLOW_SYSCALL(actual.filter + (index + 2 * i), |
| 999 | lookup_syscall(log_syscalls[i])); |
| 1000 | |
| 1001 | index += 2 * log_syscalls_len; |
| 1002 | |
| 1003 | EXPECT_ALLOW_SYSCALL(actual.filter + index, __NR_read); |
| 1004 | EXPECT_ALLOW_SYSCALL(actual.filter + index + 2, __NR_write); |
| 1005 | EXPECT_ALLOW_SYSCALL(actual.filter + index + 4, __NR_rt_sigreturn); |
| 1006 | EXPECT_ALLOW_SYSCALL(actual.filter + index + 6, __NR_exit); |
| 1007 | EXPECT_EQ_STMT(actual.filter + index + 8, BPF_RET+BPF_K, |
| 1008 | SECCOMP_RET_KILL); |
| 1009 | |
| 1010 | free(actual.filter); |
| 1011 | } |