commit | c23317c16f9009356932fc36dc88ca2a7972156e | [log] [tgz] |
---|---|---|
author | Lázaro Clapp <lazaro.clapp@gmail.com> | Fri Sep 29 13:38:58 2017 -0700 |
committer | GitHub <noreply@github.com> | Fri Sep 29 13:38:58 2017 -0700 |
tree | fafe2eafc962bdda8712436e6ac21370417421f3 | |
parent | 7d6e253ecb3f68aeda71d767fc4ea29ac177e985 [diff] |
Add lambda support to the RxNullabilityPropagator handler. (#12) Add lambda support to the RxNullabilityPropagator handler, with relevant tests.
NullAway is a tool to help eliminate NullPointerException
s (NPEs) in your Java code. To use NullAway, first add @Nullable
annotations in your code wherever a field, method parameter, or return value may be null
. Given these annotations, NullAway performs a series of type-based, local checks to ensure that any pointer that gets dereferenced in your code cannot be null
. NullAway is similar to the type-based nullability checking in the Kotlin and Swift languages, and the Checker Framework and Eradicate null checkers for Java.
NullAway is fast. It is built as a plugin to Error Prone and can run on every single build of your code. In our measurements, the build-time overhead of running NullAway is usually less than 10%. NullAway is also practical: it does not prevent all possible NPEs in your code, but it catches most of the NPEs we have observed in production while imposing a reasonable annotation burden, giving a great "bang for your buck." At Uber, we combine NullAway with RAVE to obtain thorough protection against NPEs in our Android apps.
NullAway requires that you build your code with Error Prone, version 2.1.1 or higher. See the Error Prone documentation for instructions on getting started with Error Prone and integration with your build system. The instructions below assume you are using Gradle; see the docs for discussion of other build systems.
To integrate NullAway into your non-Android Java project, add the following to your build.gradle
file:
buildscript { repositories { maven { url "https://plugins.gradle.org/m2/" } } } plugins { // we assume you are already using the Java plugin id "net.ltgt.apt" version "0.11" id "net.ltgt.errorprone" version "0.0.11" } dependencies { apt "com.uber.nullaway:nullaway:0.1.4" // Optional, some source of nullability annotations compileOnly "com.google.code.findbugs:jsr305:3.0.2" errorprone "com.google.errorprone:error_prone_core:2.1.1" } tasks.withType(JavaCompile) { // remove the if condition if you want to run NullAway on test code if (!name.toLowerCase().contains("test")) { options.compilerArgs += ["-Xep:NullAway:ERROR", "-XepOpt:NullAway:AnnotatedPackages=com.uber"] } }
Let's walk through this script step by step. The buildscript
section of the script adds the Maven repository for Gradle plugins. The plugins
section pulls in the Gradle Error Prone plugin for Error Prone integration, and the Gradle APT plugin to ease specification of annotation processor dependencies for a build. We need the latter since Error Prone loads plugin checkers from the annotation processor path. If you are using the older apply plugin
syntax instead of a plugins
block, the following is equivalent:
buildscript { repositories { maven { url "https://plugins.gradle.org/m2/" } } dependencies { classpath "net.ltgt.gradle:gradle-errorprone-plugin:0.0.11" classpath "net.ltgt.gradle:gradle-apt-plugin:0.11" } } apply plugin: 'net.ltgt.errorprone' apply plugin: 'let.ltgt.apt'
In dependencies
, the apt
line loads NullAway, and the compileOnly
line loads a JSR 305 library which provides a suitable @Nullable
annotation (javax.annotation.Nullable
). NullAway allows for any @Nullable
annotation to be used, so, e.g., @Nullable
from the Android Support Library or JetBrains annotations is also fine. The errorprone
line ensures that the minimum compatible version of Error Prone is used.
Finally, in the tasks.withType(JavaCompile)
section, we pass some configuration options to NullAway as compiler arguments. The first argument -Xep:NullAway:ERROR
is a standard Error Prone argument that sets NullAway issues to the error level; by default NullAway emits warnings. The second argument, -XepOpt:NullAway:AnnotatedPackages=com.uber
, tells NullAway that source code in packages under the com.uber
namespace should be checked for null dereferences and proper usage of @Nullable
annotations, and that class files in these packages should be assumed to have correct usage of @Nullable
(see the docs for more detail). NullAway requires at least the AnnotatedPackages
configuration argument to run, in order to distinguish between annotated and unannotated code. See the configuration docs for other useful configuration options.
We recommend addressing all the issues that Error Prone reports, particularly those reported as errors (rather than warnings). But, if you'd like to try out NullAway without running other Error Prone checks, you can pass "-XepDisableAllChecks"
to the compiler, before the NullAway-specific arguments.
The configuration for an Android project is very similar to the Java case, with two key differences:
net.ltgt.apt
plugin is not required.apt
dependence, use an annotationProcessor
dependence:dependencies { annotationProcessor "com.uber.nullaway:nullaway:0.1.4" }
Let's see how NullAway works on a simple code example:
static void log(Object x) { System.out.println(x.toString()); } static void foo() { log(null); }
This code is buggy: when foo()
is called, the subsequent call to log()
will fail with an NPE. You can see this error in the NullAway sample app by running:
cp sample/src/main/java/com/uber/mylib/MyClass.java.buggy sample/src/main/java/com/uber/mylib/MyClass.java ./gradlew build
By default, NullAway assumes every method parameter, return value, and field is non-null, i.e., it can never be assigned a null
value. In the above code, the x
parameter of log()
is assumed to be non-null. So, NullAway reports the following error:
warning: [NullAway] passing @Nullable parameter 'null' where @NonNull is required log(null); ^
We can fix this error by allowing null
to be passed to log()
, with a @Nullable
annotation:
static void log(@Nullable Object x) { System.out.println(x.toString()); }
With this annotation, NullAway points out the possible null dereference:
warning: [NullAway] dereferenced expression x is @Nullable System.out.println(x.toString()); ^
We can fix this warning by adding a null check:
static void log(@Nullable Object x) { if (x != null) { System.out.println(x.toString()); } }
With this change, all the NullAway warnings are fixed.
For more details on NullAway's checks, error messages, and limitations, see our detailed guide.
NullAway is licensed under the MIT license. See the LICENSE.txt file for more information.