NB: big update - may break stuff. Please test!

 - (djm) OpenBSD CVS sync:
   - markus@cvs.openbsd.org  2001/02/03 03:08:38
     [auth-options.c auth-rh-rsa.c auth-rhosts.c auth.c canohost.c]
     [canohost.h servconf.c servconf.h session.c sshconnect1.c sshd.8]
     [sshd_config]
     make ReverseMappingCheck optional in sshd_config; ok djm@,dugsong@
   - markus@cvs.openbsd.org  2001/02/03 03:19:51
     [ssh.1 sshd.8 sshd_config]
     Skey is now called ChallengeResponse
   - markus@cvs.openbsd.org  2001/02/03 03:43:09
     [sshd.8]
     use no-pty option in .ssh/authorized_keys* if you need a 8-bit clean
     channel. note from Erik.Anggard@cygate.se (pr/1659)
   - stevesk@cvs.openbsd.org 2001/02/03 10:03:06
     [ssh.1]
     typos; ok markus@
   - djm@cvs.openbsd.org     2001/02/04 04:11:56
     [scp.1 sftp-server.c ssh.1 sshd.8 sftp-client.c sftp-client.h]
     [sftp-common.c sftp-common.h sftp-int.c sftp-int.h sftp.1 sftp.c]
     Basic interactive sftp client; ok theo@
 - (djm) Update RPM specs for new sftp binary
 - (djm) Update several bits for new optional reverse lookup stuff. I
   think I got them all.
diff --git a/sftp-int.c b/sftp-int.c
new file mode 100644
index 0000000..f050c09
--- /dev/null
+++ b/sftp-int.c
@@ -0,0 +1,583 @@
+/*
+ * Copyright (c) 2001 Damien Miller.  All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ *    notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ *    notice, this list of conditions and the following disclaimer in the
+ *    documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY EXPRESS OR
+ * IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES
+ * OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED.
+ * IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT,
+ * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT
+ * NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+ * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+ * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
+ * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+/* XXX: finish implementation of all commands */
+/* XXX: do fnmatch() instead of using raw pathname */
+/* XXX: recursive operations */
+
+#include "includes.h"
+RCSID("$OpenBSD: sftp-int.c,v 1.1 2001/02/04 11:11:54 djm Exp $");
+
+#include "buffer.h"
+#include "xmalloc.h"
+#include "log.h"
+#include "pathnames.h"
+
+#include "sftp.h"
+#include "sftp-common.h"
+#include "sftp-client.h"
+#include "sftp-int.h"
+
+/* Seperators for interactive commands */
+#define WHITESPACE " \t\r\n"
+
+/* Commands for interactive mode */
+#define I_CHDIR		1
+#define I_CHGRP		2
+#define I_CHMOD		3
+#define I_CHOWN		4
+#define I_GET		5
+#define I_HELP		6
+#define I_LCHDIR	7
+#define I_LLS		8
+#define I_LMKDIR	9
+#define I_LPWD		10
+#define I_LS		11
+#define I_LUMASK	12
+#define I_MKDIR		13
+#define I_PUT		14
+#define I_PWD		15
+#define I_QUIT		16
+#define I_RENAME	17
+#define I_RM		18
+#define I_RMDIR		19
+#define I_SHELL		20
+
+struct CMD {
+	const int n;
+	const char *c;
+};
+
+const struct CMD cmds[] = {
+	{ I_CHDIR,	"CD" },
+	{ I_CHDIR,	"CHDIR" },
+	{ I_CHDIR,	"LCD" },
+	{ I_CHGRP,	"CHGRP" },
+	{ I_CHMOD,	"CHMOD" },
+	{ I_CHOWN,	"CHOWN" },
+	{ I_HELP,	"HELP" },
+	{ I_GET,	"GET" },
+	{ I_LCHDIR,	"LCHDIR" },
+	{ I_LLS,	"LLS" },
+	{ I_LMKDIR,	"LMKDIR" },
+	{ I_LPWD,	"LPWD" },
+	{ I_LS,		"LS" },
+	{ I_LUMASK,	"LUMASK" },
+	{ I_MKDIR,	"MKDIR" },
+	{ I_PUT,	"PUT" },
+	{ I_PWD,	"PWD" },
+	{ I_QUIT,	"EXIT" },
+	{ I_QUIT,	"QUIT" },
+	{ I_RENAME,	"RENAME" },
+	{ I_RMDIR,	"RMDIR" },
+	{ I_RM,		"RM" },
+	{ I_SHELL,	"!" },
+	{ -1,		NULL}
+};
+
+void
+help(void)
+{
+	printf("Available commands:\n");
+	printf("CD path                       Change remote directory to 'path'\n");
+	printf("LCD path                      Change local directory to 'path'\n");
+	printf("CHGRP grp path                Change group of file 'path' to 'grp'\n");
+	printf("CHMOD mode path               Change permissions of file 'path' to 'mode'\n");
+	printf("CHOWN own path                Change owner of file 'path' to 'own'\n");
+	printf("HELP                          Display this help text\n");
+	printf("GET remote-path [local-path]  Download file\n");
+	printf("LLS [ls options] [path]       Display local directory listing\n");
+	printf("LMKDIR path                   Create local directory\n");
+	printf("LPWD                          Print local working directory\n");
+	printf("LS [path]                     Display remote directory listing\n");
+	printf("LUMASK umask                  Set local umask to 'umask'\n");
+	printf("MKDIR path                    Create remote directory\n");
+	printf("PUT local-path [remote-path]  Upload file\n");
+	printf("PWD                           Display remote working directory\n");
+	printf("EXIT                          Quit sftp\n");
+	printf("QUIT                          Quit sftp\n");
+	printf("RENAME oldpath newpath        Rename remote file\n");
+	printf("RMDIR path                    Remove remote directory\n");
+	printf("RM path                       Delete remote file\n");
+	printf("!command                      Execute 'command' in local shell\n");
+	printf("!                             Escape to local shell\n");
+}
+
+void
+local_do_shell(const char *args)
+{
+	int ret, status;
+	char *shell;
+	pid_t pid;
+	
+	if (!*args)
+		args = NULL;
+	
+	if ((shell = getenv("SHELL")) == NULL)
+		shell = _PATH_BSHELL;
+
+	if ((pid = fork()) == -1)
+		fatal("Couldn't fork: %s", strerror(errno));
+
+	if (pid == 0) {
+		/* XXX: child has pipe fds to ssh subproc open - issue? */
+		if (args) {
+			debug3("Executing %s -c \"%s\"", shell, args);
+			ret = execl(shell, shell, "-c", args, NULL);
+		} else {
+			debug3("Executing %s", shell);
+			ret = execl(shell, shell, NULL);
+		}
+		fprintf(stderr, "Couldn't execute \"%s\": %s\n", shell, 
+		    strerror(errno));
+		_exit(1);
+	}
+	if (waitpid(pid, &status, 0) == -1)
+		fatal("Couldn't wait for child: %s", strerror(errno));
+	if (!WIFEXITED(status))
+		error("Shell exited abormally");
+	else if (WEXITSTATUS(status))
+		error("Shell exited with status %d", WEXITSTATUS(status));
+}
+
+void 
+local_do_ls(const char *args)
+{
+	if (!args || !*args)
+		local_do_shell("ls");
+	else {
+		char *buf = xmalloc(8 + strlen(args) + 1);
+
+		/* XXX: quoting - rip quoting code from ftp? */
+		sprintf(buf, "/bin/ls %s", args);
+		local_do_shell(buf);
+	}
+}
+
+char *
+make_absolute(char *p, char *pwd)
+{
+	char buf[2048];
+
+	/* Derelativise */
+	if (p && p[0] != '/') {
+		snprintf(buf, sizeof(buf), "%s/%s", pwd, p);
+		xfree(p);
+		p = xstrdup(buf);
+	}
+
+	return(p);
+}
+
+int
+parse_getput_flags(const char **cpp, int *pflag)
+{
+	const char *cp = *cpp;
+
+	/* Check for flags */
+	if (cp[0] == '-' && cp[1] && strchr(WHITESPACE, cp[2])) {
+		switch (*cp) {
+		case 'P':
+			*pflag = 1;
+			break;
+		default:
+			error("Invalid flag -%c", *cp);
+			return(-1);
+		}
+		cp += 2;
+		*cpp = cp + strspn(cp, WHITESPACE);
+	}
+
+	return(0);
+}
+
+int
+get_pathname(const char **cpp, char **path)
+{
+	const char *quot, *cp = *cpp;
+	int i;
+
+	cp += strspn(cp, WHITESPACE);
+	if (!*cp) {
+		*cpp = cp;
+		*path = NULL;
+		return(0);
+	}
+
+	/* Check for quoted filenames */
+	if (*cp == '\"' || *cp == '\'') {
+		quot = cp++;
+		for(i = 0; cp[i] && cp[i] != *quot; i++)
+			;
+		if (!cp[i]) {
+			error("Unterminated quote");
+			*path = NULL;
+			return(-1);
+		}
+		if (i == 0) {
+			error("Empty quotes");
+			*path = NULL;
+			return(-1);
+		}
+		*path = xmalloc(i + 1);
+		memcpy(*path, cp, i);
+		(*path)[i] = '\0';
+		cp += i + 1;
+		*cpp = cp + strspn(cp, WHITESPACE);
+		return(0);
+	}
+
+	/* Read to end of filename */
+	for(i = 0; cp[i] && cp[i] != ' '; i++)
+		;
+
+	*path = xmalloc(i + 1);
+	memcpy(*path, cp, i);
+	(*path)[i] = '\0';
+	cp += i;
+	*cpp = cp + strspn(cp, WHITESPACE);
+
+	return(0);
+}
+
+int
+infer_path(const char *p, char **ifp)
+{
+	char *cp;
+
+	debug("XXX: P = \"%s\"", p);
+
+	cp = strrchr(p, '/');
+
+	if (cp == NULL) {
+		*ifp = xstrdup(p);
+		return(0);
+	}
+
+	if (!cp[1]) {
+		error("Invalid path");
+		return(-1);
+	}
+
+	*ifp = xstrdup(cp + 1);
+	return(0);
+}
+
+int
+parse_args(const char **cpp, int *pflag, unsigned long *n_arg,
+    char **path1, char **path2)
+{
+	const char *cmd, *cp = *cpp;
+	int i, cmdnum;
+
+	/* Skip leading whitespace */
+	cp = cp + strspn(cp, WHITESPACE);
+
+	/* Ignore blank lines */
+	if (!*cp)
+		return(-1);
+
+	/* Figure out which command we have */
+	for(i = 0; cmds[i].c; i++) {
+		int cmdlen = strlen(cmds[i].c);
+
+		/* Check for command followed by whitespace */
+		if (!strncasecmp(cp, cmds[i].c, cmdlen) &&
+		    strchr(WHITESPACE, cp[cmdlen])) {
+			cp += cmdlen;
+			cp = cp + strspn(cp, WHITESPACE);
+			break;
+		}
+	}
+	cmdnum = cmds[i].n;
+	cmd = cmds[i].c;
+
+	/* Special case */
+	if (*cp == '!') {
+		cp++;
+		cmdnum = I_SHELL;
+	} else if (cmdnum == -1) {
+		error("Invalid command.");
+		return(-1);
+	}
+
+	/* Get arguments and parse flags */
+	*pflag = *n_arg = 0;
+	*path1 = *path2 = NULL;
+	switch (cmdnum) {
+	case I_GET:
+	case I_PUT:
+		if (parse_getput_flags(&cp, pflag))
+			return(-1);
+		/* Get first pathname (mandatory) */
+		if (get_pathname(&cp, path1))
+			return(-1);
+		if (*path1 == NULL) {
+			error("You must specify at least one path after a "
+			    "%s command.", cmd);
+			return(-1);
+		}
+		/* Try to get second pathname (optional) */
+		if (get_pathname(&cp, path2))
+			return(-1);
+		/* Otherwise try to guess it from first path */
+		if (*path2 == NULL && infer_path(*path1, path2))
+			return(-1);
+		break;
+	case I_RENAME:
+		/* Get first pathname (mandatory) */
+		if (get_pathname(&cp, path1))
+			return(-1);
+		if (get_pathname(&cp, path2))
+			return(-1);
+		if (!*path1 || !*path2) {
+			error("You must specify two paths after a %s "
+			    "command.", cmd);
+			return(-1);
+		}
+		break;
+	case I_RM:
+	case I_MKDIR:
+	case I_RMDIR:
+	case I_CHDIR:
+	case I_LCHDIR:
+	case I_LMKDIR:
+		/* Get pathname (mandatory) */
+		if (get_pathname(&cp, path1))
+			return(-1);
+		if (*path1 == NULL) {
+			error("You must specify a path after a %s command.", 
+			    cmd);
+			return(-1);
+		}
+		break;
+	case I_LS:
+		/* Path is optional */
+		if (get_pathname(&cp, path1))
+			return(-1);
+		break;
+	case I_LLS:
+	case I_SHELL:
+		/* Uses the rest of the line */
+		break;
+	case I_LUMASK:
+	case I_CHMOD:
+	case I_CHOWN:
+	case I_CHGRP:
+		/* Get numeric arg (mandatory) */
+		if (*cp < '0' && *cp > '9') {
+			error("You must supply a numeric argument "
+			    "to the %s command.", cmd);
+			return(-1);
+		}
+		*n_arg = strtoul(cp, (char**)&cp, 0);
+		if (!*cp || !strchr(WHITESPACE, *cp)) {
+			error("You must supply a numeric argument "
+			    "to the %s command.", cmd);
+			return(-1);
+		}
+		cp += strspn(cp, WHITESPACE);
+
+		/* Get pathname (mandatory) */
+		if (get_pathname(&cp, path1))
+			return(-1);
+		if (*path1 == NULL) {
+			error("You must specify a path after a %s command.", 
+			    cmd);
+			return(-1);
+		}
+		break;
+	case I_QUIT:
+	case I_PWD:
+	case I_LPWD:
+	case I_HELP:
+		break;
+	default:
+		fatal("Command not implemented");
+	}
+
+	*cpp = cp;
+
+	return(cmdnum);
+}
+
+int
+parse_dispatch_command(int in, int out, const char *cmd, char **pwd)
+{
+	char *path1, *path2;
+	int pflag, cmdnum;
+	unsigned long n_arg;
+	Attrib a, *aa;
+	char path_buf[PATH_MAX];
+
+	path1 = path2 = NULL;
+	cmdnum = parse_args(&cmd, &pflag, &n_arg, &path1, &path2);
+
+	/* Perform command */
+	switch (cmdnum) {
+	case -1:
+		break;
+	case I_GET:
+		path1 = make_absolute(path1, *pwd);
+		do_download(in, out, path1, path2, pflag);
+		break;
+	case I_PUT:
+		path2 = make_absolute(path2, *pwd);
+		do_upload(in, out, path1, path2, pflag);
+		break;
+	case I_RENAME:
+		path1 = make_absolute(path1, *pwd);
+		path2 = make_absolute(path2, *pwd);
+		do_rename(in, out, path1, path2);
+		break;
+	case I_RM:
+		path1 = make_absolute(path1, *pwd);
+		do_rm(in, out, path1);
+		break;
+	case I_MKDIR:
+		path1 = make_absolute(path1, *pwd);
+		attrib_clear(&a);
+		a.flags |= SSH2_FILEXFER_ATTR_PERMISSIONS;
+		a.perm = 0777;
+		do_mkdir(in, out, path1, &a);
+		break;
+	case I_RMDIR:
+		path1 = make_absolute(path1, *pwd);
+		do_rmdir(in, out, path1);
+		break;
+	case I_CHDIR:
+		path1 = make_absolute(path1, *pwd);
+		xfree(*pwd);
+		*pwd = do_realpath(in, out, path1);
+		break;
+	case I_LS:
+		path1 = make_absolute(path1, *pwd);
+		do_ls(in, out, path1?path1:*pwd);
+		break;
+	case I_LCHDIR:
+		if (chdir(path1) == -1)
+			error("Couldn't change local directory to "
+			    "\"%s\": %s", path1, strerror(errno));
+		break;
+	case I_LMKDIR:
+		if (mkdir(path1, 0777) == -1)
+			error("Couldn't create local directory to "
+			    "\"%s\": %s", path1, strerror(errno));
+		break;
+	case I_LLS:
+		local_do_ls(cmd);
+		break;
+	case I_SHELL:
+		local_do_shell(cmd);
+		break;
+	case I_LUMASK:
+		umask(n_arg);
+		break;
+	case I_CHMOD:
+		path1 = make_absolute(path1, *pwd);
+		attrib_clear(&a);
+		a.flags |= SSH2_FILEXFER_ATTR_PERMISSIONS;
+		a.perm = n_arg;
+		do_setstat(in, out, path1, &a);
+	case I_CHOWN:
+		path1 = make_absolute(path1, *pwd);
+		aa = do_stat(in, out, path1);
+		if (!aa->flags & SSH2_FILEXFER_ATTR_UIDGID) {
+			error("Can't get current ownership of "
+			    "remote file \"%s\"", path1);
+			break;
+		}
+		aa->uid = n_arg;
+		do_setstat(in, out, path1, aa);
+		break;
+	case I_CHGRP:
+		path1 = make_absolute(path1, *pwd);
+		aa = do_stat(in, out, path1);
+		if (!aa->flags & SSH2_FILEXFER_ATTR_UIDGID) {
+			error("Can't get current ownership of "
+			    "remote file \"%s\"", path1);
+			break;
+		}
+		aa->gid = n_arg;
+		do_setstat(in, out, path1, aa);
+		break;
+	case I_PWD:
+		printf("Remote working directory: %s\n", *pwd);
+		break;
+	case I_LPWD:
+		if (!getcwd(path_buf, sizeof(path_buf)))
+			error("Couldn't get local cwd: %s\n",
+			    strerror(errno));
+		else
+			printf("Local working directory: %s\n",
+			    path_buf);
+		break;
+	case I_QUIT:
+		return(-1);
+	case I_HELP:
+		help();
+		break;
+	default:
+		fatal("%d is not implemented", cmdnum);
+	}
+
+	if (path1)
+		xfree(path1);
+	if (path2)
+		xfree(path2);
+
+	return(0);
+}
+
+void
+interactive_loop(int fd_in, int fd_out)
+{
+	char *pwd;
+	char cmd[2048];
+
+	pwd = do_realpath(fd_in, fd_out, ".");
+	if (pwd == NULL)
+		fatal("Need cwd");
+
+	setlinebuf(stdout);
+	setlinebuf(stdin);
+
+	for(;;) {
+		char *cp;
+
+		printf("sftp> ");
+
+		/* XXX: use libedit */
+		if (fgets(cmd, sizeof(cmd), stdin) == NULL) {
+			printf("\n");
+			break;
+		}
+		cp = strrchr(cmd, '\n');
+		if (cp)
+			*cp = '\0';
+		if (parse_dispatch_command(fd_in, fd_out, cmd, &pwd))
+			break;
+	}
+	xfree(pwd);
+}