- djm@cvs.openbsd.org 2006/03/25 01:13:23
[buffer.c channels.c deattack.c misc.c scp.c session.c sftp-client.c]
[sftp-server.c ssh-agent.c ssh-rsa.c xmalloc.c xmalloc.h auth-pam.c]
[uidswap.c]
change OpenSSH's xrealloc() function from being xrealloc(p, new_size)
to xrealloc(p, new_nmemb, new_itemsize).
realloc is particularly prone to integer overflows because it is
almost always allocating "n * size" bytes, so this is a far safer
API; ok deraadt@
diff --git a/deattack.c b/deattack.c
index 746ff5d..ff9ca4d 100644
--- a/deattack.c
+++ b/deattack.c
@@ -97,7 +97,7 @@
n = l;
} else {
if (l > n) {
- h = (u_int16_t *) xrealloc(h, l * HASH_ENTRYSIZE);
+ h = (u_int16_t *)xrealloc(h, l, HASH_ENTRYSIZE);
n = l;
}
}