commit 52d7078421844b2f88329f5be3de370b0a938636
author mmcc@openbsd.org <mmcc@openbsd.org> Fri Dec 11 04:21:11 2015 +0000
committer Damien Miller <djm@mindrot.org> Fri Dec 18 14:50:48 2015 +1100
tree 1241462a841b14259755de181563cc83acd42109
parent a4b9e0f4e4a6980a0eb8072f76ea611cab5b77e7

upstream commit

Remove NULL-checks before sshbuf_free().

ok djm@

Upstream-ID: 5ebed00ed5f9f03b119a345085e8774565466917

ssh-dss.c

diff --git a/ssh-dss.c b/ssh-dss.c
index 254f2a3..cc47dcf 100644
--- a/ssh-dss.c
+++ b/ssh-dss.c
@@ -1,4 +1,4 @@
-/* $OpenBSD: ssh-dss.c,v 1.33 2015/12/10 17:08:40 mmcc Exp $ */
+/* $OpenBSD: ssh-dss.c,v 1.34 2015/12/11 04:21:12 mmcc Exp $ */
 /*
  * Copyright (c) 2000 Markus Friedl.  All rights reserved.
  *
@@ -122,8 +122,7 @@
 	explicit_bzero(digest, sizeof(digest));
 	if (sig != NULL)
 		DSA_SIG_free(sig);
-	if (b != NULL)
-		sshbuf_free(b);
+	sshbuf_free(b);
 	return ret;
 }
 
@@ -209,8 +208,7 @@
 	explicit_bzero(digest, sizeof(digest));
 	if (sig != NULL)
 		DSA_SIG_free(sig);
-	if (b != NULL)
-		sshbuf_free(b);
+	sshbuf_free(b);
 	free(ktype);
 	if (sigblob != NULL) {
 		explicit_bzero(sigblob, len);