commit f1f047fb031c0081dbc8738f05bf5d4cc47acadf
author dtucker@openbsd.org <dtucker@openbsd.org> Wed Feb 07 22:52:45 2018 +0000
committer Damien Miller <djm@mindrot.org> Fri Feb 09 20:00:18 2018 +1100
tree 1be06338e02d74a923527cdc03b88b472294a420
parent aee49b2a89b6b323c80dd3b431bd486e51f94c8c

upstream commit

ssh_free checks for and handles NULL args, remove NULL
checks from remaining callers.  ok djm@

OpenBSD-Commit-ID: bb926825c53724c069df68a93a2597f9192f7e7b

auth2-pubkey.c

diff --git a/auth2-pubkey.c b/auth2-pubkey.c
index e649822..8fb7ffe 100644
--- a/auth2-pubkey.c
+++ b/auth2-pubkey.c
@@ -1,4 +1,4 @@
-/* $OpenBSD: auth2-pubkey.c,v 1.75 2018/01/23 05:27:21 djm Exp $ */
+/* $OpenBSD: auth2-pubkey.c,v 1.76 2018/02/07 22:52:45 dtucker Exp $ */
 /*
  * Copyright (c) 2000 Markus Friedl.  All rights reserved.
  *
@@ -471,8 +471,7 @@
 		/* Always consume entire file */
 		if (found_key)
 			continue;
-		if (found != NULL)
-			sshkey_free(found);
+		sshkey_free(found);
 		found = sshkey_new(sshkey_is_cert(key) ? KEY_UNSPEC : key->type);
 		if (found == NULL)
 			goto done;
@@ -563,8 +562,7 @@
 		}
 	}
  done:
-	if (found != NULL)
-		sshkey_free(found);
+	sshkey_free(found);
 	if (!found_key)
 		debug2("key not found");
 	return found_key;

ssh-keysign.c

diff --git a/ssh-keysign.c b/ssh-keysign.c
index ac5034d..17e87a2 100644
--- a/ssh-keysign.c
+++ b/ssh-keysign.c
@@ -1,4 +1,4 @@
-/* $OpenBSD: ssh-keysign.c,v 1.52 2016/02/15 09:47:49 dtucker Exp $ */
+/* $OpenBSD: ssh-keysign.c,v 1.53 2018/02/07 22:52:45 dtucker Exp $ */
 /*
  * Copyright (c) 2002 Markus Friedl.  All rights reserved.
  *
@@ -158,7 +158,7 @@
 
 	debug3("%s: fail %d", __func__, fail);
 
-	if (fail && key != NULL)
+	if (fail)
 		sshkey_free(key);
 	else if (ret != NULL)
 		*ret = key;

sshconnect.c

diff --git a/sshconnect.c b/sshconnect.c
index cddf22e..e37bb08 100644
--- a/sshconnect.c
+++ b/sshconnect.c
@@ -1,4 +1,4 @@
-/* $OpenBSD: sshconnect.c,v 1.292 2018/01/23 18:33:49 stsp Exp $ */
+/* $OpenBSD: sshconnect.c,v 1.293 2018/02/07 22:52:45 dtucker Exp $ */
 /*
  * Author: Tatu Ylonen <ylo@cs.hut.fi>
  * Copyright (c) 1995 Tatu Ylonen <ylo@cs.hut.fi>, Espoo, Finland
@@ -1177,8 +1177,7 @@
 		host_key = raw_key;
 		goto retry;
 	}
-	if (raw_key != NULL)
-		sshkey_free(raw_key);
+	sshkey_free(raw_key);
 	free(ip);
 	free(host);
 	if (host_hostkeys != NULL)

sshconnect2.c

diff --git a/sshconnect2.c b/sshconnect2.c
index 870c3d2..8138e46 100644
--- a/sshconnect2.c
+++ b/sshconnect2.c
@@ -1,4 +1,4 @@
-/* $OpenBSD: sshconnect2.c,v 1.267 2018/01/23 05:27:21 djm Exp $ */
+/* $OpenBSD: sshconnect2.c,v 1.268 2018/02/07 22:52:45 dtucker Exp $ */
 /*
  * Copyright (c) 2000 Markus Friedl.  All rights reserved.
  * Copyright (c) 2008 Damien Miller.  All rights reserved.
@@ -624,8 +624,7 @@
 		}
 	}
 done:
-	if (key != NULL)
-		key_free(key);
+	key_free(key);
 	free(pkalg);
 	free(pkblob);