| commit | 12bc1c4dae87f210dc1b379d658a7f329c74d469 | [log] [tgz] |
|---|---|---|
| author | Tom Sepez <tsepez@chromium.org> | Tue Jul 30 19:29:08 2019 +0000 |
| committer | Chromium commit bot <commit-bot@chromium.org> | Tue Jul 30 19:29:08 2019 +0000 |
| tree | 4ab219bd64bebe6ae207ab9fe7c80d7077cb8293 | |
| parent | 45501f3d1eac1d34b4abaf22d04428e61257a801 [diff] [blame] |
Use RetainableTreeNode for LayoutItems. Removes explicit deletes. The CL at https://pdfium-review.googlesource.com/c/pdfium/+/54790 fixes a lifetime issue with TT faces that was exposed by this CL. Update a few places where the FF widgets go away earlier. Change-Id: I52ba800af7044a418365fa1df6cf56065103fed9 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/54190 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org>
diff --git a/fpdfsdk/cpdfsdk_interactiveform.cpp b/fpdfsdk/cpdfsdk_interactiveform.cpp index 6d65d57..b33bd06 100644 --- a/fpdfsdk/cpdfsdk_interactiveform.cpp +++ b/fpdfsdk/cpdfsdk_interactiveform.cpp
@@ -235,8 +235,8 @@ } void CPDFSDK_InteractiveForm::RemoveXFAMap(CXFA_FFWidget* hWidget) { - ASSERT(hWidget); - m_XFAMap.erase(hWidget); + if (hWidget) + m_XFAMap.erase(hWidget); } CPDFSDK_XFAWidget* CPDFSDK_InteractiveForm::GetXFAWidget(