commit 24a48881c5407651a58cfd6547ac9b6a9823a63e
author tsepez <tsepez@chromium.org> Mon Apr 11 15:18:40 2016 -0700
committer Commit bot <commit-bot@chromium.org> Mon Apr 11 15:18:40 2016 -0700
tree 845e370897a8479fe83b99d56352965c562da717
parent 1fdde02d90963f774e7d1b6b0353d23aefe0a357

Pass CFX_ByteStrings rather than raw ptrs to JS_GlobalData.

Helps to avoid re-allocating strings when the caller already
has one allocated.

Review URL: https://codereview.chromium.org/1876203002

fpdfsdk/javascript/global.cpp

diff --git a/fpdfsdk/javascript/global.cpp b/fpdfsdk/javascript/global.cpp
index fe974c7..d843b60 100644
--- a/fpdfsdk/javascript/global.cpp
+++ b/fpdfsdk/javascript/global.cpp
@@ -407,7 +407,7 @@
   m_mapGlobal.clear();
 }
 
-FX_BOOL JSGlobalAlternate::SetGlobalVariables(const FX_CHAR* propname,
+FX_BOOL JSGlobalAlternate::SetGlobalVariables(const CFX_ByteString& propname,
                                               int nType,
                                               double dData,
                                               bool bData,