commit 3343d146f2d9cd2f9eaa3a40fed3a5b94f3f107e
author Tom Sepez <tsepez@chromium.org> Mon Nov 02 09:54:54 2015 -0800
committer Tom Sepez <tsepez@chromium.org> Mon Nov 02 09:54:54 2015 -0800
tree ab220ffcea223cacd136054603c63324a1d9d5f4
parent 1b700c3c452429dacde3c163a6edb2706f93d4a7

Fix XFA compilation noise, part 1.

Mainly:
  volatile/override/method shadowing.
  unused variables.
  intialization list init order.

R=thestig@chromium.org

Review URL: https://codereview.chromium.org/1422113003 .

fpdfsdk/src/javascript/JS_Runtime.h

diff --git a/fpdfsdk/src/javascript/JS_Runtime.h b/fpdfsdk/src/javascript/JS_Runtime.h
index 4772823..01a8827 100644
--- a/fpdfsdk/src/javascript/JS_Runtime.h
+++ b/fpdfsdk/src/javascript/JS_Runtime.h
@@ -57,10 +57,11 @@
   v8::Isolate* GetIsolate() const { return m_isolate; }
   v8::Local<v8::Context> NewJSContext();
 
-  virtual FX_BOOL GetHValueByName(const CFX_ByteStringC& utf8Name,
-                                  FXJSE_HVALUE hValue);
-  virtual FX_BOOL SetHValueByName(const CFX_ByteStringC& utf8Name,
-                                  FXJSE_HVALUE hValue);
+  // IJS_Runtime:
+  FX_BOOL GetHValueByName(const CFX_ByteStringC& utf8Name,
+                          FXJSE_HVALUE hValue) override;
+  FX_BOOL SetHValueByName(const CFX_ByteStringC& utf8Name,
+                          FXJSE_HVALUE hValue) override;
 
   void AddObserver(Observer* observer);
   void RemoveObserver(Observer* observer);