Add CFXJSE_Value::IsEmpty() and use it in SetArray()
Because values have yet another possibility: they might be empty
and v8 will assert if we try to set an array element to an empty
value. Note that this is an entirely different state than being
undefined, or null, which it handles properly. In fact, newly
created CFXJSE_Values are IsEmpty().
Needed to fix a segv in a forthcoming CL.
Change-Id: I74f075ab3e483533e9c6ad81254e2b819553cdf8
Reviewed-on: https://pdfium-review.googlesource.com/c/48750
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
diff --git a/fxjs/BUILD.gn b/fxjs/BUILD.gn
index e4435b3..706884b 100644
--- a/fxjs/BUILD.gn
+++ b/fxjs/BUILD.gn
@@ -478,7 +478,10 @@
pdfium_root_dir = "../"
if (pdf_enable_xfa) {
- sources += [ "xfa/cfxjse_formcalc_context_embeddertest.cpp" ]
+ sources += [
+ "xfa/cfxjse_formcalc_context_embeddertest.cpp",
+ "xfa/cfxjse_value_embeddertest.cpp",
+ ]
deps += [ "..///xfa/fxfa" ]
}
}