commit 5f95f36cac52c92d34bffbfa22a7da49d0653978
author Nicolás Peña <npm@chromium.org> Thu Sep 28 13:00:45 2017 +0900
committer Chromium commit bot <commit-bot@chromium.org> Thu Sep 28 04:11:37 2017 +0000
tree 85f9004d9b290e07cfd2d0bfeef26e288d96bdde
parent 86f5cf12b517d348a64868a477a19fbf1f1318fc

Change bottom-top order in FontBBox

The FontBBox, for compatiblity reasons, must be specified top to
bottom. This CL flips the current implementation which was bottom to
top.

Bug: pdfium:892
Change-Id: Ieb8d3bb183ed7870e3b3d7f0380f1343adedf87b
Reviewed-on: https://pdfium-review.googlesource.com/14851
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Reviewed-by: dsinclair <dsinclair@chromium.org>

fpdfsdk/fpdfedittext.cpp

diff --git a/fpdfsdk/fpdfedittext.cpp b/fpdfsdk/fpdfedittext.cpp
index 2a9ef53..bac1108 100644
--- a/fpdfsdk/fpdfedittext.cpp
+++ b/fpdfsdk/fpdfedittext.cpp
@@ -54,9 +54,9 @@
   pFont->GetBBox(bbox);
   auto pBBox = pdfium::MakeUnique<CPDF_Array>();
   pBBox->AddNew<CPDF_Number>(bbox.left);
-  pBBox->AddNew<CPDF_Number>(bbox.bottom);
-  pBBox->AddNew<CPDF_Number>(bbox.right);
   pBBox->AddNew<CPDF_Number>(bbox.top);
+  pBBox->AddNew<CPDF_Number>(bbox.right);
+  pBBox->AddNew<CPDF_Number>(bbox.bottom);
   fontDesc->SetFor("FontBBox", std::move(pBBox));
 
   // TODO(npm): calculate italic angle correctly