commit 63fbd8d8ece5f49f7f9b8cac29b9aba73d5d7d23
author Dan Sinclair <dsinclair@chromium.org> Wed Jul 05 14:10:36 2017 -0400
committer Chromium commit bot <commit-bot@chromium.org> Wed Jul 05 18:22:59 2017 +0000
tree 6d07eca9ea6be919963e5411f8dad89c60913354
parent 7e0336e278d69f1d66967db7375c75322da55d69

Remove PNM_SCROLLWINDOW and replace with direct method

This CL removes PNM_SCROLLWINDOW from OnNotify and replaces it with a call to
ScrollWindowVerticallyTo.

Change-Id: I62f6da60cdcd4926b0c74b980b3855a28a834411
Reviewed-on: https://pdfium-review.googlesource.com/7253
Commit-Queue: dsinclair <dsinclair@chromium.org>
Reviewed-by: Nicolás Peña <npm@chromium.org>

fpdfsdk/pdfwindow/cpwl_edit_ctrl.cpp

diff --git a/fpdfsdk/pdfwindow/cpwl_edit_ctrl.cpp b/fpdfsdk/pdfwindow/cpwl_edit_ctrl.cpp
index f18aaaa..2c005a4 100644
--- a/fpdfsdk/pdfwindow/cpwl_edit_ctrl.cpp
+++ b/fpdfsdk/pdfwindow/cpwl_edit_ctrl.cpp
@@ -74,6 +74,10 @@
     pChild->SetScrollPosition(pos);
 }
 
+void CPWL_EditCtrl::ScrollWindowVertically(float pos) {
+  m_pEdit->SetScrollPos(CFX_PointF(m_pEdit->GetScrollPos().x, pos));
+}
+
 void CPWL_EditCtrl::OnNotify(CPWL_Wnd* pWnd,
                              uint32_t msg,
                              intptr_t wParam,
@@ -81,14 +85,6 @@
   CPWL_Wnd::OnNotify(pWnd, msg, wParam, lParam);
 
   switch (msg) {
-    case PNM_SCROLLWINDOW: {
-      float fPos = *(float*)lParam;
-      switch (wParam) {
-        case SBT_VSCROLL:
-          m_pEdit->SetScrollPos(CFX_PointF(m_pEdit->GetScrollPos().x, fPos));
-          break;
-      }
-    } break;
     case PNM_SETCARETINFO: {
       if (PWL_CARET_INFO* pCaretInfo = (PWL_CARET_INFO*)wParam) {
         SetCaret(pCaretInfo->bVisible, pCaretInfo->ptHead, pCaretInfo->ptFoot);