commit 77fe069bd19ea8207664293f631c63dab330f825
author Dan Sinclair <dsinclair@chromium.org> Thu Nov 02 18:15:07 2017 +0000
committer Chromium commit bot <commit-bot@chromium.org> Thu Nov 02 18:15:07 2017 +0000
tree 25ecc84aefed75c57c7783e464392591d71cc692
parent f45406f8ec992560353756cff1e2c3931984e62b

Remove default value to CJX_Node::SetAttribute

The bNotify value has been moved into the call sites and the default
removed.

Change-Id: Ifd2c0252b0f1421f7fc244d69e6f6bddc80e5591
Reviewed-on: https://pdfium-review.googlesource.com/17450
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: dsinclair <dsinclair@chromium.org>

fxjs/cjx_node.cpp

diff --git a/fxjs/cjx_node.cpp b/fxjs/cjx_node.cpp
index 64894b7..3fd0877 100644
--- a/fxjs/cjx_node.cpp
+++ b/fxjs/cjx_node.cpp
@@ -2732,7 +2732,8 @@
                                     bool bSetting,
                                     XFA_ATTRIBUTE eAttribute) {
   if (bSetting) {
-    SetAttribute(XFA_ATTRIBUTE_Checksum, pValue->ToWideString().AsStringView());
+    SetAttribute(XFA_ATTRIBUTE_Checksum, pValue->ToWideString().AsStringView(),
+                 false);
     return;
   }
   WideString wsChecksum;
@@ -3440,7 +3441,8 @@
         GetAttribute(XFA_ATTRIBUTE_ContentType, wsContentType, false);
         if (wsContentType == L"text/html") {
           wsContentType = L"";
-          SetAttribute(XFA_ATTRIBUTE_ContentType, wsContentType.AsStringView());
+          SetAttribute(XFA_ATTRIBUTE_ContentType, wsContentType.AsStringView(),
+                       false);
         }
       }
       CXFA_Node* pContentRawDataNode =
@@ -3531,7 +3533,7 @@
         CXFA_Node* pChildValue = pValue->GetNodeItem(XFA_NODEITEM_FirstChild);
         if (pChildValue && XFA_FieldIsMultiListBox(GetXFANode())) {
           pChildValue->JSNode()->SetAttribute(XFA_ATTRIBUTE_ContentType,
-                                              L"text/xml");
+                                              L"text/xml", false);
         }
         return pChildValue ? pChildValue->JSNode()->TryContent(
                                  wsContent, bScriptModify, bProto)

fxjs/cjx_node.h

diff --git a/fxjs/cjx_node.h b/fxjs/cjx_node.h
index 77c564e..47fb0d6 100644
--- a/fxjs/cjx_node.h
+++ b/fxjs/cjx_node.h
@@ -55,11 +55,10 @@
   bool HasAttribute(XFA_ATTRIBUTE eAttr);
   bool SetAttribute(XFA_ATTRIBUTE eAttr,
                     const WideStringView& wsValue,
-                    bool bNotify = false);
-
+                    bool bNotify);
   bool SetAttribute(const WideStringView& wsAttr,
                     const WideStringView& wsValue,
-                    bool bNotify = false);
+                    bool bNotify);
   bool GetAttribute(const WideStringView& wsAttr,
                     WideString& wsValue,
                     bool bUseDefault = true);

xfa/fxfa/parser/cxfa_image.cpp

diff --git a/xfa/fxfa/parser/cxfa_image.cpp b/xfa/fxfa/parser/cxfa_image.cpp
index cfa3db7..3407239 100644
--- a/xfa/fxfa/parser/cxfa_image.cpp
+++ b/xfa/fxfa/parser/cxfa_image.cpp
@@ -43,7 +43,7 @@
   if (m_bDefValue)
     return m_pNode->JSNode()->SetCData(XFA_ATTRIBUTE_Href, wsHref);
   return m_pNode->JSNode()->SetAttribute(XFA_ATTRIBUTE_Href,
-                                         wsHref.AsStringView());
+                                         wsHref.AsStringView(), false);
 }
 
 bool CXFA_Image::SetTransferEncoding(int32_t iTransferEncoding) {

xfa/fxfa/parser/cxfa_nodehelper.cpp

diff --git a/xfa/fxfa/parser/cxfa_nodehelper.cpp b/xfa/fxfa/parser/cxfa_nodehelper.cpp
index 6bf7cc2..d8ccf85 100644
--- a/xfa/fxfa/parser/cxfa_nodehelper.cpp
+++ b/xfa/fxfa/parser/cxfa_nodehelper.cpp
@@ -358,7 +358,7 @@
       CXFA_Node* pNewNode = m_pCreateParent->CreateSamePacketNode(eClassType);
       if (pNewNode) {
         pNewNode->JSNode()->SetAttribute(XFA_ATTRIBUTE_Name,
-                                         wsName.AsStringView());
+                                         wsName.AsStringView(), false);
         pNewNode->CreateXMLMappingNode();
         m_pCreateParent->InsertChild(pNewNode);
         if (iIndex == m_iCreateCount - 1) {

xfa/fxfa/parser/cxfa_simple_parser.cpp

diff --git a/xfa/fxfa/parser/cxfa_simple_parser.cpp b/xfa/fxfa/parser/cxfa_simple_parser.cpp
index 9d3f2b0..c129214 100644
--- a/xfa/fxfa/parser/cxfa_simple_parser.cpp
+++ b/xfa/fxfa/parser/cxfa_simple_parser.cpp
@@ -651,7 +651,7 @@
       pNode->JSNode()->SetCData(XFA_ATTRIBUTE_Name,
                                 XFA_GetPacketByIndex(XFA_PACKET_Form)->pName);
       pNode->JSNode()->SetAttribute(XFA_ATTRIBUTE_Checksum,
-                                    wsChecksum.AsStringView());
+                                    wsChecksum.AsStringView(), false);
       CXFA_Node* pTemplateRoot =
           m_pRootNode->GetFirstChildByClass(XFA_Element::Template);
       CXFA_Node* pTemplateChosen =
@@ -877,7 +877,7 @@
           return nullptr;
         if (ePacketID == XFA_XDPPACKET_Config) {
           pXFAChild->JSNode()->SetAttribute(XFA_ATTRIBUTE_Name,
-                                            wsTagName.AsStringView());
+                                            wsTagName.AsStringView(), false);
         }
 
         bool IsNeedValue = true;
@@ -897,7 +897,7 @@
             continue;
           }
           pXFAChild->JSNode()->SetAttribute(lpAttrInfo->eName,
-                                            it.second.AsStringView());
+                                            it.second.AsStringView(), false);
         }
         pXFANode->InsertChild(pXFAChild);
         if (eType == XFA_Element::Validate || eType == XFA_Element::Locale) {