commit 8a1758bf11c2d741e0cddc761b1dd2cdf564db93
author Ryan Harrison <rharrison@chromium.org> Tue Aug 15 10:37:59 2017 -0400
committer Chromium commit bot <commit-bot@chromium.org> Tue Aug 15 15:03:10 2017 +0000
tree 82cbafc46f574a05ae0c1d1d3d7f9ebde6cb932d
parent 171cb27a720036c48ae3a6176084e880742af0a9

Remove GetAt from string classes

This method duplicates the behaviour of the const [] operator and
doesn't offer any additional safety. Folding them into one
implementation.

SetAt is retained, since implementing the non-const [] operator to
replace SetAt has potential performance concerns. Specifically many
non-obvious cases of reading an element using [] will cause a realloc
& copy.

BUG=pdfium:860

Change-Id: I3ef5e5e5a15376f040256b646eb0d90636e24b67
Reviewed-on: https://pdfium-review.googlesource.com/10870
Commit-Queue: Ryan Harrison <rharrison@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>

fpdfsdk/javascript/Document.cpp

diff --git a/fpdfsdk/javascript/Document.cpp b/fpdfsdk/javascript/Document.cpp
index 77878a5..9b82147 100644
--- a/fpdfsdk/javascript/Document.cpp
+++ b/fpdfsdk/javascript/Document.cpp
@@ -1018,7 +1018,7 @@
   CFX_WideString wsFilePath = m_pFormFillEnv->JS_docGetFilePath();
   int32_t i = wsFilePath.GetLength() - 1;
   for (; i >= 0; i--) {
-    if (wsFilePath.GetAt(i) == L'\\' || wsFilePath.GetAt(i) == L'/')
+    if (wsFilePath[i] == L'\\' || wsFilePath[i] == L'/')
       break;
   }
   if (i >= 0 && i < wsFilePath.GetLength() - 1) {