commit 940967de0b588d3abb9cba5822ae5f5c5fe05017
author Tom Sepez <tsepez@chromium.org> Thu May 18 12:32:20 2017 -0700
committer Chromium commit bot <commit-bot@chromium.org> Thu May 18 20:16:06 2017 +0000
tree 6c34432c66d716918efd1917075076dbd870084a
parent 690d456ad54f021063dcc17fde27c7ba4d910717

Use Unowned/Observed pointers between doc and FF onwership hierarchies.

See the explanation in CPDFSDK_FormFillEnvironment.h

Change-Id: I52feb25fb358831233a636e3ead5aa70e98c5baa
Reviewed-on: https://pdfium-review.googlesource.com/5658
Reviewed-by: dsinclair <dsinclair@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>

fpdfsdk/javascript/JS_Runtime_Stub.cpp

diff --git a/fpdfsdk/javascript/JS_Runtime_Stub.cpp b/fpdfsdk/javascript/JS_Runtime_Stub.cpp
index dcd8ceb..73a38fc 100644
--- a/fpdfsdk/javascript/JS_Runtime_Stub.cpp
+++ b/fpdfsdk/javascript/JS_Runtime_Stub.cpp
@@ -6,6 +6,7 @@
 
 #include <memory>
 
+#include "core/fxcrt/cfx_unowned_ptr.h"
 #include "fpdfsdk/javascript/ijs_event_context.h"
 #include "fpdfsdk/javascript/ijs_runtime.h"
 #include "third_party/base/ptr_util.h"
@@ -133,7 +134,7 @@
   void ReleaseEventContext(IJS_EventContext* pContext) override {}
 
   CPDFSDK_FormFillEnvironment* GetFormFillEnv() const override {
-    return m_pFormFillEnv;
+    return m_pFormFillEnv.Get();
   }
 
 #ifdef PDF_ENABLE_XFA
@@ -152,7 +153,7 @@
   }
 
  protected:
-  CPDFSDK_FormFillEnvironment* m_pFormFillEnv;
+  CFX_UnownedPtr<CPDFSDK_FormFillEnvironment> const m_pFormFillEnv;
   std::unique_ptr<CJS_EventContextStub> m_pContext;
 };