commit 956553e715787cfc4dd8423d5e9a04a0131878c3
author jaepark <jaepark@google.com> Wed Aug 31 06:49:27 2016 -0700
committer Commit bot <commit-bot@chromium.org> Wed Aug 31 06:49:27 2016 -0700
tree 08622d504322d5dae37b5bb5025a90c81ebdee6b
parent 87dffc0315477150c9c1964913b65bc97bdf654f

Use enum class for subtypes of CPDF_Annot.

Comparing CFX_ByteString for annotation subtypes is inefficient and
error-prone. This CL uses enum class to compare annotation subtypes.

Also, remove unused IPDFSDK_AnnotHandler::GetType() and
FSDK_XFAWIDGET_TYPENAME.

Review-Url: https://codereview.chromium.org/2295953002

fpdfsdk/cpdfsdk_interform.cpp

diff --git a/fpdfsdk/cpdfsdk_interform.cpp b/fpdfsdk/cpdfsdk_interform.cpp
index 1346deb..345487a 100644
--- a/fpdfsdk/cpdfsdk_interform.cpp
+++ b/fpdfsdk/cpdfsdk_interform.cpp
@@ -71,8 +71,8 @@
 
 CPDFSDK_Widget* CPDFSDK_InterForm::GetSibling(CPDFSDK_Widget* pWidget,
                                               FX_BOOL bNext) const {
-  std::unique_ptr<CBA_AnnotIterator> pIterator(
-      new CBA_AnnotIterator(pWidget->GetPageView(), "Widget"));
+  std::unique_ptr<CBA_AnnotIterator> pIterator(new CBA_AnnotIterator(
+      pWidget->GetPageView(), CPDF_Annot::Subtype::WIDGET));
 
   if (bNext)
     return static_cast<CPDFSDK_Widget*>(pIterator->GetNextAnnot(pWidget));