| commit | a282c7380f3964de41ea93c9980b12c4513d3473 | [log] [tgz] |
|---|---|---|
| author | dsinclair <dsinclair@chromium.org> | Thu Oct 13 12:14:34 2016 -0700 |
| committer | Commit bot <commit-bot@chromium.org> | Thu Oct 13 12:14:35 2016 -0700 |
| tree | 5202284e527cd2bdcd7bcd22495018c9fbff1fd5 | |
| parent | f3736bca5f874b0889c5906ffbd74a405089f671 [diff] [blame] |
Revert of Reland: Make the CPDFXFA_App non-global (patchset #2 id:20001 of https://codereview.chromium.org/2418653003/ ) Reason for revert: https://build.chromium.org/p/client.pdfium/builders/linux_xfa_asan_lsan/builds/117/steps/corpus%20tests/logs/stdio Original issue's description: > Reland: Make the CPDFXFA_App non-global > > This reverts commit b685e6471075bebd26711bc183de3128f54932e3. > > This CL changes CPDFXFA_App from a global object to a child of the CPDFXFA_Document objects. > > BUG=pdfium:623 > > Committed: https://pdfium.googlesource.com/pdfium/+/f3736bca5f874b0889c5906ffbd74a405089f671 TBR=tsepez@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=pdfium:623 Review-Url: https://codereview.chromium.org/2414883006
diff --git a/fpdfsdk/fpdfdoc_unittest.cpp b/fpdfsdk/fpdfdoc_unittest.cpp index 45beacf..fc85404 100644 --- a/fpdfsdk/fpdfdoc_unittest.cpp +++ b/fpdfsdk/fpdfdoc_unittest.cpp
@@ -35,7 +35,8 @@ class CPDF_TestXFADocument : public CPDFXFA_Document { public: CPDF_TestXFADocument() - : CPDFXFA_Document(pdfium::MakeUnique<CPDF_TestDocument>()) {} + : CPDFXFA_Document(pdfium::MakeUnique<CPDF_TestDocument>(), + CPDFXFA_App::GetInstance()) {} void SetRoot(CPDF_Dictionary* root) { reinterpret_cast<CPDF_TestDocument*>(GetPDFDoc())->SetRoot(root);