Merge to XFA: Return OS status code from python test driver scripts.
Original Review URL: https://codereview.chromium.org/1014083003
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1011243002
diff --git a/testing/tools/run_javascript_tests.py b/testing/tools/run_javascript_tests.py
index 4361ea0..ddc8266 100755
--- a/testing/tools/run_javascript_tests.py
+++ b/testing/tools/run_javascript_tests.py
@@ -30,6 +30,8 @@
subprocess.check_call(['diff', expected_path, txt_path])
except subprocess.CalledProcessError as e:
print "FAILURE: " + input_filename + "; " + str(e)
+ return False
+ return True
def main():
parser = optparse.OptionParser()
@@ -78,14 +80,17 @@
if not os.path.exists(working_dir):
os.makedirs(working_dir)
+ os_exit_code = 0
input_file_re = re.compile('^[a-zA-Z0-9_.]+[.]in$')
for input_filename in os.listdir(source_dir):
if input_file_re.match(input_filename):
input_path = os.path.join(source_dir, input_filename)
if os.path.isfile(input_path):
- generate_and_test(input_filename, source_dir, working_dir,
- fixup_path, pdfium_test_path)
- return 0
+ if not generate_and_test(input_filename, source_dir, working_dir,
+ fixup_path, pdfium_test_path):
+ os_exit_code = 1
+
+ return os_exit_code
if __name__ == '__main__':