commit c08cd7abb2069b6056ec99c8ec5b87524e45df01
author thestig <thestig@chromium.org> Mon Jun 27 09:47:59 2016 -0700
committer Commit bot <commit-bot@chromium.org> Mon Jun 27 09:47:59 2016 -0700
tree a1b919599cd5f3f23aeb9834aff5b6d21c7549ec
parent dff03da3d403b72098d5d43ea90b03ed340de5ec

Fix memory leaks with V8 startup data.

Review-Url: https://codereview.chromium.org/2068563002

testing/test_support.cpp

diff --git a/testing/test_support.cpp b/testing/test_support.cpp
index 96a18a5..c4d915e 100644
--- a/testing/test_support.cpp
+++ b/testing/test_support.cpp
@@ -157,12 +157,14 @@
                            v8::StartupData* snapshot_blob,
                            v8::Platform** platform) {
   InitializeV8Common(exe_path.c_str(), platform);
-  if (!GetExternalData(exe_path, bin_dir, "natives_blob.bin", natives_blob))
-    return false;
-  if (!GetExternalData(exe_path, bin_dir, "snapshot_blob.bin", snapshot_blob))
-    return false;
-  v8::V8::SetNativesDataBlob(natives_blob);
-  v8::V8::SetSnapshotDataBlob(snapshot_blob);
+  if (natives_blob && snapshot_blob) {
+    if (!GetExternalData(exe_path, bin_dir, "natives_blob.bin", natives_blob))
+      return false;
+    if (!GetExternalData(exe_path, bin_dir, "snapshot_blob.bin", snapshot_blob))
+      return false;
+    v8::V8::SetNativesDataBlob(natives_blob);
+    v8::V8::SetSnapshotDataBlob(snapshot_blob);
+  }
   return true;
 }
 #else   // V8_USE_EXTERNAL_STARTUP_DATA