Refactoring JS Callbacks.
This CL updates the fpdfsdk/javascript callbacks to have explicit
get/set methods instead of one method which worked differently
depending on the mode.
This allows better ownership of the passed in params, (get takes a *
and set takes a const&). The Value object was changed to have To*
and Set methods to make the code clearer compared to the operator<<
and operator>> overloading.
Bug:
Change-Id: Id6ff20a4e3252adfd0a78b643e50b9f095085018
Reviewed-on: https://pdfium-review.googlesource.com/16330
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: dsinclair <dsinclair@chromium.org>
diff --git a/fpdfsdk/javascript/PublicMethods.cpp b/fpdfsdk/javascript/PublicMethods.cpp
index af47159..7758771 100644
--- a/fpdfsdk/javascript/PublicMethods.cpp
+++ b/fpdfsdk/javascript/PublicMethods.cpp
@@ -850,9 +850,9 @@
CJS_PropValue vProp(pRuntime);
vProp.StartGetting();
- vProp << arColor;
+ vProp.Set(arColor);
vProp.StartSetting();
- fTarget->textColor(pRuntime, vProp, sError); // red
+ fTarget->set_text_color(pRuntime, vProp, &sError); // red
}
}
} else {
@@ -869,7 +869,7 @@
CJS_PropValue vProp(pRuntime);
vProp.StartGetting();
- fTarget->textColor(pRuntime, vProp, sError);
+ fTarget->get_text_color(pRuntime, &vProp, &sError);
CJS_Array aProp;
vProp.GetJSValue()->ConvertToArray(pRuntime, aProp);
@@ -882,9 +882,9 @@
if (crColor != crProp) {
CJS_PropValue vProp2(pRuntime);
vProp2.StartGetting();
- vProp2 << arColor;
+ vProp2.Set(arColor);
vProp2.StartSetting();
- fTarget->textColor(pRuntime, vProp2, sError);
+ fTarget->set_text_color(pRuntime, vProp2, &sError);
}
}
}