tree 3e99ea1e5090c1fc1f791e971fa7f47404392d40
parent f7926992c6852e2a842d197412b0eeb47743b10d
author Lei Zhang <thestig@chromium.org> 1576778067 +0000
committer Chromium commit bot <commit-bot@chromium.org> 1576778067 +0000

Do less work in XFATestEnvironment::SetUp().

XFATestEnvironment::SetUp() gets called once per gtest test environment
set-up. With --gtest-repeat=N, XFATestEnvironment::SetUp() gets called N
times. Whereas InitializeXFATestEnvironment(), which instantiates
XFATestEnvironment, is only called once for the lifetime of the test
suite.

Given this, move the SystemFontInfoIface::CreateDefault() call out of
XFATestEnvironment::SetUp() and into InitializeXFATestEnvironment().
This makes repeated test runs have constant test environment set-up
time, instead of getting slower with each repeated test run.

Change-Id: I6ed1e01244d2dacd97af5ef5da5399479d69e60c
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/64250
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>