commit f3dc8c6941635e5c4cc20c8388289f6b148dc9eb
author tsepez <tsepez@chromium.org> Wed Aug 10 06:29:29 2016 -0700
committer Commit bot <commit-bot@chromium.org> Wed Aug 10 06:29:29 2016 -0700
tree 2e56d2707bed8383cb7950ea4ccda65f3bc30e71
parent 85af2a3cfcdfb2200510d337bfbf5b405858aa3b

Remove backpointer to CJS_Runtime from CJS_Value

Review-Url: https://codereview.chromium.org/2227673005

fpdfsdk/javascript/JS_Define.h

diff --git a/fpdfsdk/javascript/JS_Define.h b/fpdfsdk/javascript/JS_Define.h
index e120758..4c24a4d 100644
--- a/fpdfsdk/javascript/JS_Define.h
+++ b/fpdfsdk/javascript/JS_Define.h
@@ -92,7 +92,7 @@
                                             sError));
     return;
   }
-  info.GetReturnValue().Set(value.ToV8Value());
+  info.GetReturnValue().Set(value.GetJSValue()->ToV8Value(isolate));
 }
 
 template <class C,
@@ -111,7 +111,7 @@
   CJS_Object* pJSObj = (CJS_Object*)FXJS_GetPrivate(isolate, info.Holder());
   C* pObj = reinterpret_cast<C*>(pJSObj->GetEmbedObject());
   CFX_WideString sError;
-  CJS_PropValue propValue(CJS_Value(pRuntime, value));
+  CJS_PropValue propValue(pRuntime, CJS_Value(pRuntime, value));
   propValue.StartSetting();
   if (!(pObj->*M)(pContext, propValue, sError)) {
     FXJS_Error(isolate, JSFormatErrorString(class_name_string, prop_name_string,
@@ -160,7 +160,7 @@
                                             method_name_string, sError));
     return;
   }
-  info.GetReturnValue().Set(valueRes.ToV8Value());
+  info.GetReturnValue().Set(valueRes.ToV8Value(isolate));
 }
 
 #define JS_STATIC_METHOD(method_name, class_name)                             \
@@ -383,7 +383,7 @@
     FXJS_Error(isolate, JSFormatErrorString(class_name, "GetProperty", sError));
     return;
   }
-  info.GetReturnValue().Set(value.ToV8Value());
+  info.GetReturnValue().Set(value.GetJSValue()->ToV8Value(isolate));
 }
 
 template <class Alt>
@@ -404,7 +404,7 @@
   CFX_WideString propname = CFX_WideString::FromUTF8(
       CFX_ByteStringC(*utf8_value, utf8_value.length()));
   CFX_WideString sError;
-  CJS_PropValue PropValue(CJS_Value(pRuntime, value));
+  CJS_PropValue PropValue(pRuntime, CJS_Value(pRuntime, value));
   PropValue.StartSetting();
   if (!pObj->DoProperty(pContext, propname.c_str(), PropValue, sError)) {
     FXJS_Error(isolate, JSFormatErrorString(class_name, "PutProperty", sError));
@@ -456,7 +456,7 @@
                JSFormatErrorString(func_name_string, nullptr, sError));
     return;
   }
-  info.GetReturnValue().Set(valueRes.ToV8Value());
+  info.GetReturnValue().Set(valueRes.ToV8Value(pRuntime->GetIsolate()));
 }
 
 #define JS_STATIC_GLOBAL_FUN(fun_name)                   \