Gitiles
Code Review
Sign In
gerrit-public.fairphone.software
/
platform
/
external
/
pdfium
/
4c59ad08c14ac31b745d868596cde886f0210f3f
/
xfa
/
fxfa
3d3dcdf
Simplify a call in CXFA_ImageRenderer::Start().
by Lei Zhang
· 6 years ago
ae5a4c9
Check for zero-length strings in CXFA_NodeHelper::CreateNode().
by Tom Sepez
· 6 years ago
266517d
Specify CFGAS_StringFormatter format at creation time.
by Tom Sepez
· 6 years ago
b271c06
Make CFGAS_StringFormatter::SplitOnBars() static.
by Tom Sepez
· 6 years ago
f81f9f0
Fix a crash in DataMerge_UpdateBindingRelations().
by Lei Zhang
· 6 years ago
c3abbbb
Use spans in CFGAS_StringFormatter::SplitFormatString()
by Tom Sepez
· 6 years ago
d62f028
Rename CFGAS_FormatString to CFGAS_StringFormatter.
by Tom Sepez
· 6 years ago
e11b4d7
Use spans in CFGAS_FormatString, part 2
by Tom Sepez
· 6 years ago
3df5c7c
Fix temporary going out of scope too early in XFA_LoadImageData()
by Tom Sepez
· 6 years ago
9ecb28f
Make members private in CXFA_LayoutItem, adding accessors.
by Tom Sepez
· 6 years ago
3727e2f
Tidy cxfa_itemlayoutprocessor.h
by Tom Sepez
· 6 years ago
f28eb5a
ExtractLayoutItem() breaks when current item found in old list.
by Tom Sepez
· 6 years ago
e8f5721
Fix a nullptr crash in CXFA_Node::GetLocaleName().
by Lei Zhang
· 6 years ago
8ad64c7
Fix 2 XFA nullptr crashes.
by Lei Zhang
· 6 years ago
91bef18
Rename "bool iFoo" variables to "bool bFoo".
by Lei Zhang
· 6 years ago
f4d777d
Check node types in CXFA_LayoutPageMgr::ProcessBreakBeforeOrAfter().
by Lei Zhang
· 6 years ago
434de07
Fix nits in CXFA_Document::DataMerge_CopyContainer().
by Lei Zhang
· 6 years ago
afc4979
Use early return in CXFA_LayoutPageMgr::ProcessBreakBeforeOrAfter().
by Lei Zhang
· 6 years ago
ed975f9
Forward declare CPDF_Stream when possible.
by Lei Zhang
· 6 years ago
333ac4a
Remove some more redundant CJX_Object subclass methods.
by Tom Sepez
· 6 years ago
cc6297d
Reflow CXFA_ItemLayoutProcessor::GotoNextContainerNode().
by Lei Zhang
· 6 years ago
b2f59ad
Split off code from CXFA_ItemLayoutProcessor::GotoNextContainerNode().
by Lei Zhang
· 6 years ago
26ba8e2
Use early returns in CXFA_FFNotify::OnCreateContentLayoutItem().
by Lei Zhang
· 6 years ago
bff397d
Move XFA_ItemLayoutProcessorStages into CXFA_ItemLayoutProcessor.
by Lei Zhang
· 6 years ago
1a2165d
Remove CFGAS_Decimal implicit conversion operators.
by Tom Sepez
· 6 years ago
20ac643
Use Optional return value inside CXFA_ItemLayoutProcessor.
by Lei Zhang
· 6 years ago
9693052
Give CXFA_ItemLayoutProcessor::GotoNextContainerNode() a return value.
by Lei Zhang
· 6 years ago
3407b0d
Use std::vector<TextCharPos> in CXFA_TextLayout.
by Lei Zhang
· 6 years ago
58fc126
Remove more redundant CJX attribute wrappers.
by Tom Sepez
· 6 years ago
793691a
Move some single-use CJX_Object property getters to subclasses.
by Tom Sepez
· 6 years ago
7abb469
Disallow invalid colspan values in RelocateTableRowCells().
by Lei Zhang
· 6 years ago
3f684bd
Add CJX_Object::GetMeasureInUnit();
by Lei Zhang
· 6 years ago
2f1edd6
Break off parts of CXFA_ItemLayoutProcessor::GotoNextContainerNode().
by Lei Zhang
· 6 years ago
011147f
Add null test before inserting in DoLayoutFlowedContainer()
by Tom Sepez
· 6 years ago
8c7f027
Clean up CFX_RTFBreak::GetDisplayPos() and its caller.
by Lei Zhang
· 6 years ago
b8df605
Break circular dependency between xfa/fxfa and xfa/fgas.
by Lei Zhang
· 6 years ago
7ab1c4c
Add JavaScript test for CXJ_Model object.
by Tom Sepez
· 6 years ago
8210549
Use even more size_t in CXFA_TextLayout.
by Lei Zhang
· 6 years ago
c85ee4e
Rename FXTEXT_CHARPOS and FXTEXT_GLYPHPOS.
by Lei Zhang
· 6 years ago
0dcb8fd
Remove unneeded fx_font.h includes from headers.
by Lei Zhang
· 6 years ago
ad7d586
Document that CXFA_Document::GetLayoutProcessor() never returns null
by Tom Sepez
· 6 years ago
537da1e
Fix xfa/fxfa/layout/BUILD.gn.
by Lei Zhang
· 6 years ago
75faf7b
Break CXFA_Node direct dependence on CXFA_LayoutProcessor.
by Tom Sepez
· 6 years ago
4b71e90
Use more size_t in CXFA_TextLayout.
by Lei Zhang
· 6 years ago
fabb0d3
CXFA_TextProvider does not need to know about layout/ objects
by Tom Sepez
· 6 years ago
8ec3cb1
Separate CXFA layout hierarchy from CXFA parser hierarchy.
by Tom Sepez
· 6 years ago
5830d87
Change CXFA_ContentLayoutItem::GetIndex() to return size_t.
by Lei Zhang
· 6 years ago
b11ecd3
Create CXFA_FFDoc via static function.
by Tom Sepez
· 6 years ago
e039dc3
Remove unneeded testing/test_support.h includes.
by Lei Zhang
· 6 years ago
fef199e
Use size_t for BlockData in CXFA_TextLayout.
by Lei Zhang
· 6 years ago
75fa481
Simplify a conditional in CXFA_TextLayout::ItemBlocks().
by Lei Zhang
· 6 years ago
6ea07ba
Use size_t for |iBlockIndex| in CXFA_TextLayout::DoSplitLayout().
by Lei Zhang
· 6 years ago
c2c8e63
Split CXFA_TextLayout::DoLayout() into two.
by Lei Zhang
· 6 years ago
69873e9
Mark CXFA_Document::notify_ as const.
by Tom Sepez
· 6 years ago
520d5f2
Get rid of |CXFA_TextLayout::m_Blocks| wrappers.
by Lei Zhang
· 6 years ago
503c246
Use a struct for |CXFA_TextLayout::m_Blocks|.
by Lei Zhang
· 6 years ago
cdb8549
Wrap direct access to elements in |CXFA_TextLayout::m_Blocks|.
by Lei Zhang
· 6 years ago
229def4
Fix indexing confusion in CXFA_TextLayout::Layout().
by Lei Zhang
· 6 years ago
9e2d243
Use a struct for |CXFA_LoaderContext::blockHeights|.
by Lei Zhang
· 6 years ago
12eacc8
Copy m_NewAddedNodes before iterating over it.
by Tom Sepez
· 6 years ago
0e08d59
Clean up parts of CXFA_TextLayout::DoLayout().
by Lei Zhang
· 6 years ago
43a4e15
Clean up CXFA_TextLayout.
by Lei Zhang
· 6 years ago
96a7c58
Resolve xfa/fxa/parser to xfa/fgas/crt circular includes.
by Tom Sepez
· 6 years ago
9301f89
Remove optional parameters to FindPageAreaFromPageSet_SimplexDuplex().
by Lei Zhang
· 6 years ago
202486b
Clean up CXFA_RenderContext.
by Lei Zhang
· 6 years ago
7eeb78e
Split XFA_FFWidgetType into its own header file.
by Lei Zhang
· 6 years ago
3c90892
Prevent cxfa_contentlayoutitem linked lists from getting entangled.
by Tom Sepez
· 6 years ago
a482e1f
Remove unreachable null checks for CXFA_Document::GetScriptContext().
by Tom Sepez
· 6 years ago
b600f15
Remove optional parameter from CFWL_Edit::SetText().
by Lei Zhang
· 6 years ago
a8c86c2
Delete "NULL terminator" CFXA_Node property/attribute records.
by Tom Sepez
· 6 years ago
578e248
Store properties/attributes in CXFA_Node as span<>
by Tom Sepez
· 6 years ago
c0fa5f6
Pass attributes and properties to CFXA_Node as span<>
by Tom Sepez
· 6 years ago
148c144
Deprecate 7-Arg form of CFXA_Node constructor.
by Tom Sepez
· 6 years ago
da86ca3
Remove last CJX_ classes that do not meaningfully extend superclasses
by Tom Sepez
· 6 years ago
f0898a2
Remove CJX_ classes that do not meaningfully extend CJX_Container.
by Tom Sepez
· 6 years ago
e24ead1
Remove CJX_ classes that do not meaningfully extend CJX_TextNode
by Tom Sepez
· 6 years ago
ef6c19f
Remove CJX_ classes that do not meaningfully extend CJX_Node.
by Tom Sepez
· 6 years ago
e799885
Remove unneeded cfx_memorystream.h includes.
by Lei Zhang
· 6 years ago
13a5f9e
Remove ampersands from element_attributes.inc function name entries
by Tom Sepez
· 6 years ago
56250c3
Rework JSE_PROP() macro to avoid illegal cast in xfa_basic_data.cpp.
by Tom Sepez
· 6 years ago
8dbd0e2
CXFA_GEPattern::m_matrix is always the identity matrix.
by Tom Sepez
· 6 years ago
cd85620
No need to check return value from CXFA_Graphics::GetRenderDevice().
by Tom Sepez
· 6 years ago
f801451
Pass CFWL_Theme{Background,Text,Part} params by const-ref.
by Tom Sepez
· 6 years ago
89aff06
Pass out parameter to GetTextNode() by pointer, not reference
by Tom Sepez
· 6 years ago
28cfe34
Remove unreachable code paths in cxfa_document_parser.cpp
by Tom Sepez
· 6 years ago
7802e2a
Tidy CXFA_EventParam
by Tom Sepez
· 6 years ago
92cc793
Move XFA-only fxcrt/ files to fgas/layout/ or fgas/crt.
by Tom Sepez
· 6 years ago
800298c
Small cleanup in CXFA_ArrayNodeList::SetArrayNodeList()
by Tom Sepez
· 6 years ago
55d5d6c
Make CXFA_ItemLayoutProcessor::m_pPageMgr an UnownedPtr<>.
by Tom Sepez
· 6 years ago
ab41f25
Rename "Embeddertest" to "EmbedderTest".
by Lei Zhang
· 6 years ago
81e9b68
Remove CFX_RectF::Reset().
by Tom Sepez
· 6 years ago
0f0b30c
Avoid duplicate desc/lock attributes on leaf elements
by Tom Sepez
· 6 years ago
4b9d8e9
Re-structure element.inc hierarchy to avoid duplication.
by Tom Sepez
· 6 years ago
70340c1
Use span in CFDE_TextOut::DrawString().
by Lei Zhang
· 6 years ago
5a6d70c
Fix a crash in CXFA_Document::DoProtoMerge().
by Lei Zhang
· 6 years ago
ff027ce
Avoid some hash comparisons in CXFA_NodeHelper.
by Tom Sepez
· 6 years ago
a0c3680
Split part of xfa/fgas/BUILD.gn into xfa/fgas/layout/BUILD.gn.
by Lei Zhang
· 6 years ago
4aebf8c
Fix nits in CFX_TxtBreak and related code.
by Lei Zhang
· 6 years ago
5360e70
Remove non-const parameter in CXFA_ItemLayoutProcessor.
by Lei Zhang
· 6 years ago
a0e5e20
Add CXFA_ItemLayoutProcessor::GotoNextContainerNodeSimple().
by Lei Zhang
· 6 years ago
Next »