| commit | 10911d280ed903419b10cd357f2df09964dacd02 | [log] [tgz] |
|---|---|---|
| author | Primiano Tucci <primiano@google.com> | Mon May 24 21:06:13 2021 +0100 |
| committer | Primiano Tucci <primiano@google.com> | Mon May 24 21:06:13 2021 +0100 |
| tree | c7002d19a276ee8bc966d319a69bb835f41a6cee | |
| parent | ee7355902ac7bd1ba8645fee4f89ca5ed29bbb82 [diff] |
traced_probes: Don't set --only_userspace on older atrace
atrace --only_userspace was introduced only in Android P.
When sideloading perfetto on older versions of android,
any tracing session that involves atrace will fail,
because older versions of android don't understand that
option.
This CL makes it fallback gracefully by checking the
Android version at runtime. When an older version of
Android is detecte we do two things:
- Don't pass --only_userspace
- Relax the "somebody did unexpectedly enable ftrace"
checks (Because atrace would do that).
Also, because of the invasiveness of atrace without
--only-userspace, we prevent concurrent tracing sessions.
Test: manual on a Pixel 2 runing Android O device:
tools/record_android_trace -b 256mb -t 60s sched gfx view irq adb camera -a* --sideload-path out/android_release_arm64/stripped/tracebox
Bug: 158465724
Change-Id: Ie6f222bf26724bb2a4cfa7a811bf8e3228a5260ePerfetto is a production-grade open-source stack for performance instrumentation and trace analysis. It offers services and libraries and for recording system-level and app-level traces, native + java heap profiling, a library for analyzing traces using SQL and a web-based UI to visualize and explore multi-GB traces.
See https://perfetto.dev/docs or the /docs/ directory for documentation.