commit | 131a7dad3bbecac40b02925f9eeb2bd9b3a4c02f | [log] [tgz] |
---|---|---|
author | Stephen Nusko <nuskos@google.com> | Fri Jan 17 11:04:04 2020 +0000 |
committer | Stephen Nusko <nuskos@google.com> | Fri Jan 17 11:04:04 2020 +0000 |
tree | b876218a3187a0a36c9329aed83309c6aec8a9b2 | |
parent | 01eb879e258a90700d5b25a0fdb0ad6dfff5b9bd [diff] |
GTEST_EXECUTE_STATEMENT_ is not available on iOS execute the statement directly instead. Previous attempt: https://android-review.googlesource.com/c/platform/external/perfetto/+/1209091 GTEST_EXECUTE_STATEMENT_ is used for GTest Death Test, and is only available on systems that support it. So if it is available use it for the same behaviour today. GTest says[1] the following about GTEST_EXECUTE_STATEMENT_: " // This macro is for implementing ASSERT/EXPECT_DEBUG_DEATH when compiled in // NDEBUG mode. In this case we need the statements to be executed and the macro // must accept a streamed message even though the message is never printed. // The regex object is not evaluated, but it is used to prevent "unused" // warnings and to avoid an expression that doesn't compile in debug mode. " For us since we aren't in DEBUG (we would use the IF_SUPPORTED macro instead) these statements should not die in DEBUG we can just execute the statement directly and they might be optimized away on iOS but this isn't a huge concern if one platform has less coverage. [1] https://github.com/google/googletest/blob/master/googletest/include/gtest/internal/gtest-death-test-internal.h Bug: 147743969 Change-Id: Ie220e1efef08b6939de0ec061123d7742c297c49
Perfetto is an open-source project for performance instrumentation and tracing of Linux/Android/Chrome platforms and user-space apps.
See www.perfetto.dev for docs.
See /docs/contributing.md for instructions.
The source-of-truth repo is Android's Gerrit. The GitHub repo is a read-only mirror.
You can reach us on our Discord channel. If you prefer using IRC we have an experimental Discord <> IRC bridge synced with #perfetto-dev
on Freenode.