commit 33d8ea23556233ad668fc3b4c02347ceb72b3242
author Florian Mayer <fmayer@google.com> Thu May 09 19:57:07 2019 +0100
committer Florian Mayer <fmayer@google.com> Thu May 09 19:57:07 2019 +0100
tree e885004e8822f082d200a0357d27e93c99f5dda4
parent 1adec0c11252cf7ceb01c8e4d6192c7de1685740

Use PERFETTO_DFATAL_OR_ELOG to get errors from release builds.

Change-Id: Ib5dac80fafe6c14ed6017b24676c292bc0c8f60e

src/profiling/memory/wire_protocol.cc

diff --git a/src/profiling/memory/wire_protocol.cc b/src/profiling/memory/wire_protocol.cc
index 67b0f38..52af41b 100644
--- a/src/profiling/memory/wire_protocol.cc
+++ b/src/profiling/memory/wire_protocol.cc
@@ -60,7 +60,7 @@
     iovecs[1].iov_base = msg.free_header;
     iovecs[1].iov_len = sizeof(*msg.free_header);
   } else {
-    PERFETTO_DFATAL("Neither alloc_header nor free_header set.");
+    PERFETTO_DFATAL_OR_ELOG("Neither alloc_header nor free_header set.");
     errno = EINVAL;
     return false;
   }
@@ -90,7 +90,7 @@
     buf = shmem->BeginWrite(lock, total_size);
   }
   if (!buf) {
-    PERFETTO_DFATAL("Buffer overflow.");
+    PERFETTO_DLOG("Buffer overflow.");
     shmem->EndWrite(std::move(buf));
     errno = EAGAIN;
     return false;
@@ -111,7 +111,7 @@
   RecordType* record_type;
   char* end = buf + size;
   if (!ViewAndAdvance<RecordType>(&buf, &record_type, end)) {
-    PERFETTO_DFATAL("Cannot read record type.");
+    PERFETTO_DFATAL_OR_ELOG("Cannot read record type.");
     return false;
   }
 
@@ -121,22 +121,22 @@
 
   if (*record_type == RecordType::Malloc) {
     if (!ViewAndAdvance<AllocMetadata>(&buf, &out->alloc_header, end)) {
-      PERFETTO_DFATAL("Cannot read alloc header.");
+      PERFETTO_DFATAL_OR_ELOG("Cannot read alloc header.");
       return false;
     }
     out->payload = buf;
     if (buf > end) {
-      PERFETTO_DFATAL("Buffer overflowed");
+      PERFETTO_DFATAL_OR_ELOG("Receive buffer overflowed");
       return false;
     }
     out->payload_size = static_cast<size_t>(end - buf);
   } else if (*record_type == RecordType::Free) {
     if (!ViewAndAdvance<FreeBatch>(&buf, &out->free_header, end)) {
-      PERFETTO_DFATAL("Cannot read free header.");
+      PERFETTO_DFATAL_OR_ELOG("Cannot read free header.");
       return false;
     }
   } else {
-    PERFETTO_DFATAL("Invalid record type.");
+    PERFETTO_DFATAL_OR_ELOG("Invalid record type.");
     return false;
   }
   return true;