Gitiles
Code Review Sign In
gerrit-public.fairphone.software / platform / external / perfetto / 36b3919c291cfb1fc991304ae620355e1849b0fc
commit36b3919c291cfb1fc991304ae620355e1849b0fc[log] [tgz]
authorHector Dearman <hjd@google.com>Wed Dec 04 11:56:10 2019 +0000
committerHector Dearman <hjd@google.com>Wed Dec 04 11:56:10 2019 +0000
tree443970c821bd61ab17b47a981d39804340ce43f3
parenta097c941d4f8cb3af5b3979b5494549b7fdb5309 [diff]
perfetto-ui: Fix js stack overflow

Fix a couple of instances where we used:

someArray.push(...someOtherArray);

to append all elements from someOtherArray to someArray as
this (I now realaise) is an anti-pattern. If someOtherArray is very
large this code will cause a stackoverflow attempting to pass all the
elements as arguments.

Also fix an N+1 query pattern in trace_controller that was slow when
there are many tracks.

Bug: 144595839
Change-Id: I5fa8773af66adb617578795c68da8ccfe1035504
2 files changed
tree: 443970c821bd61ab17b47a981d39804340ce43f3
  1. bazel/
  2. build_overrides/
  3. buildtools/
  4. debian/
  5. docs/
  6. gn/
  7. include/
  8. infra/
  9. protos/
  10. src/
  11. test/
  12. tools/
  13. ui/
  14. .clang-format
  15. .gitignore
  16. .gn
  17. .style.yapf
  18. Android.bp
  19. Android.bp.extras
  20. BUILD
  21. BUILD.extras
  22. BUILD.gn
  23. codereview.settings
  24. heapprofd.rc
  25. MODULE_LICENSE_APACHE2
  26. NOTICE
  27. OWNERS
  28. perfetto.rc
  29. PRESUBMIT.py
  30. README.chromium
  31. README.md
  32. TEST_MAPPING
  33. WORKSPACE
README.md

Perfetto - Performance instrumentation and tracing

Perfetto is an open-source project for performance instrumentation and tracing of Linux/Android/Chrome platforms and user-space apps.

See www.perfetto.dev for docs.

Bugs

  • For bugs affecting Android or the tracing internals use the internal bug tracker (go/perfetto-bugs).
  • For bugs affecting Chrome use http://crbug.com, Component:Speed>Tracing label:Perfetto.

Community

You can reach us on our Discord channel. If you prefer using IRC we have an experimental Discord <> IRC bridge synced with #perfetto-dev on Freenode.