commit 82527cb0be329894be1b4eb08a6ef40ef0b270f8
author Primiano Tucci <primiano@google.com> Fri May 14 14:22:59 2021 +0100
committer Primiano Tucci <primiano@google.com> Fri May 14 14:22:59 2021 +0100
tree 597417197a8babcc810e724c3a9e17819ed14222
parent db86c66a557ebec2d1d1fd41aba4a8e875452da1

Proto filter: use "bytes" field w/ checksum for bytecode

This CL makes a minor tweak to the bytecode filter
serialization. It's still a packed sequence of varints
with the only two tweaks:
1. Got rid of the proto_filter.proto definition. That
   was not defining anything other than a packed varint
   array but turned out to be very inconvenient to write
   pbtx trace config. In fact arrays in .pbtx require one
   row per entry (in this case, one row per filter word).
   On top of this, I discovered that our pbtx parser doesn't
   support yet packed arrays. So I switched this to be just
   a bytes field (in the next CLs, where it will be plumbed)
   even though its content it's still a sequence of varints.
2. Added a final word to the bytecode with a checksum. This is
   to make sure that we don't screw up accidentally the filter
   in the various proto->string->proto conversions.

Bug: 181012016
Test: updated unittests and fuzzers.
Change-Id: I9d5c5c23de1b4ec93ed307187fdedcc813623572